[GitHub] tomcat-maven-plugin pull request #26: Allow easy myEclipse development

2017-05-07 Thread hazendaz
GitHub user hazendaz opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/26 Allow easy myEclipse development MyEclipse uses tag when importing projects to workspace by default. In order to allow development easily for users of myEclipse, colons are

[GitHub] tomcat-maven-plugin pull request: Allow easy myEclipse development

2015-07-12 Thread hazendaz
Github user hazendaz closed the pull request at: https://github.com/apache/tomcat-maven-plugin/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tomcat pull request: now json is fashion

2015-01-13 Thread hazendaz
Github user hazendaz commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69741658 We run json using Jackson with jersey in tomcat. No issues. This code doesn't do anything. So unclear how it solves anything. All you did was add an emp

[GitHub] tomcat pull request: now json is fashion

2015-01-13 Thread hazendaz
Github user hazendaz commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69744890 Sure...what I meant here is that this patch does nothing from tomcat perspective. It's just an empty if statement. It does nothing at all. --- Original Me

[GitHub] tomcat-maven-plugin pull request: Allow easy myEclipse development

2014-11-15 Thread hazendaz
GitHub user hazendaz opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/13 Allow easy myEclipse development MyEclipse uses tag when importing projects to workspace by default. In order to allow development easily for users of myEclipse, colons are

[GitHub] tomcat pull request: Document the use of "shutdown" and "port" att...

2014-05-05 Thread hazendaz
Github user hazendaz commented on the pull request: https://github.com/apache/tomcat/pull/6#issuecomment-4225 Another -1 on this change. I'm not sure how this would solve any perceived security issue. The shutdown port is only accessible as local host so it requires you a