Hi, I'm trying to put together a patch as per.
http://marc.info/?l=tomcat-user&m=128249845732568&w=2
I've put an optional value in StandardContext that I need to check in
org.apache.catalina.connector.Response however I've left the interface
for Context alone. (new implementations shouldn't need t
On Mon, Aug 23, 2010 at 1:07 PM, Mark Thomas wrote:
> I would (and have in the past) just add the attribute to the context.
Oh right okay thats much easier then. Is there unit tests that need
updating too?
Regards,
Wesley Ache
On Wed, Aug 25, 2010 at 1:55 PM, Pid wrote:
> On 25/08/2010 10:14, Mladen Turk wrote:
>> On 08/25/2010 10:53 AM, Rainer Jung wrote:
>>>
>>> What about linking to the Specs? Like
>>>
>>> http://jcp.org/aboutJava/communityprocess/final/jsr315/index.html
>>>
>>
>> Still, is it so important that this
Hi
In tomcat 6 trunk
At the point o.a.c.c.CoyoteAdapter#parseSessionId(org.apache.coyote.Request,
org.apache.catalina.connector.Request) gets called the context isn't
set in the o.a.c.c.Request parameter. This is set later in
#postParseRequest.
Is there any way that isn't too heavy to find the
I understand that the Apache voting system is a bit odd. For enhancement
requests though is there no way for users to vote for the features that they
would like. (Which is different to you as devs voting on whether to apply a
patch or not). I'm pretty sure that's a normal bugzilla feature but I
hav
> I don't recall it ever being used very much (by users or by committers)
> so I disabled it for the newer projects.
>
>
Okay fair enough. Would the best process for suggesting changes be to raise
a discussion on the users list? Suggestions that outside the users ability
to patch.
Oh and there is
I'm looking through the source now where I'm seeing a lot of
Throwables caught. I was always told this was bad practice is there a
reason for this? Some I could understand but there seems to be places
where throwable is caught even though the javadocs say it throws an
exception. And by your handlin
Hi,
I'm looking at adding a host node to server.xml on the 6.0 branch via
host manager, If I get this correct there can be more than one service
node which in turn has one Engine which contains the hosts.
So assuming there are multiple Service nodes how do I know which
Engine node to add the Host
On Sun, Sep 12, 2010 at 11:28 AM, Mark Thomas wrote:
> On 12/09/2010 09:59, Wesley Acheson wrote:
>> does (Service) host.getParent() make sense, If so is service name both
>> compulsory and guaranteed to be unique?
>
> Get the correct engine the way host manager does
Em what I mean is I don't see a trunk node within tc7.0x folder. Does
the trunk folder http://svn.apache.org/repos/asf/tomcat/trunk
represent tomcat 7?
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional com
Hi
I think the documentation in tomcat 7 about building tomcat is
incorrect or out of date.
I've tried to get it running in eclipse using the following steps.
1 Checkout from http://svn.apache.org/repos/asf/tomcat/trunk. This was
the location given to me on the mailing list.
2 Tried "ant downlo
This was a bug which Mark made a request to the user mailing list to look at.
Okay I think I've got some information on this. I've put a comment in
the bug showing where I "believe" the behaviour to be wrong. What's
the next step on this?
--
On Tue, Sep 14, 2010 at 1:26 PM, Mark Thomas wrote:
> On 14/09/2010 12:12, Wesley Acheson wrote:
>> This was a bug which Mark made a request to the user mailing list to look at.
>>
>> Okay I think I've got some information on this. I've put a comment in
>>
On Tue, Sep 14, 2010 at 3:01 PM, Remy Maucherat wrote:
> On Tue, 2010-09-14 at 12:26 +0100, Mark Thomas wrote:
>> You need to be able to quote the section of the spec that demonstrates
>> it is wrong. Having quickly scanned the 2.5 and 3.0 specs I think you
>> are going to find that there is no cl
Was there something wrong with this question? Or the one about
catching throwable, okay I might not be the most knowledgeable but I'm
trying to help, in general.
On Tue, Sep 14, 2010 at 11:10 AM, Wesley Acheson
wrote:
> Hi
>
> I think the documentation in tomcat 7 about buil
Okay a last questions in this case. Also please note works pretty
hetic at the moment. If theres multiple changes to be made it may take
some time.
On Wed, Sep 15, 2010 at 9:56 PM, Mark Thomas wrote:
> On 15/09/2010 20:44, Wesley Acheson wrote:
>>> 6 I received an error that two ja
>
>>> 2 Tried "ant download" as per
>>> http://tomcat.apache.org/tomcat-7.0-doc/building.html#Building%20Tomcat.
>>> Apparently there is no target called "download"
> Already fixed in svn.
In trunk? because I just tried a fresh checkout doesn't seem to have
that target.
--
Hi,
>>> Is this the "correct" way to run TC7? Do you want a bug on this? If
>>> you let me know where the documentation is I'll enter a patch
>>> (assuming documentation is in SVN).
> Yes, yes, yes.
Good, done, done.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955
Wes
---
>> 2. Coding conventions seem to be applied ... inconsistently. Is there a
>> code style guide that I can actually follow so my code "looks right", or
>> should I just look at what's already there in the files I'm modifying
>> and take my best guess at what's appropriate?
>
> Yep. Go with the curre
homas wrote:
> On 20/09/2010 15:04, Wesley Acheson wrote:
>>>> 2. Coding conventions seem to be applied ... inconsistently. Is there a
>>>> code style guide that I can actually follow so my code "looks right", or
>>>> should I just look at what'
On Tue, Sep 14, 2010 at 3:16 PM, Wesley Acheson
wrote:
> On Tue, Sep 14, 2010 at 3:01 PM, Remy Maucherat wrote:
>> On Tue, 2010-09-14 at 12:26 +0100, Mark Thomas wrote:
>>> You need to be able to quote the section of the spec that demonstrates
>>> it is wrong. Having
On Tue, Sep 21, 2010 at 9:30 AM, Remy Maucherat wrote:
> On Mon, 2010-09-20 at 16:31 -0700, Mark Thomas wrote:
> If he wants universal filtering, he can use "/*" I think, right ?
Yes that should work. I use that all the time. And "" is supposed to
be root not "/" according to the specs.
> As we
>
> URL: http://svn.apache.org/viewvc?rev=1000392&view=rev
> Log:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=49955
>
> Improvements and corrections for the Building Tomcat guide, plus
> sample Eclipse launch targets.
>
> Based on contribution from Wesley Acheson.
>
> -1 on the names. File names with spaces are a PITA.
>
> Do these have to be in the root of the source tree? I know I started the
> whole adding Eclipse files to the source tree but I am beginning to
> regret how I did it. How about moving all the the IDE support files to
> res/ide-support and upd
On Thu, Sep 23, 2010 at 12:15 PM, wrote:
> Author: timw
> Date: Thu Sep 23 10:15:16 2010
> New Revision: 1000392
>
> URL: http://svn.apache.org/viewvc?rev=1000392&view=rev
> Log:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=49955
>
> Improvements and corrections for the Building Tomcat gu
On Thu, Sep 23, 2010 at 7:47 PM, Caldarale, Charles R
wrote:
>> From: Wesley Acheson [mailto:wesley.ache...@gmail.com]
>> Subject: [OT]Re: svn commit: r1000392 - in /tomcat/trunk:
>> Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml
>> webapps/docs/chang
On Thu, Sep 23, 2010 at 7:56 PM, Caldarale, Charles R
wrote:
>> From: Wesley Acheson [mailto:wesley.ache...@gmail.com]
>> Subject: Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk:
>> Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml
>> webapps/docs/ch
Just a suggestion but I feel the work directory should be in
svn:ignore. I'm looking at trunk for tc7 and it says I've a lot of
outgoing changes because I've executed it. It also showed outgoing
additions in conf. I'd put in a patch but dunno how to put in a patch
for svn properties.
Wes
>> Okay yes I discovered the meaning of *both* acronym's. Which is ironic
>> considering the meaning of the second (given the way I found it out).
>>
>> PITA is a type of bread. Still not sure what that has to do with a
>> filesystem though.
>
> http://www.urbandictionary.com/define.php?term=PITA
Okay thanks for the heads up.
On Thu, Sep 23, 2010 at 9:45 PM, Mark Thomas wrote:
> On 23/09/2010 12:10, Wesley Acheson wrote:
>> Just a suggestion but I feel the work directory should be in
>> svn:ignore. I'm looking at trunk for tc7 and it says I've a lot of
>>
In that case looking further at this I think the eclipse.classpath is wrong.
On Thu, Sep 23, 2010 at 9:45 PM, Mark Thomas wrote:
> On 23/09/2010 12:10, Wesley Acheson wrote:
> You build env is messed up. You should be running Tomcat from
> trunk/output/build and that is already ign
On Thu, Sep 23, 2010 at 11:28 PM, Mark Thomas wrote:
> On 23/09/2010 13:28, Wesley Acheson wrote:
>> In that case looking further at this I think the eclipse.classpath is wrong.
>
> That was intended for building Tomcat, not running it. Personally, I'd
> never run Tomcat i
Pardon my language but WTF?
please don't respond GIYF.
On Fri, Sep 24, 2010 at 11:35 PM, wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=4
>
> Summary: More bugs
> Product: Tomcat 5
> Version: 5.5.31
> Platform: All
> OS/Version: All
On Fri, Sep 24, 2010 at 11:59 PM, William A. Rowe Jr.
wrote:
> On 9/24/2010 4:55 PM, Caldarale, Charles R wrote:
>>> From: Wesley Acheson [mailto:wesley.ache...@gmail.com]
>>> Subject: Re: DO NOT REPLY [Bug 4] New: More bugs
>>
>>> Pardon my language but WT
On Sun, Sep 26, 2010 at 6:05 PM, Konstantin Kolinko
wrote:
> 2010/9/26 sebb :
>> On 26 September 2010 10:00, Tim Whittington wrote:
>>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>>> will be more vigilent..
>>
>> Hit me too amny times.
>>
>> The tabs setting for the XML e
Commiters, patch authors.
Do you use an IDE to modify tomcat source code?
If you do which one?
Asking again in releation to bug 50001. Trying to see what ide's
should be supported.
-
To unsubscribe, e-mail: dev-unsubscr...@tomc
On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote:
> On 26/09/2010 19:08, Wesley Acheson wrote:
>> Commiters, patch authors.
>>
>> Do you use an IDE to modify tomcat source code?
>
> Yes.
>
>> If you do which one?
>
> Eclipse for Java.
Really do yo
On Sun, Sep 26, 2010 at 1:37 PM, sebb wrote:
> On 26 September 2010 10:00, Tim Whittington wrote:
>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>> will be more vigilent..
>
> Hit me too amny times.
>
> The tabs setting for the XML editor is in a different place:
> Prefere
On Sun, Sep 26, 2010 at 8:44 PM, Mark Thomas wrote:
> On 26/09/2010 19:38, Wesley Acheson wrote:
>> On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote:
>>> On 26/09/2010 19:08, Wesley Acheson wrote:
>>>> Commiters, patch authors.
>>>>
>>&
On Sun, Sep 26, 2010 at 10:26 PM, Pid wrote:
> On 26/09/2010 19:57, Mark Thomas wrote:
>> On 26/09/2010 19:47, Wesley Acheson wrote:
>>> Which is really nice. Its a big noise but its a big noise once.
>>
>> Which persists in the file's history making diffs th
On Mon, Sep 27, 2010 at 12:18 AM, David Jencks wrote:
>
> On Sep 26, 2010, at 11:08 AM, Wesley Acheson wrote:
>
>> Commiters, patch authors.
>>
>> Do you use an IDE to modify tomcat source code?
>>
>> If you do which one?
>
> IDEA
>>
>> A
On Tue, Sep 28, 2010 at 11:36 AM, wrote:
> Author: timw
> Date: Tue Sep 28 09:36:08 2010
> New Revision: 1002073
>
> URL: http://svn.apache.org/viewvc?rev=1002073&view=rev
> Log:
> Moved all Eclipse specific files into res/ide-support/eclipse.
> Removed spaces from launch target filenames.
> Corr
HI All,
I'm not actually sure how OT this is or if the question belongs here.
This is semi duplicating some comments seen in a bug. However I think
its useful for anyone trying to create future patches who is
inexperienced like me, so I'm sort of double posting.
I'm trying to create a patch. How
I don't really run SVN from the command line. But yes I believe thats
been done via the eclipse plugin actually I think it called svn move.
On Tue, Sep 28, 2010 at 5:11 PM, Caldarale, Charles R
wrote:
>> From: Wesley Acheson [mailto:wesley.ache...@gmail.com]
>> Subject: [OT] Di
Hi Some comments below. Sorry I've been on holiday for a bit and
haven't got arround to this.
On Mon, Oct 4, 2010 at 4:17 PM, Pid wrote:
> On 04/10/2010 15:00, Konstantin Kolinko wrote:
>> 2010/10/4 Pid :
>>> Hi,
>>>
>>> A talking point:
>>>
>>> http://people.apache.org/~pidster/tomcat/site/
>>>
On Tue, Oct 12, 2010 at 4:07 PM, Pid wrote:
> On 11/10/2010 21:04, Wesley Acheson wrote:
>> Hi Some comments below. Sorry I've been on holiday for a bit and
>> haven't got arround to this.
>
> Thanks. The main question is:
>
>>> What do you believe ar
46 matches
Mail list logo
