Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Mladen Turk wrote: Filip Hanik - Dev Lists wrote: to eager to press send, that way the connector would have only on/off values, while the actual SSLEngine value neuron would be in the APRLifeCycleListener, much cleaner, and all our connectors become consistent

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: not really, this wouldn't work protocol="org.apache.coyote.http11.Http11AprProtocol" SSLEngine="oneengine"/> protocol="org.apache.coyote.http11.Http11AprProtocol" SSLEngine="otherengine"/> Fully valid configuration, and the docs don't mention that a uniqueness

Re: svn commit: r465418 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

2006-10-18 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: is this existent in 6.0 as well? It's possible there are leaks, but we'll have to find them, as the implementation is completely different. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Remy Maucherat
Mladen Turk wrote: If that is the case the secure="true|false" can be used to determine if the transport is ssl or not, and fake the front end handled https/ssl connection. I find that doubtful. I am against such a change right now, since it might restrict usage of the connector for no good

Re: [build]fail message

2006-10-19 Thread Remy Maucherat
Yoav Shapira wrote: You have the wrong version of the Eclipse JDT jar on your classpath. It may be a good idea to package rename JDT as well (evil grin). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional command

Re: [VOTE] Tomcat 6 release plan

2006-10-19 Thread Remy Maucherat
Yoav Shapira wrote: Hi, Assuming you mean the small thread that started with http://marc.theaimsgroup.com/?l=tomcat-dev&m=114684618907238&w=2, I would say no. That whole thread was conjecture and was never discussed seriously. Of course we may do such things (major features = a .5 release incre

Re: [VOTE] Tomcat 6 release plan

2006-10-19 Thread Remy Maucherat
Remy Maucherat wrote: Hi, The release plan is located here: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/RELEASE-PLAN-6.0.txt [ ] +1 [ ] +0 [ ] -1 This calls for a first build to be released by friday, and it will use the same release process as 5.5.x. At the moment, there'

Re: [VOTE] Tomcat 6 release plan

2006-10-19 Thread Remy Maucherat
Yoav Shapira wrote: Hi, On 10/19/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: I plan to tag 6.0.0 late friday. Is it ok ? Fine by me, I'm too swamped at work to commit anything right now anyways. But for others who might be working on trunk, maybe we can pick a more precise

Re: v5.5.x default context support outside of server.xml

2006-10-19 Thread Remy Maucherat
Yoav Shapira wrote: Jon, We got your original message. I didn't see any replies, unfortunately. If you care to submit a patch that does any of what you asked for into our Bugzilla issue tracker, that'd be great. I would have to veto that. Rémy ---

Re: v5.5.x default context support outside of server.xml

2006-10-19 Thread Remy Maucherat
Jon Wilmoth wrote: will continue to work in 6.0.0 until a more elaborate web application deployer is written (if ever). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r465675 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/core/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Remy Maucherat
Mladen Turk wrote: Filip Hanik - Dev Lists wrote: The scenario we are trying to achieve is this: How will in that case behave: Please explain for each case. Who knows ? People have been asking for a lot of decoupling in these options. scheme and secure are what will be exposed to th

Re: svn commit: r465675 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/core/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Remy Maucherat
Mladen Turk wrote: Changing what? Previous or new Filip's implementation? I am happy with Filip's implementation. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r465417 - in /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11: Http11NioProcessor.java InternalNioInputBuffer.java

2006-10-19 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: gentlemen, not sure if you had a chance to look this over, but it is pretty interesting, after some very basic tests, I get the NIO connector to perform better than the blocking io connector the peak data throughput are NIO - 36,000KB/s JIO - 35,000KB/s APR - 24,0

Re: [VOTE] Tomcat 6 release plan

2006-10-20 Thread Remy Maucherat
Remy Maucherat wrote: This calls for a first build to be released by friday, and it will use the same release process as 5.5.x. At the moment, there's no plan to port the admin webapp, but it would certainly be possible to do so should volunteers show up. I've tagged and uploaded

Re: SPDY support

2012-02-02 Thread Remy Maucherat
On Wed, 2012-02-01 at 13:54 -0800, Costin Manolache wrote: > Hi, > > Some initial patch for SPDY - using the NPN SSL extension, as required by > chrome/firefox. > > I used github so it's easy to add comments or test: > > https://github.com/costinm/tomcat/commit/e97def3314216c083cc4b68ad9731e5a94

Re: SPDY support

2012-02-02 Thread Remy Maucherat
On Thu, 2012-02-02 at 12:28 +, Pid wrote: > > Of course, I'm even less sure about websockets since it's kind of a mess. > > I'd say it was the other way round. WebSockets finalised before Xmas, > and there's lots of interest from various communities to judge from the BZ. Websocrap is a bad t

Re: non blocking API

2012-06-29 Thread Remy Maucherat
On Thu, 2012-06-28 at 16:59 -0600, Filip Hanik (mailing lists) wrote: > I posted some feedback to the expert group: > > http://java.net/projects/servlet-spec/lists/users/archive/2012-06/message/15 You can find all the discussions about the API in the archive, which hopefully explain nearly all of

Re: Recent performance tweaks in trunk

2012-09-24 Thread Remy Maucherat
On Sun, 2012-09-23 at 12:35 +0100, Mark Thomas wrote: > ab -c 4 -k -n 100 http://localhost:8080/test-1k.txt The concurrency of the test is very low, there will be only 4 threads used with that test, which means decent sync performance. Although with NIO the executor count can remain lower tha

Re: Resources - Is DirContext the right basis for the API?

2012-09-27 Thread Remy Maucherat
On Thu, 2012-09-27 at 07:34 -0700, Costin Manolache wrote: > One use for a resource API is if it provides different backends - like > Hadoop filesystem abstraction > does. Than you could serve from hdfs/db/etc, and someone could use the same > api in deploy tools > or general programs. > One of th

Re: Resources - Custom URL scheme for unified access

2012-10-09 Thread Remy Maucherat
On Tue, 2012-10-09 at 22:19 +0100, Mark Thomas wrote: > If we do go this route I'd like to change the scheme from "jndi://" to > "tomcat://". This is for several reasons: > - I believe there was a complaint that "jndi://" clashed with another > component. > - It makes clear the old and the new ar

Re: [VOTE] Release build 6.0.36

2012-10-18 Thread Remy Maucherat
On Tue, 2012-10-16 at 10:52 +0200, jean-frederic clere wrote: > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.36/ > > According to the release process, the 6.0.36 build corresponding to the > tag TOMCAT_6_0_36 is: > [ ] Broken > [ ] Alpha > [ ] Beta

Re: JSR 315 - status ?

2009-09-01 Thread Remy Maucherat
On Tue, 2009-09-01 at 13:40 +0200, Matthias Wessendorf wrote: > Is there no Tomcat developer an active member on the JSR ? You do understand this is confidential information, right ? Follow the JCP progress and announcements. Rémy ---

Re: svn commit: r828212 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2009-10-22 Thread Remy Maucherat
On Wed, 2009-10-21 at 20:57 +, ma...@apache.org wrote: > Author: markt > Date: Wed Oct 21 20:57:14 2009 > New Revision: 828212 > > URL: http://svn.apache.org/viewvc?rev=828212&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987 > Limit size of not found resources cac

Re: [VOTE] Releasing Apache Tomcat Native 1.1.17

2009-10-26 Thread Remy Maucherat
On Tue, 2009-10-20 at 21:55 +0200, jean-frederic clere wrote: > [X] Stable - no major issues, no regressions > [ ] Beta - at least one significant issue -- tell us what it is > [ ] Alpha - multiple significant issues -- tell us what they are Rémy -

Re: svn commit: r831536 - in /tomcat/trunk: java/org/apache/tomcat/util/http/ test/org/apache/tomcat/util/http/ webapps/docs/config/

2009-10-31 Thread Remy Maucherat
On Sat, 2009-10-31 at 12:59 +, ma...@apache.org wrote: > Author: markt > Date: Sat Oct 31 12:59:51 2009 > New Revision: 831536 > > URL: http://svn.apache.org/viewvc?rev=831536&view=rev > Log: > Add an explicit configuration option for cookie version switching and update > test cases and docs

Re: svn commit: r832039 - in /tomcat/trunk/java/org/apache/naming: HandlerRef.java ResourceRef.java ServiceRef.java StringManager.java resources/DirContextURLStreamHandler.java

2009-11-02 Thread Remy Maucherat
On Mon, 2009-11-02 at 18:46 +, ma...@apache.org wrote: > Author: markt > Date: Mon Nov 2 18:46:21 2009 > New Revision: 832039 > > URL: http://svn.apache.org/viewvc?rev=832039&view=rev > Log: > StringBuffer -> StringBuilder for o.a.naming So I did not test or anything, but is SBuilder faster

Cookie issues

2009-11-11 Thread Remy Maucherat
Hi, I think cookies are still broken, and this is getting more and more complex. The apparent issue is that the parser applies v1 parsing rules when parsing v0 cookies (which are generated using a much more lenient character exclusion), resulting in cookies that cannot be parsed back. A simple ex

Re: Cookie issues

2009-11-11 Thread Remy Maucherat
On Wed, 2009-11-11 at 16:45 -0500, Mark Thomas wrote: > I really do loath cookies right now. I've pulled the proposed patches for > 5.5.x > and 6.0.x until I (or someone else) can take a look at this. I do too. v0 cookies is 15 years old stuff that Netscape hacked out of thin air without thinking

Re: Cookie issues

2009-11-12 Thread Remy Maucherat
On Thu, 2009-11-12 at 16:03 -0500, Mark Thomas wrote: > I've done some more digging and I think I have found what was causing this. > I'll > have a fix for trunk shortly and (after some testing) I'll re-propose. No, what I meant is that, if you want to go the strict route and use '/' as a separat

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Remy Maucherat
On Wed, 2009-11-18 at 16:18 +0100, jean-frederic clere wrote: > [X] Stable - no major issues, no regressions > [ ] Beta - at least one significant issue -- tell us what it is > [ ] Alpha - multiple significant issues -- tell us what they are Rémy -

Re: svn commit: r1094069 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

2011-04-18 Thread Remy Maucherat
On Sat, 2011-04-16 at 22:25 +, ma...@apache.org wrote: > Author: markt > Date: Sat Apr 16 22:25:28 2011 > New Revision: 1094069 > > URL: http://svn.apache.org/viewvc?rev=1094069&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51042 > Don't trigger session creation list

Re: svn commit: r1132367 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml

2011-06-06 Thread Remy Maucherat
On Sun, 2011-06-05 at 10:21 +, ma...@apache.org wrote: > Author: markt > Date: Sun Jun 5 10:21:25 2011 > New Revision: 1132367 > > URL: http://svn.apache.org/viewvc?rev=1132367&view=rev > Log: > Correctly handle range requests when using sendfile and the APR/native HTTP > connector. > -

Re: svn commit: r1132367 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml

2011-06-06 Thread Remy Maucherat
On Mon, 2011-06-06 at 19:15 +0100, Mark Thomas wrote: > Doh. Got it. We do need to modify the length to handle range requests, > but not like that. What's the issue exactly ? When actually sending data, "pos" is set to "start" and the length is used as the usual "end - pos". Rémy -

Re: svn commit: r1140463 - in /tomcat/trunk/java/org/apache/catalina: connector/Request.java ssi/SSIServletExternalResolver.java util/Base64.java

2011-06-28 Thread Remy Maucherat
On Tue, 2011-06-28 at 07:22 +, ma...@apache.org wrote: > Author: markt > Date: Tue Jun 28 07:22:28 2011 > New Revision: 1140463 > > URL: http://svn.apache.org/viewvc?rev=1140463&view=rev > Log: > Fix the remaining instances of new String(byte[] b, String enc) that can be > fixed It is possib

Re: new year, new version? 6.0.16

2008-01-08 Thread Remy Maucherat
On Fri, 2008-01-04 at 11:20 -0700, Filip Hanik - Dev Lists wrote: > we have a lot of updates added in, I think it may be good to set a date > for our next release and work towards that r297710 is a hack, and reintroduces a data corruption bug that was fixed a long time ago. Rémy -

Re: svn commit: r609294 - in /tomcat/tc6.0.x/trunk: STATUS.txt conf/catalina.policy webapps/docs/changelog.xml

2008-01-09 Thread Remy Maucherat
On Sun, 2008-01-06 at 11:43 +, [EMAIL PROTECTED] wrote: > // These permissions apply to the logging API > grant codeBase "file:${catalina.home}/bin/tomcat-juli.jar" { > -permission java.security.AllPermission; > +permission java.util.PropertyPermission > "java.util.logging.co

Re: svn commit: r609294 - in /tomcat/tc6.0.x/trunk: STATUS.txt conf/catalina.policy webapps/docs/changelog.xml

2008-01-10 Thread Remy Maucherat
On Thu, 2008-01-10 at 20:07 +, Mark Thomas wrote: > Remy Maucherat wrote: > > > > On my platform [Linux + IcedTea], with the new policy in place, I get an > > error initializing a timestamp used by the FileHandler (why such a class > > ends up using a file like t

RE: svn commit: r609294 - in /tomcat/tc6.0.x/trunk: STATUS.txt conf/catalina.policy webapps/docs/changelog.xml

2008-01-11 Thread Remy Maucherat
On Fri, 2008-01-11 at 13:27 -0500, Larry Isaacs wrote: > > I used java.security.debug=failure. The NPE isn't visible without it > > (and nothing gets logged). I also did try adding various file > > permissions, without much success. > > > > Rémy > > > > If I recall correctly, the "failure" option

Re: svn commit: r609294 - in /tomcat/tc6.0.x/trunk: STATUS.txt conf/catalina.policy webapps/docs/changelog.xml

2008-01-14 Thread Remy Maucherat
On Sun, 2008-01-13 at 22:38 +, Mark Thomas wrote: > Remy Maucherat wrote: > > On Fri, 2008-01-11 at 13:27 -0500, Larry Isaacs wrote: > >>> I used java.security.debug=failure. The NPE isn't visible without it > >>> (and nothing gets logged). I also did try

Re: [VOTE] tcnative releases independent from tomcat

2008-01-15 Thread Remy Maucherat
On Tue, 2008-01-15 at 16:19 +0100, jean-frederic clere wrote: > Hi, > > I think that the tcnative releases should be independent from tomcat. > There are several reasons: > - The native code is in /tomcat/connectors/trunk/jni/native and it > checked out via links in tc trunk/6.0.x/5.5.x. > - The

Re: [VOTE] tcnative releases independent from tomcat

2008-01-15 Thread Remy Maucherat
On Tue, 2008-01-15 at 17:54 +0100, Rainer Jung wrote: > Looking at it's formal qualities, it already has some properties of such > a product: > > - the API between tcnative and the component using it seems stable > - When we have a problem in tcnative, we fix it there and allow TC users > to upd

Re: new year, new version? 6.0.16

2008-01-17 Thread Remy Maucherat
On Wed, 2008-01-16 at 15:26 -0700, Filip Hanik - Dev Lists wrote: > could we get a target date for this? I believe there is enough community > interest to push out a new release There are still a lot of pending patches. Rémy

Re: new year, new version? 6.0.16

2008-01-17 Thread Remy Maucherat
On Thu, 2008-01-17 at 07:56 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > On Wed, 2008-01-16 at 15:26 -0700, Filip Hanik - Dev Lists wrote: > > > >> could we get a target date for this? I believe there is enough community > >> i

Re: [VOTE] tcnative releases independent from tomcat

2008-01-18 Thread Remy Maucherat
On Tue, 2008-01-15 at 16:19 +0100, jean-frederic clere wrote: > [X] Make tcnative release independent from tomcat release and add the > corresponding pages in http://tomcat.apache.org/connectors-doc/ > [ ] Remove existing tcnative releases. (others are using them). Rémy ---

Re: svn commit: r613196 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-01-18 Thread Remy Maucherat
On Fri, 2008-01-18 at 17:35 +0100, Peter Rossbach wrote: > HI Remy, > > the problem is the current getLastAccessedTime and getCreationTime > methods has standard formated Date result. Good > for humans, but bad for jmx scripts writers. You can't simply parse > those standard format strings at

Re: svn commit: r613796 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2008-01-21 Thread Remy Maucherat
On Mon, 2008-01-21 at 08:41 +, [EMAIL PROTECTED] wrote: > Author: pero > Date: Mon Jan 21 00:41:31 2008 > New Revision: 613796 > > URL: http://svn.apache.org/viewvc?rev=613796&view=rev > Log: > WatchedResource doesn't work if app is outside host appbase webapps The previous behavior has alway

Re: svn commit: r613796 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2008-01-21 Thread Remy Maucherat
Peter Rossbach wrote: The previous behavior has always been intentional, as I considered that webapps out of the auto deploy folder are not to be automagically managed by Tomcat. It's not a very important issue, but it seems you are committing this on a very fast track due to some customer need :

Re: Patch for tomcat 5.5.25 to actually close on Connection: close

2008-01-25 Thread Remy Maucherat
On Thu, 2008-01-24 at 17:11 -0500, John Wehle wrote: > Currently if a servlet uses: > > res.setHeader("Connection", "close"); > > tomcat just sets the header and sends the reponse to the client. It > then waits for the client to close the connection. In some cases (i.e. > buggy client) the cl

[VOTE] Release build 6.0.16

2008-01-30 Thread Remy Maucherat
The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.16/ According to the release process, the 6.0.16 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Rémy - To unsubscribe, e-mail: [EMAIL P

Re: svn commit: r616973 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-01-31 Thread Remy Maucherat
On Thu, 2008-01-31 at 19:21 +, Mark Thomas wrote: > [EMAIL PROTECTED] wrote: > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > > URL: > > http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=616973&r1=616972&r2=616973&view=diff > >

Re: [VOTE] Release build 6.0.16

2008-02-01 Thread Remy Maucherat
On Wed, 2008-01-30 at 15:21 +0100, Remy Maucherat wrote: > The candidates binaries are available here: > http://people.apache.org/~remm/tomcat-6/v6.0.16/ > > According to the release process, the 6.0.16 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [ ] Stable Ok, the vo

Re: [VOTE] Release build 6.0.16

2008-02-01 Thread Remy Maucherat
On Sat, 2008-02-02 at 00:14 +0100, Rainer Jung wrote: > Can't vote before Sunday evening, but no need to wait for that. I'll wait at least until monday. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

Re: [VOTE] Release build 6.0.16

2008-02-05 Thread Remy Maucherat
Rainer Jung wrote: Remy Maucherat schrieb: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.16/ According to the release process, the 6.0.16 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Rémy One small note: there is a new Thumbs.db file in server

Re: [VOTE] Release build 6.0.16

2008-02-05 Thread Remy Maucherat
On Tue, 2008-02-05 at 17:57 +0100, Rainer Jung wrote: > Remy Maucherat wrote: > > Rainer Jung wrote: > >> Remy Maucherat schrieb: > >>> The candidates binaries are available here: > >>> http://people.apache.org/~remm/tomcat-6/v6.0.16/ > >>> >

Re: Tomcat 6.0.16 RPM Package Available

2008-02-07 Thread Remy Maucherat
On Thu, 2008-02-07 at 07:42 -0800, Jason Brittain wrote: > - Zero RPM package dependencies on any other RPM packages, for ease > of installation as a single file (other than Java itself, which you > already have). Hum, that last feature doesn't look so good to me :( Rémy

[ANN] Apache Tomcat 6.0.16 released

2008-02-08 Thread Remy Maucherat
The Apache Tomcat team announces the immediate availability of Apache Tomcat 6.0.16 stable. This release includes many bugfixes over Apache Tomcat 6.0.14. Apache Tomcat 6.0 includes new features over Apache Tomcat 5.5, including support for the new Servlet 2.5 and JSP 2.1 specifications, a refacto

Re: Cookies are broken in 6.0.16?

2008-02-09 Thread Remy Maucherat
On Sat, 2008-02-09 at 13:03 +, Mark Thomas wrote: > Maik Jablonski wrote: > > Hi, > > > > I've just encountered that Cookies seem to be a little bit broken in > > 6.0.16. If you want to read a cookie which ends on one or more > > equals-sign (=), the equals-signs are removed by Tomcat when the

Re: Cookies are broken in 6.0.16?

2008-02-09 Thread Remy Maucherat
On Sat, 2008-02-09 at 16:14 -0700, Filip Hanik - Dev Lists wrote: > no regression, if you do this > > c = new javax.servlet.http.Cookie("abcv1","123=="); > c.setVersion(1); > response.addCookie(c); > > then it works just fine. > > however, if you do > c = new javax.servlet.http.Cookie("a

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Jim Manico wrote: > I guess we could throw a run time exception if the value contained any of those. other than that, I'm not sure how to behave I think this is the best case scenario for v0 cookies. Perhaps, if you really want to get fancy, you can add a flag t

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Remy Maucherat
On Sun, 2008-02-10 at 11:44 -0500, Jim Manico wrote: > Filip - you are 100% correct on this thread. Are you basically the > traffic cop guarding the core of Tomcat? I understand, you are not impacted by the behavior change, and as a result this allows you to be "fair", I suppose. The issue is tha

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Remy Maucherat
On Sun, 2008-02-10 at 11:17 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > On Sun, 2008-02-10 at 11:44 -0500, Jim Manico wrote: > > > >> Filip - you are 100% correct on this thread. Are you basically the > >> traffic cop guarding the co

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Remy Maucherat
On Sun, 2008-02-10 at 23:29 +, Mark Thomas wrote: > Filip Hanik - Dev Lists wrote: > > Would this be ok, given its a spec class? or do we have to leave this > > class untouched and modify it elsewhere, in which case it'd be more of a > > hack. > > I think, as long as we leave the public inte

Re: Implementing wildcard hostnames or aliases

2008-02-13 Thread Remy Maucherat
Michael Wyraz wrote: Hi, I was searching for a way to use wildcard host names in tomcat (e.g. *.myhost.com). With the current implementation it seems not to be possible. I found some ideas like using a valve at engine level which forwards to the correct hostname. The problem with this is that

Re: svn commit: r628117 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-18 Thread Remy Maucherat
On Sun, 2008-02-17 at 02:40 +, Filip Hanik - Dev Lists wrote: > [EMAIL PROTECTED] wrote: > > Author: remm > > Date: Fri Feb 15 08:49:10 2008 > > New Revision: 628117 > > > > > > > > * Allow old style cookie values to work(auto switch to v1) (regression) > >http://svn.apache.org/viewvc?

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Remy Maucherat
On Wed, 2008-02-27 at 12:51 -0700, Filip Hanik - Dev Lists wrote: > Bill Barker wrote: > > "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message > > news:[EMAIL PROTECTED] > > > >> Filip Hanik - Dev Lists wrote: > >> > &

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Remy Maucherat
On Wed, 2008-02-27 at 16:04 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > >> unfortunately, the "elegant" solution caused a regression :( > >> http://issues.apache.org/bugzilla/show_bug.cgi?id=44494 > >> I tested this with the in

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Remy Maucherat
On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > This makes me think there's a straight issue in CharChunk (I suppose the > > problem is that realReadChars gets called with len = 0; if it handled > > that scenario, things sho

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Remy Maucherat
On Wed, 2008-02-27 at 18:25 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: > > > >> Remy Maucherat wrote: > >> > >>> This makes me think there's a straig

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Remy Maucherat
On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: > Index: java/org/apache/catalina/connector/InputBuffer.java > === > ---java/org/apache/catalina/connector/InputBuffer.java(revision > 630535) > +++

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Remy Maucherat
On Mon, 2008-03-03 at 21:13 +, Mark Thomas wrote: > Filip Hanik - Dev Lists wrote: > > Mark Thomas wrote: > >> Remy Maucherat wrote: > >>> On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: > >>>> Index: java/o

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Remy Maucherat
On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > This problem is a small detail. Much more should be done if you want to > > do a refactoring: both the mark functionality and readLine need to have > > direct access to the buffer t

Re: DispatchData in ApplicationContext causes ClassLoader leak

2008-03-04 Thread Remy Maucherat
On Tue, 2008-03-04 at 12:32 +0200, Arto Huusko wrote: > The DispatchData subclass in org.apache.cataline.core.ApplicationContext > causes ClassLoader leak, when a web application is undeployed. And so you feel your bug is important enough to spam about it ? Rémy ---

Re: DispatchData in ApplicationContext causes ClassLoader leak

2008-03-04 Thread Remy Maucherat
On Tue, 2008-03-04 at 12:45 +0100, Remy Maucherat wrote: > On Tue, 2008-03-04 at 12:32 +0200, Arto Huusko wrote: > > The DispatchData subclass in org.apache.cataline.core.ApplicationContext > > causes ClassLoader leak, when a web application is undeployed. > > And so

Re: Possible bug in forwarding HEAD requests

2008-03-07 Thread Remy Maucherat
On Fri, 2008-03-07 at 20:46 +, Mark Thomas wrote: > David Jencks wrote: > > I wondered if there would be consensus that this is a bug > +1 > > and the proposed fix is appropriate? > +1 This issue was actually found a long time ago, but we couldn't fix it. Now our API bundle is no longer offici

Re: Adding HTTPOnly support to Tomcat

2008-03-10 Thread Remy Maucherat
On Sun, 2008-03-09 at 19:56 -0700, Filip Hanik - Dev Lists wrote: > haven't forgotten about you, it's still on the todo list. I am against adding support for IE only hacks ? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For

Re: Adding HTTPOnly support to Tomcat

2008-03-10 Thread Remy Maucherat
On Mon, 2008-03-10 at 08:16 -0400, Jim Manico wrote: > Rely, > > This is not a ms hack, but a security enhancement supported by all > browsers. Do some research and get back to us. This feature does not have good browser support, and I think it's a hack. Well, at least you know how I will vote

Re: svn commit: r638442 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-18 Thread Remy Maucherat
On Tue, 2008-03-18 at 16:05 -0600, Filip Hanik - Dev Lists wrote: > Mark Thomas wrote: > > Filip Hanik - Dev Lists wrote: > >> this wont work either. for the value of the cookie, it must be what > >> it was before. tspecials2. those are the correct characters for the > >> "value" of the cookie, b

Re: svn commit: r638854 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-19 Thread Remy Maucherat
On Wed, 2008-03-19 at 15:03 +, [EMAIL PROTECTED] wrote: > Author: fhanik > Date: Wed Mar 19 08:03:50 2008 > New Revision: 638854 > > URL: http://svn.apache.org/viewvc?rev=638854&view=rev > Log: > change a vote > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/t

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-19 Thread Remy Maucherat
On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote: >+1 : remm, markt > - -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also > saw the bug report, informing about further issues that are still valid > + +1 : fhanik - I don't think we should support mark/reset, we

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-20 Thread Remy Maucherat
On Wed, 2008-03-19 at 18:17 -0600, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > > On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote: > > > >>+1 : remm, markt > >> - -1 : fhanik - I tried this patch, and it doesn't work, it

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 11:25 -0600, Filip Hanik - Dev Lists wrote: > what this filter does, is it relies on the already implemented > BufferedReader, no need to reinvent the wheel. > The java.io.BufferedReader, already has this logic implemented, and it > works, so CoyoteReader, will only be treat

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 14:29 -0600, Filip Hanik - Dev Lists wrote: > I'd prefer to move forward with just the truncation fix so that we can > move towards a release. > > Any other efforts can be postponed at this time. If the mark/reset bug > in fact exists, there is an easy work around, and that

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote: > Remy Maucherat wrote: > regression, the fact that you can't read more than 8k when using > ServletRequest.getReader I proposed a patch for that. If it doesn't fix it with the patch I proposed applied, I w

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Remy Maucherat
On Fri, 2008-03-21 at 21:44 +, Mark Thomas wrote: > The cookies patch is short and you haven't voted yet so if you > could find the time to review the cookies patch we could get to agreed > fixes for both issues quite quickly. I did get lost somewhere between the new new patch and the new ne

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-07 Thread Remy Maucherat
On Mon, 2008-04-07 at 22:47 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Mon Apr 7 15:47:54 2008 > New Revision: 645722 > > URL: http://svn.apache.org/viewvc?rev=645722&view=rev > Log: > All of the issues I was seeing with mark/reset were due to states that > resulted in a call to Char

Re: svn commit: r646106 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Remy Maucherat
On Tue, 2008-04-08 at 22:26 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Tue Apr 8 15:26:05 2008 > New Revision: 646106 > > URL: http://svn.apache.org/viewvc?rev=646106&view=rev > Log: > Better patch for 44766. I still can't see why the original code listed the > classes individually.

Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java

2008-04-10 Thread Remy Maucherat
On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Wed Apr 9 15:29:28 2008 > New Revision: 646571 > > URL: http://svn.apache.org/viewvc?rev=646571&view=rev > Log: > Clean up type checking code. Patch provided by Konstantin Kolinko. > > Modified: > tomcat/trun

Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java

2008-04-10 Thread Remy Maucherat
On Thu, 2008-04-10 at 19:01 +0100, Mark Thomas wrote: > Remy Maucherat wrote: > > On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote: > >> Author: markt > >> Date: Wed Apr 9 15:29:28 2008 > >> New Revision: 646571 > >> > >> URL: htt

Re: svn commit: r648019 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-15 Thread Remy Maucherat
On Mon, 2008-04-14 at 21:51 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Mon Apr 14 14:51:34 2008 > New Revision: 648019 > > URL: http://svn.apache.org/viewvc?rev=648019&view=rev > Log: > Proposal Since the biggest problems are supposedly fixed, maybe it would be time for a new build ?

Re: Osgifing Tomcat

2008-04-23 Thread Remy Maucherat
On Tue, 2008-04-22 at 12:45 +0200, Henri Gomez wrote: > Hi to all, > > Did there is plans, ideas or interest around about OSGI-fing Tomcat ? The only thing which ever attracts you is pointless hype, it's quite funny ;) Rémy -

Re: Osgifing Tomcat

2008-04-23 Thread Remy Maucherat
On Wed, 2008-04-23 at 14:23 +0200, Henri Gomez wrote: > > The only thing which ever attracts you is pointless hype, it's quite > > funny ;) > > Remy, I, and many others, will be happy, at least one time, see you > discuss technicals and usage aspects of a Tomcat evolution. > > * What's the pros

Re: Osgifing Tomcat

2008-04-23 Thread Remy Maucherat
On Wed, 2008-04-23 at 16:00 +0200, Florent.BENOIT wrote: > Also, for OSGi, as all is done by package (import/export) the first step > is to be sure that API and Implementation are never in the same package > name. So we can export APIs and keep private the implementation. I think the first main

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-29 Thread Remy Maucherat
On Tue, 2008-04-29 at 22:09 +0200, Henri Gomez wrote: > Just a new thread to discuss about mavenizing Tomcat (OSGI Thread is > allready fully loaded and really interesting). > > Costin told us he didn't want to change the current source layout. > > Alternative to mavenizing tomcat could be : > >

Re: Osgifing Tomcat

2008-04-29 Thread Remy Maucherat
On Tue, 2008-04-29 at 22:12 +0200, Henri Gomez wrote: > Read on serverside that JSR-315 needs ideas for servlet 3.0 specs. You should try to read the article I think :) This is about a specific issue, where there's no actual disagreement (basically it is a publicity stunt). Rémy --

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-29 Thread Remy Maucherat
On Tue, 2008-04-29 at 21:03 -0400, Yoav Shapira wrote: > But like I said earlier, it's not worth disrupting the current Tomcat > build or source layout. Only if it can be done without requiring any > changes, which it can. I will still vote against any inclusion of Maven usage in TC 6.0, 5.5 and

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-30 Thread Remy Maucherat
On Tue, 2008-04-29 at 22:28 -0400, Yoav Shapira wrote: > On Tue, Apr 29, 2008 at 10:09 PM, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > The current build scripts are fully tested and work well. Adding > > additional methods of building or replacing these scripts altog

Re: Generics and the spec interfaces

2008-05-06 Thread Remy Maucherat
On Tue, 2008-05-06 at 08:27 +0100, Mark Thomas wrote: > I am leaning towards 4 on the basis that > a) This is trunk, not a release branch > b) This option generates no warnings > c) I assume the spec will start using generics at some point (maybe in 3.0?) > If modifying the spec interfaces seems li

Re: svn commit: r654932 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2008-05-11 Thread Remy Maucherat
On Fri, 2008-05-09 at 20:21 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Fri May 9 13:21:20 2008 > New Revision: 654932 > > URL: http://svn.apache.org/viewvc?rev=654932&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42934 > Trigger contextInitialized() before

Re: svn commit: r656839 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/Validator.java webapps/docs/changelog.xml

2008-05-16 Thread Remy Maucherat
On Fri, 2008-05-16 at 14:08 +0100, Mark Thomas wrote: > >> java.lang.NullPointerException > >>at > >> org.apache.jasper.compiler.Validator$DirectiveVisitor.comparePageEncodings(Validator.java:330) > > Yep, my bad. I'll take a look over the weekend. Fix should be simple. Woops, I hadn't rerev

Re: svn commit: r658132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-20 Thread Remy Maucherat
On Tue, 2008-05-20 at 07:34 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Tue May 20 00:34:01 2008 > New Revision: 658132 > > URL: http://svn.apache.org/viewvc?rev=658132&view=rev > Log: > Add some comments to Remy's -1s >-1: remm (I think it is a good patch, but it throws an error f

<    5   6   7   8   9   10   11   12   >