Re: svn commit: r1456491 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2013-03-15 Thread Nicholas Williams
On Mar 15, 2013, at 4:50, Rainer Jung wrote: > On 14.03.2013 16:47, ma...@apache.org wrote: >> Author: markt >> Date: Thu Mar 14 15:47:24 2013 >> New Revision: 1456491 >> >> URL: http://svn.apache.org/r1456491 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54660 >> Allow the Ac

Re: [Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-19 Thread Nicholas Williams
On Mar 19, 2013, at 8:31, "bugzi...@apache.org" wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 > > Mark Thomas changed: > > What|Removed |Added > > Status

OT: Will web containers be required to implement WebSockets

2013-03-21 Thread Nicholas Williams
I know that WebSockets will be a part of the Java EE 7 specification for full application servers. But will web containers also be required to implement this? Or will it be optional, and Tomcat is just being nice? :-) Nick Sent from my iPhone, so please forgive brief replies and frequent typos

Re: OT: How do I subscribe to the Tomcat Dev/User lists with my @apache.org address?

2013-05-14 Thread Nicholas Williams
On Tue, May 14, 2013 at 7:13 PM, sebb wrote: > On 15 May 2013 00:37, Christopher Schultz > wrote: > > Nick, > > > > On 5/14/13 6:35 PM, Nick Williams wrote: > >> I recently became a committer on the Logging project and thus I now > have an @apache.org address. Since it's a forwarding address, I'

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nicholas Williams
On Tue, Aug 20, 2013 at 1:10 PM, Mark Thomas wrote: > On 20/08/2013 18:47, Nick Williams wrote: >> My remaining original concern was the best approach for weaving byte >> code in Tomcat's unit tests, which I detailed in an earlier message. > > Use the Weaver to completely replace the byte code of