Re: svn commit: r783570 - /tomcat/current/tc4.1.x/STATUS.txt

2009-06-11 Thread Konstantin Kolinko
s will be much appreciated. > > Mark > It is odd to see that encoding is being set after obtaining a writer, but the old code does effectively the same, isn't it? May be I do not understand something... Best regards, Konstantin Kolinko

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
Sorry for somewhat slow reply, but just on formal grounds it is [x] BROKEN - I found some show stoppers See http://apache.org/legal/src-headers.html#notice http://www.apache.org/dev/release.html#distribute-other-artifacts So, a copy of a LICENSE and NOTICE files is required, at least along with

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
2009/6/11 Konstantin Kolinko : > Sorry for somewhat slow reply, > but just on formal grounds it is > >  [x] BROKEN - I found some show stoppers > > See > http://apache.org/legal/src-headers.html#notice > http://www.apache.org/dev/release.html#distribute-other-artifacts >

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
jdbc-1.0.3.zip, *.tar.gz are distribution that will be downloadable, aren't they? Unpacking a distribution and clicking those *.html files will open a document with missing images. Best regards, Konstantin Kolinko - To un

Re: svn commit: r783570 - /tomcat/current/tc4.1.x/STATUS.txt

2009-06-11 Thread Konstantin Kolinko
issue, and won't change the error page encoding for existing applications. We cannot fix CharsetMapper, because it can be overwritten, but we can fix those places where it is called. Here is the patch: http://people.apache.org/~kkolinko/patches/2009-06-12_tc41_CharsetMapper.patch Best regard

Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

2010-04-29 Thread Konstantin Kolinko
2010/4/29 sebb : > On 29/04/2010, Konstantin Kolinko wrote: >> 2010/4/29 sebb : >>  > >>  > Just a thought - could perhaps remove the Date keyword to stop it being >> used? >>  > >> >> >> True, but >>  a) I do not see a fast and

Re: svn commit: r939221 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java

2010-04-29 Thread Konstantin Kolinko
2010/4/29 Konstantin Kolinko : > 2010/4/29 Peter Roßbach : >> A lot of tomcat classes has this problem. I found 861 java files at tomcat 7 >> with token "Revision"! >> > > $Revision$ keyword is OK. It is $Date$ that is faulty > I replaced all occurren

Comet API incompatibility between TC 6 and TC 7

2010-04-29 Thread Konstantin Kolinko
hose web applications explicitly. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread Konstantin Kolinko
2010/5/1 : > Author: markt > Date: Sat May  1 14:26:50 2010 > New Revision: 940038 > > URL: http://svn.apache.org/viewvc?rev=940038&view=rev > Log: > Minor clean-up having reviewed the diff between current code and the code > prior to the Lifecycle re-factoring > > @@ -780,11 +780,7 @@ public cl

Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread Konstantin Kolinko
2010/5/1 Mark Thomas : > On 01/05/2010 16:15, Konstantin Kolinko wrote: >> 2010/5/1  : >> Why are you removing the above try/catch? > > It was added to catch LifecycleException when I made Catalina implement > Lifecycle. When I removed that interface, I changed this to Exce

Re: clearReferencesThreads, Poller SunPKCS11-Solaris and strange context class loader

2010-05-07 Thread Konstantin Kolinko
y original post. > TCCL is inherited from the parent thread. It means that that thread was started either during request processing, or during webapplication startup. BTW, 4th result in http://www.google.com/search?q=SunPKCS11+TokenPoller gives source code for that class. Be

Re: clearReferencesThreads, Poller SunPKCS11-Solaris and strange context class loader

2010-05-07 Thread Konstantin Kolinko
2010/5/7 Rainer Jung : > On 07.05.2010 11:00, Konstantin Kolinko wrote: >> >> 2010/5/7 Rainer Jung: >>> >>> I'm wondering why the PCKS Token >>> Poller thread was captured by the leak prevention. Since we know the >>> code, >

Re: clearReferencesThreads, Poller SunPKCS11-Solaris and strange context class loader

2010-05-09 Thread Konstantin Kolinko
y.AuthProvider 3. SunPKCS11() constructor calls initToken(slotInfo) and that method will call createPoller() if the token is not present in the slot. (Thus apparently it starts waiting for the token). 4. It is said that PKCS11 "defines a platfor

Re: CSRF prevention filter and Tomcat 5/6

2010-05-10 Thread Konstantin Kolinko
e A+C: E. Use a different name for the new role that allows access to GUI interface only, "manager-gui", as well as new "manager-script", "manager-jmx", "manager-status". We can even rename "manager&qu

Re: svn commit: r943081 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties MapperListener.java

2010-05-11 Thread Konstantin Kolinko
object [{0}]. Changes in the object state may not be correctly reflected in > the mapper for connector [{1}] in domain [{2}]. s/mapperLister./mapperListener./ both in *.properties and in *.java Best regards, Konstantin Kolinko -

Re: svn commit: r944390 - in /tomcat/tc6.0.x/trunk: STATUS.txt build.properties.default build.xml webapps/docs/changelog.xml

2010-05-15 Thread Konstantin Kolinko
t;General" section and why it does not fit into the existing section "Other"? I can say it is a notable change, but we usually also have important changes/fixes in Catalina or Jasper, so what is different here? We can always add it to the top of the respective section. Best re

Re: svn commit: r944390 - in /tomcat/tc6.0.x/trunk: STATUS.txt build.properties.default build.xml webapps/docs/changelog.xml

2010-05-15 Thread Konstantin Kolinko
2010/5/15 Mark Thomas : > On 15/05/2010 13:48, Konstantin Kolinko wrote: >> 2010/5/14: >>> >>> Author: markt >>> Date: Fri May 14 18:54:22 2010 >>> New Revision: 944390 >>> >>> URL: http://svn.apache.org/viewvc?rev=944390&view=re

Re: svn commit: r944511 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2010-05-15 Thread Konstantin Kolinko
uals(scName) with null value for scName caused the NullPointerException reported by Gump. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r944918 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

2010-05-16 Thread Konstantin Kolinko
t method: my IDE does not find any references to the find* methods (findChar, findChars and findNotChars) of ByteChunk in our trunk or in TC6. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r944918 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

2010-05-17 Thread Konstantin Kolinko
2010/5/17 Mark Thomas : > On 17/05/2010 00:03, Konstantin Kolinko wrote: >> 2010/5/17  : >>> Author: markt >>> Date: Sun May 16 21:31:57 2010 >>> New Revision: 944918 >>> >>> URL: http://svn.apache.org/viewvc?rev=944918&view=rev >>>

Re: svn commit: r944918 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

2010-05-17 Thread Konstantin Kolinko
2010/5/17 Mark Thomas : > On 17/05/2010 09:49, Konstantin Kolinko wrote: >> findChar() was the "correct" implementation. >> It is indexOf() that is 0-127. > > We could fix that but given the current usage, I am happy with just > supporting 0-127. > I

Re: svn commit: r944918 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

2010-05-17 Thread Konstantin Kolinko
2010/5/17 Mark Thomas : > On 17/05/2010 10:47, Konstantin Kolinko wrote: >> 2010/5/17 Mark Thomas : >>> On 17/05/2010 09:49, Konstantin Kolinko wrote: >>>> findChar() was the "correct" implementation. >>>> It is indexOf() that is 0-127. >>

Re: svn commit: r944918 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

2010-05-17 Thread Konstantin Kolinko
is as good a time as any. > I am +1 for the name change. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r945231 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

2010-05-17 Thread Konstantin Kolinko
body has tried to optimize it for performance. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Draft of first blog post announcing TC7

2010-05-17 Thread Konstantin Kolinko
vailable in the latest 6.0 releases ;). s/&/and/ ? There also must be a link to http://tomcat.apache.org/migration.html#6.0.x_to_7.0.x Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache

Re: svn commit: r945231 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

2010-05-17 Thread Konstantin Kolinko
2010/5/17 Mark Thomas : > On 17/05/2010 18:08, Mark Thomas wrote: >> On 17/05/2010 17:50, Konstantin Kolinko wrote: >>> I am a bit shivering looking at ([a++] != [b++]), >>> but I did minimal changes to fix the issue. >> >> Understood. If I get a chance, I&

Re: svn commit: r945271 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamFilter.java DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestConte

2010-05-17 Thread Konstantin Kolinko
of 'else' branches? http://svn.apache.org/viewvc?rev=945265&view=rev Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: About to tag Tomcat 7.0.0-RC2

2010-05-17 Thread Konstantin Kolinko
know what is the deal. I done a clean run, but the tests are still succeeding. Is there access to /srv/gump/public/workspace/tomcat-trunk/output/build/logs/ to look at the output file from the test run? Best regards, Konstantin Kolinko ---

Re: About to tag Tomcat 7.0.0-RC2

2010-05-17 Thread Konstantin Kolinko
2010/5/17 Rainer Jung : > On 17.05.2010 19:56, Konstantin Kolinko wrote: >> >> 2010/5/17 Mark Thomas: >>> >>> I've just completed testing of trunk. >>> >>> Unit tests - pass >>> >> >> They also pass for me, but Gump fai

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-05-18 Thread Konstantin Kolinko
r.TestCoyoteAdaptor.testPath(TestCoyoteAdaptor.java:58) at org.apache.catalina.connector.TestCoyoteAdaptor.testPathParams(TestCoyoteAdaptor.java:49) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-un

Re: Draft of first blog post announcing TC7

2010-05-18 Thread Konstantin Kolinko
port/support for mapping external folders into web application context (aliases)/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-05-19 Thread Konstantin Kolinko
2010/5/18 Konstantin Kolinko : > 2010/5/18 Bill Barker : >> The current state of this project is 'Failed', with reason 'Build Failed'. >> For reference only, the following projects are affected by this: >>    - tomcat-trunk-test :  Java Servlet 3.0, Java

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-05-19 Thread Konstantin Kolinko
2010/5/19 Mark Thomas : > On 19/05/2010 12:25, Konstantin Kolinko wrote: >> In the meanwhile, >> As of now (at revision 946127), >> org.apache.catalina.mbeans.TestRegistration  fails for me: >> >> Testcase: testMBeanDeregistration took 1,907 sec >>  

Re: [VOTE] Move tomcat/trunk/modules to tomcat/modules

2010-05-19 Thread Konstantin Kolinko
.x/trunk branch. 2010/5/19 Mark Thomas : > [x] 0 Move them, leave them. Don't mind. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-05-19 Thread Konstantin Kolinko
2010/5/19 Konstantin Kolinko : > 1. I fixed the issues with tests failing because of non-default value of ${tomcat.output}. All tests on a VM running Linux are now completing successfully for me. 2. Gump run has happened. The failures in TestCoyoteAdapter were observed. http://vmgump.apache.

Re: svn commit: r946583 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2010-05-20 Thread Konstantin Kolinko
 File docBase = new File(System.getProperty("java.io.tmpdir")); > + Just a note: in r946241 I added TomcatBaseTest#getTemporaryDirectory(), that exposes TomcatBaseTest.tempDir Thus now we are able to get rid of those System.getProperty("ja

Port tomcat-juli.jar handling from TC6 to TC7

2010-05-21 Thread Konstantin Kolinko
revert current implementation of the feature in trunk and port the implementation from TC6 (r885002). Are there any objections? The essence is that bootstrap.jar will mention tomcat-juli.jar in its "Class-Path" value in its MANIFEST.MF. It does not mention it in the current trunk. Best reg

Re: Port tomcat-juli.jar handling from TC6 to TC7

2010-05-21 Thread Konstantin Kolinko
support issue for one of our customers. This sound bad. Well, if your concerns are really serious and we go this way, let's 1. Remove commons-daemon.jar reference from bootstrap.jar manifest as well. 2. Update JSVC instructions in setup.html AFAIK, the c

Re: svn commit: r948294 - in /tomcat/tc5.5.x/trunk: ./ container/webapps/docs/ jasper/src/share/org/apache/jasper/ jasper/src/share/org/apache/jasper/compiler/ jasper/src/share/org/apache/jasper/sec

2010-05-26 Thread Konstantin Kolinko
there any observable consequences? If they are, you may file an issue. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r948294 - in /tomcat/tc5.5.x/trunk: ./ container/webapps/docs/ jasper/src/share/org/apache/jasper/ jasper/src/share/org/apache/jasper/compiler/ jasper/src/share/org/apache/jasper/sec

2010-05-26 Thread Konstantin Kolinko
but all they are more confusing than the current name). > May I suggest adding a comment to document this for future maintainers? > ;) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Changing the 10th anniversary logo

2010-05-29 Thread Konstantin Kolinko
nths ago) Though I am +1 to return to the original logo now / in few days, as the summer starts. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Weekly Bugzilla e-mails are missing on dev@

2010-06-01 Thread Konstantin Kolinko
Hi! I just noticed that dev@ no more receives those weekly "Bug report" emails from Bugzilla. The last ones that I saw were on 2010-04-11, http://marc.info/?t=12710273891&r=1&w=2 Best regards, Konstantin Kolinko --

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-06-02 Thread Konstantin Kolinko
e timer threads is now disabled by default. All other tests run by Gump completed successfully. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands

Re: svn commit: r948044 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-06-02 Thread Konstantin Kolinko
ose should not/cannot be backported as they are, because that method differs in tc6.0.x. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r951093 - in /tomcat/trunk/java/org/apache: catalina/connector/ coyote/ coyote/ajp/ coyote/http11/

2010-06-04 Thread Konstantin Kolinko
gument was not used. Though if its value is always zero then nobody will notice the difference. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Release plans for 6.0.27 - ?

2010-06-04 Thread Konstantin Kolinko
Hi! When can we make 6.0.27? There were a couple of important fixes since 6.0.26, like BZ 48903 (classloader deadlock). I think it is about time to make 6.0.27. I think that the logging improvement will need some more work and can go into the next release. Best regards, Konstantin Kolinko

Re: svn commit: r952000 - /tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java

2010-06-06 Thread Konstantin Kolinko
tDone = true; } finally { if (!startDone) { setState(LifecycleState.FAILED); } } Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r951992 - in /tomcat/trunk/java/org/apache/catalina/ha: authenticator/ClusterSingleSignOn.java authenticator/ClusterSingleSignOnListener.java session/ClusterSessionListener.java

2010-06-07 Thread Konstantin Kolinko
bout this Valve implementation. >>       */ >>      protected static String info = > > Should be final? > Done in r952467 >>  -        "org.apache.catalina.cluster.authenticator.ClusterSingleSignOn"; >>  +        "org.apache.catalina.ha.authenticator.ClusterSingleSignOn"; >> Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JIKESPATH in setclasspath.sh

2010-06-08 Thread Konstantin Kolinko
be updated: bin/setclasspath.sh conf/web.xml webapps/docs/jasper-howto.xml. Best regards, Konstantin Kolinko 2010/6/9 Tim Funk : > From what I can tell, JIKESPATH is used by jikes which was an alternative > java compiler. (a long time ago). I believe this is unused (even in tomcat6) > -

Re: ISAPI Redirector issue | Building |

2010-06-09 Thread Konstantin Kolinko
some DLLs are missing? Are there any evidenced, that the dll does not work, besides a blank page? Note, that Tomcat can reply with a blank page if no ROOT application is configured in it. 3) I think that this question should have been sent to the users@ list. Best regard

Re: Uses of tool wrapper, sourcong setenv

2010-06-09 Thread Konstantin Kolinko
est regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Uses of tool wrapper, sourcong setenv

2010-06-09 Thread Konstantin Kolinko
gt; Moving that code from RealmBase to some standalone class makes perfect sense for me, but I have doubts about the rest of the above proposal. > make sure the code has zero dependencies It still has dependency on JRE that provides the digesting algorithm. // trunk RealBase, line 1184:

Timestamp when request was received

2010-06-09 Thread Konstantin Kolinko
field into org.apache.catalina.connector.Request The Request instance is already passed as an argument to AccessLog.log(..), so no need to add additional parameter there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: de

Re: tag 6.0.27 on Monday

2010-06-10 Thread Konstantin Kolinko
2010/6/10 jean-frederic clere : > Hi, > > I plan to tag 6.0.27 on Monday (European morning) and  start the release > process. > > Comments? > +1. BTW, I plan to be offline on this Sunday and Monday. Best regard

Re: [VOTE] Release build 6.0.27

2010-06-19 Thread Konstantin Kolinko
differences in dist/.KEYS vs ../tc6.0.x/trunk/KEYS are: 1) 1024-bit key of Remy Maucherat was removed 2) changed name in 4096-bit subkey of 1024-bit key of Remy: using UTF-8 instead of old single-byte encoding. 3) 4096-bit key of Jean-Frederic Clere was added. Best regards, Kon

Re: [VOTE] Release Apache Tomcat 7.0.0 as beta

2010-06-21 Thread Konstantin Kolinko
e propsoed 7.0.0 release is > [ ] Broken - do not release > [ ] Alpha  - go ahead and release as 7.0.0 Alpha > [x] Beta   - go ahead and release as 7.0.0 Beta Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-

Re: svn commit: r957830 - in /tomcat/trunk: java/org/apache/catalina/loader/LocalStrings.properties java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/config/context.xml

2010-06-25 Thread Konstantin Kolinko
...) > +        // Step through the methods in reverse order looking for a > +        // CoyoteAdapter.service() call. All requests will have this unless There are also CoyoteAdapter.event() CoyoteAdapter.asyncDispatch() Best regards, Konstantin Kolinko ---

Re: [VOTE] Release build 6.0.28

2010-06-29 Thread Konstantin Kolinko
/tomcat/tomcat-6/KEYS Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Proposal: Some todo's at AsyncContext detected...

2010-06-30 Thread Konstantin Kolinko
2010/6/30 Marc Guillemot : > Hi, > > What you write means that the freshly release Tomcat 7 doesn't fully > implement Servlet API 3.0, isn't it? > 1. It was released as Beta 2. It passes TCK Best re

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-01 Thread Konstantin Kolinko
. Best regards Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-01 Thread Konstantin Kolinko
2010/7/1 Jim Jagielski : > > On Jul 1, 2010, at 12:58 PM, Konstantin Kolinko wrote: > >> 2010/7/1 Jim Jagielski : >>> The builds for Tomcat 5.5.30 are ready for testing and approval. >>> The candidates binaries are available here: >>> >>>   htt

Re: RTF and fixcrlf during build

2010-07-04 Thread Konstantin Kolinko
uot; Maybe we can be more specific to what subcomponents that license applies? Based on the above experience for 5.5.x, I suspect that we can get rid of License.rtf and INSTALLLICENSE files, and display the same LICENSE in the installer. Best regards, Konstantin Kolinko

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-07-06 Thread Konstantin Kolinko
che.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.el.TestELInJsp.txt.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-06 Thread Konstantin Kolinko
cceeds, so the missing groupcom build files do not break the build. Tested installing, uninstalling, running some sample applications on WinXP 32-bit / JRE 6u20. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: de

Re: [VOTE] Release build 6.0.28

2010-07-06 Thread Konstantin Kolinko
available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.28/ > > According to the release process, the 6.0.28 build corresponding to the > tag TOMCAT_6_0_28 is: > [ ] Broken > [ ] Alpha > [ ] Beta > [x] S

Re: svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-07 Thread Konstantin Kolinko
y, so it makes sense to have such a check, but I think that there must be a way to turn it off. Re: https://issues.apache.org/bugzilla/attachment.cgi?id=25726 The patch is incomplete. The "SKIP_IDENTIFIER_CHECK" property is mentioned in documentation only. It is not used in the code. &

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread Konstantin Kolinko
t in general sense it has caveats). 3. There already are "tag.bat"/"tag.sh" scripts that perform URL -> URL copy. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r962881 - in /tomcat/trunk: java/org/apache/catalina/filters/CsrfPreventionFilter.java java/org/apache/catalina/filters/LocalStrings.properties webapps/docs/changelog.xml webapps/doc

2010-07-10 Thread Konstantin Kolinko
A typo in the docs patch above. s/Rnadom/Random/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [ANN] Apache Tomcat 5.5.30 released

2010-07-10 Thread Konstantin Kolinko
x/browser BTW, the only place that I know that lists the mail-lists where the announcements go is in mod_jk, http://svn.apache.org/repos/asf/tomcat/jk/trunk/HOWTO-RELEASE.txt Best regards, Konstantin Kolinko - To unsubscribe, e-

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-10 Thread Konstantin Kolinko
at already succeed for the existing code. Though if they always succeed they are not really useful. Regarding the checks that fail -- before enabling the check I would like to discuss whether we can fix the code in TC7, and whether we can bac

Re: svn commit: r961948 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELFunctionMapper.java webapps/docs/changelog.xml

2010-07-10 Thread Konstantin Kolinko
name > +         * @return          Canonical equivalent > +         */ > +        private String getCanonicalName(String className) { > +            return className.replace('$', '.'); > +        } >     } >  } > I wonder why funcInfo.getFunctionClass(

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Konstantin Kolinko
ty > -> not really a success Really? I thought it was a success. > - try to be ironical (...) > -> according to your comment, it seems that it fails as well Please see "How it works", esp. "Project Management" and "Decision Making" http://www.apache.org/foundation/how-it-works.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: New joiner - where to start

2010-07-13 Thread Konstantin Kolinko
t-7.0-doc/BUILDING.txt Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [PROPOSAL] Change the name of the default host in server.xml

2010-07-15 Thread Konstantin Kolinko
to access the server locally. 4) There is a chance that whatever new name you offer, it will be registered as domain name by somebody. E.g. "defaulthost" is already used by some hosting provider. Best regards, Konstantin Kolinko --

Re: Bug 49165 - Allow %{TIME_FORMAT}t As Configuration for AccessLogValve

2010-07-17 Thread Konstantin Kolinko
EW to RESOLVED after submitting the > patch? No. A bug is marked as resolved only after the issue was fixed in all affected Tomcat versions. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn history of StandardHostValve

2010-07-19 Thread Konstantin Kolinko
/valves/ErrorDispatcherValve class. http://svn.apache.org/viewvc?view=revision&revision=302028 The first revision of ErrorDispatcherValve (r.301082, 8 years ago) already has the flushBuffer() code, and r.301077 is where cvs2svn import of /container/catalina has started. Best regards, Konsta

Re: Not able to download eclipse-JDT-3.3.1.zip

2010-07-20 Thread Konstantin Kolinko
a ${base.path}) Once "eclipse/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar" file is present, the download will not be attempted anymore. See "jdt.loc" and other "jdt.*" settings in build.properties.default The http://archive.eclipse.org/... UR

Re: [VOTE] Release build 6.0.29

2010-07-21 Thread Konstantin Kolinko
[X] Stable > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r966586 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2010-07-22 Thread Konstantin Kolinko
cat/site/trunk/xdocs/whichversion.xml > > -  6.0.28 > +  6.0.29 I am not doing "svn up" now, because download page was not svn up'ed yet. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubsc

Re: svn commit: r981842 - /tomcat/trunk/webapps/docs/changelog.xml

2010-08-03 Thread Konstantin Kolinko
2010/8/3 : > +       > +        Update to Commons Daemon from 1.0.2 to 1.0.3.(markt) > +       One "to" should be enough. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@to

Re: SharingWebappClassLoader proposal

2010-08-03 Thread Konstantin Kolinko
w you describe it it seeks for trouble. A web application and be unloaded (stopped, reloaded) at any time. Since that moment any classes loaded by its classloader should not be accesses any more. Thus, no other web applications should keep references to them. Be

Re: svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-08-03 Thread Konstantin Kolinko
2010/8/3 Mark Thomas : > On 07/07/2010 12:16, Mark Thomas wrote: >> On 07/07/2010 11:36, Konstantin Kolinko wrote: >>> It is not mentioned there that Java language keywords are >>> also reserved. >> >> Yes it is. Section 1.19 in the EL 2.2 spec. >> &g

Re: Sharing Native Library from parent classloader?

2010-08-09 Thread Konstantin Kolinko
p://tomcat.apache.org/tomcat-6.0-doc/class-loader-howto.html In essence, you have to put your jar in ${catalina.base}\lib and at the same time _remove_ it from your webapp. The result will be that it will be loaded by the Common classloader. Best regards, Konstantin Kolinko

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2010-08-11 Thread Konstantin Kolinko
73/steps/compile/logs/stdio says: BUILD FAILED /home/buildslave3/slave3/tomcat-trunk/build/build.xml:440: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Best regards, Konstantin Kolinko - To uns

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-08-24 Thread Konstantin Kolinko
Client.java:202) at org.apache.catalina.authenticator.TestFormAuthenticator.doTest(TestFormAuthenticator.java:59) at org.apache.catalina.authenticator.TestFormAuthenticator.testGet(TestFormAuthenticator.java:30) Best regards, Konstantin Kolinko -

Re: Links to Sun/Oracle on welcome page

2010-08-25 Thread Konstantin Kolinko
uld link to www.apache.org. These probably were made for this preview, but shall be corrected before committing: - examples app links should be relative links, without explicit "localhost:8080". - documentation links should go to tomcat.apache.org, or to local /docs/ ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Links to Sun/Oracle on welcome page

2010-08-27 Thread Konstantin Kolinko
better to mention both [1] and [2]. 3. It came to my mind, that not only those two specs might be important, but also some others, like the ones mentioned here: http://markmail.org/message/olpuftjrqhcfk3vb Maybe create a Wiki page to list the relevant specification links? (I don't have t

Re: Finding the context of a Request at the point of parsing session

2010-08-29 Thread Konstantin Kolinko
I decoding" part of postParseRequest(). You have to take care of that before invoking the mapper. If I am reading the code correctly, parseSessionId() call modifies the req.requestURI() bytechunk if a semicolon was there. Best regards, Konstantin Kolinko

Using JDK compiler with Tomcat (was: Re: svn commit: r999941)

2010-09-22 Thread Konstantin Kolinko
rrent *.sh/*.bat files of 6.0.x and 5.5.x. It looks that that phrase can be removed. Am I missing anything else? Reading "Using Jikes" part there, http://tomcat.apache.org/tomcat-5.5-doc/jasper-howto.html#Using_Jikes maybe it means, that one has to edit conf/web.xml and set the

Re: svn commit: r1000003 - /tomcat/trunk/webapps/docs/logging.xml

2010-09-22 Thread Konstantin Kolinko
rints to System.err by default. The exceptions that are caught by Tomcat are printed to catalina..log, not only to the console. Maybe that phrase can be removed as a whole. Best regards, Konstantin Kolinko - To unsubs

Re: NamingContext Possible Bug

2010-09-23 Thread Konstantin Kolinko
global resource in server.xml and a ResourceLink in your context.xml. [2] It would be undesirable to break that. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=47512 [2] http://tomcat.apache.org/tomcat-6.0-doc/jndi-resources-howto.html#context

Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2010-09-26 Thread Konstantin Kolinko
2010/9/26 sebb : > On 26 September 2010 10:00, Tim Whittington wrote: >> Bah. Trying to convince Eclipse not to use tabs is proving tricky - >> will be more vigilent.. > > Hit me too amny times. > > The tabs setting for the XML editor is in a different place: > Preferences / XML / XML Files / Edit

Re: [OT] Difficulty creating working patch - renamed file.

2010-09-28 Thread Konstantin Kolinko
Regarding BZ 50001, note that *.launch files have already been moved and renamed in the current /trunk. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1002277 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-28 Thread Konstantin Kolinko
.apache.org/viewvc?rev=1002274&view=rev >> +  +1: markt >> +  -1: >> > > Could you guys (markt and kkolinko) setup your editors > so that they don't leave files with trailing spaces? > Sorry, but no. I cannot say

Re: svn commit: r1002277 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-28 Thread Konstantin Kolinko
2010/9/28 Mladen Turk : > On 09/28/2010 08:16 PM, Konstantin Kolinko wrote: >> >> 2010/9/28 Mladen Turk: >>> >>> On 09/28/2010 07:24 PM, ma...@apache.org wrote: >>>> >>>> Author: markt >>>> +* Fix https://issues.apache.org/b

Re: svn commit: r964780 - in /tomcat/trunk: java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2010-10-03 Thread Konstantin Kolinko
while (lockPathsList.hasMoreElements()) { generatedXML.writeElement("D", null, "response", XMLWriter.OPENING); generatedXML.w

Re: Site redesign

2010-10-04 Thread Konstantin Kolinko
he existing design has all pages and subsections listed in well defined manner. The proposed one has information scattered all over the place. For the ROOT webapp that was OK because that app is effectively a single page. Best regards,

Re: svn commit: r1004393 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2010-10-05 Thread Konstantin Kolinko
et entire path under context look wrong to me. (It does not matter how the servlet is mapped, but how it is requested) The code is correct though. I think those two wrong comments can be removed, as there is already a long comment at the start of the method that explains the things. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [taglibs] Pick common format for test class names

2010-10-10 Thread Konstantin Kolinko
i would suggest one of the latter 2 to avoid conflicts with inner classes > (e.g. TestTransformSupport$1) > I do not know surefire, but the above file masks end with *.java, and your inner classes do not have .java suffix in them. Is there really a pr

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-13 Thread Konstantin Kolinko
value), but a triple of (path, name, value), taking into account the path segment where it was applied. The proposed patch strips information on the parameters from the path. How the application is supposed to have access to them? Best regards, Konstantin Kolinko -

<    4   5   6   7   8   9   10   11   12   13   >