tifacts"
A. The maven-metadata.xml files are not updated by Nexus during
deployment, they are updated by Maven. It downloads the file, updates
it, and then redeploys it.
(...)
Best regards,
Konstantin Kolinko
-
To un
rgapachetomcat-020/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_26/
>
> The proposed 7.0.26 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.26 Stable
rs, so it is worth waiting for 2 hours more.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ml (original)
> +++ tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Tue Feb 21
> 13:15:42 2012
> @@ -38,6 +38,9 @@
>
>
>
> +
> + 52717: Set scope_id for IPv6 addresses if provided. (mturk)
> +
>
> 50570: Allow explicit us
2012/2/21 Mladen Turk :
> On 02/21/2012 03:06 PM, Konstantin Kolinko wrote:
>>
>> 2012/2/21:
>>
>>> @@ -58,6 +70,13 @@ TCN_IMPLEMENT_CALL(jlong, Address, info)
>>> sl = sa;
>>> }
>>> }
>>> + if (sp) {
>
st regards,
Konstantin Kolinko
2012/2/21 Bill Barker :
> To whom it may engage...
>
> This is an automated request, but not an unsolicited one. For
> more information please visit http://gump.apache.org/nagged.html,
> and/or contact the folk at gene...@gump.apache.org.
>
> Project
nt. I think that
if there is more data than buffer can handle it will hang looping
indefinitely with read=0.
3. doPong() method has unbounded while() loop. It wouldn't hang, but I
think it is bad that there is no control on how many data are
consumed.
Best regards,
Konstantin Kolink
2012/2/22 Mark Thomas :
> On 21/02/2012 16:31, Konstantin Kolinko wrote:
>> Regarding StreamInbound#doClose(), doPing(), doPong()
>
> Thanks for the review.
>
>>
>> 1. in doClose():
>> status = status + is.read();
>> There is no check whether is.read(
compress library.
>
> That's one of the ways spdy gets its speed - it is not optional in
> chrome/firefox.
>
1. AJP/1.3 protocol has dictionary for header names.
2. In Deflater class explicit flush operation was added in Java 1.7.
That is without knowing spe
E="$2"
> shift; shift;
>
> Propchange: tomcat/trunk/bin/daemon.sh
> ('svn:executable' removed)
>
231 echo "Unkown command: \`$1'"
Unknown
232 echo "Usage: $PROGRAM ( commands ... )&quo
c void pong(ByteBuffer data) throws IOException {
> // TODO Think about threading requirements for writing. This is not
> // currently thread safe and writing almost certainly needs to be.
>
in the pong() method the following:
276 upgradeOutbound.wr
2012/2/23 sebb :
> On 23 February 2012 19:00, Konstantin Kolinko wrote:
>> 2012/2/23 :
>>> Author: markt
>>> Date: Thu Feb 23 18:44:02 2012
>>> New Revision: 1292891
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1292891&view=rev
>>
anged as well.
BTW, what happens if we are passed more than 125 bytes of data? IAE?
> - upgradeOutbound.write(data.array(), 0, data.limit());
> + upgradeOutbound.write(data.array(), data.position(),
> + data.limit() - data.positi
uld build tomcat-native in the same manner,
and use produced binaries to run APR connector tests on Gump.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
curity
> +software using or performing cryptographic functions with asymmetric
> +algorithms. The form and manner of this Apache Software Foundation
> +distribution makes it eligible for export under the License Exception
> +ENC Technology Software Unrestricted (TSU) exception (see the BIS
generated from this parent pom.
Best regards,
Konstantin Kolinko
> On Feb 28, 2012, at 12:12 PM, Mladen Turk wrote:
>
>> On 02/28/2012 08:57 PM, sebb wrote:
>>> On 28 February 2012 16:43, Mladen Turk wrote:
>>>>
>>>> Although not sure why you have LICENSE
2012/3/1 :
> Author: markt
> Date: Wed Feb 29 21:24:59 2012
> New Revision: 1295286
>
> URL: http://svn.apache.org/viewvc?rev=1295286&view=rev
> Log:
> Fix a TODO
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/websocket/LocalStrings.properties
> tomcat/trunk/java/org/apache/catalina/w
thenticators and SingleSignOn" in the hope of avoiding wasted effort or
> confusion.
It is better to propose new code and parches through Bugzilla.
That way there are lesser chances that it is lost in the flood of e-mails.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
g files like in Gump has no progress at all.
>From RAT report I know that buildbot has build.properties file in the
root of the project. I do not know how it is created - probably by
some shell script. The new property can be added there.
Best regards,
Konstantin Kolinko
's!^:!.:!;s!:$!:.!;s!::!:.:!g;s!:! !g'`
> @@ -270,6 +271,9 @@ do
> elinks)
> TOOL="elinks $ELNKOPTS"
> ;;
> + lynx)
> + TOOL="lynx $LYXKOPTS"
> + ;;
> esac
> rm -f CHANGES
> ech
ketTimeoutException: Read timed out
Last message: [Client: READ: 4 bytes]
Last response line: [Client: READ: 4 bytes]
Last comet event: [READ]
Mar 6, 2012 11:43:37 AM org.apache.catalina.core.StandardService stopInternal
INFO: Stopping service Tomcat
]]]
It is likely that Tomcat stops wi
2012/3/7 Konstantin Kolinko :
> 2012/3/7 Mark Thomas :
>> On 06/03/2012 21:27, build...@apache.org wrote:
>>> The Buildbot has detected a new failure on builder tomcat-trunk while
>>> building ASF Buildbot.
>>> Full details are available at:
>>> http
=
> LogFactory.getLog(SetCharacterEncodingFilter.class);
> @@ -105,6 +106,11 @@ public class SetCharacterEncodingFilter
> }
> }
>
> + public void destroy() {
> + // NOOP
> + }
> +
> +
> /**
> * Select and set (if s
o
> case $c in
> v) version=$OPTARG;;
> @@ -92,7 +94,7 @@ do
> d) local_dir=$OPTARG
> conflict=$(($conflict+1));;
> f) force='y';;
> - d) txtgen='y';;
> + h) txtgen='y
f the mirrors
2. The "sources" download links are broken with error 404.
The links should point to
http://tomcat.apache.org/download-connectors.cgi
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-uns
m, but those
textual files are in native/CHANGES and native/NEWS.
+1 to drop them.
I think that if one does not have a browser, it would be easier to
read the *.xml files in xdocs directory. They are nicely formatted
with no more than 80 chars per line.
00,0x00,0x00,0x00,0x00,0x00,0x00, /* 176-183 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 184-191 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 192-199 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 200-207 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 208-215 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 216-223 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 224-231 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 232-239 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, /* 240-247 */
> + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00};/* 248-255 */
> +
> +/* End of chartables.c */
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
1. TC 7.0 backport fails to compile:
http://ci.apache.org/builders/tomcat-7-trunk/builds/435/steps/compile/logs/stdio
2. svn:eol-style on new files.
2012/3/8 :
> Author: schultz
> Date: Thu Mar 8 17:52:12 2012
> New Revision: 1298485
>
> URL: http://svn.apache.org/viewvc?rev=1298485&view=rev
>
ty manually (using "svn propset" command or a GUI)
and then commit.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ct[] conversions?
Just a simple solution might be a ReadWriteLock.
> Can I create a bugzilla ticket fot those two?
>
> Regards,
>
> Kočičák
>
> [1] http://www.mail-archive.com/dev@myfaces.apache.org/msg48482.html
>
Best regards,
Konstantin Kolinko
t.SocketTimeoutException: Read timed out
Last message: [Client: READ: 4 bytes]
Last response line: [Client: READ: 4 bytes]
Last comet event: [READ]
]]]
That is connection is closed and times out at the client, but there
was no END event, only a READ one.
Best regards,
Konstantin Kolinko
--
instead of
org.apache:apache, please verify your project structure @ line 20,
column 11
]]]
So "taglibs-parent" released version 1 was found, but it failed elsewhere.
Previous Jenkins builds of "Taglibs-All" were failing as well.
Jenkins sends its e-mail
t;keystorePass",
> keystorePass );
> }
> + if ( keystoreType != null )
> + {
> + httpsConnector.setAttribute( "keystoreType",
> keystoreType);
> + }
> embeddedTomcat.getEngine().getService().addConnector(
> httpsConnector );
>
> }
>
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/3/13 :
> Author: mturk
> Date: Tue Mar 13 17:18:38 2012
> New Revision: 1300245
>
> URL: http://svn.apache.org/viewvc?rev=1300245&view=rev
> Log:
> Update 1.2.33 release notes
>
> Modified:
> tomcat/jk/trunk/xdocs/index.xml
> tomcat/jk/trunk/xdocs/news/20120301.xml
>
> Modified: tomcat/
ou'll need to set
network.http.spdy.enabled to true in about:config"
[1] https://www.mozilla.org/en-US/firefox/11.0/releasenotes/
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=528288#c174
Best regards,
Konstantin Kolinko
-
,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012
> @@ -72,6 +72,7 @@
> href="windows-auth-howto.html"/>
> href="jdbc-pool.html"/>
> +
>
>
>
>
> Added: tomcat/trunk/webapps/docs/web-socket-howto.xml
> URL:
> http://svn
2805
The next release of 7.0.x will have 3.7.2 in it.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Ps you would have to also
reconfigure JspServlet (using compilerSourceVM / compilerTargetVM
options) to target Java 7.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additiona
there are no issues, the easier it is to
> update.
>
> In your case, to use Java 7 features in JSPs you would have to also
> reconfigure JspServlet (using compilerSourceVM / compilerTargetVM
> options) to target Java 7.
>
> Best regards,
> Konstantin Kolinko
>
> -
Stack trace was not visible there
unless you turned on the debugging.
The DecodeException class used there overrides fillInStackTrace() so
that no time is wasted to fill in the stack trace. No messed stack is
printed - it is not printed at all.
Just exception text will be different.
Best regard
wvc?view=revision&revision=1239295
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
mpiler 3.7.2. (markt)
> +
>
>
>
>
There is one more place where ecj version is mentioned:
res/maven/tomcat-jasper.pom
has
org.eclipse.jdt.core.compiler
ecj
3.7
Though searching for it I currently see only version 3.7.1 as the lates
| 2012-03-18 00:00:54 +0400 (Вс, 18 мар 2012) | 1 line
Fix BZ52921
There was a commit e-mail for r1301987, so nothing has been lost yet.
Best regards,
Konst
tor instead of
org.apache:apache, please verify your project structure @ line 20,
column 11
Other taglibs reference "2-SNAPSHOT", with exception of standard
taglib that references version "1" of parent now (I changed 1-SNAPSHOT
-&
+ }
> + strcpy(lkname, shame);
> + strcat(lkname, "_MUTEX");
> jk_shm_hlock = CreateMutex(jk_get_sa_with_null_dacl(), TRUE, lkname);
> if (jk_shm_hlock == NULL) {
> if (GetLastError() == ERROR_ALREADY_EXISTS) {
> @@ -199,11 +
2012/3/19 Jeremy Boynes :
> On Mar 18, 2012, at 3:33 PM, Jeremy Boynes wrote:
>
>> On Mar 18, 2012, at 10:42 AM, Konstantin Kolinko wrote:
>>
>>> 2012/3/18 Jeremy Boynes :
>>>> Since this release, I've updated the parent pom to move all the site
>
s to chat.html, but there is no such file.
Also
webapps/docs/web-socket-howto.xml
has not been copied to Tomcat 7.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Fo
downloads the
file.
E.g.
1. opening this in a web browser
http://svn.apache.org/repos/asf/tomcat/trunk/bin/catalina.bat
will show unexpanded keyword, and I would expect "$Id$" there, not "$Id:$".
2. displaying it with an svn client
svn
2012/3/19 Konstantin Kolinko :
> 2012/3/19 Mark Thomas :
>> On 19/03/2012 10:25, ma...@apache.org wrote:
>>> Author: markt
>>> Date: Mon Mar 19 10:25:25 2012
>>> New Revision: 1302359
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1302359&v
/svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1242101&r1=1242100&r2=1242101&view=diff
> ==
> --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
>
the above clone() method.
It has the same access level (protected) as super one.
I see that PoolProperties is written as "implements Cloneable". In
such case the clone method is usually redeclared as public one.
> +
> +
> +
> }
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
vision: 1303096
>>
>> URL: http://svn.apache.org/viewvc?rev=1303096&view=rev
>> Log:
>> Fix checkstyle issues with trailing spaces and imports formatting.
>>
>> Modified:
>> tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
>> tomcat/t
; server admins know right off the bat that they’ve done something wrong.
>
The service wrapper is not part of Tomcat project.
It is "procrun" from Apache Commons Daemon. If you want to file an
issue, you should do it there.
http://commons.apache.org/daemon/
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
t;> URL: http://svn.apache.org/viewvc?rev=1303082&view=rev
>> Log:
>> svn:eol-style = native
>>
>> (...)
>>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
annelListener(listeners[i]);
> channels[i].start(Channel.SND_RX_SEQ|Channel.SND_TX_SEQ);
> }
The above start() call probably should be done in a separate loop,
after adding the domain is added.
> + TesterUtil.addRandomDomain(channels);
>
wakeupCounter.set(0);
> }
> if (close) {
(2)
> + events();
> timeout(0, false);
> selector.close();
> break;
>
Comparing (1) a
apter,
"The type, subtype, and parameter attribute names are case-
insensitive."
I do not see where we allow "charset" parameter name to be
case-insensitive. We allow lowercase only.
-> AstMediaType#getCharset()
-> AstMediaType#toStringNoCharset()
4) The "value" of a parameter can be quoted-string. We do not handle
unquoting of charset parameter value. I am OK with leaving as is,
because nobody asked.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
have it - apply the change manually.
(r1304260 being in mergeinfo will cause changes to be ignored if you
re-run the merge).
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/3/23 :
> Hi All,
>
> I have several web applications running on distinct tomcat instances. Apache
> httpd is in front of all the tomcat instances, running as a reverse proxy.
> Authentication is realized at the container side. Access log files are active
> on the httpd side.
"at the conta
2012/3/23 Mark Thomas :
> On 23/03/2012 01:41, Konstantin Kolinko wrote:
>> 2012/3/13 :
>>> Author: markt
>>> Date: Tue Mar 13 14:39:24 2012
>>> New Revision: 1300154
>
>> 1) It seems that quoted text handling (" TOKEN"
>> constr
the logs.
4. It is easier to pass the information back via AJP13_SEND_HEADERS
message.instead of inventing a new message type and marshalling it
over the wire.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e
2012/3/23 Konstantin Kolinko :
> 2012/3/22 :
>
>> URL: http://svn.apache.org/viewvc?rev=1304011&view=rev
>
> Comparing (1) and (2),
> both are terminating the loop, but the (2)nd block has
> "selector.close()" call and (1)st does not have the call. I sus
ore committing. (Some care will be needed for "!
missing" and "? new" ones).
Regarding imported 3.2 docs:
Some of them have unusual filenames (*.howto, faq) and thus did not
have svn:eol-style applied. I'll look at it ~tomorrow when Mark
finishes the import.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
I'll upload those bins when I collect two more votes.
+1
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-rf maven-plugin-2.0-beta-1
svn cleanup
svn up
Svn complains because the old directory is unversioned one.
IIRC there is also possible to do "svn up --force", but I have not used it.
Best regards,
Konstantin Kolinko
-
free to modify the index.xml and update the url.
>
>
> Done in r1305416.
r1305419 :/ There was more than just a typo.
>
> Looks like we both are "svn up" the site on p.a.o nearly in parallel during
> the last minutes. Will log out now.
>
I was ther
ULI with org.apache.juli.AsyncFileHandler.
It might show better numbers.
(The usual FileHandler by default performs flush() after each log message).
2. Is the same printed to console? If yes then remove ConsoleHandler.
Best regards,
Konstantin Kolinko
---
1) shortly and add 2) to bugzilla.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
immediately when they are called". When the actual
interruption happens the exception is created and the flag is
cleared.)
To propagate the interruption state the code would be
if (propagate) {
Thread.currentThread().interrupt();
}
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
lla issue. Instructions are
at [1], but probably you already know them.
If the issue does not get devs' attention, feel free to ping on dev@ list.
[1]
http://tomcat.apache.org/bugreport.html#How_to_submit_patches_and_enhancement_reques
me.
Looking at mailing list archives, markmail [1] shows the footer, ASF
mail archive [2] looses it.
In [2] -> click "View raw message" -> the same base64 bytes as in my
copy of this message in GMail.
[1] http://markmail.org/mess
2012/3/9 Konstantin Kolinko :
> 2012/3/9 Martin Koci :
>> Hi,
>>
>> we did performance tests in myfaces core project recently and we found
>> two performance problems in tomcat (7.0.26):
>>
>>
>> 1) javax.el.ExpressionFactory.newInsta
When this "out" directory is created?
It is not "target" as usually in Maven, not "output" as in Tomcat
sources. Where it comes from? Just wondering.
2012/3/29 :
> Author: olamy
> Date: Thu Mar 29 13:50:31 2012
> New Revision: 1306869
>
> URL: http://svn.apache.org/viewvc?rev=1306869&view=rev
>
ed by
date and they are not created unless necessary. The date format is
configurable. E.g. it is possible to use it to generate different
directories for different dates.
IIRC JRE's java.util.logging.FileHandler can be configured to keep n
old files, but it uses different naming scheme.
9
2012/3/30 Olivier Lamy :
> intellij create that.
>
> 2012/3/29 Konstantin Kolinko :
>> When this "out" directory is created?
>>
>>
>> It is not "target" as usually in Maven, not "output" as in Tomcat
>> sources. Where it comes
2012/3/28 Konstantin Kolinko :
> 2012/3/27 Mark Thomas :
>> The 7.0.x change log is looking long again and with the only open TC7
>> bugs in NEEDINFO state, I am going to start the process of rolling the
>> 7.0.27 release.
>>
>> I'm not going to tag 7.0.27 unt
hangelog.xml
>
> Propchange: tomcat/tc7.0.x/trunk/
> --
> Merged /tomcat/trunk:r1307511-1307512
>
Best regards,
Konstantin Kolinko
---
ore elaborate, but provides better control on your working copy.
b. Specify path to "jk-xdocs", "native-xdocs" in build.properties. The
files might be somewhere else on your hard drive (where you normally
work on those components).
It is possible to combine a+b.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
rg/viewvc?rev=1307893&view=rev
Those WEB-INF subdirectories are needed when documentation is run as a
web application on Tomcat, but are not needed when it is published
through Apache HTTPD.
Best regards,
Konstantin Kolinko
-
T
&utm_content=pod&utm_campaign=mdb_002136";
> rel="nofollow">Apache Tomcat 7 Essentials, by Tanuj Khare
> + Packt Publishing (03/2012)
Best regards,
Konstantin Kolinko
-
To unsubscribe,
[x] Stable - go ahead and release as 7.0.27 Stable
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
hat working copy. At that time it
should be served correctly.
[1] http://subversion.apache.org/faq.html#website-auto-update
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additio
takes up a quarter of my screen or less.
> I would therefor suggest to increase this, as it will dramatically shrink the
> number of lines of code, and readability
>
I know of two places where long lines cause problems:
1. Commit e-mails.
Long lines are wrapped and it impacts readability.
uot; and "preference".
If it is a preference of many then it has to be respected as a
convention. Isn't it?
Previous discussion (December 2010):
http://markmail.org/thread/alo77qd4yiduvqvz
We also have this description of our coding style:
http://tomcat.apache.org/getinvolved.html#C
Public
> Methods
>
> @@ -270,6 +324,7 @@ public final class UserConfig
> while (users.hasMoreElements()) {
> String user = users.nextElement();
> String home = database.getHome(user);
> + if (!isDeployEnabled(user)) continu
no confusion here and are easier to read
(and using static imports for those assert methods is what is
recommended in many places).
2. It should be already allowed by configuration in checkstyle.xml,
so was there a problem?
Best regards,
Konstantin Kolinko
> Mod
2012/4/7 Mark Thomas :
> On 06/04/2012 22:16, Konstantin Kolinko wrote:
>> 2012/4/6 :
>>> Author: markt
>>> Date: Fri Apr 6 18:44:19 2012
>>> New Revision: 1310541
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1310541&view=rev
>>
2012/4/7 Konstantin Kolinko :
> 2012/4/7 Mark Thomas :
>> On 06/04/2012 22:16, Konstantin Kolinko wrote:
>>> 2012/4/6 :
>>>> Author: markt
>>>> Date: Fri Apr 6 18:44:19 2012
>>>> New Revision: 1310541
>>>>
>>>> U
here can be some better text. I wish it were more
understandable that it is part of Tomcat-Native).
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
originalClassLoaser );
> + Thread.currentThread().setContextClassLoader(
> originalClassLoader );
> }
> }
> }
1. Do you need to keep "originalClassLoader" as a c
tc7.0.x from svn. There was a fix
53021: Correct WebSocket protocol version detection. (pero)
2. Debugging Tomcat:
http://wiki.apache.org/tomcat/FAQ/Developing#Debugging
Best regards,
Konstantin Kolinko
-
To
ents, as specified in the Servlet
3.0 Rev.a specification. If current behaviour contradicts with
specification, please cite what point in merging algorithm is not
followed.
Best regards,
Konstantin Kolinko
-
To
on attribute from
replication. Its content makes sense for the current node only.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
{ }
I do not understand the above wording.
You mean that "${ }" can be used starting with 2.0?
If yes then the sentence says quite the opposite.
It should be s/prior/since/ and s/is filtering/is filtered/.
If no then I'd note explicitly that "Since 2.0 you can no long
2012/4/14 Konstantin Kolinko :
> 2012/4/13 :
>> Author: olamy
>> Date: Fri Apr 13 19:12:47 2012
>> New Revision: 1325908
>>
>> URL: http://svn.apache.org/viewvc?rev=1325908&view=rev
>> Log:
>> document new filtering on context file
>>
>>
}
> + }
> }
>
> @Override
> @@ -1277,6 +1299,7 @@ public abstract class AbstractReplicated
> public static final int MSG_INIT = 8;
> public static final int MSG_COPY = 9;
> public static final int MSG_STATE_COPY = 10;
> +
t having leading or trailing
'/'.
The algorithm in ch. 10.10 may work with empty strings (running a
fruitless loop - looking for a resource that is already known to not
exist), but I am not sure that it is a well-defined behaviour.
I'd be nice to have
2012/4/19 Keiichi Fujino :
> 2012/4/19 Konstantin Kolinko :
>>
>> What happens if "repl" variable is true because of "complete" being true?
>> Shouldn't it be
>> if (diff && (isDirty || complete))
>> ?
>>
>> I do not
lders once we need it.
>
Now that this feature works, I'll update "tomcat-tc7.0.x-validate"
target on Gump today
and will do the same for "tomcat-trunk-validate" tomorrow,
to remove hard-coded checkstyle version number there.
Just warning dev@ in advance in case it break
201 - 300 of 2494 matches
Mail list logo
