Restart taglibs release

2012-02-25 Thread Jeremy Boynes
I intend restart work on getting a release out of taglibs. Before I went on hiatus there were issues with building on Maven3.0 but it looks like those have been fixed as it now builds cleanly for me. There is one new bug #51234 related to formatNumber but I plan to mark that as wontfix due to sp

Re: Restart taglibs release

2012-02-25 Thread Jeremy Boynes
ctual artifacts and call a vote on them. Cheers Jeremy On Feb 25, 2012, at 9:14 AM, Jeremy Boynes wrote: > I intend restart work on getting a release out of taglibs. Before I went on > hiatus there were issues with building on Maven3.0 but it looks like those > have been fixed as it now

[VOTE] Release Apache Taglibs Parent POM 1

2012-02-25 Thread Jeremy Boynes
The proposed Apache Taglibs Parent POM v1 release is now available for voting. This contains Maven project metadata for building and releasing the actual Taglibs project files. The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-068/ The svn tag is: htt

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-26 Thread Jeremy Boynes
he "Staging > repositories" entry menu. > After that the url > (https://repository.apache.org/content/repositories/orgapachetomcat-068/) > will be available. > > > 2012/2/25 Jeremy Boynes : >> The proposed Apache Taglibs Parent POM v1 release is now available fo

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-26 Thread Jeremy Boynes
OK. Artefacts re-staged at https://repository.apache.org/content/repositories/orgapachetomcat-084/ Thanks Jeremy On Feb 26, 2012, at 3:00 PM, Olivier Lamy wrote: > 2012/2/26 Jeremy Boynes : >> I do but I can't as it seems I signed with the wrong key - a subkey that is >

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-26 Thread Jeremy Boynes
26 February 2012 23:33, Jeremy Boynes wrote: >> OK. Artefacts re-staged at >> https://repository.apache.org/content/repositories/orgapachetomcat-084/ > > Looks a bit odd to have > > orgapachetomcat > > above > > yet the Maven package is org.apache.taglibs

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-28 Thread Jeremy Boynes
A gentle call for more votes please, only one at the moment. On Feb 26, 2012, at 11:15 PM, Olivier Lamy wrote: > +1 > > 2012/2/27 Jeremy Boynes : >> OK. Artefacts re-staged at >> https://repository.apache.org/content/repositories/orgapachetomcat-084/ >> >>

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-28 Thread Jeremy Boynes
Removed from svn. A dry run of the next release shows they are automatically added to the source bundle. Thanks Jeremy On Feb 28, 2012, at 12:12 PM, Mladen Turk wrote: > On 02/28/2012 08:57 PM, sebb wrote: >> On 28 February 2012 16:43, Mladen Turk wrote: >>> >>> Although not sure why you have

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-28 Thread Jeremy Boynes
On Feb 28, 2012, at 9:11 PM, Konstantin Kolinko wrote: > 2012/2/29 Jeremy Boynes : >> Removed from svn. A dry run of the next release shows they are automatically >> added to the source bundle. >> > > 1. Where it takes those files from? Is their content correct. The

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-29 Thread Jeremy Boynes
Reverted r1294943. Do you know how this was addressed in Commons? Any patches? :) On Feb 29, 2012, at 9:14 AM, sebb wrote: > On 29 February 2012 05:11, Konstantin Kolinko wrote: >> 2012/2/29 Jeremy Boynes : >>> Removed from svn. A dry run of the next release shows they are

[RESULT] Release Apache Taglibs Parent POM 1

2012-02-29 Thread Jeremy Boynes
+1 votes from olamy, mturk and kkolinko; no -1's Issues raised during the vote: * duplicate LICENSE and NOTICE files, and how to avoid this * site contents * version of commons-skin used for site to be addressed before we release any of the taglibs Thanks. I'll promote the staging repo later this

Publishing taglibs mini-site

2012-03-01 Thread Jeremy Boynes
Is there any information lying around on how to update the taglibs site? Is taglibs-parent/site.xml actually used or is everything in the site module? What's the process for publishing? Where does it deploy to? Is a vote needed before push? Do we want to preview changes online or is a review bas

Re: Publishing taglibs mini-site

2012-03-03 Thread Jeremy Boynes
-DdistributionSiteUrl=scp://people.apache.org/home/jboynes/public_html/taglib > > As it you can see it in live http://people.apache.org/~jboynes/taglib > > HTH, > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/

License/Notice Files

2012-03-03 Thread Jeremy Boynes
On Feb 29, 2012, at 11:37 AM, sebb wrote: > On 29 February 2012 19:15, Olivier Lamy wrote: >> Perso, I prefer using something which read pom and generate >> automatically N&L from metadatas rather than maintaining those files >> manually (for me manually means you always missed to add/modify :-)

Re: License/Notice Files

2012-03-18 Thread Jeremy Boynes
at to the particular module at that time. On Mar 4, 2012, at 5:40 PM, sebb wrote: > On 4 March 2012 03:44, Jeremy Boynes wrote: >> On Feb 29, 2012, at 11:37 AM, sebb wrote: >> >>> On 29 February 2012 19:15, Olivier Lamy wrote: >>>> Perso, I prefer us

Re: [RESULT] Release Apache Taglibs Parent POM 1

2012-03-18 Thread Jeremy Boynes
s. Thanks Jeremy On Feb 29, 2012, at 7:39 PM, Jeremy Boynes wrote: > +1 votes from olamy, mturk and kkolinko; no -1's > > Issues raised during the vote: > * duplicate LICENSE and NOTICE files, and how to avoid this > * site contents > * version of commons-skin used for site &g

Re: [RESULT] Release Apache Taglibs Parent POM 1

2012-03-18 Thread Jeremy Boynes
On Mar 18, 2012, at 10:42 AM, Konstantin Kolinko wrote: > 2012/3/18 Jeremy Boynes : >> Since this release, I've updated the parent pom to move all the site >> information into the site module. I plan to fix the duplicate file issue >> soon. Were there an other is

Taglibs-all Jenkins build

2012-03-18 Thread Jeremy Boynes
On Mar 18, 2012, at 3:33 PM, Jeremy Boynes wrote: > On Mar 18, 2012, at 10:42 AM, Konstantin Kolinko wrote: > >> 2012/3/18 Jeremy Boynes : >>> Since this release, I've updated the parent pom to move all the site >>> information into the site module. I p

Fwd: Taglibs-All - Build # 15 - Fixed

2012-03-18 Thread Jeremy Boynes
:) Begin forwarded message: > From: Apache Jenkins Server > Subject: Taglibs-All - Build # 15 - Fixed > Date: March 18, 2012 4:07:11 PM PDT > To: jboy...@gmail.com > > The Apache Jenkins build system has built Taglibs-All (build #15) > > Status: Fixed > > Check console output at https://build

[VOTE] Release Apache Taglibs Parent POM 2

2012-03-24 Thread Jeremy Boynes
The proposed 2 release of Apache Taglibs Parent POM is now available for voting. This release addresses issues found during the 1 release process including duplicate LICENSE files and poor site configuration. The Maven staging repo is: https://repository.apache.org/content/repositories/orgapache

[WITHDRAWN] Release Apache Taglibs Parent POM 2

2012-03-25 Thread Jeremy Boynes
Withdrawing this to fix date in NOTICE. On Mar 24, 2012, at 8:09 AM, sebb wrote: > On 24 March 2012 14:45, Jeremy Boynes wrote: >> The proposed 2 release of Apache Taglibs Parent POM is now available for >> voting. >> >> This release addresses issues found d

[VOTE] Release Apache Taglibs Parent POM 3

2012-03-25 Thread Jeremy Boynes
The proposed 3 release of Apache Taglibs Parent POM is now available for voting. This release addresses issues found during the 1 release process including duplicate LICENSE files and poor site configuration, and updates the copyright date in the NOTICE file from release 2 (withdrawn). The Mave

Jenkins permissions

2012-03-26 Thread Jeremy Boynes
Who controls permissions in Jenkins (builds.a.o)? Please can you grant me build rights for Taglibs-All? Thanks Jeremy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.

Re: Jenkins permissions

2012-03-26 Thread Jeremy Boynes
Thanks, request sent to Mladen as per that page. Do we know who set this up? On Mar 26, 2012, at 12:30 PM, Olivier Lamy wrote: > Hello, > See http://wiki.apache.org/general/Jenkins#How_do_I_get_an_account > > > > 2012/3/26 Jeremy Boynes : >> Who controls permission

Re: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Jeremy Boynes
Request for more votes please, we only have one binding vote so far. Thanks Jeremy On Mar 27, 2012, at 12:35 PM, Olivier Lamy wrote: > +1 > > 2012/3/26 Jeremy Boynes : >> The proposed 3 release of Apache Taglibs Parent POM is now available for >> voting. >> >&

Re: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Jeremy Boynes
My non-binding +1 but one more PMC vote is needed please. Thanks Jeremy On Mar 28, 2012, at 8:35 AM, Filip Hanik (mailing lists) wrote: > > >> -Original Message----- >> From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy >> Boynes >> Sent: Wed

Re: Jenkins configuration

2012-03-28 Thread Jeremy Boynes
would also remove the aggregator stub trunks. On Mar 26, 2012, at 10:37 PM, Olivier Lamy wrote: > I setup the build on Jenkins long ago. > Do you need some configuration change ? > > -- > Olivier > Le 27 mars 2012 03:38, "Jeremy Boynes" a écrit : > >> Thank

Re: Jenkins configuration

2012-03-29 Thread Jeremy Boynes
On Mar 29, 2012, at 8:22 AM, Olivier Lamy wrote: > 2012/3/29 Jeremy Boynes : ... >> However, we are also getting errors about the effective path of parent files >> which I believe is caused because the aggregating pom in trunks is not >> actually the parent of the modules

[RESULT] Release Apache Taglibs Parent POM 3

2012-03-29 Thread Jeremy Boynes
WIth binding +1's from olamy, fhanik and mturk and my non-binding +1, I call the vote passed and will deploy the staged artefacts. Thanks Jeremy On Mar 29, 2012, at 4:55 AM, Mladen Turk wrote: > +1 > > Signatures and generic content OK > > On 03/26/2012 07:01 AM, Jeremy

Taglibs build #2 failed due to Hudson error

2012-03-30 Thread Jeremy Boynes
From the log: https://builds.apache.org/job/taglib-standard/2/consoleText Parsing POMs ERROR: Failed to parse POMs hudson.util.IOException2: remote file operation failed: /home/jenkins/jenkins-slave/workspace/taglib-standard at hudson.remoting.Channel@1c4071a9:ubuntu3 at hudson.FilePath.

Re: Time for Taglibs to be sent to the archive?

2012-11-26 Thread Jeremy Boynes
+0 It's perhaps not surprising that there is not much activity as there has been no update to the JSR in many years. The JSTL code in trunk does pass the 1.2 TCK and could be released if someone had the energy to fix the website and rustle up votes. On Oct 13, 2012, at 10:58 AM, Henri Yandell

[taglibs] Thread safety in FormatDateSupport

2010-06-27 Thread Jeremy Boynes
I was looking at a patch for FormatDateSupport [1] to remove its dependency on a copy of LRUMap taken from Commons and have a question on the thread safety involved as, although the cache is synchronized, the formatters it contains are used outside that block. This was discussed in bug 32311 [2

[taglibs] Questions in ForEachSupport

2010-06-29 Thread Jeremy Boynes
In bug 45197 https://issues.apache.org/bugzilla/show_bug.cgi?id=45197 Henri wrote: * Look at questions in the length method in ForEachSupport.java * Look at commented out code in prepre in ForEachSupport.java By "in the length method" did you mean line #241 where the length gets set to 0? That's

[taglibs] Null handling in Functions

2010-07-04 Thread Jeremy Boynes
Different methods in our Functions implementation handle null parameters inconsistently; for example, toUpperCase does not perform any null check whereas indexOf does. If I grok the EL spec correctly, all String parameter values should be coerced by the rules in 1.18.2 which would guarantee that

Re: [taglibs] Null handling in Functions

2010-07-05 Thread Jeremy Boynes
. Jeremy On Jul 4, 2010, at 11:36 PM, Henri Yandell wrote: > Agreed on 1.18.2. For String params (and Number, Character and > Boolean) it looks like Functions should be able to assume that they're > null-safe. > > Hen > > On Sun, Jul 4, 2010 at 12:20 PM, Jeremy B

Re: [taglibs] Null handling in Functions

2010-07-06 Thread Jeremy Boynes
On Mon, Jul 5, 2010 at 12:17 AM, Jeremy Boynes wrote: >> I work on a patch to remove them and add JavaDoc. >> >> What do you think of adding JSR-303 javax.validation annotations like >> NotNull? Those are part of JavaEE 6 so are guaranteed to be available there >>

Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-07-09 Thread Jeremy Boynes
I've disabled the test module that uses Cactus until we can fix this. I'm not very familiar with what Gump is doing and could use some help rectifying this. We specify the version of Cactus to use in the POM and the module does build locally. What's going on inside Gump that would cause it to u

Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-07-09 Thread Jeremy Boynes
On Jul 9, 2010, at 8:57 AM, Stefan Bodewig wrote: > On 2010-07-09, Jeremy Boynes wrote: ... >> We specify the version of Cactus to use in the POM and the module does >> build locally. What's going on inside Gump that would cause it to use >> a different version? Is

Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-07-09 Thread Jeremy Boynes
On Jul 9, 2010, at 9:17 AM, Stefan Bodewig wrote: > On 2010-07-09, Jeremy Boynes wrote: > >> On Jul 9, 2010, at 8:57 AM, Stefan Bodewig wrote: > >>> I see. I'll switch Gump to use the package goal and add a new >>> definition running the install goal so we

[taglibs] XPath support

2010-07-09 Thread Jeremy Boynes
In light of the performance issues logged against the XML taglib and functional issues like #49578, I was looking at refactor the XML tags to use the JAXP XPath API to pre-compile expressions and dynamically resolve variables. I think this can be done fairly easily and will eliminate a lot of th

Re: [taglibs] XPath support

2010-07-10 Thread Jeremy Boynes
, Henri Yandell wrote: > On Fri, Jul 9, 2010 at 12:51 PM, Jeremy Boynes wrote: >> In light of the performance issues logged against the XML taglib and >> functional issues like #49578, I was looking at refactor the XML tags to use >> the JAXP XPath API to pre-compile

Re: [taglibs] XPath support

2010-07-11 Thread Jeremy Boynes
There may be an issue here with Xalan and/or the JDK. We might be advised to consider a different XPath implementation. Does anyone have any thoughts on Jaxen? Thanks Jeremy On Jul 10, 2010, at 10:38 PM, Jeremy Boynes wrote: > I've added two attachments to bug 27717 >https://i

Re: [taglibs] XPath support

2010-07-12 Thread Jeremy Boynes
On Jul 12, 2010, at 1:08 AM, Mark Thomas wrote: > On 12/07/2010 06:40, Jeremy Boynes wrote: >> Implementation seems to work but does not provide as much benefit as >> expected. Jasper tag pooling does not pool tags with the same attribute >> values so the select attrib

Re: [taglibs] XPath support

2010-07-14 Thread Jeremy Boynes
On Jul 12, 2010, at 7:04 PM, Jeremy Boynes wrote: > I'm going to ping Xalan about the increase in time taken as expressions are > evaluated as I would assume I'm doing something silly. I looked into the Xalan implementation and the problem appears to be in creation of the

Re: New joiner's question - mocking for unit tests

2010-07-23 Thread Jeremy Boynes
There is some use of EasyMock in the Taglibs sub-project. On Jul 22, 2010, at 7:51 PM, Alexander Shirkov wrote: > Hello all > > I have quick question: Is there mocking framework in project? > Writing dummies for unit tests is quite useless and boring thing. Plus it’s > filling codebase with “noi

Re: The status of tomcat taglibs project?

2010-09-29 Thread Jeremy Boynes
On Sep 24, 2010, at 11:37 PM, Rex Wang wrote: > Could anyone tell me any clue about this? or it has never been built since > transferred from jakarta project? I can confirm I have built it but, as sebb said, you need to install the parent pom locally first as there's no released version. > And,

Re: [taglibs] XPath support

2010-10-02 Thread Jeremy Boynes
On Jul 15, 2010, at 12:19 AM, Henri Yandell wrote: > On Wed, Jul 14, 2010 at 8:45 PM, Jeremy Boynes wrote: >> On Jul 12, 2010, at 7:04 PM, Jeremy Boynes wrote: >> >>> I'm going to ping Xalan about the increase in time taken as expressions are >>> evaluated

[taglibs] How about splitting up the resource bundle?

2010-10-07 Thread Jeremy Boynes
Now that we require 1.5, I refactored Resources to use varargs rather than having multiple methods taking combinations of parameters. However, now that it is greatly simplified, i was wondering whether we should replace the single resource bundle containing messages for all implementations with

[taglibs] Pick common format for test class names

2010-10-07 Thread Jeremy Boynes
We have different formats for test class names and need to specifically list them in the pom.xml file. i'd like to propose picking a standard format and using a single wildcarded pattern to select them. The defaults for the surefire plugin are: **/Test*.java **/*Test.java

[taglibs] Proposal to separate out 1.0 functionality

2010-10-07 Thread Jeremy Boynes
The 1.0 taglibs included their own implementation of EL. With EL now being provided by the JSP container and newer code using the 1.1 tag URIs, this is complexity that would not be needed for many newer implementation. I've been wondering if we could refactor the library into two jars: one supp

[taglibs] JRE version, was: How about splitting up the resource bundle?

2010-10-09 Thread Jeremy Boynes
On Oct 8, 2010, at 10:40 AM, Kris Schneider wrote: > On Thu, Oct 7, 2010 at 9:29 PM, Jeremy Boynes wrote: >> Now that we require 1.5, I refactored Resources to use varargs rather than >> having multiple methods taking combinations of parameters. However, now that >> it is

Re: [taglibs] Proposal to separate out 1.0 functionality

2010-10-09 Thread Jeremy Boynes
On Oct 7, 2010, at 11:15 PM, Rahul Akolkar wrote: > On Thu, Oct 7, 2010 at 9:48 PM, Jeremy Boynes wrote: ... >> A further refinement would be to refactor the 1.0 code to use the JSP EL >> support from javax.el. >> > > > 1.0 code? That would preclude its use un

[taglibs] Release for 1.2, was: The status of tomcat taglibs project?

2010-10-09 Thread Jeremy Boynes
On Oct 9, 2010, at 12:37 AM, Rex Wang wrote: > > 2. When do you plan to make the first release? Our project really wants to > switch to the open source implementation.. Trunk now passes the JSTL1.2 TCK so we can release when we want to. However, there have already been some large changes in the

Patch for DataSourceWrapper #48773, problem with memory leak

2010-10-09 Thread Jeremy Boynes
On Oct 9, 2010, at 12:37 AM, Rex Wang wrote: > 3. For the patch in #48773, could anyone help review and apply it? I think there's a problem here that would cause a memory leak when the JDBC Driver is bundled with an application jar. When the driver class is instantiated, it is meant to register

Re: [taglibs] Pick common format for test class names

2010-10-10 Thread Jeremy Boynes
On Oct 10, 2010, at 7:01 AM, Konstantin Kolinko wrote: ... > > I do not know surefire, but the above file masks end with *.java, and > your inner classes do not have .java suffix in them. Is there really a > problem?? This is what happens if I rename SetSupportTest to TestSetSupport: --

Re: [taglibs] Pick common format for test class names

2010-10-10 Thread Jeremy Boynes
On Oct 10, 2010, at 7:01 AM, Konstantin Kolinko wrote: > 2010/10/8 Jeremy Boynes : >> We have different formats for test class names and need to specifically list >> them in the pom.xml file. >> >> i'd like to propose picking a standard format and using a single

Re: [taglibs] Proposal to separate out 1.0 functionality

2010-10-16 Thread Jeremy Boynes
d provide strict compatibility with the JSTL 1.0 EL spec by using the original EL evaluator If this sounds good, I'll make this split and refactor the other 1.0EL tags later this week. On Oct 7, 2010, at 6:48 PM, Jeremy Boynes wrote: > The 1.0 taglibs included their own implementation o

Request logging with async examples

2010-10-20 Thread Jeremy Boynes
When I run the async1 example in trunk, the request gets logged twice in the access log: 0:0:0:0:0:0:0:1%0 - - [20/Oct/2010:21:32:39 -0700] "GET /examples/async/async1 HTTP/1.1" 200 - 0:0:0:0:0:0:0:1%0 - - [20/Oct/2010:21:32:42 -0700] "GET /examples/async/async1 HTTP/1.1" 200 863 Is this the ex

Re: svn commit: r1026723 - in /tomcat/taglibs/standard/trunk: compat/ compat/src/main/java/org/apache/taglibs/standard/tag/compat/core/ impl/src/main/java/org/apache/taglibs/standard/tag/common/core/

2010-10-24 Thread Jeremy Boynes
Thanks. I'll fix that. On Oct 24, 2010, at 4:37 AM, Konstantin Kolinko wrote: > 2010/10/24 : >> Author: jboynes >> Date: Sun Oct 24 00:43:55 2010 >> New Revision: 1026723 >> >> URL: http://svn.apache.org/viewvc?rev=1026723&view=rev >> Log: >> Add JSTL 1.0 Out tag that uses javax.el to process E

[taglibs] svn properties, was: svn commit: r1026723 - in /tomcat/taglibs/standard/trunk...

2010-10-24 Thread Jeremy Boynes
IDEA is not setting these when new files are added; I'd swear it used to. Is anyone else using it and seeing an issue like this? They do get set when I use svn add from the command line. I've set svn:eol-style on everything in standard (I think). I've not set svn:keywords as that is not set on a

[taglibs] [Bug 50064] bundle-ify the taglibs jars

2010-10-31 Thread Jeremy Boynes
omment #7 from Jeremy Boynes 2010-10-31 14:26:45 > EDT --- > Patches applied, thanks. > > -- > Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email > --- You are receiving this mail because: --- &g

Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-11-01 Thread Jeremy Boynes
This started failing with r1029387. If I remove the bundle from the spec module then the reactor starts resolving it again. Could this be something with the bundle plugin not working with the package goal? I'm going to revert the bundle packaging until we can resolve this. On Nov 1, 2010, at 6

Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

2010-11-01 Thread Jeremy Boynes
On Nov 1, 2010, at 7:42 PM, Rex Wang wrote: > Thanks Jeremy, > > Is that because the group id dose not start with org.apache.tomcat...? I think so. I opened the issue asking for org.apache.taglibs to be added as that's the current group id. https://issues.apache.org/jira/browse/INFRA-31

Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-11-02 Thread Jeremy Boynes
). On Nov 2, 2010, at 2:18 AM, Stefan Bodewig wrote: > On 2010-11-02, Jeremy Boynes wrote: > >> This started failing with r1029387. If I remove the >> bundle from the spec module then the reactor >> starts resolving it again. Could this be something with the bundle >>

Re: [g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-11-03 Thread Jeremy Boynes
On Nov 3, 2010, at 2:05 AM, Stefan Bodewig wrote: > On 2010-11-02, Jeremy Boynes wrote: > >> The package goal should work as the reactor resolves dependencies >> using the built artifacts rather than the local repository. > > That's different from what I've see

Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

2010-11-03 Thread Jeremy Boynes
On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote: > On Nov 1, 2010, at 7:42 PM, Rex Wang wrote: > >> Thanks Jeremy, >> >> Is that because the group id dose not start with org.apache.tomcat...? > > I think so. I opened the issue asking for org.apache.taglibs to be

[taglibs] Tab police

2010-11-16 Thread Jeremy Boynes
As well as the tabs, there are broader inconsistencies in the style (e.g. consistent braces, missing javadoc, and the like) that lead to IDE warnings. How about running everything through a re-formatter to clean this up? Downside is that it will make back-patching harder. +1 from me. On Nov 16,

Re: [taglibs] Tab police

2010-11-16 Thread Jeremy Boynes
tab replacement with 4 spaces. > > -Rex > > 2010/11/16 Jeremy Boynes > >> As well as the tabs, there are broader inconsistencies in the style (e.g. >> consistent braces, missing javadoc, and the like) that lead to IDE warnings. >> >> How about running every

Re: svn commit: r1037279 [1/10] - in /tomcat/taglibs/standard/trunk/impl: (..)

2010-11-20 Thread Jeremy Boynes
That was me rather than the reformatter when I was checking out checkstyle. Forgot to revert that from the original patch, sorry. On Nov 20, 2010, at 3:34 PM, Konstantin Kolinko wrote: > 2010/11/20 : >> Author: jboynes >> Date: Sat Nov 20 17:57:45 2010 >> New Revision: 1037279 >> >> URL: http:

Re: svn commit: r1037360 - /tomcat/taglibs/standard/trunk/jstlel/src/main/java/org/apache/taglibs/standard/lang/jstl/parser/

2010-11-20 Thread Jeremy Boynes
Can we generate these during the build rather than checking in the generated source? On Nov 20, 2010, at 4:18 PM, kkoli...@apache.org wrote: > Author: kkolinko > Date: Sun Nov 21 00:18:14 2010 > New Revision: 1037360 > > URL: http://svn.apache.org/viewvc?rev=1037360&view=rev > Log: > Formatting

Re: DO NOT REPLY [Bug 50462] xalan import should not be optional in maven-bundle-plugin

2010-12-21 Thread Jeremy Boynes
On Dec 21, 2010, at 6:15 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=50462 > > --- Comment #3 from Rex Wang 2010-12-21 21:15:19 EST --- > (In reply to comment #2) >> It's marked optional in Maven as it is only needed if someone is using the >> XML >> tags

Re: DO NOT REPLY [Bug 50462] xalan import should not be optional in maven-bundle-plugin

2010-12-21 Thread Jeremy Boynes
On Dec 21, 2010, at 10:28 PM, Rex Wang wrote: > 2010/12/22 Jeremy Boynes >> >> Perhaps the changes needed to address the performance issue in #27717 are >> relevant here. >> These stem from issues in Xalan's implementation which would also apply if >> we tr

Re: DO NOT REPLY [Bug 50462] xalan import should not be optional in maven-bundle-plugin

2010-12-22 Thread Jeremy Boynes
On Dec 22, 2010, at 1:01 AM, Rex Wang wrote: > 2010/12/22 Jeremy Boynes >> >> The XPath implementation in Oracle's JDK was originally based on Xalan and >> has the same performance issue. >> >> One issue with the JAXP API is that it does not allow context

[taglibs] Trying to use JAXP XPath instead of raw Xalan

2010-12-23 Thread Jeremy Boynes
On Dec 22, 2010, at 1:01 AM, Rex Wang wrote: >>> >>> Why not move to the standard api in jdk instead of defining new apis and >>> wrappers? I put together an API to abstract the XPath implementation and tried to use the JAXP XPath support; see https://issues.apache.org/bugzilla/show_bug

Re: svn commit: r1051539 - /tomcat/trunk/java/org/apache/tomcat/util/threads/CounterLatch.java

2010-12-30 Thread Jeremy Boynes
Doug Lea also has information here: http://g.oswego.edu/dl/jmm/cookbook.html and Intel's doc is here: http://download.intel.com/design/processor/manuals/253668.pdf Section 8 has the info on the memory model. However, as the value is immutable and only set in the constructor, IMO fi

[taglibs] Refactoring XPath support

2010-12-30 Thread Jeremy Boynes
9578 which basically clears up the open bugs with the XML taglib On my machine, iterating 10 items took 1600ms which seems OK. It still increases with n^2 for some reason I have not figured out. On Dec 22, 2010, at 7:47 PM, Jeremy Boynes wrote: > > On Dec 22, 2010, at 1:01 AM, Rex Wang w

Re: DO NOT REPLY [Bug 50265] FormatDateSupport.dateFormatCache lazy init is not safe

2011-01-01 Thread Jeremy Boynes
g.cgi?id=50265 > > Jeremy Boynes changed: > > What|Removed |Added > > Depends on||32311 > > --- Comment #1 from Jeremy Bo

[taglibs] Move to pre-req Java 1.6 for Locale services?

2011-01-02 Thread Jeremy Boynes
In Java6 support was added for LocaleServiceProviders that extend the Locales supported by the java.text formatters. This causes #46052 as getAvailableLocales() now needs to scan the entire classpath rather than just return the Locales built in to the JRE. It also means we cannot continue to ca

Re: [taglibs] Move to pre-req Java 1.6 for Locale services?

2011-01-02 Thread Jeremy Boynes
On Jan 2, 2011, at 5:49 PM, Caldarale, Charles R wrote: >> From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy Boynes >> Subject: [taglibs] Move to pre-req Java 1.6 for Locale services? > >> As most users are likely to be running on 1.6 > > As the traf

Re: [taglibs] Move to pre-req Java 1.6 for Locale services?

2011-01-16 Thread Jeremy Boynes
iness of supporting the old versions when >> it gets painful, we're not. >> >> Hen >> >> On Sun, Jan 2, 2011 at 3:27 PM, Jeremy Boynes wrote: >>> In Java6 support was added for LocaleServiceProviders that extend the >>> Locales supported by

[taglibs] Time to release 1.2.0?

2011-01-23 Thread Jeremy Boynes
The only bug remaining that impact the JSTL libraries is #46052 (locale performance on 1.6). Henri suggested releasing in its current form which sounds reasonable. Should we release this as 1.2.0? Is this a good version number - should we use something like 1.2.0-beta? This will be the first re

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Jeremy Boynes
It also interacts with tag reinitialization as described here: https://issues.apache.org/bugzilla/show_bug.cgi?id=49589 in that we hang on to the value when the tag is in the pool only to clear it when we use it. I think there are other optimizations that could be done to forEach but have

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Jeremy Boynes
On Jan 27, 2011, at 10:14 AM, Kris Schneider wrote: > On Thu, Jan 27, 2011 at 11:54 AM, Christopher Schultz > wrote: >> ... >> I'd love to hear some comments. > > Some additional background: > https://issues.apache.org/bugzilla/show_bug.cgi?id=33934 > > I haven't looked at the patch, so I'm not

Re: [taglibs] Time to release 1.2.0?

2011-03-27 Thread Jeremy Boynes
On Mar 25, 2011, at 2:15 AM, Mark Thomas wrote: > On 23/01/2011 20:41, Jeremy Boynes wrote: >> The only bug remaining that impact the JSTL libraries is #46052 (locale >> performance on 1.6). Henri suggested releasing in its current form which >> sounds reasonable. Shou

Re: svn commit: r1085963 - /tomcat/taglibs/taglibs-parent/trunk/pom.xml

2011-03-27 Thread Jeremy Boynes
Thanks, fixed. On Mar 27, 2011, at 10:19 AM, Konstantin Kolinko wrote: > 2011/3/27 : >> Author: jboynes >> Date: Sun Mar 27 15:33:57 2011 >> New Revision: 1085963 >> >> URL: http://svn.apache.org/viewvc?rev=1085963&view=rev >> Log: >> applied parent patch for #50674 from Olivier Lamy >> >> Mod

[taglibs] Maven3 thinks the project structure is malformed

2011-03-27 Thread Jeremy Boynes
If I build standard I things are OK but if I build one of the modules (e.g. standard/impl) I get the following warning: [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.taglibs:taglibs-standard-impl:bundle:1.2-SNAPSHOT [WARNING] 'parent.relati

Re: Bug #57505 - Integration tests for JspC

2015-10-07 Thread Jeremy Boynes
On Sep 21, 2015, at 11:23 AM, Dinesh Joshi wrote: > > Hi all, > > I'm looking to contribute to Tomcat development. I am planning to take a > crack at this bug - https://bz.apache.org/bugzilla/show_bug.cgi?id=57505 > Anybody working on it? Can someone give me some pointers on how I should > pr

[ANN} Apache Standard Taglib 1.2.3 released

2015-02-26 Thread Jeremy Boynes
The Apache Tomcat team announces the immediate availability of Apache Standard Taglib 1.2.3. Apache Standard Taglib is an open source software implementation of the JSP Standard Tag Library (JSTL) technology. This release supports JSTL version 1.2 and includes bug-fixes and improvements on the

[SECURITY] CVE-2015-0254 XXE and RCE via XSL extension in JSTL XML tags

2015-02-26 Thread Jeremy Boynes
CVE-2015-0254 XXE and RCE via XSL extension in JSTL XML tags Severity: Important Vendor: The Apache Software Foundation Versions Affected: Standard Taglibs 1.2.1 The unsupported 1.0.x and 1.1.x versions may also be affected. Description: When an application uses or tags to process untrusted

Taglibs sub-site

2015-02-27 Thread Jeremy Boynes
On Feb 27, 2015, at 3:38 AM, kkoli...@apache.org wrote: > > Author: kkolinko > Date: Fri Feb 27 11:38:13 2015 > New Revision: 1662662 > > URL: http://svn.apache.org/r1662662 > Log: > Announcement for Standard Taglib 1.2.3. > > I do not like the CVE link (goes to announce@a.o mail archive) and CH

Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

2015-02-27 Thread Jeremy Boynes
On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko wrote: > > 2015-02-27 19:26 GMT+03:00 : >> Author: jboynes >> Date: Fri Feb 27 16:26:21 2015 >> New Revision: 1662736 >> >> URL: http://svn.apache.org/r1662736 >> Log: >> Replace old taglibs library with Apache Standard Taglib 1.2.3 >> >> Added:

Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

2015-02-27 Thread Jeremy Boynes
On Feb 27, 2015, at 6:43 PM, Jeremy Boynes wrote: > > On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko > wrote: >> >> 2015-02-27 19:26 GMT+03:00 : >>> Author: jboynes >>> Date: Fri Feb 27 16:26:21 2015 >>> New Revision: 1662736 >

Re: svn commit: r1662913 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestStandardContextAliases.java

2015-02-28 Thread Jeremy Boynes
On Feb 28, 2015, at 1:18 AM, r...@apache.org wrote: > > Author: remm > Date: Sat Feb 28 09:18:57 2015 > New Revision: 1662913 > > URL: http://svn.apache.org/r1662913 > Log: > Fix JSTL related test (already in skip list). Sorry about that, I didn’t think about running the tests for a change affec

Re: Time for Taglibs to be sent to the archive?

2015-02-28 Thread Jeremy Boynes
Resurrecting this old thread[1] as the topic came up related to the site changes. First message included for context below. TL;DR: Konstantin and I had interest in new work on Standard, Henri has helped with logistics. No-one had any interest in RDC. A concern at the time was lack of progress t

Using functional interfaces for tags and JSP

2015-03-02 Thread Jeremy Boynes
After the recent thread around taglibs future, I wanted to explore the possibility of using Java8’s functional interfaces to implement tags. http://svn.apache.org/r1663366 is a straw man I used. To explain the approach here, I started with the thought that the SimpleTag model in JSP2.0 was a ki

Taglibs/JSP future work, was: Time for Taglibs to be sent to the archive?

2015-03-02 Thread Jeremy Boynes
On Mar 2, 2015, at 5:21 AM, Konstantin Kolinko wrote: > > 2015-03-01 1:04 GMT+03:00 Jeremy Boynes : ... >> - Put Standard 1.2.x in maintenance mode for bug fixes only >> - Start a tree/branch for new work without the limitations of the >> now-ancient 1.2 spec >> -

WAR FileSystem for fast nested JAR access?

2015-03-03 Thread Jeremy Boynes
In https://bz.apache.org/bugzilla/show_bug.cgi?id=57251, Mark Thomas wrote: > The fix for bug 57472 might shave a few seconds of the deployment time but > it doesn't appear to make a significant difference. > > The fundamental problem when running from a packed WAR is that to access any > resource

Re: WAR FileSystem for fast nested JAR access?

2015-03-04 Thread Jeremy Boynes
On Mar 4, 2015, at 3:49 AM, Konstantin Kolinko wrote: > > 2015-03-04 8:20 GMT+03:00 Jeremy Boynes : >> In https://bz.apache.org/bugzilla/show_bug.cgi?id=57251, Mark Thomas wrote: >> >>> The fix for bug 57472 might shave a few seconds of the deployment time but >

Re: [VOTE][RESULT] Release Apache Taglibs 1.2.3

2015-03-06 Thread Jeremy Boynes
On Mar 6, 2015, at 1:06 AM, Mark Thomas wrote: > > On 20/02/2015 16:01, Konstantin Kolinko wrote: >> 2015-02-20 18:39 GMT+03:00 Jeremy Boynes : >>> The following vote were cast: >>> >>> Binding: >>> +1: jboynes, kkolinko, kfujino >>> >

Re: WAR FileSystem for fast nested JAR access?

2015-03-06 Thread Jeremy Boynes
On Mar 4, 2015, at 9:09 AM, Jeremy Boynes wrote: > > My suggestion for using an NIO2 FileSystem is because its API provides for > nesting and for random access to the entries in the filesystem. Something > like: > > Path war = FileSystems.getDefault().getPath(“real/path/

  1   2   3   >