Re: Problem with adding a StandardWrapper to an already started StandardContext

It's been a while since I looked at it, but once the context is started, the only way to update mappings it to invoke an additional JMX call to get the mapping registered with the connector. Take a look at org.apache.tomcat.util.http.mapper.Mapper org.apache.tomcat.util.http.mapper.MapperListene

Re: svn commit: r733748 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/s

this implementation may ask for more than is warranted. I would -1 based on for example "javax.servlet.request.ssl_session_mgr"; shouldn't extensions be named differently, and not within the javax.servlet namespace? SSLSessionManager.invalidateSession > not sure why the SSL sessions shoul

Re: svn commit: r733748 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/s

Mark Thomas wrote: From: Filip Hanik - Dev Lists [mailto:devli...@hanik.com] this implementation may ask for more than is warranted. I would -1 based on for example "javax.servlet.request.ssl_session_mgr"; shouldn't extensions be named differently, and

Campaign for votes for NIO patches

gents, I'm gonna campaign for some votes on the NIO connectors, let me line up what is needed * [2] Prevent async close NPE on already closed sockets - This simply performs a != null check to make sure the closure of a socket goes through all the phases * [3] Add ability to fix the keyAlias

Re: [g...@vmgump]: Project tomcat-trunk (in module tomcat-trunk) failed

time to move this boy to JDK 1.6 as we move towards servlet 3.0 Filip Bill Barker wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.ap

Tomcat JDBC Pool - first release tag

I am planning on tagging the Tomcat JDBC pool for a first release. I was wondering if there is any feedback, objections, support before I do so? Tagging is planned tomorrow, and a vote next week. Filip - To unsubscribe, e-mai

Re: View towards refactoring changes?

We once tried to merge them, it didn't pan out as we thought. They eventually drifted apart. They are probably better left as they are for now. The connectors are fairly complex and start merging them will almost guaranteed break them. The NIO connector for example, is spaghetti code heaven, wi

svn repo layout for modules

ok, I was just about to tag the connection pool, and realized, I'm not setup to do it. I would suggest https://svn.apache.org/repos/asf/tomcat/ - site - tc6.0.x - trunk - modules <-- ADD THIS - jdbc-pool - trunk - tags - branches - bayeux - trunk

Re: svn repo layout for modules

;ve seen projects with 10x more code and components than tomcat happily under one repo ( and one source tree even ). the entire ASF is under one repo, hence /repos/asf/... Costin On Fri, Jan 30, 2009 at 4:44 PM, Filip Hanik - Dev Lists wrote: ok, I was just about to tag the connect

Re: svn repo layout for modules

that would work for me, then the tag name could differentiate the module itself Filip Mark Thomas wrote: How about adding .../tomcat/tags ? Mark Filip Hanik - Dev Lists wrote: Costin Manolache wrote: It's getting spaghetti... If you really have to - no need to add &#x

Re: svn repo layout for modules

Remy Maucherat wrote: On Fri, 2009-01-30 at 17:44 -0700, Filip Hanik - Dev Lists wrote: I would suggest https://svn.apache.org/repos/asf/tomcat/ - site - tc6.0.x - trunk - modules <-- ADD THIS - jdbc-pool - trunk - tags - branches - bay

Re: svn repo layout for modules

Remy Maucherat wrote: On Fri, 2009-02-06 at 10:37 -0700, Filip Hanik - Dev Lists wrote: ASF is community over code, its hard to grow the community if you never add any code. Tomcat JDBC would actually make TC 7 even more light weight since it is smaller than DBCP. Tomcat JDBC is not

Re: tomcat-native: multicast on win32

Lorenz Breu wrote: David Knox wrote: I saw something like this once. It turned out to be a firewall on XP. Just a thought. thx for the pointer, after weeks of programming and debugging and profiling and testing i completely forgot about the "simple" problems :) unfortunately, even with

Re: Approach for keep alive timeouts

sounds pretty straight forward to me, remove most of the test basically 1. set regular soTimeout (connectionTimeout) -- loop starts here-- 2. read the request line and headers 3. check disableupload, if set to true, increase soTimeout to what ever we use 4. At the end of the request, if user sp

Re: svn commit: r751304 - in /tomcat/trunk: java/org/apache/catalina/valves/AddDefaultCharsetValve.java webapps/docs/config/valve.xml

Bill Barker wrote: wrote in message news:20090307184553.971be2388...@eris.apache.org... Author: markt Date: Sat Mar 7 18:45:53 2009 New Revision: 751304 URL: http://svn.apache.org/viewvc?rev=751304&view=rev Log: Add AddDefaultCharSetValve Added: tomcat/trunk/java/org/apache/catalina/valv

Re: [VOTE] Releasing Tomcat Connectors 1.2.28

[X] Stable - no major issues, no regressions - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r757381 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java

one could also make a toilet made out of solid gold, but it's just not in the cards now is it? http://www.imdb.com/character/ch0002425/quotes sebb wrote: On 23/03/2009, fha...@apache.org wrote: Author: fhanik Date: Mon Mar 23 12:07:36 2009 New Revision: 757381 URL: http://svn.apache.

Re: svn commit: r757381 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java

sebb wrote: Since it's a new variable, define new one can make it private now without breaking anything. Every little helps. On 23/03/2009, Filip Hanik - Dev Lists wrote: one could also make a toilet made out of solid gold, but it's just not in the cards now is it? http://ww

Re: bug in org.apache.tomcat.jdbc.pool.PooledConnection.validate() for initSQL

Thank you Torin, fixed in r758273 Filip torin.e.mcc...@jci.com wrote: Hi there is a bug in org.apache.tomcat.jdbc.pool.PooledConnection.validate (int validateAction, String sql) for initSQL. You do not perform the validation if it has occurred recently--getValidationInterval(). However this sh

Re: [GSOC] Filters & Async Support in Servlet 3.0

Anas Ahmed wrote: Two Scenarios of thread per request :- 1- if the request send directly to server without filter:- When a connection is idle between requests, the thread can be recycled, and the connection is placed in a centralized NIO select set to detect new request

Re: How to produce a Comet READ Event (EventType.READ) from the client side?‏

Comet READ events are generating when there is a POST method with a body John Dous wrote: Hello, Recently I started to develop a web application that is based on the Comet Architecture. After a lot of research, I realize that there is a lack of documentation and tutorials about how to build s

Re: [Proposal] Remove older of the two BIO AJP connectors

Mladen Turk wrote: Costin Manolache wrote: So in essence you have a new protocol but the sole difference is how you describe it. The API can be something like: - legacyRequest(RequestMessage) - whatever we have in the current AJP protocol - getServerLoad() and whatever new we wanted to add

Re: svn commit: r762374 - in /tomcat/trunk: build.xml java/org/apache/catalina/cluster/ java/org/apache/catalina/cluster/CollectedInfo.java java/org/apache/catalina/cluster/HeartbeatListener.java

Is the idea here to communicate the Tomcat server state to httpd using multicast? For that, you could simply build the feature set into org.apache.catalina.ha where you can send multicast packets, where you already have heart beat information etc. So going that route, why not use code, or at lea

Re: [VOTE] Release build 6.0.19

[X] Stable Filip Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.19/ According to the release process, the 6.0.19 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Note: The i18n issue for the French language could be addressed by

Re: svn commit: r762374 - in /tomcat/trunk: build.xml java/org/apache/catalina/cluster/ java/org/apache/catalina/cluster/CollectedInfo.java java/org/apache/catalina/cluster/HeartbeatListener.java

jean-frederic clere wrote: Filip Hanik - Dev Lists wrote: Is the idea here to communicate the Tomcat server state to httpd using multicast? Yes. For that, you could simply build the feature set into org.apache.catalina.ha where you can send multicast packets, where you already have heart

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? Filip ma...@apache.org wrote: Author: markt Date: Wed Apr 8 16:08:42 2009 New Revision: 763298 URL: http://svn.apache.org/viewvc?rev=763298&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi

Re: svn commit: r763726 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Proxy.java Sender.java TcpSender.java

jean-frederic clere wrote: It requires some new code in httpd-trunk to work... sounds like you're reinventing the wheel in tomcat trunk to avoid code in httpd trunk :) I'm fine either way, I just wanted to notify you of work that probably already does everything you are trying to do, and some m

Re: svn commit: r763726 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Proxy.java Sender.java TcpSender.java

jean-frederic clere wrote: Filip Hanik - Dev Lists wrote: jean-frederic clere wrote: It requires some new code in httpd-trunk to work... sounds like you're reinventing the wheel in tomcat trunk to avoid code in httpd trunk :) Not completely :) The logic in httpd-trunk is for a mult

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

Ian Darwin wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? It's generally making the code "better". What do you object to about it? very simple, if one is about to refactor code, how a

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSuppor

sebb wrote: On 10/04/2009, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. > is there an actual bug here? Reported bug, no. Bugs uses could hit, yes. Hence why this is in trunk and not

Re: o.a.c.ha.session.BackupManager question

The methods on the interface are custom to a specific implementation. And the backup manager for example, doesn't need these, nor does it use them So not entirely intentional, just legacy that lives on. Filip Ian Darwin wrote: While running an automated code testing tool of my own design I fou

Re: is this bug in tomcat 7 ?

it's work to be done :) Anas Ahmed wrote: hello all, mbean-descripator.xml in org.apache.catalina.tribes package is the same as mbean-descripator.xml in org.apache.catalina.ha package Anas _ More than messages–check out the res

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSuppor

sebb wrote: On 12/04/2009, Filip Hanik - Dev Lists wrote: sebb wrote: On 10/04/2009, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. > is there an actual bug here?

Re: svn commit: r766526 - in /tomcat/trunk: java/org/apache/tomcat/util/digester/Digester.java webapps/docs/config/systemprops.xml

Mark Thomas wrote: fha...@apache.org wrote: + Use this to add a property source, that will be invoked when s{parameter} + denoted parameters are found in the XML files that tomcat parses. Do you mean ${parameter} here? yes, will fix the typo Filip Mark ---

Re: svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java

As I mentioned in the bug report, what is the benefit of this? Filip ma...@apache.org wrote: Author: markt Date: Wed Apr 29 10:22:00 2009 New Revision: 769734 URL: http://svn.apache.org/viewvc?rev=769734&view=rev Log: Reduce scope - partial application of patch by Jens Kapitza from bug 46999

Re: svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java

Mark Thomas wrote: Filip Hanik - Dev Lists wrote: As I mentioned in the bug report, what is the benefit of this? General best practise - no particular bug. Note the full proposed patch was bad. Bad practice would be to change an API, based on a report for general practice. It

5.5.x release

I was thinking sometimes next week, how does that sound? Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

jdbc pool - prepping for a first release

I was thinking to create a release, (I know I dropped the ball on the last one), to gather feedback on the code itself. There have been community members already provided feedback and bug fixes so I'm hoping to gather even more. I created a tag and put it up here http://people.apache.org/~fhanik

Re: jdbc pool - prepping for a first release

so you're saying you can't run it with 1.5? if find a real bug that causes that, we will definitely fix it immediately. Filip sebb wrote: compile.source="1.5" yet there are several references to features which require Java 1.6+ On 01/05/2009, Filip Hanik - Dev Lis

Re: [VOTE] Release build 6.0.20

[X] Stable Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Rémy

Re: Mutable public fields in Tomcat 6 code

sebb wrote: There are quite a lot of public mutable static fields in the current Tomcat6 codebase. Such fields can allow malicious or accidental changes to occur, so should be avoided as far as possible. [And if a class has public mutable static fields it's generally impossible to make it thread

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

rj...@apache.org wrote: Guys fix your svn configuration. ;) This happens to me all the time, as I move between machines very often. Why is the ~/.subversion/config a client setting? isn't there a way to setup properties on the server the client can inherit from? so when I check out a proje

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

Konstantin Kolinko wrote: 2009/5/22 Filip Hanik - Dev Lists : rj...@apache.org wrote: Guys fix your svn configuration. ;) This happens to me all the time, as I move between machines very often. Why is the ~/.subversion/config a client setting? isn't there a way to

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

sebb wrote: On 22/05/2009, Rainer Jung wrote: On 22.05.2009 01:07, Filip Hanik - Dev Lists wrote: > rj...@apache.org wrote: >> Guys fix your svn configuration. ;) >> > This happens to me all the time, as I move between machines very often. > > Why is the ~/.su

Re: Coding Guidelines, encodings, keywords

Konstantin Kolinko wrote: Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there? spaces instead of tabs :) I am interested in clarifying the following question: What is the character encoding for our sources. Our build scripts do not specify

Re: Coding Guidelines, encodings, keywords

Leon Rosenberg wrote: 2009/5/22 Filip Hanik - Dev Lists : Konstantin Kolinko wrote: Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there? spaces instead of tabs :) Wow, "Are there really people out there who stil

Re: [VOTE] Release build 6.0.20

Martin Dubuc wrote: What is going to happen to the 6.0.20 load? Will it be officially released? that is based on the voting results, which passed, so yes, it will be released. If it will, when and will it be identical to the load found at: http://people.apache.org/~remm/tomcat-6/v6.0.20/

[VOTE] Release JDBC Pool module v1.0.3

The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.3/ [ ] STABLE - I couldn't find any bugs [ ] BETA - I found some bugs but not critical [ ] BROKEN - I found some show stoppers Any comments ? Thanks, Filip ---

Re: Tomcat Technical Documentation

The code itself is the best documentation there is. You could also search google for articles and other goodies Filip RamNarkhede wrote: Hi, I have just started using Tomcat. I want to understand how tomcat works. I've download the Tomcat Souces but I don't understand from where to start. Wher

Re: Tomcat Technical Documentation

I should mention that Tomcat implements the servlet and JSP specifications, so in there you will find the features that are being implemented Filip Filip Hanik - Dev Lists wrote: The code itself is the best documentation there is. You could also search google for articles and other goodies

Tagging 5.5.28

I was planning to tag 5.5.28 end of this week with a vote held next week? comments? Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Restructuring svn

+1 Filip Mark Thomas wrote: Once 4.1.x is archived, there will be no release branches sharing code. Therefore, we have the option to restructure 5.5.x to remove the use of externals. This would remove /repos/asf/tomcat /build /container /connector /current /current-svn15 /jasper /s

Re: Tagging 5.5.28

Konstantin Kolinko wrote: 2009/6/10 Filip Hanik - Dev Lists : I was planning to tag 5.5.28 end of this week with a vote held next week? 1. there are some patches that need more votes, and some of them are fixing known regressions you wanna list them out so that folks can

Re: [VOTE] Release JDBC Pool module v1.0.3

How about a little love here :) my vote [X] STABLE - I couldn't find any bugs Filip Filip Hanik - Dev Lists wrote: The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.3/ [ ] BETA - I found some bugs but not critical [ ] BROKEN - I found some show stoppers

Re: [VOTE] Release JDBC Pool module v1.0.3

Konstantin Kolinko wrote: 2009/6/11 Konstantin Kolinko : Sorry for somewhat slow reply, but just on formal grounds it is [x] BROKEN - I found some show stoppers See http://apache.org/legal/src-headers.html#notice http://www.apache.org/dev/release.html#distribute-other-artifacts will

Re: svn commit: r940189 - /tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

On 05/02/2010 04:02 AM, jfcl...@apache.org wrote: -// endpoint.processSocket(this.socket, SocketStatus.STOP); +try { +asyncDispatch(SocketStatus.STOP); // What to do with return code ? What you want to do here, is let the Endpoint know that

Re: svn commit: r940189 - /tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

On 05/03/2010 02:54 AM, jean-frederic clere wrote: On 05/02/2010 10:52 PM, Filip Hanik - Dev Lists wrote: On 05/02/2010 04:02 AM, jfcl...@apache.org wrote: -// endpoint.processSocket(this.socket, SocketStatus.STOP); +try

Re: clearReferencesThreads, Poller SunPKCS11-Solaris and strange context class loader

On 05/07/2010 08:03 AM, Rainer Jung wrote: On 07.05.2010 14:23, Konstantin Kolinko wrote: 2010/5/7 Rainer Jung: On 07.05.2010 11:00, Konstantin Kolinko wrote: 2010/5/7 Rainer Jung: I'm wondering why the PCKS Token Poller thread was captured by the leak prevention. Since we know the code, it

Re: svn commit: r944918 - /tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

we've meddled in those classes before, it was a minor disaster :D On 05/16/2010 05:03 PM, Konstantin Kolinko wrote: 2010/5/17: Author: markt Date: Sun May 16 21:31:57 2010 New Revision: 944918 URL: http://svn.apache.org/viewvc?rev=944918&view=rev Log: Code clean-up Modified: tomcat/t

Re: svn commit: r1051539 - /tomcat/trunk/java/org/apache/tomcat/util/threads/CounterLatch.java

On 12/21/2010 7:29 PM, sebb wrote: -private long signal; +private volatile long signal; It would be cheaper to make it final as it's only ever set in the ctor and is immutable. nothing cheaper, volatile are only expensive to write, not read. if maxConnections becomes a dynamically adju

Re: svn commit: r1051539 - /tomcat/trunk/java/org/apache/tomcat/util/threads/CounterLatch.java

On 12/28/2010 5:02 PM, sebb wrote: On 22 December 2010 16:04, Filip Hanik - Dev Lists wrote: On 12/21/2010 7:29 PM, sebb wrote: -private long signal; +private volatile long signal; It would be cheaper to make it final as it's only ever set in the ctor and is immutable. no

Re: Time for 6.0.30?

+1 Filip On 1/4/2011 3:44 AM, Mark Thomas wrote: It has been a while since 6.0.29 and there have been a few requests for this on the users list. Jean-Frederic, do you have any plans for 6.0.30 at this point? Cheers, Mark - T

Re: Tomcat JDBC Pool in Tomcat 6.0.x / 7.0.x

On 1/4/2011 9:22 AM, Henri Gomez wrote: I just see a new tag for jdbc-pool. I'll be very happy to have such advanced pool on Tomcat but we need some stable release (and of course artifact deployed to Maven central). So what's the status for it, and possible inclusion (as extra) in Tomcat 6.0.x

Re: svn commit: r1055137 - in /tomcat/trunk/modules/jdbc-pool: java/org/apache/tomcat/jdbc/pool/PooledConnection.java test/org/apache/tomcat/jdbc/test/AlternateUsernameTest.java

On 1/4/2011 12:27 PM, sebb wrote: On 4 January 2011 18:37, wrote: Author: fhanik Date: Tue Jan 4 18:37:44 2011 New Revision: 1055137 URL: http://svn.apache.org/viewvc?rev=1055137&view=rev Log: No need to instantiate a new driver instance each time, simply reuse the one we got Modified:

Re: DO NOT REPLY [Bug 50333] IllegalArgumentException occurs when setting maxActive to smaller than 1.

roger that Rainer, thank you! On 1/10/2011 1:43 PM, Rainer Jung wrote: Hi Filip, On 10.01.2011 17:41, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50333 Filip Hanik changed: What|Removed |Added

Re: [VOTE] Release build 6.0.30

[X] Stable On 1/10/2011 10:18 AM, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.30/ According to the release process, the 6.0.30 build corresponding to the tag TOMCAT_6_0_30 is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable C

Re: simple tomcat extension

can't you just create a directory, drop your jars in there, and in conf/catalina.properties, configure the shared.loader property? best Filip On 1/13/2011 9:05 AM, Juraj Burian wrote: Hello folks, I would like introduce new & very simple extension of Tomcat. In my opinion, many people must ha

Re: Tomcat 7.0.x. still CTR?

I'd prefer to stay CTR for a while. Chances are there are still much to be fixed given all the changes that have taken place. Filip On 1/18/2011 11:41 AM, Christopher Schultz wrote: All, Since Tomcat 7.0.x went stable, does that change the commit policy, or are we still doing commit-them-revie

Re: Need a 6.0.31 release

+1 On 1/20/2011 9:09 AM, Mark Thomas wrote: The memory leak in the Tomcat 7 NIO connector [1] got back-ported to 6.0.x and included in 6.0.30. [2] I have proposed the fix for 6.0.x. Given the severity I think we need to approve the backport and start a 6.0.31 release asap. Mark [1] http://s

Re: svn commit: r1061451 - /tomcat/tc6.0.x/trunk/STATUS.txt

On 1/20/2011 11:45 AM, kkoli...@apache.org wrote: Author: kkolinko Date: Thu Jan 20 18:45:09 2011 New Revision: 1061451 URL: http://svn.apache.org/viewvc?rev=1061451&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apa

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

I'd opt for the default value to be true. I rather have usability than spec compliance. that's exactly what the STRICT_SERVLET_COMPLIANCE flag does, it opts for usability,performance etc rather than spec compliance, and the default value I believe is false on that flag. Filip On 01/21/2011 11

Re: svn commit: r1063791 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/RpcChannel.java webapps/docs/changelog.xml

hmm, it should probably throw the commented out channel exception instead of simply bailing out with the flag set. After all the timeout has not been reached, so the caller should not be tricked into thinking that it has, since no one ever checks the interrupted flag Filip On 01/26/2011 09:5

Re: [VOTE] Release Tomcat 5.5.32 Build

On 01/22/2011 11:01 AM, Jim Jagielski wrote: [X] Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release build 6.0.32

On 02/02/2011 12:37 PM, jean-frederic clere wrote: [X] Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1068808 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

I'm glad you commented, there should be no looping at all. It was a left over from a previous proposal fixed in r1068996 Filip On 2/9/2011 2:35 AM, kkoli...@apache.org wrote: Author: kkolinko Date: Wed Feb 9 09:35:16 2011 New Revision: 1068808 URL: http://svn.apache.org/viewvc?rev=1068808&vi

Re: svn commit: r1068989 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java

I will fix it. Reattempt is managed in the channel itself at a much lower level. That has always been the case. Adding reattempt here is ambiguous, so I will readjust the interface to return void. best Filip On 2/10/2011 3:36 AM, Konstantin Kolinko wrote: 2011/2/9: Author: fhanik Date: Wed Fe

Re: Connection draining when upload to large

On 2/10/2011 6:04 AM, Rainer Jung wrote: Servlet 3 standardizes file uploads. It contains the ability to limit on request size, pretty much the same as commons fileupload supported for many years. It seems when this conditions triggers the rest of the request inout stream is still drained at th

Re: svn commit: r1071735 - /tomcat/trunk/modules/jdbc-pool/

On 02/17/2011 11:50 AM, Konstantin Kolinko wrote: -build.properties -includes -output done thanks - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Reaching ulimit values for open files can generate huge log files

Wouldn't you build this into the logging framework, instead of one specific component? best Filip On 02/21/2011 08:21 AM, Mark Thomas wrote: The ASF Sonar installation managed to generate 46GB of identical log messages [1] today in the 8 hours it took to notice it was down. While better monit

Re: Reaching ulimit values for open files can generate huge log files

On 02/22/2011 12:59 PM, Mark Thomas wrote: On 22/02/2011 19:34, Filip Hanik - Dev Lists wrote: Wouldn't you build this into the logging framework, instead of one specific component? You could, if you can find an efficient way to spot duplicate log messages and then differen

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

This looks like a CPU spinning handshake to me. The operation handshake(true, true); returns an IO interest to be registered with a selector. If the client is slow here or misbehaving, you could end up in a end less loop, and hence we can have introduced a very simple DoS vulnerability here.

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

On 2/27/2011 4:30 AM, Mark Thomas wrote: On 25/02/2011 20:16, Filip Hanik - Dev Lists wrote: The simplest solution is, would be to use an individual selector. Register the socket and issue a select() on the thread you are running on. If you want to use a shared selector (like NIO does for reads

Re: [VOTE] Release Apache Tomcat 7.0.9

[X] Broken - do not release http://svn.apache.org/viewvc?rev=1075030&view=rev http://svn.apache.org/viewvc?rev=1074675&view=rev Are not completely correct implementations as they don't - support a timeout correctly - dont account for when a write is needed on the selector - they potentially garb

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

against a trust store, then this valve, must make sure that the validation actually has taken place. Filip On 2/28/2011 11:06 AM, Filip Hanik - Dev Lists wrote: On 2/27/2011 4:30 AM, Mark Thomas wrote: On 25/02/2011 20:16, Filip Hanik - Dev Lists wrote: The simplest solution is, would be

Re: [VOTE] Release Apache Tomcat 7.0.9

On 2/28/2011 11:30 AM, Mark Thomas wrote: On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote: [X] Broken - do not release http://svn.apache.org/viewvc?rev=1075030&view=rev http://svn.apache.org/viewvc?rev=1074675&view=rev Are not completely correct implementations as they don'

Re: [VOTE] Release Apache Tomcat 7.0.9

On 2/28/2011 12:00 PM, Mark Thomas wrote: On 28/02/2011 18:45, Filip Hanik - Dev Lists wrote: On 2/28/2011 11:30 AM, Mark Thomas wrote: On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote: [X] Broken - do not release http://svn.apache.org/viewvc?rev=1075030&view=rev http://svn.apache

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

e not updated. In short, the NIO code can safely be backed out. The solution is quite simple, and it does not involve modifying the connectors. [1] setNeedClientAuth(true); http://download.oracle.com/javase/6/docs/api/javax/net/ssl/SSLEngine.html#setNeedClientAuth(boolean) best Filip On 2/

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

On 2/28/2011 4:49 PM, Mark Thomas wrote: It isn't clear to me if you are voting -1 on the above commit, and the following commits. r1074675 If you wish to do this, it should at least include: 1. input filters need to check if they retrieved the entire body if only partial, why even attempt a re

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

On 2/28/2011 5:27 PM, Mark Thomas wrote: On 01/03/2011 00:16, Filip Hanik - Dev Lists wrote: On 2/28/2011 4:49 PM, Mark Thomas wrote: It isn't clear to me if you are voting -1 on the above commit, and the following commits. r1074675 Understood and agree those commits are broken. I&#

STATUS.txt reviews

I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our bra

Re: STATUS.txt reviews

On 3/2/2011 2:05 PM, Mark Thomas wrote: On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http

[VOTE] Release jdbc-pool 1.1.0.0

Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_0/ Documentation http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html The proposed 1.1.0.0 release is: [ ] Broken - do not release [ ] Alpha - g

Re: [VOTE] Release jdbc-pool 1.1.0.0

Thanks, I will get this taken care of, and reroll. Filip On 3/2/2011 8:21 PM, sebb wrote: On 2 March 2011 22:09, Filip Hanik - Dev Lists wrote: Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ tomcat-juli.jar has NOTICE and LICENSE files, but none of the pool

[RESULT] [VOTE] Release jdbc-pool 1.1.0.0

I'll cancel this vote, get all the NOTICE and LICENSE files correct, as well as the tag matching the jars. best Filip On 3/2/2011 3:09 PM, Filip Hanik - Dev Lists wrote: Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.0/ Tag http://svn.apache.org/repos/asf/t

[VOTE] Release jdbc-pool 1.1.0.1

Source and Binary Packages http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/ Tag http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/ Documentation http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html The proposed 1.1.0.1 release is: [ ] Broken - do not release [ ] Alpha - g

Where do we stand with maven publishing?

Where do we stand with publishing Tomcat jars/artifacts to a Maven repository. I see that the mvn-pub.xml has been updated, but I don't see where the source JARs are generated from. best Filip - To unsubscribe, e-mail: dev-un

Re: svn commit: r1076736 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default build.xml sign.sh test/org/apache/tomcat/jdbc/test/Bug50571.java test/org/apache/tomcat/jdbc/test/Bug50805.java

On 3/3/2011 1:25 PM, Konstantin Kolinko wrote: 2011/3/3: Author: fhanik Date: Thu Mar 3 19:20:38 2011 New Revision: 1076736 URL: http://svn.apache.org/viewvc?rev=1076736&view=rev Log: Add missing files and license header Add NOTICE/LICENSE to all JAR files Added: tomcat/trunk/modules/jdb

Re: Where do we stand with maven publishing?

On 3/3/2011 5:25 PM, Konstantin Kolinko wrote: 2011/3/4 Filip Hanik - Dev Lists: Where do we stand with publishing Tomcat jars/artifacts to a Maven repository. I see that the mvn-pub.xml has been updated, but I don't see where the source JARs are generated from. Are you talking about Tom

Re: Where do we stand with maven publishing?

On 03/04/2011 01:54 AM, Mark Thomas wrote: On 04/03/2011 00:33, Filip Hanik - Dev Lists wrote: Got it. It doesn't seem to be published to https://repository.apache.org/ nor to ibiblio http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/tomcat/catalina/ Does it mean

Re: Where do we stand with maven publishing?

On 03/04/2011 12:18 PM, Mark Thomas wrote: On 04/03/2011 17:56, Filip Hanik - Dev Lists wrote: On 03/04/2011 01:54 AM, Mark Thomas wrote: On 04/03/2011 00:33, Filip Hanik - Dev Lists wrote: Got it. It doesn't seem to be published to https://repository.apache.org/ n

<    9   10   11   12   13   14   15   >