Re: Conflicts and JDT

2006-06-08 Thread Costin Manolache
I got it, so we have to use jdt. What about using a separate classloader to load JDT ( child or sibling of server classloader for example ), so any jdt in webapps won't be visible ? Well - if you are comfortable maintaining JDT changes, I don't have a problem, it just doesn't feel right. For sma

Re: Tomcat Comet Model

2006-06-16 Thread Costin Manolache
Not sure I understand all details here - but chunking seems like a better solution than sending a bad Content-Length. Sending a too large or incorrect content-length may break a lot of things ( and be rejected, affect proxies, etc ). Costin On 6/16/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
+1 - I'm also working on a nio connector ( it is in sandbox ), but the goals are quite different, I want to have it simpler and smaller than the apr model. I think old-style connector should be deprecated, since JDK1.5 is now required there is no point in having it. ( I assume this is intended fo

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > are quite different, > I want to have it simpler and smaller than the apr model. I think old-style > connector > should be deprecated, since JDK1.5 is now required there is no point in > ha

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > What about finally creating tomcat-modules or tomcat-addons ( or any other > name ), > for stuff that is (more or less) tomcat version independent, or at least > works for > multiple rec

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > Maybe create a modules/ under tomcat6 - with the definition 'stuff that can > be > released independently, and may support older versions of tomcat as well' > Or just 'can be release

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > By modules/ I mean mostly release units - so maybe a build.xml to create > build and package the module, some readme, manifest, etc. Tomcat normal > release wouldn't include the module,

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > I don't see the benefit of having things like cluster support in the tomcat > release - > if someone does want a cluster, they can easily download an additional > jar - > setting > up

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > Of course - all stuff must compile at least - but I don't think it's a > reasonable > requirement to have all modules or other things that are not part of tomcat > tested in order

Re: NIO Connector, please review

2006-06-22 Thread Costin Manolache
On 6/22/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Filip Hanik - Dev Lists wrote: > Ok, I have a non SSL enabled Java NIO connector created and checked in. > It works in the exact way as APR, meaning it blocks on read and write, > So its no true NIO, but close enough to handle comet style tra

Re: Tomcat sandbox

2006-06-26 Thread Costin Manolache
You mean to remove the 'single tree', and only have components ? I can live with this, but I don't think it's the best idea - and I haven't seen any reasons for that. The idea of the sandbox is that you can try things in it - including the single source tree :-) Why don't you start a component d

Re: svn commit: r415813 - in /tomcat/sandbox/java/org/apache/tomcat/util/modeler: ./ modules/

2006-06-26 Thread Costin Manolache
We could - but since JMX is in JDK anyway, I don't think it's that important to wrap it or not have a code dependency. Wrapping won't make it lighter at runtime :-) I should just clean up the few places where jmx is abused ( i.e. used as an introspection equivalent in normal code paths ). It's us

Re: Renaming jakarta-tomcat-connectors to tomcat-connectors?

2006-06-28 Thread Costin Manolache
And why are you doing this ? For tomcat5 - I don't see how much it helps. For tomcat6+ - I think the main issue is figuring where to put the native code so the duplicated java source trees don't confuse people. Given how much unused native we have, it may be good to just move mod_jk and whatever

Re: Renaming jakarta-tomcat-connectors to tomcat-connectors?

2006-06-28 Thread Costin Manolache
#x27;jakarta tomcat', and it's more or less history - we make sort of maintainance releases. For tomcat6 and other future releases - we can stop using jakarta. Costin On 6/28/06, Yoav Shapira <[EMAIL PROTECTED]> wrote: Hi, On 6/28/06, Costin Manolache <[EMAIL PROTECTED]>

Re: JK and AJP protocol enhancements

2006-07-09 Thread Costin Manolache
What's the status with mod_proxy ? It seems this kind of change would break backward compatibility, and if this happens - maybe it's better to fix the protocol marshalling limitations or change it completely. I hate the idea of patching an old and mostly broken marshalling model. The only thing

Re: SVN propset branch for tc6

2006-07-19 Thread Costin Manolache
On 7/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Hi, I have created a branch that shows the difference between current trunk and the new one wit correctly set svn:eol-style and svn:executable For example the java/org/apache/catalina/Context.java when checked out on linux has DOS line endings

Re: SVN messages.

2006-07-20 Thread Costin Manolache
The svn messages are quite horrible IMO. Is there any way to suppress them in future ? Regarding the move - again, IMO it was not necessary, nothing prevented creation of a /sandbox/foo, and I think having a common java/ tree for components that didn't want separate tree was a good thing. But now

Re: SVN messages.

2006-07-20 Thread Costin Manolache
rce anyone to read them, those who do want to read them will subscribe to a list ( or set a filter ) anyway, those who don't will also set a filter or ignore them. Costin On 7/20/06, Yoav Shapira <[EMAIL PROTECTED]> wrote: Hi, On 7/20/06, Costin Manolache <[EMAIL PROTECTED]> wr

Re: Excessive Lock/Unlock Traffic

2006-07-21 Thread Costin Manolache
Good to hear from infrastructure@ ! We all agree that the svn lock/svn unlock traffic was a bad thing, and even worse that 2 mails were sent for each file in the repository. AFAIK this is result of changing a simple property in the tomcat repository ( for line ending ), and it's a serious bug in

Re: Excessive Lock/Unlock Traffic

2006-07-21 Thread Costin Manolache
ow to do this kind of changes without locking. Costin On 7/21/06, Garrett Rooney <[EMAIL PROTECTED]> wrote: On 7/21/06, Costin Manolache <[EMAIL PROTECTED]> wrote: > Good to hear from infrastructure@ ! > > We all agree that the svn lock/svn unlock traffic was a bad thing, and &

Re: Relation of jasper and servlet API to Tomcat

2006-08-20 Thread Costin Manolache
If you want to include the real tomcat in gentoo - please use the official label, follow the same procedure as our release, and make sure the result of emerge is identical with what the user would get if he would get tomcat from ASF. If you have to patch - and the patch alters the structure or beh

Re: svn commit: r439529 - in /tomcat/sandbox/tomcat-lite: build.xml webapps/ROOT/WEB-INF/web.xml

2006-09-04 Thread Costin Manolache
I'm trying to avoid the lib/ directory as much as possible for tomcat-lite. I would like to have a single jar, with everything needed for the runtime - and use normal webapps for the rest. For example jasper would be packaged as a webapp ( or maybe 2 - one for runtime and one for compiler ). Addi

Re: svn commit: r439529 - in /tomcat/sandbox/tomcat-lite: build.xml webapps/ROOT/WEB-INF/web.xml

2006-09-04 Thread Costin Manolache
I'm just packing a subset of tomcat6, I don't think it has any deps except tomcat6. Costin On 9/4/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > I'm trying to avoid the lib/ directory as much as possible for tomcat-lite. I was talking about

Re: [6.0] Updates

2006-09-28 Thread Costin Manolache
On 9/27/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Peter Rossbach wrote: > Hi Filip, > > I thing many people use the current cluster implementation. For those > people I want spend my time to sync two branches :-) > Some people ask me to start experiments with new Servlet and JSP API's > or t

Re: [6.0] Updates

2006-09-29 Thread Costin Manolache
On 9/29/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > IMO both clustering implementations should be provided as separate > downloads. > > No need to put them in sandbox ( since they were released in the past, it's > 'proven' cod

Re: [VOTE] Tomcat 6 release plan

2006-10-18 Thread Costin Manolache
+1 Costin On 10/17/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Hi, The release plan is located here: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/RELEASE-PLAN-6.0.txt [ ] +1 [ ] +0 [ ] -1 This calls for a first build to be released by friday, and it will use the same release pro

Re: WebSocket progress report

2012-01-28 Thread Costin Manolache
On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas wrote: > On 26/01/2012 23:15, Mark Thomas wrote: > > Good news. The WebSocket implementation has reached a state where you > > should be able to play with it. Receiving and sending of binary and text > > data via streams/writers and messages is all wor

Re: WebSocket progress report

2012-01-29 Thread Costin Manolache
On Sun, Jan 29, 2012 at 2:19 AM, Mark Thomas wrote: > On 29/01/2012 01:20, Costin Manolache wrote: > > On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas wrote: > > > > Not complaining - it's great to add this feature, please commit it - but > > I'm wondering &

Tomcat-native patch for NPN support

2012-02-01 Thread Costin Manolache
Hi, I have a patch to the jni library, I uploaded it to github for easy commenting: https://github.com/costinm/tomcat-native/commit/5e7d4b45bfa542e4b099bfdc2bda423b9a6cc85d Please let me know if it looks ok - I included a 'cmake' build, which can generate a libtcnative.so with no external depend

SPDY support

2012-02-01 Thread Costin Manolache
Hi, Some initial patch for SPDY - using the NPN SSL extension, as required by chrome/firefox. I used github so it's easy to add comments or test: https://github.com/costinm/tomcat/commit/e97def3314216c083cc4b68ad9731e5a94b2af28 Basic 'hello world' works in both jio and apr, looking for opinions

Re: SPDY support

2012-02-02 Thread Costin Manolache
On Thu, Feb 2, 2012 at 3:33 AM, Mark Thomas wrote: > On 02/02/2012 10:05, Remy Maucherat wrote: > > On Wed, 2012-02-01 at 13:54 -0800, Costin Manolache wrote: > >> Hi, > >> > >> Some initial patch for SPDY - using the NPN SSL extension, as required > b

Re: Tomcat-native patch for NPN support

2012-02-02 Thread Costin Manolache
On Thu, Feb 2, 2012 at 12:21 AM, jean-frederic clere wrote: > On 02/01/2012 09:59 PM, Costin Manolache wrote: > >> Hi, >> >> I have a patch to the jni library, I uploaded it to github for easy >> commenting: >> >> https:/

Re: svn commit: r1241356 - in /tomcat/trunk/java/org/apache/tomcat/jni: Poll.java SSL.java SSLExt.java

2012-02-07 Thread Costin Manolache
On Tue, Feb 7, 2012 at 2:14 AM, Mark Thomas wrote: > On 07/02/2012 06:13, cos...@apache.org wrote: > > Author: costin > > Date: Tue Feb 7 06:13:36 2012 > > New Revision: 1241356 > > > > URL: http://svn.apache.org/viewvc?rev=1241356&view=rev > > Log: > > Add the new ssl methods from tomcat-native

Re: SPDY support

2012-02-14 Thread Costin Manolache
2012 at 6:37 AM, Mark Thomas wrote: > On 02/02/2012 14:14, Costin Manolache wrote: > > On Thu, Feb 2, 2012 at 3:33 AM, Mark Thomas wrote: > > > >> On 02/02/2012 10:05, Remy Maucherat wrote: > > >>> Ok, I think your "light protocol" conce

Re: SPDY support

2012-02-14 Thread Costin Manolache
On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > On 14/02/2012 08:29, Costin Manolache wrote: > > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > > > Please take another look - in particular to > > > https://github.com/costinm/tom

Re: SPDY support

2012-02-14 Thread Costin Manolache
see how it looks. Costin On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > On 14/02/2012 08:29, Costin Manolache wrote: > > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > > > Please take another look - in particular to > > > htt

Re: SPDY support

2012-02-14 Thread Costin Manolache
ch is another requirement ). On Tue, Feb 14, 2012 at 3:32 PM, Mark Thomas wrote: > On 14/02/2012 20:47, Costin Manolache wrote: > > On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > > > >> On 14/02/2012 08:29, Costin Manolache wrote: > >>> Ok, took a bi

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 6:33 AM, Mark Thomas wrote: > On 15/02/2012 03:53, Costin Manolache wrote: > > Uploaded another take. > > > > This time I'm just adding > > > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.j

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:56 AM, Mladen Turk wrote: > On 02/15/2012 04:53 AM, Costin Manolache wrote: > >> Uploaded another take. >> >> >> For non-SSL ( JIO, and apr without ssl ) -> SPDY just kicks in on all >> connections, >> this is just a

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:34 AM, Mark Thomas wrote: > > > Processor is tied to one request/response - Spdy protocol is a > multiplexing > > protocol, so one spdy connection will have 100s of Requests. > > I am using Processor interface for each muxed spdy stream. > > Hmm. I wonder if we need a d

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 10:31 AM, Mark Thomas wrote: > On 15/02/2012 16:11, Costin Manolache wrote: > > After I submit, I'll give a try to changing SocketWrapper (non-generic, > > add read/write), in the git. If you don't like it - easy to drop the > branch, > &

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:10 PM, Mark Thomas wrote: > On 15/02/2012 19:58, Costin Manolache wrote: > > In spdy I'm using a SpdyFrame class ( spdy allow data frames to be > > fragmented any > > way you want by intermediary - so even if I receive a huge frame, I can

Re: Release Tomcat Native 1.1.23

2012-02-21 Thread Costin Manolache
Is this going to be from head ? How can I get the NPN ( sslext.c ) included ? Costin On Tue, Feb 21, 2012 at 9:41 AM, Mladen Turk wrote: > On 02/21/2012 06:05 PM, Christopher Schultz wrote: > >> Mladen, >> >> On 2/21/12 11:30 AM, Mladen Turk wrote: >> >>> We have couple of bugs fixed and its be

Re: Release Tomcat Native 1.1.23

2012-02-21 Thread Costin Manolache
On Tue, Feb 21, 2012 at 12:51 PM, Rainer Jung wrote: > On 21.02.2012 21:30, Costin Manolache wrote: > >> Is this going to be from head ? How can I get the NPN ( sslext.c ) >> included >> ? >> > > Mladen is aiming for 1.1.23, so he will be releasing from the 1.1

Re: Release Tomcat Native 1.1.23

2012-02-21 Thread Costin Manolache
Will do it tonight ( it's already in the trunk ) Costin On Tue, Feb 21, 2012 at 1:25 PM, Rainer Jung wrote: > On 21.02.2012 21:56, Costin Manolache wrote: > >> On Tue, Feb 21, 2012 at 12:51 PM, Rainer Jung** >> wrote: >> >> On 21.02.2012 21:30, Costin Manolac

Re: Release Tomcat Native 1.1.23

2012-02-21 Thread Costin Manolache
On Tue, Feb 21, 2012 at 3:29 PM, Mladen Turk wrote: > On 02/21/2012 09:56 PM, Costin Manolache wrote: > >> On Tue, Feb 21, 2012 at 12:51 PM, Rainer Jung** >> wrote: >> >> On 21.02.2012 21:30, Costin Manolache wrote: >>> >>> Is this going to

Re: Release Tomcat Native 1.1.23

2012-02-21 Thread Costin Manolache
e, Feb 21, 2012 at 3:29 PM, Mladen Turk wrote: > On 02/21/2012 09:56 PM, Costin Manolache wrote: > >> On Tue, Feb 21, 2012 at 12:51 PM, Rainer Jung** >> wrote: >> >> On 21.02.2012 21:30, Costin Manolache wrote: >>> >>> Is this going to

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Costin Manolache
On Tue, Feb 21, 2012 at 11:11 PM, Mladen Turk wrote: > On 02/22/2012 06:17 AM, Costin Manolache wrote: > >> Mladen: please let me know if you want to further review the change or >> should I merge it to the branch. >> >> > Well I personally would not merge that i

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 8:13 AM, Mladen Turk wrote: > On 02/22/2012 03:54 PM, Costin Manolache wrote: > >> On Tue, Feb 21, 2012 at 11:11 PM, Mladen Turk wrote: >> >>> >>>> Well I personally would not merge that into 1.1.x branch. >>> It would

Re: SPDY support

2012-02-22 Thread Costin Manolache
omatic builders run 'ant download' ? Any concerns with it ? Costin On Thu, Feb 16, 2012 at 2:11 PM, Mark Thomas wrote: > On 16/02/2012 01:44, Costin Manolache wrote: > > That doesn't mean the application must receive the entire message as one > > byte[] >

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: > On 22/02/2012 16:51, Costin Manolache wrote: > > First part submitted. For the second: what is the process for adding a > > dependency ? > > Why do you need the dependency? > Spdy requires header compression - with

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 9:12 AM, Mladen Turk wrote: > On 02/22/2012 05:47 PM, Costin Manolache wrote: > >> On Wed, Feb 22, 2012 at 8:13 AM, Mladen Turk wrote: >> >> One thing I would appreciate help with: I would like to have an option to >> statically link >>

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko wrote: > 2012/2/22 Costin Manolache : > > On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: > > > >> On 22/02/2012 16:51, Costin Manolache wrote: > >> > First part submitted. For the seco

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 10:47 AM, Mark Thomas wrote: > On 22/02/2012 18:41, Costin Manolache wrote: > > On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko < > knst.koli...@gmail.com > >> wrote: > > > >> 2012/2/22 Costin Manolache : > >>>

Re: Release Tomcat Native 1.1.23

2012-02-23 Thread Costin Manolache
Thanks, I'll try it. Costin On Thu, Feb 23, 2012 at 11:53 AM, Mladen Turk wrote: > On 02/22/2012 07:22 PM, Costin Manolache wrote: > >> On Wed, Feb 22, 2012 at 9:12 AM, Mladen Turk wrote: >> >> >> I'm trying to provide a way for people to build "l

Re: WebSocket status

2012-03-01 Thread Costin Manolache
On Thu, Mar 1, 2012 at 9:54 AM, Mark Thomas wrote: > On 01/03/2012 17:13, Filip Hanik - Dev Lists wrote: > > Mark, what buffer size are you referring to increase for the web socket > > tests to all pass? > > Sorry, should have been clearer about that. > > In o.a.c.websocket.MessageInbound > >

Re: svn commit: r1296944 - /tomcat/native/trunk/native/src/poll.c

2012-03-05 Thread Costin Manolache
On Mon, Mar 5, 2012 at 4:45 AM, Mladen Turk wrote: > On 03/05/2012 07:30 AM, cos...@apache.org wrote: > >> Author: costin >> Date: Mon Mar 5 06:30:17 2012 >> New Revision: 1296944 >> >> URL: >> http://svn.apache.org/viewvc?**rev=1296944&view=rev

Re: svn commit: r1296944 - /tomcat/native/trunk/native/src/poll.c

2012-03-05 Thread Costin Manolache
On Mon, Mar 5, 2012 at 1:39 PM, Costin Manolache wrote: > > > On Mon, Mar 5, 2012 at 4:45 AM, Mladen Turk wrote: > >> On 03/05/2012 07:30 AM, cos...@apache.org wrote: >> >>> Author: costin >>> Date: Mon Mar 5 06:30:17 2012 >>> New Revisi

Re: WebSocket status

2012-03-08 Thread Costin Manolache
Speaking of thread safety, in the APR connector, when SSL is used, it may be possible to hit some problems if read and write are called at same time from different threads on same socket - SSL_read and SSL_write share the same context and apparently are not safe. I don't know if websocket allows a

Re: SPDY support

2012-03-12 Thread Costin Manolache
rking with the NIO connector - not sure if it's ok to add this dependency, but at least to compare them. ( NPN == "next protocol negotiation", a TLS extension required for SPDY support ) Costin On Wed, Feb 22, 2012 at 11:08 PM, Costin Manolache wrote: > On Wed, Feb 22, 2012 at

Re: SPDY support

2012-03-14 Thread Costin Manolache
it'll be a separate class implementing 'npn handler for nio' ( like it is hooked in the apr protocol), and in order to use it you'll need to download the npn-boot. Costin On Wed, Mar 14, 2012 at 5:32 AM, Konstantin Kolinko wrote: > 2012/2/2 Costin Manolache : > > > &g

Re: WebSockets in Tomcat 6

2012-03-15 Thread Costin Manolache
On Thu, Mar 15, 2012 at 7:10 AM, Filip Hanik - Dev Lists wrote: > On 3/15/2012 6:54 AM, Mark Thomas wrote: > >> On 14/03/2012 17:42, Filip Hanik Mailing Lists wrote: >> >>> http://people.apache.org/~**fhanik/reports/servers/ >>> >>> Attached is a

Re: SPDY support

2012-03-19 Thread Costin Manolache
On Mon, Mar 19, 2012 at 10:43 AM, Gus Heck wrote: > I just bumped into the whole concept of SPDY this morning, and it sounds > fabulous, and I'm quite happy to see that it's already underway in trunk. > I'm quite likely to be using a lot of development using Vaadin framework in > the near future,

Re: SPDY support

2012-03-24 Thread Costin Manolache
2012 at 11:31 AM, Costin Manolache wrote: > > > On Mon, Mar 19, 2012 at 10:43 AM, Gus Heck wrote: > >> I just bumped into the whole concept of SPDY this morning, and it sounds >> fabulous, and I'm quite happy to see that it's already underway in trunk. >>

Re: SPDY support

2012-03-25 Thread Costin Manolache
7;m proposing for tomcat7. Costin > Filip > > - Original Message - > > From: "Costin Manolache" > > To: "Tomcat Developers List" > > Sent: Saturday, March 24, 2012 10:44:19 PM > > Subject: Re: SPDY support > > > > Hi, > &

Re: SPDY support

2012-03-25 Thread Costin Manolache
On Sun, Mar 25, 2012 at 5:58 PM, Bill Barker wrote: > > > "Mark Thomas" wrote in message news:4F6F8735.3090706@apache.**org... > > > On 25/03/2012 17:24, Costin Manolache wrote: > >> For Tomcat7 I'm proposing to only add hooks: 'beforeHand

Re: Purpose of unlockAccept

2012-05-07 Thread Costin Manolache
By 'unlockAccept' you mean the socket connection made to the acceptor to force the accept() to unblock ? How are you getting the socket accept() to return, my understanding was that close() or thread interrupt don't work in all cases/VMs. Costin On Mon, May 7, 2012 at 9:24 AM, Mladen Turk wrote:

Re: Purpose of unlockAccept

2012-05-07 Thread Costin Manolache
On Mon, May 7, 2012 at 3:44 PM, Mladen Turk wrote: > On 05/07/2012 11:05 PM, Costin Manolache wrote: > >> By 'unlockAccept' you mean the socket connection made to the acceptor to >> force the accept() to unblock ? How are you getting the socket accept() to >>

Re: Purpose of unlockAccept

2012-05-07 Thread Costin Manolache
On Mon, May 7, 2012 at 11:05 PM, Mladen Turk wrote: > On 05/08/2012 01:13 AM, Costin Manolache wrote: > >> On Mon, May 7, 2012 at 3:44 PM, Mladen Turk wrote: >> >> On 05/07/2012 11:05 PM, Costin Manolache wrote: >>> >>> By 'unlockAccept' yo

Re: Purpose of unlockAccept

2012-05-08 Thread Costin Manolache
8, 2012 at 3:28 AM, Mark Thomas wrote: > On 08/05/2012 07:41, Mladen Turk wrote: > > On 05/08/2012 08:34 AM, Costin Manolache wrote: > >> On Mon, May 7, 2012 at 11:05 PM, Mladen Turk wrote: > >> > >>> > >>> For real pause (stop accepting conn

Re: Purpose of unlockAccept

2012-05-08 Thread Costin Manolache
On Tue, May 8, 2012 at 11:01 AM, Mladen Turk wrote: > On 05/08/2012 07:09 PM, Costin Manolache wrote: > >> IMHO neither 'graceful shutdown' nor 'deploy' are best served by not >> accepting connections: >> - for 'graceful' - a number of conn

Re: Purpose of unlockAccept

2012-05-08 Thread Costin Manolache
On Tue, May 8, 2012 at 11:54 AM, Mark Thomas wrote: > On 08/05/2012 19:47, Costin Manolache wrote: > > You may still want to accept requests for existing sessions. > > > > Both 'graceful shutdown' and app deploy are important cases - it's just > > t

Re: SpdyProxyProtocol class using AJP constants

2012-05-12 Thread Costin Manolache
On Sat, May 12, 2012 at 8:08 AM, Konstantin Kolinko wrote: > Hi! > > The SpdyProxyProtocol class (exists in trunk only) uses ajp.Constants > class: > >setSoLinger(Constants.DEFAULT_CONNECTION_LINGER); >setSoTimeout(Constants.DEFAULT_CONNECTION_TIMEOUT); >setTcpNoDelay(Cons

Re: APR/native and per socket timeouts.

2012-05-21 Thread Costin Manolache
My understanding is that the timeout is implemented in poll.c maintain() - by scanning the socket list in C. Why not doing the same thing in java - i.e. don't touch native code, have all sockets 'long', and close whenever you need from java ? Costin On Mon, May 21, 2012 at 5:55 AM, Mark Thomas

Re: Porting native fixes from trunk to 1.1.x

2012-05-21 Thread Costin Manolache
Any plan to do a release out of trunk (1.2 ) ? interrupt() and the others seem useful. Costin On Mon, May 21, 2012 at 5:41 AM, Mark Thomas wrote: > On 21/05/2012 13:25, Mark Thomas wrote: > > Just a quick check before I hit commit. Am I correct in thinking that > > r1296944 [1] should be back-

Re: native connector tool chain

2012-05-21 Thread Costin Manolache
Sorry, haven't compiled on windows in last >10 years. I suspect the easiest path would be cygwin and gcc. If you want to use vcc - you need to find a way to generate the project file with the right flags. One option would be to use the CMakeLists.txt - you'll probably need to adjust the options an

Re: APR/native and per socket timeouts.

2012-05-21 Thread Costin Manolache
On Mon, May 21, 2012 at 9:29 AM, Mark Thomas wrote: > On 21/05/2012 15:26, Costin Manolache wrote: > > My understanding is that the timeout is implemented in poll.c maintain() > - > > by scanning the socket list in C. > > > > Why not doing the same thing in java

Re: native connector tool chain

2012-05-21 Thread Costin Manolache
On Mon, May 21, 2012 at 10:31 AM, Mark Thomas wrote: > On 21/05/2012 17:52, Mladen Turk wrote: > > On 05/21/2012 02:05 PM, Mark Thomas wrote: > >> I am trying to build the 1.1.x native connector from trunk so I can test > >> the changes I plan to make to support per socket time outs. I can build

Re: APR/native and per socket timeouts.

2012-05-21 Thread Costin Manolache
On Mon, May 21, 2012 at 10:48 AM, Mark Thomas wrote: > On 21/05/2012 18:30, Costin Manolache wrote: > > On Mon, May 21, 2012 at 9:29 AM, Mark Thomas wrote: > > > >> On 21/05/2012 15:26, Costin Manolache wrote: > >>> My understanding is that the timeout

Re: APR/native and per socket timeouts.

2012-05-21 Thread Costin Manolache
On Mon, May 21, 2012 at 12:16 PM, Mladen Turk wrote: > On 05/21/2012 08:01 PM, Costin Manolache wrote: > >> On Mon, May 21, 2012 at 10:48 AM, Mark Thomas wrote: >> >> >> My point was that you don't need to change anything in native. >> >> Leave

Re: Possible IIS SPDY Redirector for Tomcat

2012-05-29 Thread Costin Manolache
gt; are also loaded from localhost). > > 7. If you close the Java NPN SPDY tunnel and open the URL again, the > following text should appear: > HTTP 503 > The request could not be served because the remote server was not > available. > > (when starting the Java NPN Spd

Re: Resources - Is DirContext the right basis for the API?

2012-09-27 Thread Costin Manolache
On Thu, Sep 27, 2012 at 2:14 AM, Mark Thomas wrote: > On 27/09/2012 10:09, Konstantin Kolinko wrote: > > I am sure that DirContext is not the right API to define resources. > > > > At best is could be a [deprecated] view/proxy to the actual > implementation. > > > > The only benefit I see in usin

Re: Resources - Is DirContext the right basis for the API?

2012-09-27 Thread Costin Manolache
On Thu, Sep 27, 2012 at 10:54 AM, Remy Maucherat wrote: > On Thu, 2012-09-27 at 07:34 -0700, Costin Manolache wrote: > > One use for a resource API is if it provides different backends - like > > Hadoop filesystem abstraction > > does. Than you could serve from hdfs/db/etc,

Re: Resources - Is DirContext the right basis for the API?

2012-09-27 Thread Costin Manolache
On Thu, Sep 27, 2012 at 10:18 AM, Mark Thomas wrote: > > > Costin Manolache wrote: > > >On Thu, Sep 27, 2012 at 2:14 AM, Mark Thomas wrote: > > > >> On 27/09/2012 10:09, Konstantin Kolinko wrote: > >> > I am sure that DirContext is not the right A

Re: Resources - merging back the changes

2012-10-31 Thread Costin Manolache
Hi Mark, I synced from HEAD - and noticed that DefaultServlet.PUT now fails with '403' if the resource already exists. I'm pretty sure this used to work, and at least for webdav it's supposed to replace the content. Is this a bug - or intended (the problem seems to be preResourceExists() check in

Re: Resources - merging back the changes

2012-10-31 Thread Costin Manolache
On Wed, Oct 31, 2012 at 4:41 PM, Costin Manolache wrote: > Hi Mark, > > I synced from HEAD - and noticed that DefaultServlet.PUT now fails with > '403' if the resource already exists. > I'm pretty sure this used to work, and at least for webdav it's supposed &g

Re: Mavenized tomcat build

2009-07-10 Thread Costin Manolache
On Fri, Jul 10, 2009 at 5:19 PM, David Jencks wrote: > > On Jul 10, 2009, at 5:01 PM, Filip Hanik - Dev Lists wrote: > >> On 07/10/2009 05:19 PM, Yoav Shapira wrote: >>> >>> On Fri, Jul 10, 2009 at 6:26 PM, David Jencks >>>  wrote: >>> I am well aware that the tomcat developers regard ant as t

Re: Mavenized tomcat build

2009-07-11 Thread Costin Manolache
I think there are few separate issues: 1, If there is a patch that needs to be applied by geronimo to use tomcat or they are blocked by missing something from a release - we should review this again. I think we can do a tomcat-geronimo release specifically for them as worse case ( well, we did it

3.0 annotations ?

2009-08-04 Thread Costin Manolache
Hi, anyone working on the @Filter, @Servlet annotation scanner for tomcat-trunk ? If I'm understanding it correctly, tomcat will have to read all files in classes and lib and look for the annotation - and I would guess the only reasonable option is looking at bytecode. I checked BCEL - seems reason

Re: 3.0 annotations ?

2009-08-04 Thread Costin Manolache
itory.apache.org/content/repositories/snapshots/org/apache/geronimo/specs/geronimo-servlet_3.0_spec/1.0-EA-SNAPSHOT/ > > > https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec > > thanks > david jencks > > > On Aug 4, 2009, at 11:11 AM, Costin Man

Re: 3.0 annotations ?

2009-08-07 Thread Costin Manolache
On 08/04/2009 03:28 PM, David Blevins wrote: >> >>> >>> On Aug 4, 2009, at 1:22 PM, Costin Manolache wrote: >>> >>> Thanks - so objectweb instead of BCEL. >>>> I'll try it out - it's a bit different from what I had in mind, it l

Re: [proposal] remove worker based connector thread pools in trunk

2009-08-14 Thread Costin Manolache
+1 - Executor seems the right interface, didn't exist when workers were started - ifanyone needs the pool behavior it can probably be implemented as an Executor. I assume you'll have some way to configure what kind of executor ? Costin On Fri, Aug 14, 2009 at 1:30 AM, Mark Thomas wrote: > Fili

Re: UserConfig: alternative implementation

2009-11-03 Thread Costin Manolache
Curious: how does it scale for large number of users, in particular if you have NFS homes ? It would be interesting to change this to not init the contexts when tomcat starts - just register a handler that would start the context on first request. Or as a Valve that looks for ~foo and then lookups

Re: UserConfig: alternative implementation

2009-11-04 Thread Costin Manolache
On Wed, Nov 4, 2009 at 6:47 AM, Mikhail Kryshen wrote: > On Tue, 3 Nov 2009 16:34:57 -0800 > Costin Manolache wrote: > > > Curious: how does it scale for large number of users, in particular if > you > > have NFS homes ? > > I use it at a university server wi

Re: Tomcat-Lite update

2009-11-07 Thread Costin Manolache
survey > >> question for the user list) > >> > >> > > The applet-style security manager is history. I doubt anyone is using it > - > > or is using it correctly - on server side. It was a dead end anyways > > without good isolation and resource limittin

Re: SSL & Tomcat

2009-11-07 Thread Costin Manolache
On Sat, Nov 7, 2009 at 8:59 AM, Mark Thomas wrote: > All, > > I was thinking about this on my way back from ApacheCon and we probably > need to get some advice out to users early next week. > > My current understanding is that the MITM attack is triggered by a > renegotiation. > > On this basis I

Re: SSL & Tomcat

2009-11-09 Thread Costin Manolache
On Mon, Nov 9, 2009 at 8:04 AM, Konstantin Kolinko wrote: > 2009/11/9 Mark Thomas : > > Summarising the information gathered so far from various channels > > (thanks to Bill B., Bill W. & Rainer who have done most of the actual > > work to find the info below). > > > > BIO/NIO connectors using JSS

Re: SSL & Tomcat

2009-11-09 Thread Costin Manolache
On Mon, Nov 9, 2009 at 10:47 AM, Costin Manolache wrote: > > > On Mon, Nov 9, 2009 at 8:04 AM, Konstantin Kolinko > wrote: > >> 2009/11/9 Mark Thomas : >> > Summarising the information gathered so far from various channels >> > (thanks to Bill B., Bil

Re: SSL & Tomcat

2009-11-09 Thread Costin Manolache
table to commit it, it depends on having a .keystore with a 'localhost' cert, didn't find any other SSL tests in the suite. Forgot that you need to read() after startHandshake() - just cut&pasted the code from JsseSupport and it worked. Costin On Mon, Nov 9, 2009 at 1:32 PM,

Re: svn commit: r834289 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java

2009-11-09 Thread Costin Manolache
Right, need to invalidate as well. The request will not be executed - how can he continue the attack ? On Mon, Nov 9, 2009 at 7:49 PM, Bill Barker wrote: > > wrote in message > news:20091110010244.4f8382388...@eris.apache.org... > > Author: costin > > Date: Tue Nov 10 01:02:43 2009 > > New Rev

<    1   2   3   4   5   >