Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640799036 > The Java documentation for resource names also states: > > > The methods in ClassLoader use the given String as the name of the resource without applying any absolute/relative trans

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2641001780 > * Tomcat 11 and earlier, skip the `notFoundClassResources` cache if the name starts with '/' I have updated the PR according to this approach. -- This is an automated message fr

[Bug 69552] Performance regression in MessageBytes.toBytes() when using non-default charset

2025-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69552 --- Comment #7 from John Engebretson --- Looks like the right move here is to add an extra pointer on MessageBytes and reuse the utf8 payload. For example, modify the last part of toBytes() with an extra branch: ByteBuffer bb;

[Bug 69569] SPAM SPAM SPAM SPAM

2025-02-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69569 Chuck Caldarale changed: What|Removed |Added Resolution|--- |INVALID Summary|product f

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640639410 I think I understand everything that is going on now. The root cause is that Tomcat accepts name for `ClassLoader.getResource(String name)` and friends with a leading '/' whereas th

(tomcat) branch 11.0.x updated: clean up org.apache.tomcat.util.http RequestUtil (#818)

2025-02-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new dadb9b09b4 clean up org.apache.tomcat.util.http

(tomcat) branch 9.0.x updated: clean up org.apache.tomcat.util.http RequestUtil (#818)

2025-02-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 8831f15f26 clean up org.apache.tomcat.util.http Re

(tomcat) branch 10.1.x updated: clean up org.apache.tomcat.util.http RequestUtil (#818)

2025-02-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 32063efbd8 clean up org.apache.tomcat.util.http

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640347996 The Java documentation for resource names also states: > The methods in ClassLoader use the given String as the name of the resource without applying any absolute/relative transforma

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640460519 And given that `addURL()` is a protected method, how are you calling it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-06 Thread via GitHub
markt-asf commented on code in PR #818: URL: https://github.com/apache/tomcat/pull/818#discussion_r1944967982 ## java/org/apache/tomcat/util/http/RequestUtil.java: ## @@ -123,19 +123,12 @@ public static boolean isSameOrigin(HttpServletRequest request, String origin) {

(tomcat) branch main updated: clean up org.apache.tomcat.util.http RequestUtil (#818)

2025-02-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new ec48b80476 clean up org.apache.tomcat.util.http Requ

Re: [PR] clean up org.apache.tomcat.util.http RequestUtil [tomcat]

2025-02-06 Thread via GitHub
markt-asf merged PR #818: URL: https://github.com/apache/tomcat/pull/818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640684009 > But it does mean it looks like CXF has a bug that should be fixed. Thank you for pointing this out. I will make a report of this via CXF's Jira board. > And given that addURL