Re: [PR] enhanced http/2 early hints behavior [tomcat]

markt-asf commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853716196 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] enhanced http11 early hints behavior [tomcat]

markt-asf commented on code in PR #785: URL: https://github.com/apache/tomcat/pull/785#discussion_r1853737908 ## java/org/apache/coyote/http11/Http11Processor.java: ## @@ -1250,8 +1255,19 @@ protected final void ack(ContinueResponseTiming continueResponseTiming) { @Overr

Re: [PR] revoke early hints support on HTTP 1.1 [tomcat]

Chenjp commented on PR #783: URL: https://github.com/apache/tomcat/pull/783#issuecomment-2493271822 Ok, new PR will enhance this feature instead of revoke it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] enhanced http11 early hints behavior [tomcat]

Chenjp opened a new pull request, #785: URL: https://github.com/apache/tomcat/pull/785 twin PR of #784 . 1. automatically flush when earlyHints called, to enable the possibility of server-think-time between the Early Hints headers and the final response. Speeding up page loads is the ma

Re: [PR] enhanced http/2 early hints behavior [tomcat]

Chenjp commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853796863 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] enhanced http/2 early hints behavior [tomcat]

Chenjp commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853796379 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] enhanced http/2 early hints behavior [tomcat]

Chenjp commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853796379 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] enhanced http/2 early hints behavior [tomcat]

Chenjp commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853814408 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] enhanced http/2 early hints behavior [tomcat]

markt-asf commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853813923 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] revoke early hints support on HTTP 1.1 [tomcat]

Chenjp commented on PR #783: URL: https://github.com/apache/tomcat/pull/783#issuecomment-2493135169 > Not interested in that one, sorry, Tomcat will implement what the Servlet specification says. @rmaucher till now, the 6.2 Spec is not officially published. -- This is an automated

Re: [PR] revoke early hints support on HTTP 1.1 [tomcat]

rmaucher closed pull request #783: revoke early hints support on HTTP 1.1 URL: https://github.com/apache/tomcat/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] revoke early hints support on HTTP 1.1 [tomcat]

rmaucher commented on PR #783: URL: https://github.com/apache/tomcat/pull/783#issuecomment-2493131301 Not interested in that one, sorry, Tomcat will implement what the Servlet specification says. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] enhanced http/2 early hints behavior [tomcat]

Chenjp opened a new pull request, #784: URL: https://github.com/apache/tomcat/pull/784 1. automatically flush when earlyHints called, to enable the possibility of server-think-time (programmatic code in web app) between the Early Hints headers and the final response. Speeding up page load

Re: [PR] enhanced http/2 early hints behavior [tomcat]

Chenjp commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853754550 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] enhanced http/2 early hints behavior [tomcat]

Chenjp commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853835909 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

Re: [PR] enhanced http/2 early hints behavior [tomcat]

markt-asf closed pull request #784: enhanced http/2 early hints behavior URL: https://github.com/apache/tomcat/pull/784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] send 416 error to overlapping ranges request [tomcat]

markt-asf commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1854564015 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd

(tomcat) branch main updated: Re-apply code formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 483fc81696 Re-apply code formatting. No functional ch

(tomcat) branch 11.0.x updated: Re-apply code formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 608d2c60a9 Re-apply code formatting. No functiona

(tomcat) branch 10.1.x updated: Re-apply code formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new ca576e6680 Re-apply code formatting. No functiona

(tomcat) branch 9.0.x updated: Re-apply code formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d809932100 Re-apply code formatting. No functional

Re: [PR] Http11Processor minor change - magic int 103 to HttpServletResponse.SC_EARLY_HINTS [tomcat]

markt-asf closed pull request #785: Http11Processor minor change - magic int 103 to HttpServletResponse.SC_EARLY_HINTS URL: https://github.com/apache/tomcat/pull/785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Http11Processor minor change - magic int 103 to HttpServletResponse.SC_EARLY_HINTS [tomcat]

markt-asf commented on PR #785: URL: https://github.com/apache/tomcat/pull/785#issuecomment-2494595319 I've committed a change that replaces both uses of the 103 literal with the constant from the Servlet API. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] enhanced http/2 early hints behavior [tomcat]

markt-asf commented on PR #784: URL: https://github.com/apache/tomcat/pull/784#issuecomment-2494596877 The acceptable changes of this PR (literal 103 to constant) have been applied separately. -- This is an automated message from the Apache Git Service. To respond to the message, please

[Bug 69471] CloseNowException logged in ApplicationDispatcher

https://bz.apache.org/bugzilla/show_bug.cgi?id=69471 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas ---

(tomcat) branch 11.0.x updated: Fix BZ 69471

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new f1b03dc892 Fix BZ 69471 f1b03dc892 is described b

(tomcat) branch 10.1.x updated: Fix BZ 69471

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f60ba37d9f Fix BZ 69471 f60ba37d9f is described b

[Bug 69471] CloseNowException logged in ApplicationDispatcher

https://bz.apache.org/bugzilla/show_bug.cgi?id=69471 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

(tomcat) branch 9.0.x updated: Fix BZ 69471

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f01ef78305 Fix BZ 69471 f01ef78305 is described bel

(tomcat) branch main updated: Fix BZ 69471

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 3a17b1d94c Fix BZ 69471 3a17b1d94c is described below

(tomcat) branch main updated: Refactor code to use constant rather than literal for 103 status code

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6280d27454 Refactor code to use constant rather than

(tomcat) 02/02: Code clean-up - formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f9597b644a7c7ac7326c78e123be252fb237660b Author: Mark Thomas AuthorDate: Fri Nov 22 22:37:30 2024 + Code clean-up

(tomcat) 01/02: Prepare to apply standard formatting

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2fe41cb2a278121248033a3ce2ad04615414d6b6 Author: Mark Thomas AuthorDate: Fri Nov 22 22:21:05 2024 + Prepare to app

(tomcat) branch main updated (483fc81696 -> f9597b644a)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 483fc81696 Re-apply code formatting. No functional change. new 2fe41cb2a2 Prepare to apply standard formatting

(tomcat) branch 11.0.x updated (608d2c60a9 -> 663897f115)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 608d2c60a9 Re-apply code formatting. No functional change. new 65fbf6ceb5 Prepare to apply standard formatting

(tomcat) 02/02: Code clean-up - formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 663897f1150aa991fb6bd88e9720c204869a08ee Author: Mark Thomas AuthorDate: Fri Nov 22 22:38:31 2024 + Code clean-u

(tomcat) 01/02: Prepare to apply standard formatting

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 65fbf6ceb5e85f2ab659e5775cba2dde12681222 Author: Mark Thomas AuthorDate: Fri Nov 22 22:21:05 2024 + Prepare to a

(tomcat) 02/02: Code clean-up - formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c73b37ca4ef828c55cfd62a1ea20d8c19cc99c55 Author: Mark Thomas AuthorDate: Fri Nov 22 22:42:14 2024 + Code clean-u

(tomcat) 01/02: Prepare to apply standard formatting

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 16e829289fb71f0a6bd2332602e97e5502b034d1 Author: Mark Thomas AuthorDate: Fri Nov 22 22:21:05 2024 + Prepare to a

(tomcat) branch 10.1.x updated (ca576e6680 -> c73b37ca4e)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from ca576e6680 Re-apply code formatting. No functional change. new 16e829289f Prepare to apply standard formatting

Re: [PR] send 416 error to overlapping ranges request [tomcat]

Chenjp commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495274861 > I'd like to see similar protection for `Content-Range` when used with partial `PUT`. @markt-asf done with PR #778 -- This is an automated message from the Apache Git Service. To r

Re: [PR] send 416 error to overlapping ranges request [tomcat]

Chenjp commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495275038 > I'd like to see similar protection for `Content-Range` when used with partial `PUT`. @markt-asf done with PR #778 -- This is an automated message from the Apache Git Service. To r

(tomcat) branch 9.0.x updated (d809932100 -> 57927365b7)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from d809932100 Re-apply code formatting. No functional change. new 29285c6a56 Prepare to apply standard formatting

(tomcat) 02/02: Code clean-up - formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 57927365b716e16d543edbdea0d77ec80b2d9553 Author: Mark Thomas AuthorDate: Fri Nov 22 22:44:50 2024 + Code clean-up

(tomcat) 01/02: Prepare to apply standard formatting

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 29285c6a56ac7cca12f307a58353050f096eaea7 Author: Mark Thomas AuthorDate: Fri Nov 22 22:21:05 2024 + Prepare to ap

(tomcat) branch 9.0.x updated: Fix BZ 69466 - rework handling of HEAD requests

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 51e43f4e7b Fix BZ 69466 - rework handling of HEAD r

Re: [PR] enhanced http/2 early hints behavior [tomcat]

markt-asf commented on code in PR #784: URL: https://github.com/apache/tomcat/pull/784#discussion_r1853843378 ## java/org/apache/coyote/http2/Stream.java: ## @@ -604,10 +611,23 @@ final void writeAck() throws IOException { final void writeEarlyHints() throws IOException {

[Bug 69466] Content-Length removal from HEAD response should not be mandatory

https://bz.apache.org/bugzilla/show_bug.cgi?id=69466 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 69471] New: CloseNowException logged in ApplicationDispatcher

https://bz.apache.org/bugzilla/show_bug.cgi?id=69471 Bug ID: 69471 Summary: CloseNowException logged in ApplicationDispatcher Product: Tomcat 10 Version: 10.1.33 Hardware: PC Status: NEW Severity: minor Priority