PaulLodge opened a new pull request, #763:
URL: https://github.com/apache/tomcat/pull/763
This test covers the regression mentioned in https://svn.apache.org/r1830547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377
--- Comment #4 from John Engebretson ---
The biggest error comes when a JSP uses the following structure:
I didn't know this was a supported behavior, but it shows up throughout our
application. The code generation for delegates the
On 10/10/2024 04:03, micha...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2405043622
> Oh, I see the code that you use to benchmark in the PR. Have you tried to
run an external tool like `ab` or `wrk2`?
@isapir thanks for your suggestion, will try run ab benchmark from
On Thu, Oct 10, 2024 at 12:05 PM wrote:
> -sb.append(" - +sb.append(" \u2013 @@ -123,6 +123,10 @@
> the base class. The primary advantage for doing this is less code to
> process init-param values. (markt)
>
> +
> +69370: DefaultSer
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new a2aaab004f Avoid possible NPE
a2aaab004f is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new dc75d702b2 Avoid possible NPE
dc75d702b2 is descri
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 16ff28c709 Avoid possible NPE
16ff28c709 is descri
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new d597dd0ef1 Avoid possible NPE
d597dd0ef1 is describe
https://bz.apache.org/bugzilla/show_bug.cgi?id=69388
Bug ID: 69388
Summary: At Lovenotes Films, We Believe Capturing timeless
moments of love and joy, I specialize in crafting
exquisite wedding photography that tells your unique
https://bz.apache.org/bugzilla/show_bug.cgi?id=69388
LoveNotes Films changed:
What|Removed |Added
URL||https://lovenotesfilms.com/
Build status: BUILD FAILED: Snapshot deployed to ASF Maven snapshot repository
(failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/120/builds/127
Blamelist: Michael Osipov
Build Text: Snapshot deployed to ASF Maven snapshot repository (failure)
Status Detected: new fail
On 2024/10/10 10:12:56 Rémy Maucherat wrote:
> On Thu, Oct 10, 2024 at 12:05 PM wrote:
> > -sb.append(" - > +sb.append(" \u2013
> If this really needed ?
>
> > @@ -123,6 +123,10 @@
> > the base class. The primary advantage for doing this is less code
> > to
>
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2404718668
> > Could the headers follow
https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers/ ?
>
> Great! Will look into the spec and implement it tomorrow.
ratelimit-head
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 8e90a82759 Update
add ebc6cfb227 BZ 69370: DefaultServlet's HTML listing uses incorrect
labels
No new revisions
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 507a76013d BZ 69370: DefaultServlet's HTML lis
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 78e4bd0994 BZ 69370: DefaultServlet's HTML listi
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 098834facf BZ 69370: DefaultServlet's HTML lis
michael-o closed pull request #759: BZ 69370: DefaultServlet's HTML listing
uses incorrect labels
URL: https://github.com/apache/tomcat/pull/759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
michael-o commented on PR #759:
URL: https://github.com/apache/tomcat/pull/759#issuecomment-2404653354
Merged manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
https://bz.apache.org/bugzilla/show_bug.cgi?id=69370
Michael Osipov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
rmaucher commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404535177
> Is there now static final for that status code?
Are you talking about
https://github.com/apache/tomcat/blob/main/java/jakarta/servlet/http/HttpServletResponse.java#L406
?
--
Thi
michael-o commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404594880
> > Is there now static final for that status code?
>
> Are you talking about
https://github.com/apache/tomcat/blob/main/java/jakarta/servlet/http/HttpServletResponse.java#L406
?
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405394259
I will also be adding at least one unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405393185
Tomcat 11 is based on Jakarta EE 11 which does not (yet) have this constant.
I originally wrote this patch just for Tomcat 11 but now that I think about
it, I think I should
ChristopherSchultz commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1795646509
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1069,16 +1069,20 @@ public void sendError(int status, String message)
throws IOException {
Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/1326
Blamelist: remm
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch 11.0.x] 16ff28c709f2d41a618f7a27460608c90a615f46
Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/1123
Blamelist: remm
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch 9.0.x] d597dd0ef1e2ee5a3902acded19f4abfa0b1b201
S
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/1327
Blamelist: remm
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 11.0.x] ec2f2f2b6a463e30fc5a2290fdee9950344130cf
Steps:
worker_preparati
ChristopherSchultz closed pull request #761: Allow applications to trigger
sending of 103 early hints
URL: https://github.com/apache/tomcat/pull/761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405802038
I'm not great at github, so I ended up killing this branch and re-creating
it. I will have a follow-up PR soon.
--
This is an automated message from the Apache Git Service.
To r
ChristopherSchultz opened a new pull request, #764:
URL: https://github.com/apache/tomcat/pull/764
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
On 2024/10/10 10:12:56 Rémy Maucherat wrote:
> On Thu, Oct 10, 2024 at 12:05 PM wrote:
> > -sb.append(" - > +sb.append(" \u2013
> If this really needed ?
Consistency with the ErrorReportValve. Look at the LocalStrings of it.
On 2024/10/10 12:06:38 Mark Thomas wrote:
> On 10/10/2024 04:03, micha...@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > michaelo pushed a commit to branch 10.1.x
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> >
> > The f
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/120/builds/129
Blamelist: Michael Osipov , remm
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch main] c46c37649e2d086ccc67f1236b2856305f2a03ce
Steps:
wo
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/44/builds/1444
Blamelist: remm
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 10.1.x] 50dfe21c55684fa0f0c9f633d89f9ee86791996f
Steps:
worker_preparatio
rmaucher commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794983398
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1209,7 +1213,11 @@ public void setStatus(int status) {
return;
}
-getCoyoteRes
michael-o commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404487095
Is there now static final for that status code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new c46c37649e Fix test
c46c37649e is described below
com
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new ec2f2f2b6a Fix test
ec2f2f2b6a is described below
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 50dfe21c55 Fix test
50dfe21c55 is described below
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 02cb461652 Fix test
02cb461652 is described below
c
Igal,
On 10/9/24 23:50, isapir (via GitHub) wrote:
isapir commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794575451
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1069,16 +1069,20 @@ public void sendError(int status, Strin
markt-asf commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405469155
> I originally wrote this patch just for Tomcat 11 but now that I think
about it, I think I should re-write it for Tomcat 12/main so that the behavior
is consistent regardless of version.
Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/44/builds/1443
Blamelist: remm
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch 10.1.x] dc75d702b2dc350d695b1ae631b140bcb300af92
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377
--- Comment #5 from John Engebretson ---
I'm going to proceed with the tag plugin mechanism, configured for strictly
c:set and c:if. This captures at least half the opportunity, with no code
changes required and with little risk of hitting the
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from c46c37649e Fix test
new 0b84147c37 Update minimum Java version to 21
new dac8def47d Update Jasper to compile to
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6795092946a5e3ce6a14d04b432dcdf909df776a
Author: Mark Thomas
AuthorDate: Thu Oct 10 13:09:51 2024 -0600
Remove JreComp
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 43018b86cca787e91814341450f9460646bd5357
Author: Mark Thomas
AuthorDate: Thu Oct 10 13:58:57 2024 -0600
Add markers so
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 9c6304ad789c5c4b6063d60c591f79aaf5d3c722
Author: Mark Thomas
AuthorDate: Thu Oct 10 12:53:22 2024 -0600
Update Javadoc
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit dac8def47dd9037e050853462612bac37b095ba8
Author: Mark Thomas
AuthorDate: Thu Oct 10 12:52:51 2024 -0600
Update Jasper
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 20525303316274ab712901f480c9711b626d4452
Author: Mark Thomas
AuthorDate: Thu Oct 10 13:51:07 2024 -0600
Update Derby t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 0b84147c37cad9cabb298cfe6b2ce79689d342aa
Author: Mark Thomas
AuthorDate: Thu Oct 10 12:48:58 2024 -0600
Update minimum
53 matches
Mail list logo
