[PR] removed null eval statement code if os400 [tomcat]

CloudWise-Lukemiao opened a new pull request, #701: URL: https://github.com/apache/tomcat/pull/701 Code optimization removed the null eval statement code if os400 is true in the script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Avoid performance issues that may arise when the array is large. [tomcat]

rmaucher commented on PR #702: URL: https://github.com/apache/tomcat/pull/702#issuecomment-1968755182 I think FilterDef getAsyncSupported can be optimized. But I'm not super convinced by the rest. Where is the inflection point ? -- This is an automated message from the Apache Git Service.

Re: [PR] Attempt to protect against asynchronous thread safety violations [tomcat]

markt-asf closed pull request #700: Attempt to protect against asynchronous thread safety violations URL: https://github.com/apache/tomcat/pull/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Attempt to protect against asynchronous thread safety violations [tomcat]

markt-asf commented on PR #700: URL: https://github.com/apache/tomcat/pull/700#issuecomment-1969192558 I'm closing this as I have come up with a better plan that makes slightly better uses of the existing facades to trigger some NPEs when this happens. -- This is an automated message from

(tomcat) branch main updated: Performance tweaks for filter chain

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 835e1be32a Performance tweaks for filter chain 835e1be

(tomcat) branch 10.1.x updated: Performance tweaks for filter chain

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 55ff302cfb Performance tweaks for filter chain 55f

(tomcat) branch 9.0.x updated: Performance tweaks for filter chain

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6c55aab511 Performance tweaks for filter chain 6c55a

Re: [PR] Avoid performance issues that may arise when the array is large. [tomcat]

rmaucher commented on PR #702: URL: https://github.com/apache/tomcat/pull/702#issuecomment-1969224578 I added some optimizations, still based on the array. If you investigate something, then fully using a LinkedHashSet would likely be better than HashSet + array. Please provide actual micro

Re: [PR] Avoid performance issues that may arise when the array is large. [tomcat]

rmaucher closed pull request #702: Avoid performance issues that may arise when the array is large. URL: https://github.com/apache/tomcat/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: (tomcat) branch main updated: Performance tweaks for filter chain

> diff --git a/java/org/apache/tomcat/util/descriptor/web/FilterDef.java > b/java/org/apache/tomcat/util/descriptor/web/FilterDef.java > index 3a208964e0..b742d5c19c 100644 > --- a/java/org/apache/tomcat/util/descriptor/web/FilterDef.java > +++ b/java/org/apache/tomcat/util/descriptor/web/FilterDe

Re: (tomcat) branch main updated: Performance tweaks for filter chain

On Wed, Feb 28, 2024 at 5:10 PM Konstantin Kolinko wrote: > > > diff --git a/java/org/apache/tomcat/util/descriptor/web/FilterDef.java > > b/java/org/apache/tomcat/util/descriptor/web/FilterDef.java > > index 3a208964e0..b742d5c19c 100644 > > --- a/java/org/apache/tomcat/util/descriptor/web/Filte

Buildbot failure in on tomcat-9.0.x

Build status: BUILD FAILED: Snapshot deployed to ASF Maven snapshot repository (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/875 Blamelist: remm Build Text: Snapshot deployed to ASF Maven snapshot repository (failure) Status Detected: new failure Build S

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 --- Comment #4 from Christopher Schultz --- The typical way to do this is: 1. Remove all inbound HTTP headers you want to set at the proxy 2. Set your specific HTTP headers at the proxy 3. Read your now-trusted HTTP headers from the request in

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 --- Comment #5 from dub...@gmail.com --- Again - I need something integrated w/ Tomcat and a true reverse proxy over HTTP will never be that. How would things like REMOTE_USER or the client certificate get propagated to Tomcat? This is somethi

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 --- Comment #6 from Christopher Schultz --- (In reply to dub357 from comment #5) > How would things like REMOTE_USER or the client > certificate get propagated to Tomcat? This is something your presentation > fails to discuss and is arguably t

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 --- Comment #7 from dub...@gmail.com --- Im stuck with IIS, hence the request for a mod to the isapi filter connector. If I could use Apache, I would be able to use the JkEnvVar directive. -- You are receiving this mail because: You are the as

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 dub...@gmail.com changed: What|Removed |Added Severity|normal |enhancement -- You are receiving th

Add support for HTTP connectors to accept REMOTE_USER information from a proxy?

All, When using AJP, setting tomcatAuthentication="false" allows mod_jk or mod_proxy_ajp to transmit authenticated user information across the connection to Tomcat so that request.getRemoteUser() will return whatever httpd has for REMOTE_USER. The same is not true for the HTTP connectors.

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 --- Comment #8 from Christopher Schultz --- I've proposed making arrangements for REMOTE_USER on the dev list. I realize that's not quite what you are asking for, here, but I thought I'd mention it since I really do think we as a community shou

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 --- Comment #9 from Christopher Schultz --- Back to your original request... Could you set HTTP headers (to proxy either using AJP or HTTP) and then have your application pick those up using a Filter? Something like: Client -- HTTP --> IIS II

[Bug 68677] no support for enviroment variables/request attributes

https://bz.apache.org/bugzilla/show_bug.cgi?id=68677 --- Comment #10 from dub...@gmail.com --- First off, what I'm asking for already exists in mod_jk via the JkEnvVar directive. I just want the same thing for jk_isapi_plugin (the IIS equivalent of mod_jk). This request stemmed from a deep dive

[PR] Remove duplicate if statements from the OutputBuffer.close() method [tomcat]

RealTake opened a new pull request, #703: URL: https://github.com/apache/tomcat/pull/703 Hello I was checking the code regarding the "Content-length" of the response and found it. In my opinion, it is because I decided that it is unnecessary to double check !coyoteResponse.isCommitted()