[Bug 68321] Same LifecycleException exception is logged many times

2023-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68321 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

TCK servlet TCK 6.0

2023-12-19 Thread jean-frederic clere
Hi, I have tried to run the TCK against Tomcat-10.1.17 I have 12 failed tests. Before investigating I have questions: Did someone run the servlet TCK recently? Are some tests expected to fail (well for sure the DefaultContextPathTest and the signatures, but are there others? I have created

(tomcat) branch main updated: Port cleanups

2023-12-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e79712fd3f Port cleanups e79712fd3f is described below

(tomcat) branch 10.1.x updated: Port cleanups

2023-12-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new d392bb0361 Port cleanups d392bb0361 is described b

(tomcat) branch 9.0.x updated: Port cleanups

2023-12-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new bd5a20ecae Port cleanups bd5a20ecae is described bel

Re: TCK servlet TCK 6.0

2023-12-19 Thread Rémy Maucherat
On Tue, Dec 19, 2023 at 2:05 PM jean-frederic clere wrote: > > Hi, > > I have tried to run the TCK against Tomcat-10.1.17 I have 12 failed > tests. Before investigating I have questions: > > Did someone run the servlet TCK recently? > Are some tests expected to fail (well for sure the > DefaultCon

Buildbot failure in on tomcat-9.0.x

2023-12-19 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/793 Blamelist: remm Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] bd5a20ecae028f555f656f479971fec102cb4bf5 St

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431610887 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431612056 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431615348 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431618064 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431639832 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431641166 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
markt-asf commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431736198 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase { private

Re: TCK servlet TCK 6.0

2023-12-19 Thread Mark Thomas
On 19/12/2023 13:05, jean-frederic clere wrote: Hi, I have tried to run the TCK against Tomcat-10.1.17 I have 12 failed tests. Before investigating I have questions: Did someone run the servlet TCK recently? Not recently but I have run it. Are some tests expected to fail (well for sure the