[Bug 66545] StandardRoot.createMainResourceSet() doesn't report permission issues

2023-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66545 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 66549] New: Performance issue while accessing application between servers Application hosted on AIX to WINDOWS(Apache Tomcat Configured)

2023-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66549 Bug ID: 66549 Summary: Performance issue while accessing application between servers Application hosted on AIX to WINDOWS(Apache Tomcat Configured) Product: Tomcat 8

[Bug 66549] Performance issue while accessing application between servers Application hosted on AIX to WINDOWS(Apache Tomcat Configured)

2023-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66549 Remy Maucherat changed: What|Removed |Added OS||All Resolution|---

[Bug 66548] Tomcat does not validate value of Sec-Websocket-Key header

2023-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66548 --- Comment #4 from Remy Maucherat --- This could break things if someone we find out that clients have been using random values there instead of faithfully implementing the specification. -- You are receiving this mail because: You are the a

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
ChristopherSchultz commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154550009 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
ChristopherSchultz commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154552815 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[Bug 66548] Tomcat does not validate value of Sec-Websocket-Key header

2023-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66548 --- Comment #5 from Mark Thomas --- Yes, but. Historically, we have been generally unsympathetic to clients that don't follow the relevant specs. Given there doesn't seem to be any advantage for the server here (the feature benefits clients)

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154701109 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154702239 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[Bug 66548] Tomcat does not validate value of Sec-Websocket-Key header

2023-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66548 --- Comment #6 from Christopher Schultz --- (In reply to Remy Maucherat from comment #4) > This could break things if someone we find out that clients have been using > random values there instead of faithfully implementing the specification.

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154707393 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154709784 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154710887 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154712109 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154782761 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154784584 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154785188 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154792436 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154828691 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1154883838 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

Re: [tomcat] branch main updated: Revert "Refactor AmbiguousBean test after seeing failures in CI"

2023-03-31 Thread Christopher Schultz
Mark, On 3/30/23 19:10, ma...@apache.org wrote: +public static class AmbiguousBean { +public void setValue(@SuppressWarnings("unused") TypeA value) { +} + +public void setValue(@SuppressWarnings("unused") String value) { +} +} Best. Class. Name. Ever. ;

[GitHub] [tomcat] rmannibucau commented on a diff in pull request #607: Added RateLimitFilter

2023-03-31 Thread via GitHub
rmannibucau commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1155068209 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo