FSchumacher opened a new pull request, #45:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45
…efix
We already rename files in JAR files, so directory handling should follow
here. A more correct way to handle this, would probably be to restrict the
renaming to files,
codecov-commenter commented on PR #45:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/45#issuecomment-1483795564
##
[Codecov](https://codecov.io/gh/apache/tomcat-jakartaee-migration/pull/45?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p
https://bz.apache.org/bugzilla/show_bug.cgi?id=66544
Felix Schumacher changed:
What|Removed |Added
OS||All
Status|NEW
ebourg commented on code in PR #45:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148359861
##
src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java:
##
@@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception {
S
ebourg commented on code in PR #45:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148359876
##
src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java:
##
@@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception {
S
FSchumacher opened a new pull request, #604:
URL: https://github.com/apache/tomcat/pull/604
Give it its own log message instead of re-using the one from
fireRequestInitEvent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
FSchumacher commented on code in PR #45:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/45#discussion_r1148360532
##
src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java:
##
@@ -139,6 +139,39 @@ public void testMigrateDirectory() throws Exception {
https://bz.apache.org/bugzilla/show_bug.cgi?id=66543
--- Comment #1 from Felix Schumacher ---
I have created a PR (https://github.com/apache/tomcat/pull/604) and will merge
it, if no comments on the PR suggest otherwise.
--
You are receiving this mail because:
You are the assignee for the bug.
ebourg merged PR #45:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/main by this push:
new 040b951 Migrate SPI files in di
10 matches
Mail list logo