[GitHub] [tomcat] rmaucher commented on pull request #598: Use available constants

2023-03-13 Thread via GitHub
rmaucher commented on PR #598: URL: https://github.com/apache/tomcat/pull/598#issuecomment-1465711314 The thing to look for is to not add any dependencies to the bootstrap, but it looks ok here (I think). -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [tomcat] ChristopherSchultz commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-13 Thread via GitHub
ChristopherSchultz commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466223964 > I have a question that why we don't add a real **primary key**(auto-increment) to solve the problem that primary key constraint violation when insert data to database simultaneo

[GitHub] [tomcat] ChristopherSchultz commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-13 Thread via GitHub
ChristopherSchultz commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466230691 > I would love to see an interface that goes a step further and allows for NoSQL implementations as well. For example, Redis is an excellent option for a data store IMO. Th

[GitHub] [tomcat] ChristopherSchultz commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-13 Thread via GitHub
ChristopherSchultz commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466235515 > Punt the session update operation to a callback or interface, have one or two sensible defaults (like for the major databases and specific table configuration) and have a way fo

[GitHub] [tomcat] isapir commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-13 Thread via GitHub
isapir commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1466395493 > This does bring up a good point: rather than having a new configuration option, I could simply have a subclass of DataSourceStore which overrides the store method to do the SELECT...FOR UPD

[Bug 66196] HTTP/1 connector doesn't blow-up when HTTP header contains non-ASCII characters

2023-03-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196 --- Comment #11 from gabriel.holl...@appian.com --- Looking over the thread here, it sounded like the path forward was to log, and potentially drop the header for Http1.1 However that same change wasnt done for the AJP Processor, causing invali

[Bug 66196] HTTP/1 connector doesn't blow-up when HTTP header contains non-ASCII characters

2023-03-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196 Mark Thomas changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[Bug 66524] resource cache eviction is MRU not LRU

2023-03-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66524 --- Comment #3 from Christopher Schultz --- (In reply to Steven Kearns from comment #2) > The field CachedResource.nextCheck is what is being sorted, it is also a > proxy for lastUsedTime. Yup. I got the reversal reversed in my head when readi

[Bug 66524] resource cache eviction is MRU not LRU

2023-03-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66524 --- Comment #4 from Mark Thomas --- +1 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org F