[GitHub] [tomcat] FSchumacher commented on a diff in pull request #597: Use a deep copy of query stats whose values won't change during sorting.

2023-03-11 Thread via GitHub
FSchumacher commented on code in PR #597: URL: https://github.com/apache/tomcat/pull/597#discussion_r1133086091 ## modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java: ## @@ -222,19 +222,55 @@ protected QueryStats getQueryStats(String sql

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #597: Use a deep copy of query stats whose values won't change during sorting.

2023-03-11 Thread via GitHub
ChristopherSchultz commented on code in PR #597: URL: https://github.com/apache/tomcat/pull/597#discussion_r1133119845 ## modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java: ## @@ -222,19 +222,55 @@ protected QueryStats getQueryStats(Str

[GitHub] [tomcat] ChristopherSchultz commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-11 Thread via GitHub
ChristopherSchultz commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1464952161 I've been thinking about this more and I think it could cause problems for people not using appId+sessionId (or just sessionId) as the primary key for the DB table storing the ses

[Bug 66524] resource cache eviction is MRU not LRU

2023-03-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66524 --- Comment #1 from Christopher Schultz --- Why reverse the reverse? What is being compared here? What do you think ought to be compared? -- You are receiving this mail because: You are the assignee for the bug. --

[GitHub] [tomcat] FSchumacher commented on a diff in pull request #597: Use a deep copy of query stats whose values won't change during sorting.

2023-03-11 Thread via GitHub
FSchumacher commented on code in PR #597: URL: https://github.com/apache/tomcat/pull/597#discussion_r1133134054 ## modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java: ## @@ -222,19 +222,55 @@ protected QueryStats getQueryStats(String sql

[GitHub] [tomcat] MikeNeilson commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-11 Thread via GitHub
MikeNeilson commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1464984575 Considering the difficult of handling all situation for all databases perhaps the following: Punt the session update operation to a callback or interface, have one or two sensible

[GitHub] [tomcat] isapir commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-11 Thread via GitHub
isapir commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1465001069 I would love to see an interface that goes a step further and allows for NoSQL implementations as well. For example, Redis is an excellent option for a data store IMO. -- This is an autom

[Bug 66524] resource cache eviction is MRU not LRU

2023-03-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66524 --- Comment #2 from Steven Kearns --- The field CachedResource.nextCheck is what is being sorted, it is also a proxy for lastUsedTime. since items will be evicted in iteration order, then sorting by "reverse nextCheck" makes the iteration orde

Bug report for Tomcat 8 [2023/03/12]

2023-03-11 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2023/03/12]

2023-03-11 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 9 [2023/03/12]

2023-03-11 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2023/03/12]

2023-03-11 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2023/03/12]

2023-03-11 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2023/03/12]

2023-03-11 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 10 [2023/03/12]

2023-03-11 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned