[GitHub] [tomcat-jakartaee-migration] markt-asf closed issue #44: Does this work tool work at the source or binary level?

2023-03-08 Thread via GitHub
markt-asf closed issue #44: Does this work tool work at the source or binary level? URL: https://github.com/apache/tomcat-jakartaee-migration/issues/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[Bug 66513] Primary Key Violation using PersistentManager + PersistentValves +

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66513 --- Comment #4 from Vincent Liautaud --- Great thanks... -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@t

Re: PersistentManager, PersistentValve, and DataSource/JDBCStore can cause PK violations

2023-03-08 Thread Romain Manni-Bucau
Hi Chris, Seems doing it only there will get back to the issue the synchronization was introduced (there are other synchronized(session) for "local" instance). However you hit a real point, the instance does not have to be stable, only its equals/hashCode could be considered stable so guess the id

[tomcat] branch main updated: Update DBCP to f131286 (2023-03-08, 2.10.0-SNAPSHOT)

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 182824c8af Update DBCP to f131286 (2023-03-08, 2.10.0

[tomcat] branch 10.1.x updated: Update DBCP to f131286 (2023-03-08, 2.10.0-SNAPSHOT)

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 41818a5841 Update DBCP to f131286 (2023-03-08, 2.

[tomcat] branch 9.0.x updated: Update DBCP to f131286 (2023-03-08, 2.10.0-SNAPSHOT)

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7a173495d5 Update DBCP to f131286 (2023-03-08, 2.10

Re: PersistentManager, PersistentValve, and DataSource/JDBCStore can cause PK violations

2023-03-08 Thread Christopher Schultz
Romain, On 3/8/23 04:10, Romain Manni-Bucau wrote: Seems doing it only there will get back to the issue the synchronization was introduced (there are other synchronized(session) for "local" instance). Don't forget that there are multiple reasons to synchronize on a session, and they solve dif

Re: PersistentManager, PersistentValve, and DataSource/JDBCStore can cause PK violations

2023-03-08 Thread Romain Manni-Bucau
Le mer. 8 mars 2023 à 16:23, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 3/8/23 04:10, Romain Manni-Bucau wrote: > > Seems doing it only there will get back to the issue the synchronization > > was introduced (there are other synchronized(session) for "local" > i

[GitHub] [tomcat] ChristopherSchultz opened a new pull request, #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-08 Thread via GitHub
ChristopherSchultz opened a new pull request, #596: URL: https://github.com/apache/tomcat/pull/596 I have only compile-tested this; I wanted to get feedback on the approach, how to handle errors, etc. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] ChristopherSchultz opened a new pull request, #597: Use a deep copy of query stats whose values won't change during sorting.

2023-03-08 Thread via GitHub
ChristopherSchultz opened a new pull request, #597: URL: https://github.com/apache/tomcat/pull/597 Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=58489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[Bug 58489] QueryStatsComparator throws IllegalArgumentException: Comparison method violates its general contract!

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58489 --- Comment #14 from Christopher Schultz --- https://github.com/apache/tomcat/pull/597 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscr

[Bug 66508] Tomcat after a GC pause causes the HTTP threads to be blocked to acquire a semaphore to process WebSockets connection closure.

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 --- Comment #3 from Mark Thomas --- Thanks for the steps to reproduce. I'll note for the record that you also need to be using the NIO2 connector. I can see what the root cause is. The write in "Event 3" fails and isn't cleaned up properly wh

[tomcat] branch 10.1.x updated: Fix BZ-66508 - avoid delay on close after write error with NIO2

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 46590145a9 Fix BZ-66508 - avoid delay on close af

[tomcat] branch main updated: Fix BZ-66508 - avoid delay on close after write error with NIO2

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a999580acb Fix BZ-66508 - avoid delay on close after

[tomcat] branch 9.0.x updated: Fix BZ-66508 - avoid delay on close after write error with NIO2

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3d5cd321b7 Fix BZ-66508 - avoid delay on close afte

[tomcat] branch 8.5.x updated: Fix BZ-66508 - avoid delay on close after write error with NIO2

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 683b74f75e Fix BZ-66508 - avoid delay on close afte

[Bug 66508] Tomcat after a GC pause causes the HTTP threads to be blocked to acquire a semaphore to process WebSockets connection closure.

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch main updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 33c6a2edc1 Code clean-up. Formatting. No functional c

[tomcat] branch main updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 597dcea653 Code clean-up. Formatting. No functional c

[tomcat] branch main updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 95487f9312 Code clean-up. Formatting. No functional c

[tomcat] branch 10.1.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 74ffc1f399 Code clean-up. Formatting. No function

[tomcat] branch 10.1.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 5fd6d601a9 Code clean-up. Formatting. No function

[tomcat] branch main updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a7d4c7b336 Code clean-up. Formatting. No functional c

[tomcat] branch main updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6364efcb63 Code clean-up. Formatting. No functional c

[tomcat] branch 9.0.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new cd4e9c7124 Code clean-up. Formatting. No functional

[tomcat] branch 9.0.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0c7815ddb2 Code clean-up. Formatting. No functional

[tomcat] branch 8.5.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 996d77a753 Code clean-up. Formatting. No functional

[tomcat] branch 9.0.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 787b688203 Code clean-up. Formatting. No functional

[tomcat] branch 8.5.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new eb5cca161b Code clean-up. Formatting. No functional

[tomcat] branch 8.5.x updated: Code clean-up. Formatting. No functional change.

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f46a2a61ea Code clean-up. Formatting. No functional

[tomcat] branch 9.0.x updated: Align with 10.1.x

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 89192df457 Align with 10.1.x 89192df457 is describe

[tomcat] branch 9.0.x updated: Align with 10.1.x

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d34cc7f087 Align with 10.1.x d34cc7f087 is describe

[tomcat] branch 8.5.x updated: Align with 9.0.x

2023-03-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f81d0719c4 Align with 9.0.x f81d0719c4 is described

Rate Limiter Filter or Valve

2023-03-08 Thread Igal Sapir
All, I would like to add a Rate Limiter Filter or Valve which will help mitigate DoS and Brute Force attacks, and want to get feedback from the community and the PMC. The checks will run before the request reaches the servlet and will be dropped if too many requests arrive from the same IP addres

[Bug 66508] Tomcat after a GC pause causes the HTTP threads to be blocked to acquire a semaphore to process WebSockets connection closure.

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 --- Comment #5 from Venkata Manda --- (In reply to Mark Thomas from comment #3) > Thanks for the steps to reproduce. > > I'll note for the record that you also need to be using the NIO2 connector. > > I can see what the root cause is. The wri

[Bug 66508] Tomcat after a GC pause causes the HTTP threads to be blocked to acquire a semaphore to process WebSockets connection closure.

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66508 --- Comment #6 from Venkata Manda --- (In reply to Mark Thomas from comment #4) > Fixed in: > - 11.0.x for 11.0.0-M5 onwards > - 10.1.x for 10.1.8 onwards > - 9.0.x for 9.0.74 onwards > - 8.5.x for 8.5.88 onwards > > If you'd like to test

[GitHub] [tomcat] isapir commented on pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-08 Thread via GitHub
isapir commented on PR #596: URL: https://github.com/apache/tomcat/pull/596#issuecomment-1460841013 @ChristopherSchultz Is there a list of supported database systems with which the DataSourceStore is compatible? Are you sure that they all support "SELECT FOR UPDATE"? I tried to look that

[GitHub] [tomcat] isapir commented on a diff in pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-08 Thread via GitHub
isapir commented on code in PR #596: URL: https://github.com/apache/tomcat/pull/596#discussion_r1130013002 ## java/org/apache/catalina/session/DataSourceStore.java: ## @@ -626,15 +626,77 @@ public void save(Session session) throws IOException { byte[] obs =

Re: Rate Limiter Filter or Valve

2023-03-08 Thread Christopher Schultz
Igal, On 3/8/23 14:36, Igal Sapir wrote: I would like to add a Rate Limiter Filter or Valve which will help mitigate DoS and Brute Force attacks, and want to get feedback from the community and the PMC. The checks will run before the request reaches the servlet and will be dropped if too many r

[GitHub] [tomcat] aooohan commented on a diff in pull request #596: Use SELECT...FOR UPDATE to update session data in the database instead of DELETE, INSERT.

2023-03-08 Thread via GitHub
aooohan commented on code in PR #596: URL: https://github.com/apache/tomcat/pull/596#discussion_r1130309107 ## java/org/apache/catalina/session/DataSourceStore.java: ## @@ -626,15 +626,77 @@ public void save(Session session) throws IOException { byte[] obs =

Re: Rate Limiter Filter or Valve

2023-03-08 Thread Igal Sapir
Chris, On Wed, Mar 8, 2023 at 4:18 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Igal, > > On 3/8/23 14:36, Igal Sapir wrote: > > I would like to add a Rate Limiter Filter or Valve which will help > mitigate > > DoS and Brute Force attacks, and want to get feedback from the comm