[tomcat] branch main updated: Improve naming. No functional change.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f2f8c90c57 Improve naming. No functional change. f2f8

[tomcat] branch 10.0.x updated: Improve naming. No functional change.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 86d6af94b4 Improve naming. No functional change.

[tomcat] branch 9.0.x updated: Improve naming. No functional change.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 411d689c5e Improve naming. No functional change. 41

[tomcat] branch 8.5.x updated: Improve naming. No functional change.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new beda7290b0 Improve naming. No functional change. be

[GitHub] [tomcat] markt-asf commented on a diff in pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
markt-asf commented on code in PR #541: URL: https://github.com/apache/tomcat/pull/541#discussion_r952256591 ## java/org/apache/catalina/valves/ExtendedAccessLogValve.java: ## @@ -298,12 +298,22 @@ public CookieElement(String name) { @Override public void addEl

[GitHub] [tomcat] aooohan commented on a diff in pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
aooohan commented on code in PR #541: URL: https://github.com/apache/tomcat/pull/541#discussion_r952287911 ## java/org/apache/catalina/valves/ExtendedAccessLogValve.java: ## @@ -298,12 +298,22 @@ public CookieElement(String name) { @Override public void addElem

[tomcat] branch main updated: BZ 66183. Log all values for given cookie, not just the first.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new cbf884c4d5 BZ 66183. Log all values for given cookie,

[tomcat] branch 10.0.x updated: BZ 66183. Log all values for given cookie, not just the first.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 83c97a17c9 BZ 66183. Log all values for given coo

[tomcat] branch 9.0.x updated: BZ 66183. Log all values for given cookie, not just the first.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c88bbac085 BZ 66183. Log all values for given cooki

[tomcat] branch 8.5.x updated: BZ 66183. Log all values for given cookie, not just the first.

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3fd2ea8e35 BZ 66183. Log all values for given cooki

[Bug 66183] AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[GitHub] [tomcat] markt-asf commented on pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
markt-asf commented on PR #541: URL: https://github.com/apache/tomcat/pull/541#issuecomment-1223727734 Applied manually with a few tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tomcat] markt-asf closed pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
markt-asf closed pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name URL: https://github.com/apache/tomcat/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[Bug 66179] NPE when retrieving locale from request

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66179 simon.lu...@sap.com changed: What|Removed |Added Resolution|--- |INFORMATIONPROVIDED S

[tomcat] branch main updated: Remove code previously marked for removal in 10.1.x

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 79173cfbca Remove code previously marked for removal

[Bug 66191] compile taglibs that are not (yet) included in jsp file

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66191 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #2 from Mark Tho

[Bug 66191] compile taglibs that are not (yet) included in jsp file

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66191 --- Comment #3 from andreas.sta...@rmcon-int.de --- > Given that the compilation of the tag files is simply a means to an ends > (dependency management) I wonder if there is a simpler solution. We could write a test that scans our tag files to

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-23 Thread GitBox
wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r951564802 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static org

[Bug 66235] New: Java Beans Standard not honoured in EL expressions when running under Graal VM (JVM Runtime Mode)

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66235 Bug ID: 66235 Summary: Java Beans Standard not honoured in EL expressions when running under Graal VM (JVM Runtime Mode) Product: Tomcat 9 Version: 9.0.x Hardware: PC

[tomcat] branch main updated: Improve error message

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6798a0058b Improve error message 6798a0058b is descri

[Bug 66235] Java Beans Standard not honoured in EL expressions when running under Graal VM (JVM Runtime Mode)

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66235 matthias.hil...@mgm-tp.com changed: What|Removed |Added OS||All --- Comment #1 from ma

[tomcat] branch 10.0.x updated: Improve error message

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 5bbd679c8e Improve error message 5bbd679c8e is de

[tomcat] branch 9.0.x updated: Improve error message

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 441e2bbfaa Improve error message 441e2bbfaa is desc

[tomcat] branch 8.5.x updated: Improve error message

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3e45f1a6f6 Improve error message 3e45f1a6f6 is desc

[Bug 66235] Java Beans Standard not honoured in EL expressions when running under Graal VM (JVM Runtime Mode)

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66235 --- Comment #2 from Remy Maucherat --- (In reply to matthias.hiller from comment #1) > By the way the commit integrating the GraalBeanELResolver already had an > comment about similar problems but it was ignored. > See > https://github.com/apac

[tomcat] branch main updated: Fix BZ 66194 - align HTTP/2 with HTTP/1.1 for handling of client errors

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 257bc23cdb Fix BZ 66194 - align HTTP/2 with HTTP/1.1

[tomcat] branch main updated: Update docs

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 200f048455 Update docs 200f048455 is described below

[tomcat] branch 10.0.x updated: Fix BZ 66194 - align HTTP/2 with HTTP/1.1 for handling of client errors

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 60745ec2d9 Fix BZ 66194 - align HTTP/2 with HTTP/

[tomcat] branch 9.0.x updated: Fix BZ 66194 - align HTTP/2 with HTTP/1.1 for handling of client errors

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ddecddc2a0 Fix BZ 66194 - align HTTP/2 with HTTP/1.

[tomcat] branch 8.5.x updated: Fix BZ 66194 - align HTTP/2 with HTTP/1.1 for handling of client errors

2022-08-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b0d7d1603a Fix BZ 66194 - align HTTP/2 with HTTP/1.

[Bug 66194] When using http2 and maxHeaderSize is exceeded, nothing is logged

2022-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66194 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[DISCUSS] MessageBytes refactoring

2022-08-23 Thread Mark Thomas
Hi all, I've been looking at a fix for bug 66196. My ideas so far have revolved around MessageBytes but the solutions are being made more complex by the current behaviour of MessageBytes in some cases. For example (I'm using strings in place of byte[] and char[] to keep it simple): mb.setB