https://bz.apache.org/bugzilla/show_bug.cgi?id=66207
--- Comment #3 from HanLi ---
It's not a bug, so close it.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...
On 19/07/2022 23:16, Rainer Jung wrote:
Roughly the same pattern I saw for TC 10.0 now also seen for TC 10.1.
A failure rate of 1 in 50 is going to make any testing a relatively slow
process. We are going to need at least 250 test runs to get a reasonable
degree of certainty in the results.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210
--- Comment #3 from Mark Thomas ---
I think we have a number of options here:
1. (Similar to my previous 'fixes') reduce the text tested to that which
doesn't change depending on locale.
2. Force the unit tests to run under en-US.
3. Use Str
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209
--- Comment #1 from Mark Thomas ---
This patch essentially trades memory for performance. We have some users that
won't want to make that trade - even if the memory concerned is relatively
small.
Given the competing demands here, I think we ne
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196
Mark Thomas changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #1 from Mark Thomas
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196
--- Comment #2 from Boris Petrov ---
Well, in my case it was the `ETag` header but I believe it's illegal to send
non-ASCII characters in any header.
--
You are receiving this mail because:
You are the assignee for the bug.
--
markt-asf closed pull request #534: Issue 66195 observe mr jar system property
URL: https://github.com/apache/tomcat/pull/534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf commented on PR #534:
URL: https://github.com/apache/tomcat/pull/534#issuecomment-1214871231
The sync block won't be reached:
https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/util/jar/JarFile.java#L382
The case hasn't been made that this ch
https://bz.apache.org/bugzilla/show_bug.cgi?id=66195
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=66194
--- Comment #1 from Mark Thomas ---
Logging every instance of this opens up the potential for a DoS.
We can look at the possibility of mirroring the logging used for HTTP/1.1 which
logs via a UserDataHelper instance.
--
You are receiving thi
https://bz.apache.org/bugzilla/show_bug.cgi?id=66194
--- Comment #2 from damien.hol...@unimarket.com ---
Logging at least the first instance would be much more helpful than the current
situation.
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210
--- Comment #4 from Han Li ---
(In reply to Mark Thomas from comment #3)
> Option 2 is sufficient to test the functionality primarily being tested
> whereas option 3 (sort of) tests some of the i18n as well.
Agreed! I also think that option 3
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209
--- Comment #2 from John Engebretson ---
I had a hand in the original implementation, and the intent was always to
create the Bloom filters once and keep them around forever. In our internal
implementation (Tomcat 8) we did exactly that. Rela
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210
--- Comment #5 from Mark Thomas ---
Sounds great. Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|NEW
--- Comment #3 from Mark Thomas ---
markt-asf merged PR #533:
URL: https://github.com/apache/tomcat/pull/533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new d54295e2d8 [Bug 66184] Ensure that all root loggers h
markt-asf commented on PR #533:
URL: https://github.com/apache/tomcat/pull/533#issuecomment-1216008668
Thanks for the bug report and PR. I just want to clean up a few minor points
(e.g. add a change log entry) and then I'll back-port this.
--
This is an automated message from the Apache G
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 46d7162237 Follow-up to #533
46d7162237 is described
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new e5a5122d2b [Bug 66184] Ensure that all root logge
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 9c9dc83e5a [Bug 66184] Ensure that all root loggers
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 55067d1ff1 [Bug 66184] Ensure that all root loggers
https://bz.apache.org/bugzilla/show_bug.cgi?id=66184
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEEDINFO
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new ad54dc88e6 Align IDE configuration with current dep
aooohan commented on PR #537:
URL: https://github.com/apache/tomcat/pull/537#issuecomment-1216053591
Will be refix according to option 3, so close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
aooohan closed pull request #537: Bugfix for 66210 - Some unit tests are
failing on a non-English PC
URL: https://github.com/apache/tomcat/pull/537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
https://bz.apache.org/bugzilla/show_bug.cgi?id=66179
Mark Thomas changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #5 from Mark Thomas
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183
--- Comment #2 from Mark Thomas ---
I agree that this needs to be fixed. Your plan sounds reasonable to me.
--
You are receiving this mail because:
You are the assignee for the bug.
markt-asf merged PR #540:
URL: https://github.com/apache/tomcat/pull/540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #540:
URL: https://github.com/apache/tomcat/pull/540#issuecomment-1216130168
Thanks for the PR. Back-ported to all other supported branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
markt-asf merged PR #538:
URL: https://github.com/apache/tomcat/pull/538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #538:
URL: https://github.com/apache/tomcat/pull/538#issuecomment-1216134107
Thanks for the PR. Back-ported to 10.0.x. (9.0.x and earlier does not have
the affected code.)
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183
--- Comment #3 from Han Li ---
(In reply to Mark Thomas from comment #2)
> I agree that this needs to be fixed. Your plan sounds reasonable to me.
Ok, I'll go ahead and fix this bug today.
Thanks Mark!
Han
--
You are receiving this mail bec
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183
--- Comment #4 from Han Li ---
There is also this problem in Extended Access Log Valve.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubsc
aooohan opened a new pull request, #541:
URL: https://github.com/apache/tomcat/pull/541
Fix [BZ66183](https://bz.apache.org/bugzilla/show_bug.cgi?id=66183)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
https://bz.apache.org/bugzilla/show_bug.cgi?id=66183
--- Comment #5 from Han Li ---
PR: https://github.com/apache/tomcat/pull/541
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mai
https://bz.apache.org/bugzilla/show_bug.cgi?id=66196
--- Comment #4 from Boris Petrov ---
Logging a warning (or even logging at the ERROR level) sounds great to me.
Everyone should be monitoring their logs for warnings and errors so this should
be visible to most. And would save people time as th
37 matches
Mail list logo
