[Bug 66195] Observe multi-release JAR system property from JVM if available via system properties

2022-08-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66195 --- Comment #6 from Behrooz Nobakht --- (In reply to Konstantin Kolinko from comment #5) > 1. If you read the above Java 9 javadoc, you may see that > "jdk.util.jar.enableMultiRelease" in that version of Java had 3 possible > values: true, fal

[tomcat] branch 8.5.x updated: This test assumes illegal headers will be rejected

2022-08-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 824d846ad2 This test assumes illegal headers will b

[GitHub] [tomcat] nobeh commented on pull request #534: Issue 66195 observe mr jar system property

2022-08-03 Thread GitBox
nobeh commented on PR #534: URL: https://github.com/apache/tomcat/pull/534#issuecomment-1203780743 > already implements the relevant logic, so we don't need to do anything extra with this property Yes, that's correct. However, Tomcat uses a "MethodHandle" invocation to call that meth

[GitHub] [tomcat] nobeh commented on pull request #534: Issue 66195 observe mr jar system property

2022-08-03 Thread GitBox
nobeh commented on PR #534: URL: https://github.com/apache/tomcat/pull/534#issuecomment-1203795589 > to evaluate to `false` could actually be an expensive operation. This is one of the main motivations for this change. And the root cause for that is because of a `synchronized` block:

[Bug 66195] Observe multi-release JAR system property from JVM if available via system properties

2022-08-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66195 --- Comment #7 from Behrooz Nobakht --- (In reply to Behrooz Nobakht from comment #6) > (In reply to Konstantin Kolinko from comment #5) > > > 1. If you read the above Java 9 javadoc, you may see that > > "jdk.util.jar.enableMultiRelease" in t

[tomcat] branch 10.0.x updated: Fix typo - thanks to Han Li

2022-08-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 5d3d244869 Fix typo - thanks to Han Li 5d3d244869

[tomcat] branch 9.0.x updated: Fix typo - thanks to Han Li

2022-08-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 4a66bc2d41 Fix typo - thanks to Han Li 4a66bc2d41 i

[tomcat] branch 8.5.x updated: Fix typo - thanks to Han Li

2022-08-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new be2e727381 Fix typo - thanks to Han Li be2e727381 i

[tomcat] branch main updated: Fix typo - thanks to Han Li

2022-08-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4d530de862 Fix typo - thanks to Han Li 4d530de862 is

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #523: Polished.

2022-08-03 Thread GitBox
ChristopherSchultz commented on code in PR #523: URL: https://github.com/apache/tomcat/pull/523#discussion_r936904336 ## java/org/apache/catalina/core/ApplicationPushBuilder.java: ## @@ -26,6 +26,7 @@ import java.util.Locale; import java.util.Map; import java.util.Set; +impor

[tomcat] branch main updated: Propertly-escape role and group information when writing MemoryUserDatabase to an XML file.

2022-08-03 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 38b93348e1 Propertly-escape role and group informat

[tomcat] branch main updated: Move logic to export MemoryUserDatabase to XML to be completely inside MemoryUserDatabase.save().

2022-08-03 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 9adbac09bc Move logic to export MemoryUserDatabase

[GitHub] [tomcat] aooohan commented on a diff in pull request #523: Polished.

2022-08-03 Thread GitBox
aooohan commented on code in PR #523: URL: https://github.com/apache/tomcat/pull/523#discussion_r937281527 ## java/org/apache/catalina/core/ApplicationPushBuilder.java: ## @@ -26,6 +26,7 @@ import java.util.Locale; import java.util.Map; import java.util.Set; +import java.util

Re: [tomcat] branch main updated: Move logic to export MemoryUserDatabase to XML to be completely inside MemoryUserDatabase.save().

2022-08-03 Thread Han Li
> 2022年8月4日 01:31,schu...@apache.org 写道: > > This is an automated email from the ASF dual-hosted git repository. > > schultz pushed a commit to branch main > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/main by this push: