[GitHub] [tomcat] markt-asf commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138227558 What is `CA.pl`? Can you point me towards that or provide an example cert/key Tomcat can't read? I'll add a test case for BZ 66089 to reduce the chances of similar regressions in th

[GitHub] [tomcat] jfclere commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
jfclere commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138238940 CA.pl comes from openssl-perl. I think that EncryptedPrivateKeyInfo() doesn't detect the encryption algorithm correctly, may we have to give a value there. -- This is an automated mess

[GitHub] [tomcat] rainerjung commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
rainerjung commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138241681 https://github.com/openssl/openssl/blob/master/apps/CA.pl.in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[tomcat] branch main updated: Fix regression that broke support for unencrypted PKCS#1 keys

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 314c31ea1e Fix regression that broke support for unen

[tomcat] branch 10.0.x updated: Fix regression that broke support for unencrypted PKCS#1 keys

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 39c4f5ee74 Fix regression that broke support for

[tomcat] branch 9.0.x updated: Fix regression that broke support for unencrypted PKCS#1 keys

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d2c5f957cf Fix regression that broke support for un

[tomcat] branch 8.5.x updated: Fix regression that broke support for unencrypted PKCS#1 keys

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 7de16c3460 Fix regression that broke support for un

[Bug 66089] Tomcat 9.0.63 won't start when used with a SSL certificate containing a RSA Private Key

2022-05-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66089 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[GitHub] [tomcat] markt-asf commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138244693 Have you got a test file (or files) that I can use to add to `TestPEMFile`? That would save me having to set up the test CA and figure out which options create the problematic cert(s). -

[GitHub] [tomcat] markt-asf commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138257773 OK. I think I have a test key to work with. Investigating now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] jfclere commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
jfclere commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138257995 [jfclere@ovpn-113-163 SERVER]$ openssl asn1parse -i -in newkey.pem 0:d=0 hl=4 l=1308 cons: SEQUENCE 4:d=1 hl=2 l= 78 cons: SEQUENCE 6:d=2 hl=2 l=

[GitHub] [tomcat] rainerjung commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
rainerjung commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138258790 Not sure that helps: an encrypted key file is for example: -BEGIN ENCRYPTED PRIVATE KEY- MIIFHDBOBgkqhkiG9w0BBQ0wQTApBgkqhkiG9w0BBQwwHAQIpBQ9Ge734xsCAggA MAwGCCqGSIb3DQ

[GitHub] [tomcat] markt-asf commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138259389 Yes, we are looking at the same thing. Just started to debug things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [tomcat] rainerjung commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
rainerjung commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138275372 Maybe unrelated, but the OpenSSL docs mention: "Make PKCS#8 the default write format for private keys, replacing the traditional format. This form is standardised, more secure and d

[GitHub] [tomcat] markt-asf commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138280071 The issue appears to be the cipher algorithm `des-ede3-cbc`. Java is expecting AES. I'm currently looking to see if I can find a way around this. -- This is an automated message from the

[GitHub] [tomcat] markt-asf commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1138382006 The short answer is that there isn't a way around this that doesn't involve installing an additional JCE provider such as BouncyCastle. The built-in provider does not support this particul

[GitHub] [tomcat] markt-asf closed pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf closed pull request #517: Fix BZ 66089 URL: https://github.com/apache/tomcat/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

[tomcat] branch main updated: Make max HTTP header size descriptions more specific

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 8acd6e3c8f Make max HTTP header size descriptions mor

[tomcat] branch 10.0.x updated: Make max HTTP header size descriptions more specific

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 5d2c505797 Make max HTTP header size descriptions

[tomcat] branch 9.0.x updated: Make max HTTP header size descriptions more specific

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ae1e384073 Make max HTTP header size descriptions m

[tomcat] branch 8.5.x updated: Make max HTTP header size descriptions more specific

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2b8b27b742 Make max HTTP header size descriptions m

[tomcat] branch main updated: Fix BZ 66068. Persist changes made by RemoteIpValve for async requests

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c52e7f9d83 Fix BZ 66068. Persist changes made by Remo

[tomcat] branch 10.0.x updated: Fix BZ 66068. Persist changes made by RemoteIpValve for async requests

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 95b9422d78 Fix BZ 66068. Persist changes made by

[tomcat] branch 9.0.x updated: Fix BZ 66068. Persist changes made by RemoteIpValve for async requests

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 437b060c96 Fix BZ 66068. Persist changes made by Re

[tomcat] branch 8.5.x updated: Fix BZ 66068. Persist changes made by RemoteIpValve for async requests

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new bf8a434cab Fix BZ 66068. Persist changes made by Re

[Bug 65951] ant package with custom tomcat.output fails in add-osgi

2022-05-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65951 --- Comment #5 from Matt M --- The fix for 9.0.x is missing a fix to this file: res/bnd/tomcat-embed-el.jar.tmp.bnd The fix for 10.0.x has it. -- You are receiving this mail because: You are the assignee for the bug. ---

[tomcat] branch 9.0.x updated: Missing fix for BZ 65951

2022-05-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new def22ec972 Missing fix for BZ 65951 def22ec972 is d

[Bug 65951] ant package with custom tomcat.output fails in add-osgi

2022-05-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65951 --- Comment #6 from Mark Thomas --- Fixed in: - 9.0.x for 9.0.64 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: d

[Bug 66068] Asynchronous request processing changes IP behind RemoteIpValve

2022-05-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66068 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[GitHub] [tomcat] ChristopherSchultz commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
ChristopherSchultz commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1139158612 I believe I was able to decode these types of files without another provider. Have a look around https://github.com/ChristopherSchultz/pem-utils/blob/main/src/main/java/net/

[GitHub] [tomcat] markt-asf commented on pull request #517: Fix BZ 66089

2022-05-26 Thread GitBox
markt-asf commented on PR #517: URL: https://github.com/apache/tomcat/pull/517#issuecomment-1139340297 @ChristopherSchultz The code you referenced is decoding PKCS#1 format keys. Tomcat already handles those. This issue is about PKCS#8 format keys. Take a look at the sub-classes of `com.sun