[GitHub] [tomcat] michael-o commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
michael-o commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031419530 @cklein05 Please apply all requested changes. I want to merge with main and proceed with Tomcat 9+ as @markt-asf has written. -- This is an automated message from the Apache G

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031426532 What about the example JSP application? Shouldn't we add support for dumping user attributes with this commit? See https://github.com/apache/tomcat/pull/463#issuecomment-10155114

[GitHub] [tomcat] michael-o commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
michael-o commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031428724 > What about the example JSP application? Shouldn't we add support for dumping user attributes with this commit? See [#463 (comment)](https://github.com/apache/tomcat/pull/463#i

[GitHub] [tomcat] michael-o edited a comment on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
michael-o edited a comment on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031428724 > What about the example JSP application? Shouldn't we add support for dumping user attributes with this commit? See [#463 (comment)](https://github.com/apache/tomcat/pul

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031432651 I'm not talking about removing methods from the interface. In the 2nd paragraph of this comment I was asking whether to include the additions to Tomcat's example JSP application

[GitHub] [tomcat] michael-o commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
michael-o commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031439345 > I'm not talking about removing methods from the interface. In the 2nd paragraph of this comment I was asking whether to include the additions to Tomcat's example JSP applicati

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031450526 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [tomcat] michael-o commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
michael-o commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031454181 @cklein05 The default methods are on not required on main since it is still bleeding edge, we can break API here. Default methods are required for backports to 9 and 10 only.

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031481006 Removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031603301 @michael-o Will provide a fix for _Travis CI failed_ ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [tomcat] michael-o commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
michael-o commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031606851 > @michael-o Will provide a fix for _Travis CI failed_ ASAP. Thanks, will then run it locally. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-02-07 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-103160 @michael-o Should be fine now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[Bug 65776] "Duplicate accept detected" error from a subsequent request with the same local port

2022-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65776 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #12 from Mark Thoma

[Bug 65776] "Duplicate accept detected" error from a subsequent request with the same local port

2022-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65776 --- Comment #13 from Brooke T. Hedrick --- @Mark RE: https://bz.apache.org/bugzilla/show_bug.cgi?id=65776#c12 - Bare metal or VM? VM - If VM, which hypervisor? VMWare ESX 7.x - What sort of load (in terms of new connections per second) was t

[Bug 65869] AbstractFileResourceSet incorrectly checks kotlin's enum with unicode value

2022-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65869 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

svn commit: r1897825 - /tomcat/site/trunk/xdocs/presentations.xml

2022-02-07 Thread schultz
Author: schultz Date: Mon Feb 7 20:28:54 2022 New Revision: 1897825 URL: http://svn.apache.org/viewvc?rev=1897825&view=rev Log: Add id to presentation. Modified: tomcat/site/trunk/xdocs/presentations.xml Modified: tomcat/site/trunk/xdocs/presentations.xml URL: http://svn.apache.org/viewvc/

svn commit: r1897826 - /tomcat/site/trunk/docs/presentations.html

2022-02-07 Thread schultz
Author: schultz Date: Mon Feb 7 20:32:05 2022 New Revision: 1897826 URL: http://svn.apache.org/viewvc?rev=1897826&view=rev Log: Actually modify the html document and not just the xml. Modified: tomcat/site/trunk/docs/presentations.html Modified: tomcat/site/trunk/docs/presentations.html URL

[GitHub] [tomcat] markt-asf merged pull request #469: Load "jakarta.annotation.*" classes from common classloader

2022-02-07 Thread GitBox
markt-asf merged pull request #469: URL: https://github.com/apache/tomcat/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

[tomcat] branch main updated: Adds "jakarta.annotation" to filter

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4a32a6d Adds "jakarta.annotation" to filter 4a32a6d

[tomcat] branch main updated: Add changelog entry

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 312c3c8 Add changelog entry 312c3c8 is described bel

[tomcat] branch 10.0.x updated (ec34852 -> a2207ad)

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from ec34852 Fix BZ 65806 - FIPS enabled JREs don't support SHA1PRNG new 8fc62c4 Adds "jakarta.annotation" to filter

[tomcat] 02/02: Add changelog entry

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a2207ad281926f9143179a5fbbbc305e2e28fb4d Author: Mark Thomas AuthorDate: Mon Feb 7 20:37:04 2022 + Add changelog

[tomcat] 01/02: Adds "jakarta.annotation" to filter

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8fc62c4a7b64843c26505bece0b0b4b8b06075e4 Author: Piotr P. Karwasz AuthorDate: Fri Jan 28 09:33:04 2022 +0100 Adds "j

[tomcat] branch 9.0.x updated (42b5661 -> 0d9a0cc)

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 42b5661 Fix BZ 65806 - FIPS enabled JREs don't support SHA1PRNG new cba2970 Adds "javax.annotation" to filter

[tomcat] 02/02: Add changelog entry

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0d9a0cc055d55172ae40c4533f6b04c232d091f1 Author: Mark Thomas AuthorDate: Mon Feb 7 20:37:04 2022 + Add changelog

[tomcat] 01/02: Adds "javax.annotation" to filter

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cba2970e726e72b1aeccd897b3f774bb00023681 Author: Piotr P. Karwasz AuthorDate: Fri Jan 28 09:33:04 2022 +0100 Adds "ja

[tomcat] branch 8.5.x updated (b8a372e -> 505642c)

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from b8a372e Fix BZ 65806 - FIPS enabled JREs don't support SHA1PRNG new 589ebce Adds "javax.annotation" to filter

[tomcat] 02/02: Add changelog entry

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 505642c30d1b3cdc2c0a870c0c354449b6d48d70 Author: Mark Thomas AuthorDate: Mon Feb 7 20:37:04 2022 + Add changelog

[tomcat] 01/02: Adds "javax.annotation" to filter

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 589ebcee2a53034edf735f060bfeb4e506ca6df2 Author: Piotr P. Karwasz AuthorDate: Fri Jan 28 09:33:04 2022 +0100 Adds "ja

[GitHub] [tomcat] markt-asf commented on pull request #470: Load "javax.annotation.*" classes from common classloader

2022-02-07 Thread GitBox
markt-asf commented on pull request #470: URL: https://github.com/apache/tomcat/pull/470#issuecomment-1031911095 Back-ported from 10.0.x (with appropriate changes to package name) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [tomcat] markt-asf closed pull request #470: Load "javax.annotation.*" classes from common classloader

2022-02-07 Thread GitBox
markt-asf closed pull request #470: URL: https://github.com/apache/tomcat/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

[tomcat] branch main updated: Fix individual test targets

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 7a33227 Fix individual test targets 7a33227 is descr

[tomcat] branch 10.0.x updated: Fix individual test targets

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 93deffc Fix individual test targets 93deffc is d

[tomcat] branch 9.0.x updated: Fix individual test targets

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 4102db7 Fix individual test targets 4102db7 is des

[tomcat] branch 8.5.x updated: Fix individual test targets

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4055b54 Fix individual test targets 4055b54 is des

[GitHub] [tomcat] markt-asf closed pull request #468: add test sub targets depend on setup-jacoco

2022-02-07 Thread GitBox
markt-asf closed pull request #468: URL: https://github.com/apache/tomcat/pull/468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

[GitHub] [tomcat] markt-asf commented on pull request #468: add test sub targets depend on setup-jacoco

2022-02-07 Thread GitBox
markt-asf commented on pull request #468: URL: https://github.com/apache/tomcat/pull/468#issuecomment-1031920321 Thanks. Applied manually so I could start with main and then backport. I also added a changelog entry that included crediting you. -- This is an automated message from

Tagging 10.1.x and 10.0.x tomorrow

2022-02-07 Thread Mark Thomas
Hi all, Just a heads up that, barring surprises, I plan to be in a position to tag 10.1.x and 10.0.x for the February release round towards the end of tomorrow. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or

[tomcat] branch 8.5.x updated: Align with 9.0.x onwards

2022-02-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ce9e6c3 Align with 9.0.x onwards ce9e6c3 is descri