[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1007732098 @cklein05 Can you rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[Bug 65785] HTTP/2.0 non US-ASCII header names should be rejected

2022-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65785 --- Comment #2 from Nils R --- Thanks a lot for this quick answer (and fix !) Since I had hard time to find the changes in github an in case someone is interested in reading it, here is the associated commit : https://github.com/apache/tomcat/

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008002451 @michael-o I will do so. However, that's no fun and it will take some time. Since @rmaucher changed lots of the UserDatabase and UserDatabaseRealm stuff, some more adjustments ar

[GitHub] [tomcat] rmaucher commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
rmaucher commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008003775 I think you should save some time and limit this to JNDIRealm. To be perfectly honest I'm -1 to adding it to anything else since it's only lower performance and no actual feature

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008005127 I really need this with JDBCRealm. We have a bunch of customers, that do not want to use LDAP/AD but only JDBC based user database. Why should there be no benefit from having ext

[GitHub] [tomcat] rmaucher commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
rmaucher commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008019368 If you really want to do this, then let's focus on adding this to JNDIRealm for now, since this is where this has obvious usefulness. If everything is merged ok, then maybe we ca

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008022559 > Why? I don't understand your position. This makes sense on any realm since the principal source shouldn't really matter. I have been using a similiar approach for the

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008022657 @rmaucher Why? I don't understand your position. This makes sense on any realm since the principal source shouldn't really matter. I have been using a similiar approach for

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008024542 @rmaucher have a look at you comment https://github.com/apache/tomcat/pull/428#issuecomment-865007741 However, maybe I just got you wrong :( -- This is an automated

[GitHub] [tomcat] rmaucher commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
rmaucher commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008025711 It seems by September I had already changed my mind on this after seeing some actual code. Anyway, the focus should be on JNDIRealm and then later DataSourceRealm. -- This is

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-08 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1008027903 Maybe this should be done in stages (PRs)? 1. Principals 2. RealmBase groundwork 3. Each Realm impl seperately? -- This is an automated message from the Apache Git Ser

[tomcat] branch 9.0.x updated: Fix backport

2022-01-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2a18ae3 Fix backport 2a18ae3 is described below c

[tomcat] branch 8.5.x updated: Fix backport

2022-01-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 7a0f1ae Fix backport 7a0f1ae is described below c

[tomcat] branch main updated: Allow for relaxed validation of path and query characters in HTTP/2

2022-01-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 3ce7bcc Allow for relaxed validation of path and que

[tomcat] branch 9.0.x updated: Allow for relaxed validation of path and query characters in HTTP/2

2022-01-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 58fd47f Allow for relaxed validation of path and q

[tomcat] branch 10.0.x updated: Allow for relaxed validation of path and query characters in HTTP/2

2022-01-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new f6a476d Allow for relaxed validation of path and

[tomcat] branch 8.5.x updated: Allow for relaxed validation of path and query characters in HTTP/2

2022-01-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2f94cc4 Allow for relaxed validation of path and q

Bug report for Taglibs [2022/01/09]

2022-01-08 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 9 [2022/01/09]

2022-01-08 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2022/01/09]

2022-01-08 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 10 [2022/01/09]

2022-01-08 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 8 [2022/01/09]

2022-01-08 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2022/01/09]

2022-01-08 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2022/01/09]

2022-01-08 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned