[GitHub] [tomcat] rrodewald opened a new pull request #439: Minimal fixes to documentation of Context and Host

2021-08-04 Thread GitBox
rrodewald opened a new pull request #439: URL: https://github.com/apache/tomcat/pull/439 - Documented default value of unpackWARs attribute - Tagged all boolean values als code - Punctuation -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] rrodewald commented on pull request #438: Bugfix for 65479 - PasswordValidationCallback does not return result

2021-08-04 Thread GitBox
rrodewald commented on pull request #438: URL: https://github.com/apache/tomcat/pull/438#issuecomment-892522194 The build failure seems unrelated to my changes IMHO. ``` /home/travis/.travis/functions: line 607: 14128 Terminated travis_jigger "${!}" "${timeout}" "${cmd[@]

[GitHub] [tomcat] michael-o commented on a change in pull request #439: Minimal fixes to documentation of Context and Host

2021-08-04 Thread GitBox
michael-o commented on a change in pull request #439: URL: https://github.com/apache/tomcat/pull/439#discussion_r682466514 ## File path: webapps/docs/config/host.xml ## @@ -302,7 +302,7 @@ placed in the appBase directory as web application archive (WAR) files

[GitHub] [tomcat] rrodewald commented on a change in pull request #439: Minimal fixes to documentation of Context and Host

2021-08-04 Thread GitBox
rrodewald commented on a change in pull request #439: URL: https://github.com/apache/tomcat/pull/439#discussion_r682483565 ## File path: webapps/docs/config/host.xml ## @@ -302,7 +302,7 @@ placed in the appBase directory as web application archive (WAR) files

[GitHub] [tomcat] kkolinko commented on pull request #439: Minimal fixes to documentation of Context and Host

2021-08-04 Thread GitBox
kkolinko commented on pull request #439: URL: https://github.com/apache/tomcat/pull/439#issuecomment-892610685 Reviewing... 1. context.xml L187 `s/docBase/docBase/ `as well 2. I am more used to "The default value is" rather than "The default is". I wonder what wording is better. To

[GitHub] [tomcat] rrodewald commented on pull request #439: Minimal fixes to documentation of Context and Host

2021-08-04 Thread GitBox
rrodewald commented on pull request #439: URL: https://github.com/apache/tomcat/pull/439#issuecomment-892615291 > Reviewing... > > 1. context.xml L187 `s/docBase/docBase/ `as well > > 2. I am more used to "The default value is" rather than "The default is". >

[GitHub] [tomcat] ChristopherSchultz commented on pull request #439: Minimal fixes to documentation of Context and Host

2021-08-04 Thread GitBox
ChristopherSchultz commented on pull request #439: URL: https://github.com/apache/tomcat/pull/439#issuecomment-893006283 To a native English speaker, either one is completely understandable. "The default value is ___" is slightly more clear, but I would actually defer to NON-native E

Re: [VOTE] Release Apache Tomcat 9.0.52

2021-08-04 Thread Rémy Maucherat
On Sat, Jul 31, 2021 at 6:35 AM Rémy Maucherat wrote: > > The proposed Apache Tomcat 9.0.52 release is now available for voting. > > The notable changes compared to 9.0.52 are: > > - Correct a regression in the previous release in the HTTP/2 flow >control window management > > - Correct a regr