[Bug 65454] Race condition with idle thread removal results in request being improperly enqueued by default ThreadPoolExecutor

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65454 --- Comment #5 from Mark Thomas --- I see why the force handling is needed. It is to address the case where there are maxThreads-1 current threads, two new connections are received, both try to create a new thread, one gets created and the othe

[Bug 65460] New: http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 Bug ID: 65460 Summary: http2 request hang with tomcat 9.0.50`s overhead protection Product: Tomcat 9 Version: 9.0.50 Hardware: PC OS: Mac OS X 10.1

[Bug 65460] http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 --- Comment #1 from dpy1123 --- A stack trace when blocking happens: void java.lang.Object.wait(long) 272 97.1 % int org.apache.coyote.http2.Stream$StreamInputBuffer.doRead(ApplicationBufferHandler) 272 97.1 % int org.apache.coyote.Request.doR

[Bug 65460] http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 dpy1123 changed: What|Removed |Added Component|Connectors |Catalina -- You are receiving this mail bec

[Bug 65460] http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Mark Thomas

[Bug 65460] http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 dpy1123 changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from dpy1123 --- all the

[Bug 65460] http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Mark Thomas

[Bug 65454] Race condition with idle thread removal results in request being improperly enqueued by default ThreadPoolExecutor

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65454 --- Comment #6 from Mark Thomas --- Just a quick update. I am currently looking at a solution along the following lines: - import latest ThreadPoolExecutor from JSR 166 repo - Fix any CheckStyle etc issues - Merge in the changes from o.a.t.util

[Bug 65443] Allow subclassing CorsFilter

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443 --- Comment #7 from ekkelenk...@gmail.com --- Just to let you know, I found a convenient way to get the job done without changing the code. Simply extending the getInitParameter method, does the job. As a reference, this is the pseudo setup of m

[Bug 65460] http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 dpy1123 changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #5 from dpy1123 --- we are

[tomcat] branch main updated: Deprecate unused Executor method

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 62a54d4 Deprecate unused Executor method 62a54d4 is

[tomcat] branch 10.0.x updated: Deprecate unused Executor method

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new f984f54 Deprecate unused Executor method f984f54

[tomcat] branch 9.0.x updated: Deprecate unused Executor method

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0857b86 Deprecate unused Executor method 0857b86 i

[tomcat] branch 8.5.x updated: Deprecate unused Executor method

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 390b017 Deprecate unused Executor method 390b017 i

[tomcat] branch main updated (62a54d4 -> c383609)

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 62a54d4 Deprecate unused Executor method new 4ae47eb Remove deprecated execute(Runnable, long, TimeUnit) method

[tomcat] 01/03: Remove deprecated execute(Runnable, long, TimeUnit) method

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4ae47eb1021f84ff255601c40167f0cc0204ead9 Author: Mark Thomas AuthorDate: Wed Jul 21 16:59:01 2021 +0100 Remove depreca

[tomcat] 02/03: Improve comment

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6590a3c3cd3044e531c6ba946c9d19ee463cb2d0 Author: Mark Thomas AuthorDate: Wed Jul 21 17:05:19 2021 +0100 Improve commen

[tomcat] 03/03: Remove unnecessary code

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c3836094e5b82123677b6edb82e5ad1b5c35fee1 Author: Mark Thomas AuthorDate: Wed Jul 21 17:08:53 2021 +0100 Remove unneces

[tomcat] branch 10.0.x updated (f984f54 -> 027b4df)

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from f984f54 Deprecate unused Executor method new 4afe23a Improve comment new 027b4df Remove unnecessary code

[tomcat] 01/02: Improve comment

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4afe23a16e55eeec43daa2037778029774c6f633 Author: Mark Thomas AuthorDate: Wed Jul 21 17:05:19 2021 +0100 Improve comm

[tomcat] 02/02: Remove unnecessary code

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 027b4dfa511c772f2aa08a4a82aac28fc66a89eb Author: Mark Thomas AuthorDate: Wed Jul 21 17:08:53 2021 +0100 Remove unnec

[tomcat] 01/02: Improve comment

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 09a64e84b61b32b4d738d21e43644eb103a32611 Author: Mark Thomas AuthorDate: Wed Jul 21 17:05:19 2021 +0100 Improve comme

[tomcat] 02/02: Remove unnecessary code

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0ccebeab3e265ac19c32c457d50ce6b5864bcb05 Author: Mark Thomas AuthorDate: Wed Jul 21 17:08:53 2021 +0100 Remove unnece

[tomcat] branch 9.0.x updated (0857b86 -> 0ccebea)

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 0857b86 Deprecate unused Executor method new 09a64e8 Improve comment new 0ccebea Remove unnecessary code

[tomcat] branch 8.5.x updated (390b017 -> 007a033)

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 390b017 Deprecate unused Executor method new fee409e Improve comment new 007a033 Remove unnecessary code

[tomcat] 02/02: Remove unnecessary code

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 007a033908c5fb8fb0951971c658997e672c59d8 Author: Mark Thomas AuthorDate: Wed Jul 21 17:08:53 2021 +0100 Remove unnece

[tomcat] 01/02: Improve comment

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fee409e7b33d84aa84d8d06d5baacaac0897dc44 Author: Mark Thomas AuthorDate: Wed Jul 21 17:05:19 2021 +0100 Improve comme

[tomcat] branch main updated: Deprecate unused method. Improve Javadoc.

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6d02df2 Deprecate unused method. Improve Javadoc. 6d

[tomcat] branch 10.0.x updated: Deprecate unused method. Improve Javadoc.

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 78c4cb9 Deprecate unused method. Improve Javadoc

[tomcat] branch 9.0.x updated: Deprecate unused method. Improve Javadoc.

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f5146f6 Deprecate unused method. Improve Javadoc.

[tomcat] branch 8.5.x updated: Deprecate unused method. Improve Javadoc.

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new fb2c92f Deprecate unused method. Improve Javadoc.

[tomcat] branch main updated (6d02df2 -> 0f2e084)

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 6d02df2 Deprecate unused method. Improve Javadoc. new 4289f47 Remove deprecated code new c03c7c8 Replace To

[tomcat] 02/05: Replace Tomcat's ThreadPoolExecutor with the current JSR 166 version

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c03c7c82d61d3b6e5f42e022db4435d0bfce04f5 Author: Mark Thomas AuthorDate: Wed Jul 21 15:59:30 2021 +0100 Replace Tomcat

[tomcat] 03/05: Clean up imported code

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8bd316a226a7ca267fce12de3a6c9553a42b2d04 Author: Mark Thomas AuthorDate: Wed Jul 21 16:15:00 2021 +0100 Clean up impor

[tomcat] 01/05: Remove deprecated code

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4289f4745cd831775abe0c5d1b08c9936889c47f Author: Mark Thomas AuthorDate: Wed Jul 21 17:27:12 2021 +0100 Remove depreca

[tomcat] 05/05: Fix BZ 65454. Correct a timing issue that could delay a request

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0f2e084d1583cfa4c00cec1958ec30113fb4f41e Author: Mark Thomas AuthorDate: Wed Jul 21 17:45:01 2021 +0100 Fix BZ 65454.

[tomcat] 04/05: Merge in changes from Tomcat's extended ThreadPoolExecutor

2021-07-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4c314648eccc75c0f8108b3ed394dea69bf75593 Author: Mark Thomas AuthorDate: Wed Jul 21 16:36:32 2021 +0100 Merge in chang

buildbot failure in on tomcat-9.0.x

2021-07-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/78 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler sche

Re: buildbot failure in on tomcat-9.0.x

2021-07-21 Thread Mark Thomas
On 21/07/2021 18:45, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/78 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf94

[Bug 65443] Allow subclassing CorsFilter

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443 --- Comment #8 from Christopher Schultz --- This violates the servlet spec, but hey if you want to do that in your code, it's fine. Honestly, I was hoping you'd end up writing a proper patch because I think this is a good idea to have in the b

[GitHub] [tomcat] Dmole opened a new pull request #435: ant ide-eclipse libs

2021-07-21 Thread GitBox
Dmole opened a new pull request #435: URL: https://github.com/apache/tomcat/pull/435 Update res/ide-support to reflect libs made by "ant ide-eclipse" etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] Dmole closed pull request #435: ant ide-eclipse libs

2021-07-21 Thread GitBox
Dmole closed pull request #435: URL: https://github.com/apache/tomcat/pull/435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tom

[GitHub] [tomcat] Dmole opened a new pull request #436: ant ide-eclipse lib update

2021-07-21 Thread GitBox
Dmole opened a new pull request #436: URL: https://github.com/apache/tomcat/pull/436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

[Bug 65460] http2 request hang with tomcat 9.0.50`s overhead protection

2021-07-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65460 --- Comment #6 from dpy1123 --- we run several more times with case.2 and find: when overhead count disconut to around -10640 to -10660, next request will hang till timeout and any requests after this will also hang till timeout. we see thes