This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new b5d84e4 Fix typo (#433)
b5d84e4 is described below
markt-asf merged pull request #433:
URL: https://github.com/apache/tomcat/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 85ff05f Remove trailing space
85ff05f is described b
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new 054c3d1 Fix typo (#433)
054c3d1 is described bel
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 0dffb1d Fix typo (#433)
0dffb1d is described below
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new b363fba Fix typo (#433)
b363fba is described below
markt-asf commented on pull request #433:
URL: https://github.com/apache/tomcat/pull/433#issuecomment-878847653
Thanks for the PR.
Please note that trailing whitespace should be removed from all lines. If
you run checkstyle using the provided configuration, it should catch issues
like t
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #5 from Mark Thomas ---
The initial implementation was clearly on the basis that the state was set
during init() and then never changed but if you have a requirement to change it
then I don't see a good reason not to refactor the co
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443
--- Comment #6 from ekkelenk...@gmail.com ---
Thanks for the feedback.
The requirement is indeed to be able to configure the allowed origins at
runtime.
Should I provide a pull request for this enhancement or is this kind of
refactoring done
On 09/07/2021 18:40, Rainer Jung wrote:
Hi Jean-Frederic,
how do you make sure, that your tests actually land in the correct
SSLHost? You are using the same server certificate, so a check on the
client side might not be easy. I would find a test more convincing, if
the three TLS hosts would u
https://bz.apache.org/bugzilla/show_bug.cgi?id=65358
Volodymyr Siedlecki changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXE
https://bz.apache.org/bugzilla/show_bug.cgi?id=65358
--- Comment #6 from Mark Thomas ---
Yes, that looks like a bug to me. The JLS states (in rather more precise
language) that a method match that doesn't use varargs beats one that does.
I'll work on a fix.
--
You are receiving this mail becau
https://bz.apache.org/bugzilla/show_bug.cgi?id=65448
Bug ID: 65448
Summary: Download of file via Servlet OutputStream blocks when
using SSL
Product: Tomcat 9
Version: 9.0.50
Hardware: PC
Status: NEW
Se
https://bz.apache.org/bugzilla/show_bug.cgi?id=65448
Roman changed:
What|Removed |Added
OS||All
--- Comment #1 from Roman ---
Important t
https://bz.apache.org/bugzilla/show_bug.cgi?id=65448
--- Comment #2 from Michael Osipov ---
If the DefaultServlet is working via HTTPS then the error is in your code. Did
you check that?
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=65448
--- Comment #3 from Roman ---
Yes, absolutely. We even pulled the code out to a separate app to check it
individually.
My main point is that it works when using HTTP. And it is really a small code
and I would consider it to be ok.
--
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=65448
--- Comment #4 from Roman ---
One other thing: how would the code be influenced by the connection timeout of
the server?
It's not that the client opens a new connection or something... it's just that
the server pauses sending the response. I wo
https://bz.apache.org/bugzilla/show_bug.cgi?id=65448
--- Comment #5 from Mark Thomas ---
A few questions (there will be more depending on the answers to these):
1. Does this happen with Tomcat 9.0.48?
2. How often does the problem occur? 1 request in 5? 1 in 10? 1 in 20?
3. Does the problem st
18 matches
Mail list logo
