https://bz.apache.org/bugzilla/show_bug.cgi?id=65124
--- Comment #16 from Mark Thomas ---
My expectation was that you'd use the plug-in mechanism to implement the
optimisation for described in issue 1.
If you want to provide a generic optimisation to multiple/all tags then that
probably won't s
rmaucher commented on issue #20:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-844881012
Since -zipInMemory worked as a workaround, I changed the default code path
to use commons-compression instead of the Java code. It seems to me it has good
results. C
ShamithaSIlva commented on issue #20:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-844891004
> Since -zipInMemory worked as a workaround, I changed the default code path
to use commons-compression instead of the Java code. It seems to me it has good
res
rmaucher commented on issue #20:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-844905756
Ok, all the entries are supposed to be properly closed (calling
closeArchiveEntry). If I cannot figure it out, I'll revert but most likely
migrateArchiveInMemory has
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new eabb165 Fix handling of neste
rmaucher commented on issue #20:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-844946443
This should now be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new d4b0576 Improve docs for maxConnections and acce
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new dc20584 Improve docs for maxConnections and accept
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 44beabf Improve docs for maxConnections and accept
markt-asf commented on pull request #419:
URL: https://github.com/apache/tomcat/pull/419#issuecomment-844978705
This report, and the proposed solution is invalid. `maxPostSize` does not,
and should not, apply to a multi-part request explicitly parsed via
`Request.getParts()` or `Request.ge
markt-asf closed pull request #419:
URL: https://github.com/apache/tomcat/pull/419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
The Buildbot has detected a new failure on builder tomcat-trunk while building
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5836
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler sc
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new fb680e1 Improve General IDE support
fb680e1 is d
markt-asf merged pull request #284:
URL: https://github.com/apache/tomcat/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
markt-asf commented on pull request #284:
URL: https://github.com/apache/tomcat/pull/284#issuecomment-845012146
Thanks for this. I want to do a few checks locally and then I'll back-port
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 8be11e3 Tweak the settings
8be11e3 is described
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 2631b37 Improve General IDE support
2631b37 is des
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new ed5916c Improve General IDE support
ed5916c is des
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 2a39474 Align with 10.0.x: Add SSO cookieName conf
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new b04c1df Align with 10.0.x: Add SSO cookieName conf
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit abf45df71342f7bed2112c689d607da07e6de72a
Author: Mark Thomas
AuthorDate: Thu May 20 13:10:12 2021 +0100
Better align
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from b04c1df Align with 10.0.x: Add SSO cookieName configuration attribute
new abf45df Better align with 10.0.x and 9
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 804ffa6728e8b7db27d10a80a0acb1e587788bb5
Author: Mark Thomas
AuthorDate: Thu May 20 13:16:49 2021 +0100
Better align
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 0610e67d41c77a961a064b6a50c9af67f9f253a3
Author: Mark Thomas
AuthorDate: Thu May 20 13:19:01 2021 +0100
Align with 10
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit b7a736fb12f5e4774c63fa20f6fc437315e1b0d0
Author: Mark Thomas
AuthorDate: Thu May 20 13:21:25 2021 +0100
Align with 10
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 434d791c0a0263d883b356ce7800eeed37295bc9
Author: Mark Thomas
AuthorDate: Thu May 20 13:23:55 2021 +0100
Align with 10
Answering various points raised in this thread...
On 18/05/2021 13:10, Emmanuel Bourg wrote:
> I don't think the 7.0.x branch should be removed, there is no harm
> keeping it.
Ack. The idea was to try and provide a clear indication that the branch
was not being developed whilst not losing any h
tianshuang commented on pull request #419:
URL: https://github.com/apache/tomcat/pull/419#issuecomment-845112219
I adjusted to check the maxPostSize first to avoid the OOM problem,
part.getString will trigger OOM when the string is huge.
--
This is an automated message from the Apache Gi
The Buildbot has detected a restored build on builder tomcat-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5837
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler
tianshuang commented on pull request #419:
URL: https://github.com/apache/tomcat/pull/419#issuecomment-845114763
If part.getString is called before checking maxPostSize, it may trigger OOM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
tianshuang commented on pull request #419:
URL: https://github.com/apache/tomcat/pull/419#issuecomment-845115322
stack trace:
```
at java.lang.OutOfMemoryError.()V (OutOfMemoryError.java:48)
at java.lang.StringCoding$StringDecoder.decode([BII)[C
(StringCoding.java:149)
at
tianshuang commented on pull request #419:
URL: https://github.com/apache/tomcat/pull/419#issuecomment-845131930
My solution did not change the original semantics. Please take a closer
look. It just adjusted the calling order of part.getString to avoid the OOM
problem of large strings. Aft
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new a7511a7 Avoid using local host name when not need
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new af16402 Improve language
af16402 is described be
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 6464db0 Improve language
6464db0 is described belo
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124
--- Comment #17 from John Engebretson ---
Our Tomcat8 implementation modified Generator.java along the following lines:
1. When a tag call is found (any tag!):
- generate a method name that uniquely identifies the tag class and the
provided at
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 9ba6f71 Improve language
9ba6f71 is described belo
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 7919934 Avoid using local host name when not needed
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new c736449 Avoid using local host name when not needed
https://bz.apache.org/bugzilla/show_bug.cgi?id=65301
Remy Maucherat changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Hi All,
I am currently working on a new catalina filter for Tomcat.
I will submit my ideas and code for discussion using Bugzilla.
While I was able to find the style guide and submissions guide, I still
have a few questions about the process:
- Romain has pointed me to
https://github.com/ap
On 20/05/2021 15:36, Neale Rudd wrote:
Hi All,
I am currently working on a new catalina filter for Tomcat.
I will submit my ideas and code for discussion using Bugzilla.
I'd recommend you do that earlier rather than later. I wouldn't want you
spend time producing this filter only to find out
markt-asf commented on pull request #419:
URL: https://github.com/apache/tomcat/pull/419#issuecomment-845237996
Re-opening to take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
https://bz.apache.org/bugzilla/show_bug.cgi?id=65317
--- Comment #1 from Mark Thomas ---
Do you have a test case that reproduces this?
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe,
https://bz.apache.org/bugzilla/show_bug.cgi?id=65317
--- Comment #2 from Mark Thomas ---
No need for a test case. I've been able to build a unit test that demonstrates
this.
--
You are receiving this mail because:
You are the assignee for the bug.
---
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124
--- Comment #18 from Christopher Schultz ---
These are good ideas, especially the Objective-C-style
_callTag_org_apache_taglibs_standard_tag_rt_core_SetTag_With_var_And_value
method generation and invocation.
The biggest problem with Java-code
https://bz.apache.org/bugzilla/show_bug.cgi?id=65317
--- Comment #3 from Mark Thomas ---
Test case now passes with the proposed patch applied.
There are a lot of edge cases here so I want to run the Autobahn test suite
before committing this.
--
You are receiving this mail because:
You are the
https://bz.apache.org/bugzilla/show_bug.cgi?id=65181
--- Comment #11 from Edin Hodzic ---
Created attachment 37870
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37870&action=edit
keep structural reference to the SSL Engine pointed to by tcn_ssl_engine
Found another problem with the rece
https://bz.apache.org/bugzilla/show_bug.cgi?id=65181
--- Comment #12 from Edin Hodzic ---
Comment on attachment 37870
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37870
keep structural reference to the SSL Engine pointed to by tcn_ssl_engine
diff -aur tomcat-native-1.2.28-src/native/sr
https://bz.apache.org/bugzilla/show_bug.cgi?id=65181
Edin Hodzic changed:
What|Removed |Added
Attachment #37870|0 |1
is obsolete|
https://bz.apache.org/bugzilla/show_bug.cgi?id=65181
Edin Hodzic changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bz.apache.org/bugzilla/show_bug.cgi?id=65181
--- Comment #14 from Edin Hodzic ---
One other potential improvement in the OpenSSL interaction might be to enable
OpenSSL configuration:
In ssl.c, initialization is done with the call:
OPENSSL_init_ssl(OPENSSL_INIT_ENGINE_ALL_BUILTIN, NUL
52 matches
Mail list logo