svn commit: r1889950 - in /tomcat/site/trunk: docs/tomcat-70-eol.html xdocs/tomcat-70-eol.xml

2021-05-17 Thread markt
Author: markt Date: Mon May 17 10:16:17 2021 New Revision: 1889950 URL: http://svn.apache.org/viewvc?rev=1889950&view=rev Log: Fix typo Modified: tomcat/site/trunk/docs/tomcat-70-eol.html tomcat/site/trunk/xdocs/tomcat-70-eol.xml Modified: tomcat/site/trunk/docs/tomcat-70-eol.html URL:

[tomcat] branch master updated (939efed -> d03377e)

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 939efed Guard new escape routines for null values add 22c7f19 Remove unnecessary code. Only called for Tag file

[tomcat] branch 9.0.x updated (937b156 -> 74717b3)

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 937b156 Guard new escape routines for null values new d5b958a Remove unnecessary code. Only called for Tag files

[tomcat] 01/03: Remove unnecessary code. Only called for Tag files.

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d5b958a03dbf7ebcba27ea7dd019371ac6de8cc0 Author: Mark Thomas AuthorDate: Fri May 14 11:51:37 2021 +0100 Remove unnece

[tomcat] 02/03: Remove unnecessary code.

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cb66b1fc93d24ef5a781a2709dafb17c24f8bc5e Author: Mark Thomas AuthorDate: Fri May 14 13:28:13 2021 +0100 Remove unnece

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva opened a new issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva opened a new issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20 Hi Guys I tried to skip these kind of jars ( [WEB-INF/lib/jcl-over-slf4j-1.7.21.jar] ) with -exclude=**WEB-INF/lib/*.jar. but seems it is not working. Any idea or what should be

[tomcat] branch 8.5.x updated (edd46e4 -> ddb4d14)

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from edd46e4 Guard new escape routines for null values new 551960d Remove unnecessary code. Only called for Tag files

[tomcat] 01/03: Remove unnecessary code. Only called for Tag files.

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 551960d706adc7d5e4a8475a901a1288985e7440 Author: Mark Thomas AuthorDate: Fri May 14 11:51:37 2021 +0100 Remove unnece

[tomcat] 02/03: Remove unnecessary code.

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b4385c721491156cee17edcd0c3c782abaf49cdf Author: Mark Thomas AuthorDate: Fri May 14 13:28:13 2021 +0100 Remove unnece

[Bug 65124] Inefficient generated JSP code

2021-05-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124 --- Comment #11 from Mark Thomas --- It has taken a while but I have just committed additional tests that bring the code coverage for Generator close to 100%. Next steps will be looking at the optimisations. The work on the tests identified so

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #20: Skipping files

2021-05-17 Thread GitBox
markt-asf commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842272261 Pattern applies only to the file name so, assuming this is a WAR file, `-exclude=*.jar` should work. -- This is an automated message from the Apache Git Service.

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842293747 > Pattern applies only to the file name so, assuming this is a WAR file, `-exclude=*.jar` should work. It gives me : Migration skipped for archive [WEB-IN

[GitHub] [tomcat-jakartaee-migration] markt-asf closed issue #20: Skipping files

2021-05-17 Thread GitBox
markt-asf closed issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #20: Skipping files

2021-05-17 Thread GitBox
markt-asf commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842299148 That suggests JAR conversion isn't where the time is being spent. Have you run this with a profiler? Can you share the WAR (or better a pointer to a project to buil

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842304084 > That suggests JAR conversion isn't where the time is being spent. Have you run this with a profiler? Can you share the WAR (or better a pointer to a project t

[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #20: Skipping files

2021-05-17 Thread GitBox
rmaucher commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842311068 Ok so do you *really* need to use the in memory mode ? That is far less efficient than the default. -- This is an automated message from the Apache Git Service. To

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842314996 > Ok so do you _really_ need to use the in memory mode ? That is far less efficient than the default. Without that I'm getting this exception: Migr

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva edited a comment on issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva edited a comment on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842304084 > That suggests JAR conversion isn't where the time is being spent. Have you run this with a profiler? Can you share the WAR (or better a pointer to a pr

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva edited a comment on issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva edited a comment on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842304084 > That suggests JAR conversion isn't where the time is being spent. Have you run this with a profiler? Can you share the WAR (or better a pointer to a pr

[tomcat] branch master updated (d03377e -> c5f7c63)

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from d03377e Improve code coverage of Generator tests new 75d8c79 Improve readability of Java source new c5f7c6

[tomcat] 02/02: Correct bug id

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c5f7c636dbf775606d91bd24414cb325b78afc62 Author: Mark Thomas AuthorDate: Mon May 17 19:01:54 2021 +0100 Correct bug

[tomcat] 01/02: Improve readability of Java source

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 75d8c7958c472274f25589695b12e7336165d41f Author: Mark Thomas AuthorDate: Mon May 17 13:41:29 2021 +0100 Improve read

[tomcat] branch 9.0.x updated (74717b3 -> 2928b0d)

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 74717b3 Improve code coverage of Generator tests new af3b0ba Improve readability of Java source new 2928b0d

[tomcat] 01/02: Improve readability of Java source

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit af3b0bab91fe37eb4e82987a987ca89cd72605ba Author: Mark Thomas AuthorDate: Mon May 17 13:41:29 2021 +0100 Improve reada

[tomcat] 02/02: Correct bug id

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2928b0df9bfb0bc9c00d340458f215c4769cf323 Author: Mark Thomas AuthorDate: Mon May 17 19:01:54 2021 +0100 Correct bug i

[tomcat] branch 8.5.x updated (ddb4d14 -> ef77b54)

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from ddb4d14 Improve code coverage of Generator tests new a938f26 Improve readability of Java source new ef77b54

[tomcat] 01/02: Improve readability of Java source

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a938f26571b286c91d7475e90b3b96b083df6262 Author: Mark Thomas AuthorDate: Mon May 17 13:41:29 2021 +0100 Improve reada

[tomcat] 02/02: Correct bug id

2021-05-17 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ef77b54bdc2c75a593340da47bd990426752f5e1 Author: Mark Thomas AuthorDate: Mon May 17 19:01:54 2021 +0100 Correct bug i

[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #20: Skipping files

2021-05-17 Thread GitBox
rmaucher commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842311068 Ok so do you *really* need to use the in memory mode ? That is far less efficient than the default. -- This is an automated message from the Apache Git Service. To

[GitHub] [tomcat-jakartaee-migration] markt-asf closed issue #20: Skipping files

2021-05-17 Thread GitBox
markt-asf closed issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842293747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #20: Skipping files

2021-05-17 Thread GitBox
markt-asf commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842272261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva edited a comment on issue #20: Skipping files

2021-05-17 Thread GitBox
ShamithaSIlva edited a comment on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842304084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

JSP code generation optimizations

2021-05-17 Thread Mark Thomas
Hi all, I am looking at some of the optimizations requested in [1] One of the examples is show below. Code like this is used when the JSP calls a tag. private boolean _jspx_meth_mytag_005fhelloWorld_005f0( jakarta.servlet.jsp.PageContext _jspx_page_context) throws java.lang.T

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #20: Skipping files

2021-05-17 Thread GitBox
markt-asf commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842558546 By profiler I mean something like YourKit Java Profiler which will tell you where all the time is being spent. Failing that an example we can test would help. --

Re: JSP code generation optimizations

2021-05-17 Thread Rémy Maucherat
On Mon, May 17, 2021 at 8:47 PM Mark Thomas wrote: > Hi all, > > I am looking at some of the optimizations requested in [1] > > One of the examples is show below. Code like this is used when the JSP > calls a tag. > > > private boolean _jspx_meth_mytag_005fhelloWorld_005f0( > jakarta.ser