8.5.x unit tests crashing

2021-01-29 Thread Mark Thomas
Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch of JVM crashes on Windows with both Java 7 and Java 8. The crashes were always in a compilation thread which was unusual. I am currently doing the binary search to figure out which commit triggered the issue. Mark -

Re: 8.5.x unit tests crashing

2021-01-29 Thread Mark Thomas
On 29/01/2021 08:06, Mark Thomas wrote: > Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch > of JVM crashes on Windows with both Java 7 and Java 8. The crashes were > always in a compilation thread which was unusual. > > I am currently doing the binary search to figure out

Re: 8.5.x unit tests crashing

2021-01-29 Thread Rémy Maucherat
On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas wrote: > On 29/01/2021 08:06, Mark Thomas wrote: > > Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch > > of JVM crashes on Windows with both Java 7 and Java 8. The crashes were > > always in a compilation thread which was unusua

[tomcat] branch 8.5.x updated: Drop fix for 65111 as it is causing crashes

2021-01-29 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9668330 Drop fix for 65111 as it is causing crashes

Re: 8.5.x unit tests crashing

2021-01-29 Thread Rémy Maucherat
On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas wrote: > On 29/01/2021 08:06, Mark Thomas wrote: > > Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch > > of JVM crashes on Windows with both Java 7 and Java 8. The crashes were > > always in a compilation thread which was unusua

Re: 8.5.x unit tests crashing

2021-01-29 Thread Mark Thomas
On 29/01/2021 09:01, Rémy Maucherat wrote: > On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas wrote: > >> On 29/01/2021 08:06, Mark Thomas wrote: >>> Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch >>> of JVM crashes on Windows with both Java 7 and Java 8. The crashes were >>>

Re: 8.5.x unit tests crashing

2021-01-29 Thread Rémy Maucherat
On Fri, Jan 29, 2021 at 10:08 AM Mark Thomas wrote: > On 29/01/2021 09:01, Rémy Maucherat wrote: > > On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas wrote: > > > >> On 29/01/2021 08:06, Mark Thomas wrote: > >>> Heads up. When I ran my pre-tag tests for 8.5.x I started to see a > bunch > >>> of JVM c

Re: 8.5.x unit tests crashing

2021-01-29 Thread Mark Thomas
On 29/01/2021 09:21, Rémy Maucherat wrote: > On Fri, Jan 29, 2021 at 10:08 AM Mark Thomas wrote: > >> On 29/01/2021 09:01, Rémy Maucherat wrote: >>> On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas wrote: >>> On 29/01/2021 08:06, Mark Thomas wrote: > Heads up. When I ran my pre-tag tests for

Re: 8.5.x unit tests crashing

2021-01-29 Thread Mark Thomas
On 29/01/2021 09:34, Mark Thomas wrote: > On 29/01/2021 09:21, Rémy Maucherat wrote: >> On Fri, Jan 29, 2021 at 10:08 AM Mark Thomas wrote: >>> I was thinking about moving the cleaning of the direct buffers to >>> destroySocket() >>> >>> I'll do some tests. >>> >> >> Yes, ideally, waiting until

[GitHub] [tomcat] minfrin commented on pull request #401: Add support for unix domain sockets (APR Protocol)

2021-01-29 Thread GitBox
minfrin commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-769728053 Thanks for this. This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [VOTE] Release Apache Tomcat 10.0.2

2021-01-29 Thread Mark Thomas
On 28/01/2021 19:12, Mark Thomas wrote: > The proposed 10.0.2 release is: > [ ] Broken - do not release > [ ] Beta - go ahead and release as 10.0.2 (beta) > [X] Stable - go ahead and release as 10.0.2 (stable) Mark - To unsubs

Re: [VOTE] Release Apache Tomcat 9.0.43

2021-01-29 Thread Mark Thomas
On 28/01/2021 20:48, Mark Thomas wrote: > The proposed 9.0.43 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.43 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additiona

[tomcat] tag 8.5.63 created (now eb8d36c)

2021-01-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 8.5.63 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at eb8d36c (commit) This tag includes the following new commits: new eb8d36c Tag 8.5.63 The 1 revisions listed abov

[tomcat] 01/01: Tag 8.5.63

2021-01-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 8.5.63 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit eb8d36c30857866536e8c931731c9f86980b00a6 Author: Mark Thomas AuthorDate: Fri Jan 29 11:19:43 2021 + Tag 8.5.63 ---

svn commit: r45641 - /dev/tomcat/tomcat-8/v8.5.62/

2021-01-29 Thread markt
Author: markt Date: Fri Jan 29 11:37:08 2021 New Revision: 45641 Log: Drop 8.5.62 (release cancelled) Removed: dev/tomcat/tomcat-8/v8.5.62/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands

svn commit: r45642 [2/2] - in /dev/tomcat/tomcat-8/v8.5.63: ./ bin/ bin/embed/ bin/extras/ src/

2021-01-29 Thread markt
Added: dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.asc == --- dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.asc (added) +++ dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.asc Fr

svn commit: r45642 [1/2] - in /dev/tomcat/tomcat-8/v8.5.63: ./ bin/ bin/embed/ bin/extras/ src/

2021-01-29 Thread markt
Author: markt Date: Fri Jan 29 11:40:20 2021 New Revision: 45642 Log: Upload Apache Tomcat 8.5.63 for voting Added: dev/tomcat/tomcat-8/v8.5.63/ dev/tomcat/tomcat-8/v8.5.63/KEYS dev/tomcat/tomcat-8/v8.5.63/README.html dev/tomcat/tomcat-8/v8.5.63/RELEASE-NOTES dev/tomcat/tomcat

[VOTE] Release Apache Tomcat 8.5.63

2021-01-29 Thread Mark Thomas
The proposed Apache Tomcat 8.5.63 release is now available for voting. The notable changes compared to the 8.5.61 release are: - Add a new StringInterpreter interface that allows applications to provide customised string attribute value to type conversion within JSPs. This allows applications

Re: [VOTE] Release Apache Tomcat 10.0.2

2021-01-29 Thread Rémy Maucherat
On Thu, Jan 28, 2021 at 8:13 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.2 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications th

Re: [VOTE] Release Apache Tomcat 9.0.43

2021-01-29 Thread Rémy Maucherat
On Thu, Jan 28, 2021 at 9:56 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.43 release is now available for voting. > > The notable changes compared to the 9.0.41 release are: > > - Add support for using Unix domain sockets for NIO when running on > Java 16 or later. > > - Add a new Str

Re: [VOTE] Release Apache Tomcat 8.5.63

2021-01-29 Thread Rémy Maucherat
On Fri, Jan 29, 2021 at 12:44 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.63 release is now available for voting. > > The notable changes compared to the 8.5.61 release are: > > - Add a new StringInterpreter interface that allows applications to > provide customised string attribute

[Bug 65114] New: HTTP/2 client

2021-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65114 Bug ID: 65114 Summary: HTTP/2 client Product: Tomcat Connectors Version: 1.2.46 Hardware: Macintosh OS: Mac OS X 10.1 Status: NEW Severity: normal

[tomcat] branch master updated (8e7e1d2 -> 069801f)

2021-01-29 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 8e7e1d2 Increment version to 10.0.3 for next development cycle add 069801f Use URI filtering in the default sour

[tomcat] branch 9.0.x updated: Use URI filtering in the default source implementation

2021-01-29 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2e58ae8 Use URI filtering in the default source imp

Re: Can't save edit to Confluence page

2021-01-29 Thread Christopher Schultz
Mark, On 1/28/21 17:13, Mark Thomas wrote: On 28/01/2021 22:08, Mark Thomas wrote: On 28/01/2021 22:04, Christopher Schultz wrote: All, I'm trying to update this page in Confluence: https://cwiki.apache.org/confluence/display/TOMCAT/TomcatCon+2021-02 I've added my own name + availability, a

[Bug 65114] HTTP/2 client

2021-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65114 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 65114] HTTP/2 client

2021-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65114 Mark Thomas changed: What|Removed |Added Resolution|FIXED |INVALID -- You are receiving this mail

[Bug 65115] New: Missing key (jsp.error.unable.renameClassFile) in localization file for Russian and Spanish

2021-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65115 Bug ID: 65115 Summary: Missing key (jsp.error.unable.renameClassFile) in localization file for Russian and Spanish Product: Tomcat 9 Version: unspecified Hardware: PC

[Bug 49822] Add hash lb worker method

2021-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=49822 Vinson Merritt changed: What|Removed |Added CC||vinnieashley4e...@gmail.com Attachme

[Bug 49822] Add hash lb worker method

2021-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=49822 Mark Thomas changed: What|Removed |Added Attachment #25941|False |Patch to add hash lb worker descr

[Bug 49822] Add hash lb worker method

2021-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=49822 --- Comment #4 from Christopher Schultz --- I question the quality of this patch. There are a number of issues that I see: 1. The combining of the URI and query string is completely wrong. Only the query string is actually used. I'm not sure i