[GitHub] [tomcat] martin-g merged pull request #391: Optimize if condition

2020-12-17 Thread GitBox
martin-g merged pull request #391: URL: https://github.com/apache/tomcat/pull/391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [tomcat] martin-g commented on pull request #391: Optimize if condition

2020-12-17 Thread GitBox
martin-g commented on pull request #391: URL: https://github.com/apache/tomcat/pull/391#issuecomment-747288205 Thank you, @lanicc ! This is an automated message from the Apache Git Service. To respond to the message, please l

[tomcat] branch master updated: Optimize if condition

2020-12-17 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 92eabe5 Optimize if condition new 58841

[tomcat] branch 9.0.x updated: Optimize if condition

2020-12-17 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 67c37e4 Optimize if condition 67c37e4 is descr

[TCK] JSTL failure

2020-12-17 Thread Jean-Louis MONTEIRO
Hi, I have been using Tomcat Taglib (shaded with Xalan and Serializer). Works quite well on TomEE but I have one failure I'd like to discuss with you before possibly opening a challenge. https://tck.work/tomee/tests?path=com.sun.ts.tests.jstl&build=1608116575927&status=FAILED I have fixed 4 or t

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-17 Thread Michael Osipov
Am 2020-12-16 um 16:38 schrieb Emmanuel Bourg: Le 11/12/2020 à 17:56, Michael Osipov a écrit : Well, isn't that really a OS vendor problem not ours? We can provide grace periods, but that's pretty much it. They need to solve that, not us on a volunteer basis. Note that (most) Debian Developer

Re: [TCK] JSTL failure

2020-12-17 Thread Jonathan Gallimore
I opened both the import-encoded.txt, and the positiveImportEncodingNotSpecifiedTest.gf file in a hex editor. I don't know if this mailing list allows attachments, but I can send a screenshot if that helps. In both cases, right before the word "output from text file", there's a sequence of 4 bytes

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-17 Thread Mladen Adamović
Hi everyone, TLTR: after switching from APR to Nio2 our processor usage went down. Longer version: Recently we had a production problem which was noticeable years ago, but it became a real problem recently. In our tests 0.75% of connection requests weren't served. I have recently posted in Tomcat

Re: [TCK] JSTL failure

2020-12-17 Thread Jonathan Gallimore
Looking at this again, those characters are a BOM, and having that in the middle of the output seems a little strange. I'd suggest asking on the spec list. Jon On Thu, Dec 17, 2020 at 10:51 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I opened both the import-encoded.txt, and t

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-17 Thread Rémy Maucherat
On Thu, Dec 17, 2020 at 12:12 PM Mladen Adamović wrote: > But what I have discovered from migrating from APR to Nio2 that our > processor usage went down. We never tried Nio2, I have setup APR back in > 2014 as I've read it has a better performance. > I would still say the APR connector is faste

[GitHub] [tomcat] rmaucher commented on pull request #382: Add support for unix domain sockets.

2020-12-17 Thread GitBox
rmaucher commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-747467253 I am not convinced about adding that feature to the APR endpoint ... Anyway: - The changes to IntrospectionUtils are too much given the actual use, strings could be used

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-17 Thread Mladen Adamović
Perhaps for some users APR is significantly faster than NIO or NIO2, but Graham Leggett didn't bring some examples like: - company ZZZ reports 39% of higher CPU usage with APR for their project - company XXX which is an Apache gold sponsor reports 43% of higher CPU usage for APR for their project L

[GitHub] [tomcat] jbampton opened a new pull request #392: docs: fix spelling

2020-12-17 Thread GitBox
jbampton opened a new pull request #392: URL: https://github.com/apache/tomcat/pull/392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[Bug 65001] New: HTTPNIO non-blocking IO servlet 3.1 API may fail to alert webapp that a request is complete

2020-12-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65001 Bug ID: 65001 Summary: HTTPNIO non-blocking IO servlet 3.1 API may fail to alert webapp that a request is complete Product: Tomcat 9 Version: 9.0.41 Hardware: PC

[Bug 65001] HTTPNIO non-blocking IO servlet 3.1 API may fail to alert webapp that a request is complete

2020-12-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65001 frraj...@cisco.com changed: What|Removed |Added OS|Mac OS X 10.1 |All Hardware|PC

[GitHub] [tomcat] lanicc opened a new pull request #394: Replace C-style array declaring with Java-style array declaring

2020-12-17 Thread GitBox
lanicc opened a new pull request #394: URL: https://github.com/apache/tomcat/pull/394 Replace the C-style parameter declaring of the method `Catalina.load(String args[])` with Java-style `load(String[] args)` This is an auto

[GitHub] [tomcat] lanicc closed pull request #394: Replace C-style array declaring with Java-style array declaring

2020-12-17 Thread GitBox
lanicc closed pull request #394: URL: https://github.com/apache/tomcat/pull/394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] lanicc opened a new pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-17 Thread GitBox
lanicc opened a new pull request #395: URL: https://github.com/apache/tomcat/pull/395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[tomcat] branch master updated: docs: fix spelling (#392)

2020-12-17 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e8dbc19 docs: fix spelling (#392) e8dbc19 is

[GitHub] [tomcat] martin-g merged pull request #392: docs: fix spelling

2020-12-17 Thread GitBox
martin-g merged pull request #392: URL: https://github.com/apache/tomcat/pull/392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [tomcat] martin-g commented on pull request #392: docs: fix spelling

2020-12-17 Thread GitBox
martin-g commented on pull request #392: URL: https://github.com/apache/tomcat/pull/392#issuecomment-747913681 Thank you, @jbampton ! This is an automated message from the Apache Git Service. To respond to the message, please

[tomcat] branch 9.0.x updated: docs: fix spelling (#392)

2020-12-17 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 8223515 docs: fix spelling (#392) 8223515 is d

[tomcat] branch 8.5.x updated: docs: fix spelling (#392)

2020-12-17 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new eed7776 docs: fix spelling (#392) eed7776 is d

[GitHub] [tomcat] martin-g commented on pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-17 Thread GitBox
martin-g commented on pull request #395: URL: https://github.com/apache/tomcat/pull/395#issuecomment-747917997 There are many of those. A quick search shows around 400 occurrences of the C-style. I am not sure this is worth it. It will make backporting very hard. --