[GitHub] [tomcat] martin-g opened a new pull request #312: Use StringBuilder instead of StringBuffer

martin-g opened a new pull request #312: URL: https://github.com/apache/tomcat/pull/312 There is no need of synchronization when it is a method local variable. Append character instead of String when possible This is a

[GitHub] [tomcat] rmaucher commented on pull request #312: Use StringBuilder instead of StringBuffer

rmaucher commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653402387 The "Append character instead of String when possible" seems wrong to me, and you're editing generated code there. ---

[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653404420 @rmaucher Could you please comment on the changed lines ? I am not sure which code is generated and which `append(char)` might be wrong. Thanks! ---

[tomcat] branch master updated: Direct use of the ALPN API

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7763877 Direct use of the ALPN API 7763877 is des

[GitHub] [tomcat] pzygielo commented on pull request #312: Use StringBuilder instead of StringBuffer

pzygielo commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653434713 > and which `append(char)` might be wrong. I suppose, there is change in produced result ``` (1) retval.append("\\t"); (2) retval.append('\

[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653439627 Thanks, @pzygielo ! Also these seem to be the generated classes! This is an automated message from the Apac

Re: [tomcat] branch master updated: Direct use of the ALPN API

On Fri, Jul 3, 2020 at 10:38 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653443649 I've reverted the changes to the generated classes. What about the DBCP2 classes ? Maybe they should be changed upstream and then copied over here ? --

[tomcat] branch master updated (7763877 -> 091f11f)

This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 7763877 Direct use of the ALPN API new 35d8448 Revert "Direct use of the ALPN API" new 091f11f Revert The

[tomcat] 02/02: Revert

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 091f11ff5c31e32b8615347ec88cd97dc858885a Author: remm AuthorDate: Fri Jul 3 11:17:40 2020 +0200 Revert --- webapps/d

[tomcat] 01/02: Revert "Direct use of the ALPN API"

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 35d84487fd10bfd6f2a00494078a5e3eef1b1830 Author: remm AuthorDate: Fri Jul 3 11:16:24 2020 +0200 Revert "Direct use of

[GitHub] [tomcat] markt-asf commented on pull request #312: Use StringBuilder instead of StringBuffer

markt-asf commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653453487 Yes, DBCP2 changes need to be made upstream. This is an automated message from the Apache Git Service. To respond

Re: [ANN] New committer: Raymond Augé

Congrats and welcome! Am 02.07.20 um 16:40 schrieb Mark Thomas: > On behalf of the Tomcat committers I am pleased to announce that > Raymond Augé (rotty3000) has been voted in as a new Tomcat committer. > > Please join me in welcoming him. > > Kind regards, > > Mark > > ---

[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653508943 OK. I've reverted the DBCP classes! And made some more changes from `.append(String)` to `.append(char)` This i

[GitHub] [tomcat] rmaucher commented on pull request #312: Use StringBuilder instead of StringBuffer

rmaucher commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653579373 Looks good to me now. The change for rewrite is likely the most significant, the rest is probably not doing anything though. -

[GitHub] [tomcat] sephiroth-j edited a comment on pull request #311: support schemes "wss" and "ws" in WsHandshakeRequest.buildRequestUri()

sephiroth-j edited a comment on pull request #311: URL: https://github.com/apache/tomcat/pull/311#issuecomment-653173711 I observed the exception in a project with Spring Boot 2.3 and Vaadin 14.2 with an enabled [`ForwardedHeaderFilter`](https://github.com/spring-projects/spring-framework/

[GitHub] [tomcat] jbampton opened a new pull request #313: Fix case of JavaScript.

jbampton opened a new pull request #313: URL: https://github.com/apache/tomcat/pull/313 Changes were: - `javascript` to `JavaScript` - `Javascript` to `JavaScript` This is an automated message from the Apache Git Se

[GitHub] [tomcat] jbampton opened a new pull request #314: Changed css to CSS

jbampton opened a new pull request #314: URL: https://github.com/apache/tomcat/pull/314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go