[GitHub] [tomcat] panchenko opened a new pull request #233: if TRACE is not allowed skip erorr page for such requests

2020-01-10 Thread GitBox
panchenko opened a new pull request #233: if TRACE is not allowed skip erorr page for such requests URL: https://github.com/apache/tomcat/pull/233 I have a Spring Boot application, and Spring Boot by default configures an erorr page. The TTACE method is not alloed (default configuration

[GitHub] [tomcat] bkahlert commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
bkahlert commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#discussion_r365162630 ## File path: res/tomcat-maven/README.md ## @@ -39,7 +39,7 @@ mvn clean; mvn package ```

[GitHub] [tomcat] bkahlert commented on issue #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
bkahlert commented on issue #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#issuecomment-572976739 1. Spring Boot is handling query parameters as described. Example: `@RequestParam MultiValueMap params` in all types of Tests

[GitHub] [tomcat] panchenko commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
panchenko commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#discussion_r365164921 ## File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java ## @@ -354,4 +

[GitHub] [tomcat] michael-o commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
michael-o commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#discussion_r365179774 ## File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java ## @@ -354,4 +

[GitHub] [tomcat] panchenko commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
panchenko commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#discussion_r365189403 ## File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java ## @@ -354,4 +

[GitHub] [tomcat] markt-asf commented on issue #233: if TRACE is not allowed skip error page for such requests

2020-01-10 Thread GitBox
markt-asf commented on issue #233: if TRACE is not allowed skip error page for such requests URL: https://github.com/apache/tomcat/pull/233#issuecomment-573001161 The Servlet specification requires that applications are given the opportunity to handle errors. There are no exceptions to thi

[GitHub] [tomcat] markt-asf closed pull request #233: if TRACE is not allowed skip error page for such requests

2020-01-10 Thread GitBox
markt-asf closed pull request #233: if TRACE is not allowed skip error page for such requests URL: https://github.com/apache/tomcat/pull/233 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [tomcat] panchenko commented on issue #233: if TRACE is not allowed skip error page for such requests

2020-01-10 Thread GitBox
panchenko commented on issue #233: if TRACE is not allowed skip error page for such requests URL: https://github.com/apache/tomcat/pull/233#issuecomment-573042875 Surely I understand what you mean, but the Servlet specification says nothing about `Connector.getAllowTrace()`, which is check

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
ChristopherSchultz commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#discussion_r365254773 ## File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java ## @@

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
ChristopherSchultz commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#discussion_r365254773 ## File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java ## @@

[Bug 64068] Tomcat failes to start when JVM start option specified for new line by "\" on linux.

2020-01-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64068 --- Comment #1 from Felix Schumacher --- I think you have been hit by the fix for bug 63815. So the backslashes are needed to prevent the newlines (at least until we find a better fix for the other bug). -- You are receiving this mail becaus

[GitHub] [tomcat] ChristopherSchultz commented on issue #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
ChristopherSchultz commented on issue #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#issuecomment-573055772 I agree that `getParameter` should remain: a parameter present with no value should return `""` and not `null`. `get

[GitHub] [tomcat] panchenko commented on issue #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
panchenko commented on issue #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#issuecomment-573059015 The parameter without value can be specified multiple times, like `?foo&foo=1&foo`. If we want to represent that. it has t

[GitHub] [tomcat] bkahlert commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
bkahlert commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#discussion_r365292432 ## File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java ## @@ -354,4 +3

[GitHub] [tomcat] bkahlert commented on issue #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
bkahlert commented on issue #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#issuecomment-573089178 I think `?foo&foo=1&foo` leading to `{null, "1", null}` is totall valid and imho the expected behaviour. Asking for a param

[GitHub] [tomcat] panchenko commented on issue #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
panchenko commented on issue #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#issuecomment-573090362 `getParameterValues(String) != null` would do that This is a

[GitHub] [tomcat] bkahlert edited a comment on issue #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
bkahlert edited a comment on issue #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#issuecomment-573089178 I think `?foo&foo=1&foo` leading to `{null, "1", null}` is totally valid and imho the expected behavior. Asking for

[GitHub] [tomcat] markt-asf commented on issue #232: Fix handling of query parameters with no value, like `?foo`

2020-01-10 Thread GitBox
markt-asf commented on issue #232: Fix handling of query parameters with no value, like `?foo` URL: https://github.com/apache/tomcat/pull/232#issuecomment-573140542 > I recall a discussion and changes in this area a few years ago. I'd like to find that discussion and remind myself of the d