Re: [GUMP@vmgump-vm3]: Project tomcat-native-1.2-1.1.0-configure (in module tomcat-native-1.2-1.1.0) failed

2018-10-29 Thread Mark Thomas
On 29/10/18 00:50, Bill Barker wrote: > To whom it may engage... > > This is an automated request, but not an unsolicited one. For > more information please visit http://gump.apache.org/nagged.html, > and/or contact the folk at gene...@gump.apache.org. > > Project tomcat-native-1.2-1.1.

Re: "Embedded" improvements

2018-10-29 Thread Rémy Maucherat
On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat wrote: > Hi, > > I'm starting to review embedded. Maybe I won't make many changes in the > end and won't need a separate API. > > However, I have another post 9.0.13 refactoring with a redoing of > ConfigFileLoader and various places which try to lo

svn commit: r1845099 - /tomcat/trunk/test/webapp/WEB-INF/test.tld

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 10:53:01 2018 New Revision: 1845099 URL: http://svn.apache.org/viewvc?rev=1845099&view=rev Log: Add missing word. Reflow. Based on a patch provided by mdfst13 This fixes #128 Modified: tomcat/trunk/test/webapp/WEB-INF/test.tld Modified: tomcat/trunk/test/webapp

[GitHub] tomcat pull request #128: Add missing word for readability

2018-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/128 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845100 - in /tomcat/tc8.5.x/trunk: ./ test/webapp/WEB-INF/test.tld

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 10:53:47 2018 New Revision: 1845100 URL: http://svn.apache.org/viewvc?rev=1845100&view=rev Log: Add missing word. Reflow. Based on a patch provided by mdfst13 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/webapp/WEB-INF/test.tld

svn commit: r1845101 - in /tomcat/tc7.0.x/trunk: ./ test/webapp-3.0/WEB-INF/test.tld

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 10:56:40 2018 New Revision: 1845101 URL: http://svn.apache.org/viewvc?rev=1845101&view=rev Log: Add missing word. Reflow. Based on a patch provided by mdfst13 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/test

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/125 I've now spent some time looking at this more closely. I like the idea of setting this once on the `Server` and then auto-magically setting this on the `Connector`s. As I reviewed

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread m-czernek
Github user m-czernek commented on the issue: https://github.com/apache/tomcat/pull/125 @markt-asf I'll check your review into a lot more detail later, possibly tonight, but at this moment: - You set `portOffset` on Server - All connectors are offset There is no p

svn commit: r1845133 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java

2018-10-29 Thread remm
Author: remm Date: Mon Oct 29 14:50:17 2018 New Revision: 1845133 URL: http://svn.apache.org/viewvc?rev=1845133&view=rev Log: Code cleanup. Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/TokenStreamProvider.java Modified: tomcat/trunk/java/org/apache/catalina/tribe

svn commit: r1845134 - /tomcat/trunk/test/org/apache/catalina/tribes/membership/cloud/TestKubernetesJson.java

2018-10-29 Thread remm
Author: remm Date: Mon Oct 29 14:51:28 2018 New Revision: 1845134 URL: http://svn.apache.org/viewvc?rev=1845134&view=rev Log: Replace with real json test, more to come eventually (that helped sort out what was standard and others like "kind" which are pretty much optional). Modified: tomcat

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/125 > Another possible, and very simple, solution is also to include in the default configuration some system property, that will be simply added to all ports if the property is set. Or, simply add the pr

svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 15:17:01 2018 New Revision: 1845136 URL: http://svn.apache.org/viewvc?rev=1845136&view=rev Log: Refactor the Connector so that the port is obtained from the Endpoint rather than a local field that could end up out of sync. Modified: tomcat/trunk/java/org/apache

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread rmaucher
Github user rmaucher commented on the issue: https://github.com/apache/tomcat/pull/125 Ok, so I'm guilty for all the system properties in Tomcat ... Sorry. So now, it's not good anymore. System properties are still fine for end users, but only by using ${...} property replacement in s

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2018-10-29 Thread Rémy Maucherat
On Mon, Oct 29, 2018 at 4:17 PM wrote: > Author: markt > Date: Mon Oct 29 15:17:01 2018 > New Revision: 1845136 > > URL: http://svn.apache.org/viewvc?rev=1845136&view=rev > Log: > Refactor the Connector so that the port is obtained from the Endpoint > rather than a local field that could end up o

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2018-10-29 Thread Mark Thomas
On 29/10/2018 16:41, Rémy Maucherat wrote: On Mon, Oct 29, 2018 at 4:17 PM wrote: Author: markt Date: Mon Oct 29 15:17:01 2018 New Revision: 1845136 URL: http://svn.apache.org/viewvc?rev=1845136&view=rev Log: Refactor the Connector so that the port is obtained from the Endpoint rather than a

svn commit: r1845144 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 17:12:12 2018 New Revision: 1845144 URL: http://svn.apache.org/viewvc?rev=1845144&view=rev Log: Improve performance of refactoring Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java Modified: tomcat/trunk/java/org/apache/catalina/connector

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2018-10-29 Thread Mark Thomas
On 29/10/2018 16:56, Mark Thomas wrote: On 29/10/2018 16:41, Rémy Maucherat wrote: On Mon, Oct 29, 2018 at 4:17 PM wrote: Author: markt Date: Mon Oct 29 15:17:01 2018 New Revision: 1845136 URL: http://svn.apache.org/viewvc?rev=1845136&view=rev Log: Refactor the Connector so that the port is

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2018-10-29 Thread Rémy Maucherat
On Mon, Oct 29, 2018 at 6:13 PM Mark Thomas wrote: > On 29/10/2018 16:56, Mark Thomas wrote: > > On 29/10/2018 16:41, Rémy Maucherat wrote: > >> On Mon, Oct 29, 2018 at 4:17 PM wrote: > >> > >>> Author: markt > >>> Date: Mon Oct 29 15:17:01 2018 > >>> New Revision: 1845136 > >>> > >>> URL: http:

Re: "Embedded" improvements

2018-10-29 Thread Mark Thomas
On 29/10/2018 10:52, Rémy Maucherat wrote: On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat wrote: Hi, I'm starting to review embedded. Maybe I won't make many changes in the end and won't need a separate API. However, I have another post 9.0.13 refactoring with a redoing of ConfigFileLoader

Re: "Embedded" improvements

2018-10-29 Thread Rémy Maucherat
On Mon, Oct 29, 2018 at 6:46 PM Mark Thomas wrote: > On 29/10/2018 10:52, Rémy Maucherat wrote: > > On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat wrote: > > > >> Hi, > >> > >> I'm starting to review embedded. Maybe I won't make many changes in the > >> end and won't need a separate API. > >> >

Re: "Embedded" improvements

2018-10-29 Thread Mark Thomas
On 29/10/2018 18:01, Rémy Maucherat wrote: On Mon, Oct 29, 2018 at 6:46 PM Mark Thomas wrote: On 29/10/2018 10:52, Rémy Maucherat wrote: On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat wrote: Hi, I'm starting to review embedded. Maybe I won't make many changes in the end and won't need

svn commit: r1845157 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ test/org/apache/catalina/tribes/group/interceptors/ webapps/docs/ webapps/docs/config/

2018-10-29 Thread schultz
Author: schultz Date: Mon Oct 29 18:11:57 2018 New Revision: 1845157 URL: http://svn.apache.org/viewvc?rev=1845157&view=rev Log: Add EncryptInterceptor for clustering. Added: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java tomcat/trunk/java/org/ap

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy et al, On 10/25/18 11:54, Rémy Maucherat wrote: > On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> Bump. >> >> I have a full

buildbot failure in on tomcat-trunk

2018-10-29 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3686 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1845158 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 18:35:36 2018 New Revision: 1845158 URL: http://svn.apache.org/viewvc?rev=1845158&view=rev Log: Add standard license header Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java Modified: tomcat/trunk/test/org/a

svn commit: r1845159 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 18:37:55 2018 New Revision: 1845159 URL: http://svn.apache.org/viewvc?rev=1845159&view=rev Log: Fix IDE/checkstyle warnings for imports Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java Modified: tomcat/trun

svn commit: r1845160 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 18:38:33 2018 New Revision: 1845160 URL: http://svn.apache.org/viewvc?rev=1845160&view=rev Log: Add @Override markers Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java Modified: tomcat/trunk/java/org/apache/cata

svn commit: r1845161 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 18:39:18 2018 New Revision: 1845161 URL: http://svn.apache.org/viewvc?rev=1845161&view=rev Log: Fix copy/paste javadoc errors Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java Modified: tomcat/trunk/java/org/apa

svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 18:40:16 2018 New Revision: 1845162 URL: http://svn.apache.org/viewvc?rev=1845162&view=rev Log: Fix redundant assignment warning. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java Modified: tomcat/trunk/java/org

Re: svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread Mark Thomas
On 29/10/2018 18:40, ma...@apache.org wrote: Author: markt Date: Mon Oct 29 18:40:16 2018 New Revision: 1845162 URL: http://svn.apache.org/viewvc?rev=1845162&view=rev Log: Fix redundant assignment warning. Chris, I think this is what you intended. Can you check my change here please? Thanks,

svn commit: r1845163 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread markt
Author: markt Date: Mon Oct 29 18:42:52 2018 New Revision: 1845163 URL: http://svn.apache.org/viewvc?rev=1845163&view=rev Log: Fix Javadoc warning Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java Modified: tomcat/trunk/java/org/apache/catali

buildbot success in on tomcat-trunk

2018-10-29 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3687 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

Re: svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 10/29/18 14:40, Mark Thomas wrote: > On 29/10/2018 18:40, ma...@apache.org wrote: >> Author: markt Date: Mon Oct 29 18:40:16 2018 New Revision: >> 1845162 >> >> URL: http://svn.apache.org/viewvc?rev=1845162&view=rev Log: Fix >> redundant a

Re: svn commit: r1845162 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-29 Thread Mark Thomas
On October 29, 2018 7:12:12 PM UTC, Christopher Schultz wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA256 > >Mark, > >On 10/29/18 14:40, Mark Thomas wrote: >> On 29/10/2018 18:40, ma...@apache.org wrote: >>> Author: markt Date: Mon Oct 29 18:40:16 2018 New Revision: >>> 1845162 >>> >>> UR

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2018-10-29 Thread Bill Barker
jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20181029.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPS

[GUMP@vmgump-vm3]: Project tomcat-native-1.2-1.1.0-configure (in module tomcat-native-1.2-1.1.0) failed

2018-10-29 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-native-1.2-1.1.0-configure has an issue affecting its community in

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2018-10-29 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. Th

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-10-29 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. Th

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-10-29 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. T

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2018-10-29 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th