svn commit: r1844818 - in /tomcat/trunk/java/org/apache/catalina: Host.java core/StandardHost.java

2018-10-25 Thread remm
Author: remm Date: Thu Oct 25 09:26:43 2018 New Revision: 1844818 URL: http://svn.apache.org/viewvc?rev=1844818&view=rev Log: Fix javadoc as XmlBase cannot be a URL (getConfigBaseFile, which is actually used, will only handle files). Modified: tomcat/trunk/java/org/apache/catalina/Host.java

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Bump. I have a full patch at this point (still without documentation), but this one includes resolution of the IV issue and also a set of unit tests which pass. I'd appreciate it if someone could install this into their cluster and see if it

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Rémy Maucherat
On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > Bump. > > I have a full patch at this point (still without documentation), but > this one includes resolution of the IV issue and also a set o

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/25/18 11:54, Rémy Maucherat wrote: > On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> Bump. >> >> I have a full patch

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Keiichi Fujino
Hi Chris! Because the argument svc is basically passed the value of SND_RX_SEQ (1) | Channel.SND_TX_SEQ (2) | MBR_RX_SEQ (4) | MBR_TX_SEQ (8), so you need to fix the following in start method. == if(Channel.SND_TX_SEQ == svc) -> if (Channel.SND_TX_SEQ == (svc & Channel.SND_TX_SEQ)) == In order