[Bug 62803] New: Tomcat Host Manager incorrectly saves connector with SSL configuration

2018-10-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62803 Bug ID: 62803 Summary: Tomcat Host Manager incorrectly saves connector with SSL configuration Product: Tomcat 9 Version: 9.0.12 Hardware: PC OS: Linux

[Bug 62803] Tomcat Host Manager incorrectly saves connector with SSL configuration

2018-10-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62803 Michal Karm Babacek changed: What|Removed |Added CC||michal.baba...@gmail.com -- You

[Bug 62799] mod_jk doesn't handle the EINPROGRESS state appropriately for non-blocking sockets.

2018-10-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62799 --- Comment #8 from m...@blackmans.org --- (In reply to Rainer Jung from comment #7) > > For the particular > > log messages above, the connection is showing failed due to EINPROGRESS long > > before the 5 second expiry, usually within millisec

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Mark Thomas
On 04/10/18 22:07, isa...@apache.org wrote: > Author: isapir > Date: Thu Oct 4 21:07:54 2018 > New Revision: 1842849 > > URL: http://svn.apache.org/viewvc?rev=1842849&view=rev > Log: > System.load() expects absolute path. Remember to consider whether or not any changes you make to trunk should b

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Rémy Maucherat
On Fri, Oct 5, 2018 at 11:40 AM Mark Thomas wrote: > On 04/10/18 22:07, isa...@apache.org wrote: > > Author: isapir > > Date: Thu Oct 4 21:07:54 2018 > > New Revision: 1842849 > > > > URL: http://svn.apache.org/viewvc?rev=1842849&view=rev > > Log: > > System.load() expects absolute path. > > Rem

svn commit: r1842878 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ test/org/apache/coyote/http11/ webapps/docs/

2018-10-05 Thread markt
Author: markt Date: Fri Oct 5 10:07:49 2018 New Revision: 1842878 URL: http://svn.apache.org/viewvc?rev=1842878&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 Do not reject requests with an empty HTTP Host header. Such requests are unusual but not invalid. Patch provided

[GitHub] tomcat issue #124: Allow empty 'Host' HTTP header

2018-10-05 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/124 Nice catch with handling the port. The patch I had come up with missed that. I refactored populateHost() as it bugged me to set the server name one way (that might throw an IOE and break the req

[GitHub] tomcat pull request #124: Allow empty 'Host' HTTP header

2018-10-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/124 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1842879 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ test/org/apache/coyote/http11/ webapps/docs/

2018-10-05 Thread markt
Author: markt Date: Fri Oct 5 10:08:37 2018 New Revision: 1842879 URL: http://svn.apache.org/viewvc?rev=1842879&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 Do not reject requests with an empty HTTP Host header. Such requests are unusual but not invalid. Patch provided

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Mark Thomas
On 05/10/18 10:42, Rémy Maucherat wrote: > On Fri, Oct 5, 2018 at 11:40 AM Mark Thomas wrote: > >> On 04/10/18 22:07, isa...@apache.org wrote: >>> Author: isapir >>> Date: Thu Oct 4 21:07:54 2018 >>> New Revision: 1842849 >>> >>> URL: http://svn.apache.org/viewvc?rev=1842849&view=rev >>> Log: >>

svn commit: r1842885 - in /tomcat/tc7.0.x/trunk: java/org/apache/coyote/AbstractProcessor.java java/org/apache/coyote/ajp/AbstractAjpProcessor.java java/org/apache/coyote/http11/AbstractHttp11Processo

2018-10-05 Thread markt
Author: markt Date: Fri Oct 5 10:38:52 2018 New Revision: 1842885 URL: http://svn.apache.org/viewvc?rev=1842885&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 Do not reject requests with an empty HTTP Host header. Such requests are unusual but not invalid. Patch provided

[Bug 62739] Tomcat should allow blank Host header

2018-10-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1842886 - /tomcat/trunk/res/checkstyle/checkstyle.xml

2018-10-05 Thread markt
Author: markt Date: Fri Oct 5 10:40:39 2018 New Revision: 1842886 URL: http://svn.apache.org/viewvc?rev=1842886&view=rev Log: Note how many need braces errors we have Modified: tomcat/trunk/res/checkstyle/checkstyle.xml Modified: tomcat/trunk/res/checkstyle/checkstyle.xml URL: http://svn.a

svn commit: r1842887 - /tomcat/trunk/res/checkstyle/checkstyle.xml

2018-10-05 Thread markt
Author: markt Date: Fri Oct 5 10:42:25 2018 New Revision: 1842887 URL: http://svn.apache.org/viewvc?rev=1842887&view=rev Log: Operator wrap errors are down to ~1100 Modified: tomcat/trunk/res/checkstyle/checkstyle.xml Modified: tomcat/trunk/res/checkstyle/checkstyle.xml URL: http://svn.apa

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio (in module tomcat-8.5.x) failed

2018-10-05 Thread Bill Barker
ic/workspace/openssl-1.1.1/dest-20181005/bin/openssl -Dexecu te.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true -Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Igal Sapir
On 10/5/2018 2:40 AM, Mark Thomas wrote: On 04/10/18 22:07, isa...@apache.org wrote: Author: isapir Date: Thu Oct 4 21:07:54 2018 New Revision: 1842849 URL: http://svn.apache.org/viewvc?rev=1842849&view=rev Log: System.load() expects absolute path. Remember to consider whether or not any chan

svn commit: r1842950 - in /tomcat/trunk: java/org/apache/catalina/storeconfig/ webapps/docs/

2018-10-05 Thread remm
Author: remm Date: Fri Oct 5 17:29:22 2018 New Revision: 1842950 URL: http://svn.apache.org/viewvc?rev=1842950&view=rev Log: 62803: Fix SSL connectors handling in storeconfig. The attribute duplication is indeed extreme. Added: tomcat/trunk/java/org/apache/catalina/storeconfig/CertificateS

svn commit: r1842956 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/storeconfig/ webapps/docs/

2018-10-05 Thread remm
Author: remm Date: Fri Oct 5 17:57:38 2018 New Revision: 1842956 URL: http://svn.apache.org/viewvc?rev=1842956&view=rev Log: 62803: Fix SSL connectors handling in storeconfig. The attribute duplication is indeed extreme. Added: tomcat/tc8.5.x/trunk/java/org/apache/catalina/storeconfig/Cert

Re: SSL Unit Tests Failing

2018-10-05 Thread Igal Sapir
On 10/4/2018 11:34 PM, Rainer Jung wrote: Am 05.10.2018 um 00:03 schrieb Igal Sapir:> And with tcnative I get: 04-Oct-2018 14:52:14.231 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testOpenSSLConfCmdCipher] 04-Oct-2018 14:52:14.434 INFO [main] org.apache.

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Igal Sapir
On 10/5/2018 3:22 AM, Mark Thomas wrote: On 05/10/18 10:42, Rémy Maucherat wrote: On Fri, Oct 5, 2018 at 11:40 AM Mark Thomas wrote: The Tomcat style is to always use { and } even for one line for clarity. Due to the age of the code base, there are a mix of styles. Generally, we try and move

RE: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Caldarale, Charles R
> From: Igal Sapir [mailto:isa...@apache.org] > Subject: Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java > test/org/apache/tomcat/util/net/TesterSupport.java > test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java > How do you feel about aligning the

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 10/5/18 06:22, Mark Thomas wrote: > On 05/10/18 10:42, Rémy Maucherat wrote: >> On Fri, Oct 5, 2018 at 11:40 AM Mark Thomas >> wrote: >> >>> On 04/10/18 22:07, isa...@apache.org wrote: Author: isapir Date: Thu Oct 4 21:07:54 2018 Ne

[Bug 62803] Tomcat Host Manager incorrectly saves connector with SSL configuration

2018-10-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62803 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio (in module tomcat-8.5.x) failed

2018-10-05 Thread Bill Barker
ic/workspace/openssl-1.1.1/dest-20181005/bin/openssl -Dexecu te.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true -Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio2 (in module tomcat-8.5.x) failed

2018-10-05 Thread Bill Barker
ath=/srv/gump/public/workspace/openssl-1.1.1/dest-20181005/bin/openssl -Dexe cute.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true -Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-apr (in module tomcat-8.5.x) failed

2018-10-05 Thread Bill Barker
pse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-1.2-1.1.1/dest-20181005/lib -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp

Re: [VOTE] Release JK 1.2.46

2018-10-05 Thread Rainer Jung
Am 01.10.2018 um 17:30 schrieb Mark Thomas: Tag: http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_46/ Source: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ This is a maintenance release with a handful of bug fixes (compared to 1.2.44) and some clean-up. It also includes

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio (in module tomcat-8.5.x) failed

2018-10-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-test-nio has an issue affecting its community integration.

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio2 (in module tomcat-8.5.x) failed

2018-10-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-test-nio2 has an issue affecting its community integration

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-10-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. T

[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-apr (in module tomcat-8.5.x) failed

2018-10-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-test-apr has an issue affecting its community integration.