[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #24 from ZhiFeng Hu --- How to remove the validation for host name? I want to use any string as the host name . Would you please let us choice ? -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #25 from Mark Thomas --- The Host validation is not optional. It is a specification requirement. The changes discussed in comment #14 and comment #15 (using the same rules for the final segment as the other segments) have been made

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #26 from ZhiFeng Hu --- Though it was a specification. why not gave us an setting or configuration to disable the check ? Gave us a switch please. or we can not upgrade our projects to latest tomcat. or we should have to switch to

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #27 from Mark Thomas --- Simply wait (until early next month) for next release round and upgrade then. -- You are receiving this mail because: You are the assignee for the bug. -

svn commit: r1832105 - in /tomcat/trunk: java/org/apache/catalina/valves/ java/org/apache/tomcat/util/net/ test/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2018-05-23 Thread markt
Author: markt Date: Wed May 23 14:23:01 2018 New Revision: 1832105 URL: http://svn.apache.org/viewvc?rev=1832105&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=51497 Add an option, ipv6Canonical, to the AccessLogValve that causes IPv6 addresses to be output in canonical form def

[Bug 51497] Use canonical IPv6 text representation in logs

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51497 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

buildbot failure in on tomcat-trunk

2018-05-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3296 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1832106 - /tomcat/trunk/java/org/apache/tomcat/util/net/IPv6Utils.java

2018-05-23 Thread markt
Author: markt Date: Wed May 23 14:36:29 2018 New Revision: 1832106 URL: http://svn.apache.org/viewvc?rev=1832106&view=rev Log: Fix Javadoc Modified: tomcat/trunk/java/org/apache/tomcat/util/net/IPv6Utils.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/IPv6Utils.java URL: http://

svn commit: r1832108 - in /tomcat/trunk: java/org/apache/catalina/filters/ java/org/apache/catalina/loader/ java/org/apache/catalina/mapper/ java/org/apache/catalina/security/ java/org/apache/catalina

2018-05-23 Thread markt
Author: markt Date: Wed May 23 14:47:45 2018 New Revision: 1832108 URL: http://svn.apache.org/viewvc?rev=1832108&view=rev Log: Fix some Javadoc errors reported by Eclipse. Modified: tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java tomcat/trunk/java/org/apache/catalina/filters

buildbot success in on tomcat-trunk

2018-05-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3297 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

[Bug 51587] Implement status and uptime commands

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51587 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Bug 51953] Proposal: netmask filtering valve and filter [PATCH]

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #24 from Mark Thomas --- It has been rather too long since this was last looked at. Apologies for that. I'm looking at this now. The good news is that the patch applies cleanly to trunk (9.0.x). There are some compilation issues to

[Bug 62391] Unable to Install Windows Service with Server JRE

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62391 --- Comment #2 from Christopher Schultz --- IIRC, java.exe will always open a command-prompt to run the command. That's why javaw.exe exists. For a "server install", does that mean that a console needs to be available because java.exe will run

[Bug 62391] Unable to Install Windows Service with Server JRE

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62391 --- Comment #3 from Mark Thomas --- Take a look at the svn history. As far as I can tell, javaw.exe has never been used. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 62391] Unable to Install Windows Service with Server JRE

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62391 --- Comment #4 from Igal Sapir --- > IIRC, java.exe will always open a command-prompt to run the command. That's > why javaw.exe exists. Right, but that is for Windowed, GUI applications where you don't want a console window to open with the

[Bug 62404] New: Visibility issue on field org.apache.catalina.util.LifecycleBase.throwOnFailure

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62404 Bug ID: 62404 Summary: Visibility issue on field org.apache.catalina.util.LifecycleBase.throwOnFailure Product: Tomcat 9 Version: unspecified Hardware: PC Sta

[Bug 62404] Visibility issue on field org.apache.catalina.util.LifecycleBase.throwOnFailure

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62404 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas ---

[Bug 62404] Visibility issue on field org.apache.catalina.util.LifecycleBase.throwOnFailure

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62404 --- Comment #2 from Laszlo Magyar --- It seems to me this class was thread safe before this field was added. I just thought it is a bug to violate this. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 62391] Unable to Install Windows Service with Server JRE

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62391 --- Comment #5 from Igal Sapir --- (In reply to Mark Thomas from comment #1) > > 2. Does the Windows installer have a similar problem? I just ran the Windows Service Installer executable of Tomcat 9.0.8 on Windows 10 and pointed it to the Ser

svn commit: r1832124 - in /tomcat/trunk: java/org/apache/catalina/util/LocalStrings.properties java/org/apache/catalina/util/NetMask.java test/org/apache/catalina/util/TestNetMask.java

2018-05-23 Thread markt
Author: markt Date: Wed May 23 20:33:35 2018 New Revision: 1832124 URL: http://svn.apache.org/viewvc?rev=1832124&view=rev Log: First part of implementation for BZ 51953 Add a NetMask utility class and some test cases Added: tomcat/trunk/java/org/apache/catalina/util/NetMask.java (with props

[Bug 51953] Proposal: netmask filtering valve and filter [PATCH]

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51953 --- Comment #25 from Mark Thomas --- I've just committed the NetMask class and associated test case. Can I just say "Nice code". An elegant solution and very clearly commented. -- You are receiving this mail because: You are the assignee for

Re: svn commit: r1832124 - in /tomcat/trunk: java/org/apache/catalina/util/LocalStrings.properties java/org/apache/catalina/util/NetMask.java test/org/apache/catalina/util/TestNetMask.java

2018-05-23 Thread Mark Thomas
On 23/05/18 21:33, ma...@apache.org wrote: > Author: markt > Date: Wed May 23 20:33:35 2018 > New Revision: 1832124 > > URL: http://svn.apache.org/viewvc?rev=1832124&view=rev > Log: > First part of implementation for BZ 51953 > Add a NetMask utility class and some test cases The code looks good t

svn commit: r1832125 - /tomcat/trunk/test/org/apache/catalina/util/TestNetMask.java

2018-05-23 Thread markt
Author: markt Date: Wed May 23 20:46:01 2018 New Revision: 1832125 URL: http://svn.apache.org/viewvc?rev=1832125&view=rev Log: Few more test cases Modified: tomcat/trunk/test/org/apache/catalina/util/TestNetMask.java Modified: tomcat/trunk/test/org/apache/catalina/util/TestNetMask.java URL:

svn commit: r1832127 - /tomcat/trunk/java/org/apache/catalina/util/NetMask.java

2018-05-23 Thread markt
Author: markt Date: Wed May 23 20:48:14 2018 New Revision: 1832127 URL: http://svn.apache.org/viewvc?rev=1832127&view=rev Log: Fix import Modified: tomcat/trunk/java/org/apache/catalina/util/NetMask.java Modified: tomcat/trunk/java/org/apache/catalina/util/NetMask.java URL: http://svn.apach

svn commit: r1832129 - /tomcat/trunk/test/org/apache/catalina/util/TestNetMask.java

2018-05-23 Thread markt
Author: markt Date: Wed May 23 20:57:55 2018 New Revision: 1832129 URL: http://svn.apache.org/viewvc?rev=1832129&view=rev Log: Additional test cases to get to 100% code coverage of the new utility class. Modified: tomcat/trunk/test/org/apache/catalina/util/TestNetMask.java Modified: tomcat/t

[Bug 62405] New: Add Rereadable Request Filter

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62405 Bug ID: 62405 Summary: Add Rereadable Request Filter Product: Tomcat 9 Version: unspecified Hardware: PC Status: NEW Severity: enhancement Priority: P2

[Bug 62405] Add Rereadable Request Filter

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62405 George Stanchev changed: What|Removed |Added OS||All --- Comment #1 from George Stanc

[Bug 62405] Add Rereadable Request Filter

2018-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62405 --- Comment #2 from Igal Sapir --- (In reply to George Stanchev from comment #1) > I am just curious, what happens if a bad actor decides to send a 10 gig > request and the filter is engaged. Obviously you have to read the whole > thing to memo