[Bug 62395] After applying 7.0.88 the minSpareThreads setting does not appear to be implemented

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62395 --- Comment #4 from Kim Walsh --- Hi Mark, I'm not sure how the users list works - is there a page that gives me information? This is clearly a change in behaviour - could it be that threads are returned to the pool much quicker than they use

[Bug 60362] Missing reason phrase in response

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #77 from Julian Reschke --- (In reply to Ralf Hauser from comment #72) > First, there are many error conditions for which no precise 4xx or 5xx code > is defined. So in this way, the reason might be helpful. > > While I understand

svn commit: r1832017 - /tomcat/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 11:07:29 2018 New Revision: 1832017 URL: http://svn.apache.org/viewvc?rev=1832017&view=rev Log: Refactor to avoid SpotBugs warning Modified: tomcat/trunk/test/org/apache/catalina/core/TestSwallowAbortedUploads.java Modified: tomcat/trunk/test/org/apache/catali

svn commit: r1832018 - /tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 11:12:25 2018 New Revision: 1832018 URL: http://svn.apache.org/viewvc?rev=1832018&view=rev Log: SpotBugs: simplify to avoid warning Modified: tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java Modified: tomcat/trunk/t

Re: [Git migration] Old git repositories

2018-05-22 Thread Coty Sutherland
On Mon, May 21, 2018 at 3:57 PM, Mark Thomas wrote: > On 04/05/18 10:22, Konstantin Kolinko wrote: > > 2018-04-30 23:48 GMT+03:00 Mark Thomas : > >> The current plan is to merge all of the existing branches into a single > >> Git repo. This will be mirrored at GitHub under apache/tomcat. This is

svn commit: r1832019 - /tomcat/trunk/test/org/apache/catalina/tribes/test/transport/SocketNioReceive.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 11:29:41 2018 New Revision: 1832019 URL: http://svn.apache.org/viewvc?rev=1832019&view=rev Log: SpotBugs: Remove unnecessary sync Modified: tomcat/trunk/test/org/apache/catalina/tribes/test/transport/SocketNioReceive.java Modified: tomcat/trunk/test/org/apach

svn commit: r1832021 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-05-22 Thread markt
Author: markt Date: Tue May 22 12:59:53 2018 New Revision: 1832021 URL: http://svn.apache.org/viewvc?rev=1832021&view=rev Log: SpotBugs: o.a.catalina false positives in test cases Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-

svn commit: r1832024 - /tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 13:10:05 2018 New Revision: 1832024 URL: http://svn.apache.org/viewvc?rev=1832024&view=rev Log: Silence a SpotBugs nag Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java Modified: tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java

buildbot failure in on tomcat-trunk

2018-05-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3287 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1832026 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2AsyncParser.java LocalStrings.properties

2018-05-22 Thread remm
Author: remm Date: Tue May 22 13:36:33 2018 New Revision: 1832026 URL: http://svn.apache.org/viewvc?rev=1832026&view=rev Log: Add exception message and validate offset as well. Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncParser.java tomcat/trunk/java/org/apache/coyote/ht

svn commit: r1832030 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-05-22 Thread markt
Author: markt Date: Tue May 22 13:46:08 2018 New Revision: 1832030 URL: http://svn.apache.org/viewvc?rev=1832030&view=rev Log: SpotBugs: o.a.[coyote|jasper] false positives in test cases Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter

buildbot success in on tomcat-trunk

2018-05-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3288 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

[Bug 62398] New: HTTP Error - Error parsing HTTP request header

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62398 Bug ID: 62398 Summary: HTTP Error - Error parsing HTTP request header Product: Tomcat 8 Version: 8.5.31 Hardware: PC Status: NEW Severity: major Priority: P2

[Bug 62273] Add support for alternate URL specification

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62273 Mark Thomas changed: What|Removed |Added CC||matthewd@paprika-software.c

[Bug 62398] HTTP Error - Error parsing HTTP request header

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62398 Mark Thomas changed: What|Removed |Added OS||All Status|NEW

[Bug 62392] Modify Windows startup command from Start to Run

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62392 --- Comment #2 from Christopher Schultz --- (In reply to Mark Thomas from comment #1) > The meaning of "start" and "run" have been fixed in Tomcat for as long as I > can remember. Changing them at this point is going to cause confusion. +1, if

Changes to hostname parsing in HttpParser breaks internationalized ccTLDs

2018-05-22 Thread Tom Yue
Hi all, So we started getting 400 responses to all requests after upgrading our Tomcat to 8.5.31. After some head-scratching, I finally found that HttpParser now rejects a hostname as invalid if it does not end with an _alphabetic_ TLD - no hyphens, no numerics. And apparently the behavior is not

Re: Changes to hostname parsing in HttpParser breaks internationalized ccTLDs

2018-05-22 Thread Mark Thomas
On 22/05/18 16:47, Tom Yue wrote: > Hi all, > > So we started getting 400 responses to all requests after upgrading > our Tomcat to 8.5.31. After some head-scratching, I finally found that > HttpParser now rejects a hostname as invalid if it does not end with > an _alphabetic_ TLD - no hyphens, no

svn commit: r1832043 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 16:28:19 2018 New Revision: 1832043 URL: http://svn.apache.org/viewvc?rev=1832043&view=rev Log: Spotbugs: remove unnecessary code Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified: tomcat/trunk/test/org/apache/catalina/startup/Tes

svn commit: r1832044 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-05-22 Thread markt
Author: markt Date: Tue May 22 16:29:03 2018 New Revision: 1832044 URL: http://svn.apache.org/viewvc?rev=1832044&view=rev Log: SpotBugs: False positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://

svn commit: r1832045 - /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/JmxPasswordTest.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 16:33:32 2018 New Revision: 1832045 URL: http://svn.apache.org/viewvc?rev=1832045&view=rev Log: SpotBugs: Use non-static field for MBean name Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/JmxPasswordTest.java Modified: tom

svn commit: r1832047 - /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestValidationQueryTimeout.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 16:48:04 2018 New Revision: 1832047 URL: http://svn.apache.org/viewvc?rev=1832047&view=rev Log: SpotBugs: Value is only read once so treat it as a constant. Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestValidationQueryTi

svn commit: r1832048 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2018-05-22 Thread markt
Author: markt Date: Tue May 22 16:48:21 2018 New Revision: 1832048 URL: http://svn.apache.org/viewvc?rev=1832048&view=rev Log: Final rank 17 false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: htt

svn commit: r1832055 - in /tomcat/trunk: java/org/apache/coyote/http2/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/t

2018-05-22 Thread markt
Author: markt Date: Tue May 22 18:54:04 2018 New Revision: 1832055 URL: http://svn.apache.org/viewvc?rev=1832055&view=rev Log: SpotBugs: Make inner classes static where possible Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java tomcat/trunk/modules/jdbc-po

svn commit: r1832059 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 19:28:48 2018 New Revision: 1832059 URL: http://svn.apache.org/viewvc?rev=1832059&view=rev Log: SpotBugs: Fix a couple of minor issues Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationPushBuilder.java Modified: tomcat/trunk/java/org/apache/catali

svn commit: r1832060 - /tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 19:32:37 2018 New Revision: 1832060 URL: http://svn.apache.org/viewvc?rev=1832060&view=rev Log: SpotBugs: Fix a couple of minor issues Modified: tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java Modified: tomcat/trunk/java/org/apache/catalina/filter

svn commit: r1832061 - /tomcat/trunk/java/org/apache/catalina/ha/ClusterListener.java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 19:35:01 2018 New Revision: 1832061 URL: http://svn.apache.org/viewvc?rev=1832061&view=rev Log: SpotBugs: Remove unnecessary code Modified: tomcat/trunk/java/org/apache/catalina/ha/ClusterListener.java Modified: tomcat/trunk/java/org/apache/catalina/ha/ClusterL

svn commit: r1832062 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java test/java/org/apache/tomcat/jdbc/test/TestAsyncQueue.java test/java

2018-05-22 Thread markt
Author: markt Date: Tue May 22 20:10:16 2018 New Revision: 1832062 URL: http://svn.apache.org/viewvc?rev=1832062&view=rev Log: Remove unused code. Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java tomcat/trunk/modules/jdbc

[Bug 62399] New: always return 400 when use a domain name due can not read serverName (virtualhost)

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62399 Bug ID: 62399 Summary: always return 400 when use a domain name due can not read serverName (virtualhost) Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC

[Bug 62399] always return 400 when use a domain name due can not read serverName (virtualhost)

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62399 Phillip Webb changed: What|Removed |Added CC||pw...@pivotal.io OS|

svn commit: r1832069 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

2018-05-22 Thread kfujino
Author: kfujino Date: Wed May 23 02:31:00 2018 New Revision: 1832069 URL: http://svn.apache.org/viewvc?rev=1832069&view=rev Log: Simplify the code. remove unnecessary code. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Modified: tomcat/trunk/java/org/apache/cat

svn commit: r1832070 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

2018-05-22 Thread kfujino
Author: kfujino Date: Wed May 23 02:31:59 2018 New Revision: 1832070 URL: http://svn.apache.org/viewvc?rev=1832070&view=rev Log: Simplify the code. remove unnecessary code. Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Modified: tomcat/tc8.5.x/trunk/ja

[GitHub] tomcat pull request #113: Modify Windows startup command from start to run

2018-05-22 Thread isapir
Github user isapir closed the pull request at: https://github.com/apache/tomcat/pull/113 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #113: Modify Windows startup command from start to run

2018-05-22 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/113 Closing per comments in the BZ ticket --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-ma

[GitHub] tomcat pull request #112: Fix BZ Bug 62391

2018-05-22 Thread isapir
Github user isapir closed the pull request at: https://github.com/apache/tomcat/pull/112 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #112: Fix BZ Bug 62391

2018-05-22 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/112 Closing on Github since I can now patch SVN directly if there is no objection to this change --- - To unsubscribe, e-mail: dev-uns

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2018-05-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community integration.

[Bug 62399] always return 400 when use a domain name due can not read serverName (virtualhost)

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62399 Mark Thomas changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 Mark Thomas changed: What|Removed |Added CC||hufeng1...@gmail.com --- Comment #23 fro

[Bug 62391] Unable to Install Windows Service with Server JRE

2018-05-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62391 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas ---