svn commit: r1829825 - /tomcat/trunk/MERGE.txt

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 07:40:52 2018 New Revision: 1829825 URL: http://svn.apache.org/viewvc?rev=1829825&view=rev Log: Fix typo Modified: tomcat/trunk/MERGE.txt Modified: tomcat/trunk/MERGE.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/MERGE.txt?rev=1829825&r1=1829824&r2=182982

svn commit: r1829830 - in /tomcat/trunk: java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ webapps/docs/

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 08:12:37 2018 New Revision: 1829830 URL: http://svn.apache.org/viewvc?rev=1829830&view=rev Log: Update the internal fork of Apache Commons BCEL to r1829827 to add early access Java 11 support to the annotation scanning code. Modified: tomcat/trunk/java/org/apac

svn commit: r1829831 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ webapps/docs/

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 08:14:37 2018 New Revision: 1829831 URL: http://svn.apache.org/viewvc?rev=1829831&view=rev Log: Update the internal fork of Apache Commons BCEL to r1829827 to add early access Java 11 support to the annotation scanning code. Modified: tomcat/tc8.5.x/trunk/ (p

svn commit: r1829832 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ webapps/docs/

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 08:15:16 2018 New Revision: 1829832 URL: http://svn.apache.org/viewvc?rev=1829832&view=rev Log: Update the internal fork of Apache Commons BCEL to r1829827 to add early access Java 11 support to the annotation scanning code. Modified: tomcat/tc7.0.x/trunk/ (p

[Bug 62140] catalina.sh should document the verbs it accepts as command-line arguments

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62140 mhkarunarat...@gmail.com changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving th

[Bug 62287] ValueExpressionImpl#equals is wrong

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 --- Comment #1 from Mark Thomas --- Given the current implementation, the odds of a hash collision look to be very small. The probably explains why the code has been like this since 6.0.x without any bugs reported. That said, the Javadoc for #h

svn commit: r1829879 - in /tomcat/trunk: java/org/apache/el/ValueExpressionImpl.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 13:24:59 2018 New Revision: 1829879 URL: http://svn.apache.org/viewvc?rev=1829879&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 Do not rely on hash codes to test instances of ValueExpressionImpl for equality. Patch provided by Mark Struberg.

svn commit: r1829880 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/el/ValueExpressionImpl.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 13:26:02 2018 New Revision: 1829880 URL: http://svn.apache.org/viewvc?rev=1829880&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 Do not rely on hash codes to test instances of ValueExpressionImpl for equality. Patch provided by Mark Struberg.

svn commit: r1829882 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/el/ValueExpressionImpl.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 13:34:24 2018 New Revision: 1829882 URL: http://svn.apache.org/viewvc?rev=1829882&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 Do not rely on hash codes to test instances of ValueExpressionImpl for equality. Patch provided by Mark Struberg.

svn commit: r1829884 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/ValueExpressionImpl.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 13:35:00 2018 New Revision: 1829884 URL: http://svn.apache.org/viewvc?rev=1829884&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 Do not rely on hash codes to test instances of ValueExpressionImpl for equality. Patch provided by Mark Struberg.

[Bug 62287] ValueExpressionImpl#equals is wrong

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

buildbot failure in on tomcat-trunk

2018-04-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3202 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

[Bug 62301] IOException Unable to unwrap data in versions after

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62301 --- Comment #2 from Mark Thomas --- I'm seeing some failures with the Autobahn test suite and a clean build of Tomcat trunk. I'm investigating... -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 62301] IOException Unable to unwrap data in versions after

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62301 --- Comment #3 from Mark Thomas --- Failures appear to be related to r1807686 Still investigating... -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 62287] ValueExpressionImpl#equals is wrong

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 --- Comment #3 from Christopher Schultz --- It's a little late, but I have a few comments about the patch. 1. There is no reason to check the hashcode if you are going to call .equals. Presumably, Node.equals() knows the best way to compare mo

[Bug 62140] catalina.sh should document the verbs it accepts as command-line arguments

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62140 --- Comment #2 from Christopher Schultz --- Thank you for your interest. Please post a message to the Tomcat users' mailing list (or dev mailing list) to get more help. We prefer not to use Bugzilla as a support forum for e.g. how to check-out

[Bug 62287] ValueExpressionImpl#equals is wrong

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 --- Comment #4 from Mark Thomas --- (In reply to Christopher Schultz from comment #3) > It's a little late, but I have a few comments about the patch. > > 1. There is no reason to check the hashcode if you are going to call > .equals. Presumab

[Bug 62287] ValueExpressionImpl#equals is wrong

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 --- Comment #5 from Christopher Schultz --- I would actually prefer to drop the hashCode because: 1. It complicates code unnecessarily (!) 2. It makes a guess about the implementation of Node.equals() that a hash-code check is faster than any

[Bug 62287] ValueExpressionImpl#equals is wrong

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 --- Comment #6 from Mark Thomas --- No objection here. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tom

svn commit: r1829915 - in /tomcat/trunk: java/org/apache/tomcat/websocket/PerMessageDeflate.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 18:46:04 2018 New Revision: 1829915 URL: http://svn.apache.org/viewvc?rev=1829915&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62301 Correct a regression in the fix for bz 61491 that didn't correctly handle a final empty message part in all circu

svn commit: r1829916 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 18:47:18 2018 New Revision: 1829916 URL: http://svn.apache.org/viewvc?rev=1829916&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62301 Correct a regression in the fix for bz 61491 that didn't correctly handle a final empty message part in all circu

svn commit: r1829917 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 18:47:48 2018 New Revision: 1829917 URL: http://svn.apache.org/viewvc?rev=1829917&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62301 Correct a regression in the fix for bz 61491 that didn't correctly handle a final empty message part in all circu

svn commit: r1829918 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 18:48:26 2018 New Revision: 1829918 URL: http://svn.apache.org/viewvc?rev=1829918&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62301 Correct a regression in the fix for bz 61491 that didn't correctly handle a final empty message part in all circu

[Bug 62301] IOException Unable to unwrap data in versions after

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62301 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

buildbot success in on tomcat-trunk

2018-04-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3203 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

Re: [ANN] Apache Tomcat 7.0.86 released

2018-04-23 Thread Mark Thomas
On 21/04/18 11:28, Konstantin Kolinko wrote: > 2018-04-20 13:45 GMT+03:00 Mark Thomas : >> On 20/04/18 07:28, Konstantin Kolinko wrote: >>> There is a regression in handling of DataSource resources that do not >>> specify a factory. >>> >>> http://bz.apache.org/bugzilla/show_bug.cgi?id=62316 >>> >>

svn commit: r1829924 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 19:33:49 2018 New Revision: 1829924 URL: http://svn.apache.org/viewvc?rev=1829924&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62309 Fix a SecurityException when using JASPIC under a SecurityManager when authentication is not mandatory. Modified

[Bug 62309] JASPIC with Security Manager

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62309 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1829925 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 19:34:47 2018 New Revision: 1829925 URL: http://svn.apache.org/viewvc?rev=1829925&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62309 Fix a SecurityException when using JASPIC under a SecurityManager when authentication is not mandatory. Modified

svn commit: r1829934 - in /tomcat/trunk: java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/changelog.xml

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 19:48:11 2018 New Revision: 1829934 URL: http://svn.apache.org/viewvc?rev=1829934&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62297 Enable the CrawlerSessionManagerValve to correctly handle bots that crawl multiple hosts and/or web applications

svn commit: r1829935 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/cha

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 19:52:12 2018 New Revision: 1829935 URL: http://svn.apache.org/viewvc?rev=1829935&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62297 Enable the CrawlerSessionManagerValve to correctly handle bots that crawl multiple hosts and/or web applications

svn commit: r1829936 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/cha

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 19:53:21 2018 New Revision: 1829936 URL: http://svn.apache.org/viewvc?rev=1829936&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62297 Enable the CrawlerSessionManagerValve to correctly handle bots that crawl multiple hosts and/or web applications

svn commit: r1829937 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/cha

2018-04-23 Thread markt
Author: markt Date: Mon Apr 23 19:56:49 2018 New Revision: 1829937 URL: http://svn.apache.org/viewvc?rev=1829937&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62297 Enable the CrawlerSessionManagerValve to correctly handle bots that crawl multiple hosts and/or web applications

[Bug 62297] Add support for multiple hosts/contexts in CrawlerSessionManagerValve

2018-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62297 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW