On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote:
> Hi,
>
> I've been looking at how we close NIO channels and I think there is an
> opportunity for a little clean-up that, in turn, may allow a little
> de-duplication between NIO and NIO2.
>
> Currently, in various places in the codebase we cl
On 11/01/18 23:12, Christopher Schultz wrote:
> If performance is a consideration, then most of the calls to write()
> should probably be calls to headerBuffer.put() because we can be
> (reasonably?) sure that writing "HTTP/1.1 " to the output buffer isn't
> going to overflow the buffer. Likewis
On 12/01/18 08:04, Rémy Maucherat wrote:
> On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote:
>
>> Hi,
>>
>> I've been looking at how we close NIO channels and I think there is an
>> opportunity for a little clean-up that, in turn, may allow a little
>> de-duplication between NIO and NIO2.
>>
>
On 18/12/17 09:56, Rory O'Donnell wrote:
> *Feedback* - If you have suggestions or encounter bugs, please submit
> them using the usual Java SE bug-reporting channel.
> Be sure to include complete version information from the output of the
> |java --version| command.
Hi,
I did some testing on
https://bz.apache.org/bugzilla/show_bug.cgi?id=61992
Bug ID: 61992
Summary: DOS after "Error parsing HTTP request header" message
Product: Tomcat 7
Version: 7.0.82
Hardware: PC
OS: Linux
Status: NEW
Severi
https://bz.apache.org/bugzilla/show_bug.cgi?id=61992
Mark Thomas changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #1 from Mark Thomas
https://bz.apache.org/bugzilla/show_bug.cgi?id=61992
--- Comment #2 from Mark Thomas ---
For completeness:
$telnet localhost 8080
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
GET/ / HTTP/1.1
HTTP/1.1 400 Bad Request
Server: Apache-Coyote/1.1
Transfer-Encoding: chunked
D
Author: remm
Date: Fri Jan 12 11:19:37 2018
New Revision: 1820963
URL: http://svn.apache.org/viewvc?rev=1820963&view=rev
Log:
Fix order issue in the sendfile setup code.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
tomcat/trunk/webapps/docs/changelog.xml
Modif
Author: remm
Date: Fri Jan 12 11:21:41 2018
New Revision: 1820964
URL: http://svn.apache.org/viewvc?rev=1820964&view=rev
Log:
Fix remote host code with the APR connector. This issue is found only in this
branch and connector.
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/Http1
Hi Mark,
Thanks for the feedback, I'll pass it on.
Rgds,Rory
On 12/01/2018 10:20, Mark Thomas wrote:
On 18/12/17 09:56, Rory O'Donnell wrote:
*Feedback* - If you have suggestions or encounter bugs, please submit
them using the usual Java SE bug-reporting channel.
Be sure to include comple
The Buildbot has detected a restored build on builder tomcat-8-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/1220
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler
https://bz.apache.org/bugzilla/show_bug.cgi?id=61993
Bug ID: 61993
Summary: org.apache.tomcat.util.ByteChunk throws NegativeArray
SizeException
Product: Tomcat 7
Version: 7.0.82
Hardware: PC
OS: Linux
Hi Mark
How serious is this issue ?
It's logged with a low priority, it might have to wait for JDK 11.
Rgds,Rory
On 12/01/2018 11:39, Rory O'Donnell wrote:
Hi Mark,
Thanks for the feedback, I'll pass it on.
Rgds,Rory
On 12/01/2018 10:20, Mark Thomas wrote:
On 18/12/17 09:56, Rory O'Don
https://bz.apache.org/bugzilla/show_bug.cgi?id=61993
Dave Crighton changed:
What|Removed |Added
CC||davecrigh...@uk.ibm.com
--
You are re
On 12/01/18 13:17, Rory O'Donnell wrote:
> Hi Mark
>
> How serious is this issue ?
Hi,
In terms of functionality, it isn't serious. As far as I can tell, there
are no functional side-effects for Tomcat.
However, the more I think about this, the more serious an issue I think
this will be. A larg
Author: markt
Date: Fri Jan 12 13:34:13 2018
New Revision: 1820981
URL: http://svn.apache.org/viewvc?rev=1820981&view=rev
Log:
Fix formatting. No functional change.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk
Author: markt
Date: Fri Jan 12 14:16:08 2018
New Revision: 1820994
URL: http://svn.apache.org/viewvc?rev=1820994&view=rev
Log:
Format classes. No functional change.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk
https://bz.apache.org/bugzilla/show_bug.cgi?id=61993
--- Comment #1 from Mark Thomas ---
Thanks for the report.
On closer inspection there appear to be a couple of other edge cases that could
be handled better.
I plan on putting together some unit tests to cover this case and the other
edge cas
https://bz.apache.org/bugzilla/show_bug.cgi?id=61993
--- Comment #2 from Dave Crighton ---
Thanks Mark,
I did consider submitting my own JUnit with the patch but it causes large
allocations which, at least for our own build systems, makes it unsuitable at
an operational level for automated unit
On Fri, Jan 12, 2018 at 9:27 AM, Mark Thomas wrote:
> On 12/01/18 08:04, Rémy Maucherat wrote:
> > On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote:
> >
> >> Hi,
> >>
> >> I've been looking at how we close NIO channels and I think there is an
> >> opportunity for a little clean-up that, in tu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Mark,
On 1/12/18 3:27 AM, Mark Thomas wrote:
> On 11/01/18 23:12, Christopher Schultz wrote:
>
>
>
>> If performance is a consideration, then most of the calls to
>> write() should probably be calls to headerBuffer.put() because we
>> can be (rea
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Mark,
On 1/12/18 3:27 AM, Mark Thomas wrote:
> On 12/01/18 08:04, Rémy Maucherat wrote:
>> On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas
>> wrote:
>>
>>> Hi,
>>>
>>> I've been looking at how we close NIO channels and I think
>>> there is an oppor
On 12/01/18 20:58, Christopher Schultz wrote:
> Mark,
>
> On 1/12/18 3:27 AM, Mark Thomas wrote:
>> On 11/01/18 23:12, Christopher Schultz wrote:
>
>>
>
>>> If performance is a consideration, then most of the calls to
>>> write() should probably be calls to headerBuffer.put() because we
>>> can
https://bz.apache.org/bugzilla/show_bug.cgi?id=61977
--- Comment #5 from marian.romasc...@nuance.com ---
Would it be possible to override in the webapp the JNDIRealm class in
catalina.jar with the patched version? I mean providing the class in a
webapp-specific jar. This taking advantage of Tomcat
https://bz.apache.org/bugzilla/show_bug.cgi?id=61977
--- Comment #6 from Mark Thomas ---
Realm's many be specified at the Context, Host or Engine level. However, the
implementation class needs to visible to Tomcat so it needs to be in
CATALINA_BASE/lib.
So, to apply this patch to a single web ap
25 matches
Mail list logo
