svn commit: r1798419 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 07:03:48 2017 New Revision: 1798419 URL: http://svn.apache.org/viewvc?rev=1798419&view=rev Log: Remove trailing space Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java URL

svn commit: r1798420 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 07:05:16 2017 New Revision: 1798420 URL: http://svn.apache.org/viewvc?rev=1798420&view=rev Log: Remove trailing space Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/Tomcat.java Propchange: tomcat/

svn commit: r1798421 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 07:06:22 2017 New Revision: 1798421 URL: http://svn.apache.org/viewvc?rev=1798421&view=rev Log: Remove trailing space Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java Propchange: tomcat/

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2017-06-12 Thread Bill Barker
space/apache-commons/beanutils/dist/commons-beanutils-20170612.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar:/srv /g

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-06-12 Thread Bill Barker
mmons/beanutils/dist/commons-beanutils-20170612.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar:/srv /gump/pub

Re: Things that we can do to increase contributor involvement?

2017-06-12 Thread Violeta Georgieva
2017-06-11 23:57 GMT+03:00 Coty Sutherland : > > On Sun, Jun 11, 2017 at 4:20 PM, Violeta Georgieva wrote: > > Hi Coty, > > > > 2017-06-02 17:50 GMT+03:00 Coty Sutherland : > >> > >> On Fri, Jun 2, 2017 at 10:27 AM, Violeta Georgieva < violet...@apache.org> > > wrote: > >> > Hi, > >> > > >> > 2017

[Bug 60594] RFC 7230/3986 url requirement that prevents unencoded curly braces should be optional, since it breaks existing sites

2017-06-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594 --- Comment #27 from Lulseged Zerfu --- Hi Any comment if you will add '"' to allow in our request URL? Ta the end of the day we are taking the risk. BR Lulseged -- You are receiving this mail because: You are the assignee for the bug. ---

Tomcat6 bug report

2017-06-12 Thread Orlando José Luque Moraira
Hi, first time here. Found in tomcat6, not sure if it have been solved / changed in a newer version. Resumee: in a URLed jSessionId controlled session, if you do, from the client, one or more html requests to get files but without jSessionId in the URL, tomcat create a new "general site" cookie w

Re: Things that we can do to increase contributor involvement?

2017-06-12 Thread Coty Sutherland
On Mon, Jun 12, 2017 at 3:20 AM, Violeta Georgieva wrote: > 2017-06-11 23:57 GMT+03:00 Coty Sutherland : >> >> On Sun, Jun 11, 2017 at 4:20 PM, Violeta Georgieva > wrote: >> > Hi Coty, >> > >> > 2017-06-02 17:50 GMT+03:00 Coty Sutherland : >> >> >> >> On Fri, Jun 2, 2017 at 10:27 AM, Violeta Geor

svn commit: r1798505 - in /tomcat/trunk: CONTRIBUTING.md README.md

2017-06-12 Thread csutherl
Author: csutherl Date: Mon Jun 12 18:37:20 2017 New Revision: 1798505 URL: http://svn.apache.org/viewvc?rev=1798505&view=rev Log: Add README and CONTRIBUTING documents to help users that are utilizing the github mirror rather than SVN. Added: tomcat/trunk/CONTRIBUTING.md tomcat/trunk/REA

svn commit: r1798507 - /tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 18:39:38 2017 New Revision: 1798507 URL: http://svn.apache.org/viewvc?rev=1798507&view=rev Log: Format the code. No functional changes. In preparation to apply PR https://github.com/apache/tomcat70/pull/3 Modified: tomcat/trunk/java/org/apache/catalina/valve

svn commit: r1798509 - in /tomcat/trunk: conf/logging.properties java/org/apache/coyote/AbstractProcessor.java java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2017-06-12 Thread markt
Author: markt Date: Mon Jun 12 18:42:32 2017 New Revision: 1798509 URL: http://svn.apache.org/viewvc?rev=1798509&view=rev Log: Make asynchronous error handling more robust. In particular ensure that onError() is called for any registered AsyncListeners after an I/O error on a non-container threa

Re: asyncError() is not valid while in Async state DISPATCHING

2017-06-12 Thread Mark Thomas
On 09/06/17 16:26, Violeta Georgieva wrote: > 2017-06-09 17:25 GMT+03:00 Mark Thomas : >> I've spent some time working through the various possible combinations >> of events and have concluded it is impossible to completely fix this >> without imposing additional requirements on applications tha

Re: svn commit: r1798509 - in /tomcat/trunk: conf/logging.properties java/org/apache/coyote/AbstractProcessor.java java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2017-06-12 Thread Martin Grigorov
Hi Mark, On Mon, Jun 12, 2017 at 8:42 PM, wrote: > Author: markt > Date: Mon Jun 12 18:42:32 2017 > New Revision: 1798509 > > URL: http://svn.apache.org/viewvc?rev=1798509&view=rev > Log: > Make asynchronous error handling more robust. In particular ensure that > onError() is called for any regi

Re: Things that we can do to increase contributor involvement?

2017-06-12 Thread Coty Sutherland
On Mon, Jun 12, 2017 at 9:39 AM, Coty Sutherland wrote: > On Mon, Jun 12, 2017 at 3:20 AM, Violeta Georgieva > wrote: >> 2017-06-11 23:57 GMT+03:00 Coty Sutherland : >>> >>> On Sun, Jun 11, 2017 at 4:20 PM, Violeta Georgieva >> wrote: >>> > Hi Coty, >>> > >>> > 2017-06-02 17:50 GMT+03:00 Coty S

[Bug 61180] New: Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

2017-06-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61180 Bug ID: 61180 Summary: Change log level of sessionIdGeneratorBase.createRandom to warn rather than info Product: Tomcat 8 Version: 8.0.x-trunk Hardwar

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

2017-06-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61180 Coty Sutherland changed: What|Removed |Added Keywords||Beginner --- Comment #1 from Coty Su

svn commit: r1798514 - /tomcat/trunk/conf/logging.properties

2017-06-12 Thread markt
Author: markt Date: Mon Jun 12 19:21:46 2017 New Revision: 1798514 URL: http://svn.apache.org/viewvc?rev=1798514&view=rev Log: Revert debug config mistakenly included in r1798509 Modified: tomcat/trunk/conf/logging.properties Modified: tomcat/trunk/conf/logging.properties URL: http://svn.ap

svn commit: r1798533 - in /tomcat/trunk: java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/changelog.xml

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:04:53 2017 New Revision: 1798533 URL: http://svn.apache.org/viewvc?rev=1798533&view=rev Log: A new configuration property 'crawlerIps' is added to the 'o.a.catalina.valves.CrawlerSessionManagerValve'. Using this property one can specify a regular expression

svn commit: r1798535 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:08:59 2017 New Revision: 1798535 URL: http://svn.apache.org/viewvc?rev=1798535&view=rev Log: Format the code. No functional changes. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/CrawlerSession

svn commit: r1798536 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/cha

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:12:29 2017 New Revision: 1798536 URL: http://svn.apache.org/viewvc?rev=1798536&view=rev Log: A new configuration property 'crawlerIps' is added to the 'o.a.catalina.valves.CrawlerSessionManagerValve'. Using this property one can specify a regular expression

svn commit: r1798537 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:13:52 2017 New Revision: 1798537 URL: http://svn.apache.org/viewvc?rev=1798537&view=rev Log: Format the code. No functional changes. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/valves/CrawlerSession

svn commit: r1798539 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/cha

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:16:35 2017 New Revision: 1798539 URL: http://svn.apache.org/viewvc?rev=1798539&view=rev Log: A new configuration property 'crawlerIps' is added to the 'o.a.catalina.valves.CrawlerSessionManagerValve'. Using this property one can specify a regular expression

svn commit: r1798540 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:22:41 2017 New Revision: 1798540 URL: http://svn.apache.org/viewvc?rev=1798540&view=rev Log: Format the code. No functional changes. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/CrawlerSession

buildbot failure in on tomcat-8-trunk

2017-06-12 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/1034 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sc

svn commit: r1798541 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/CrawlerSessionManagerValve.java test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java webapps/docs/cha

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:25:26 2017 New Revision: 1798541 URL: http://svn.apache.org/viewvc?rev=1798541&view=rev Log: A new configuration property 'crawlerIps' is added to the 'o.a.catalina.valves.CrawlerSessionManagerValve'. Using this property one can specify a regular expression

svn commit: r1798543 - /tomcat/tc8.5.x/trunk/test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:33:40 2017 New Revision: 1798543 URL: http://svn.apache.org/viewvc?rev=1798543&view=rev Log: Fix the build Modified: tomcat/tc8.5.x/trunk/test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java Modified: tomcat/tc8.5.x/trunk/test/org/apache

svn commit: r1798544 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:34:34 2017 New Revision: 1798544 URL: http://svn.apache.org/viewvc?rev=1798544&view=rev Log: Fix the build Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java Pro

buildbot failure in on tomcat-7-trunk

2017-06-12 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/765 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1798545 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:37:11 2017 New Revision: 1798545 URL: http://svn.apache.org/viewvc?rev=1798545&view=rev Log: Fix the build Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java Pro

svn commit: r1798546 - /tomcat/trunk/res/ide-support/eclipse/eclipse.classpath

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:44:12 2017 New Revision: 1798546 URL: http://svn.apache.org/viewvc?rev=1798546&view=rev Log: When using EasyMock for mocking classes, one needs cglib and objenesis in the class path. Modified: tomcat/trunk/res/ide-support/eclipse/eclipse.classpath Modif

svn commit: r1798547 - in /tomcat/tc8.5.x/trunk: ./ res/ide-support/eclipse/eclipse.classpath

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:46:27 2017 New Revision: 1798547 URL: http://svn.apache.org/viewvc?rev=1798547&view=rev Log: When using EasyMock for mocking classes, one needs cglib and objenesis in the class path. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/tr

svn commit: r1798548 - in /tomcat/tc8.0.x/trunk: ./ res/ide-support/eclipse/eclipse.classpath

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:47:55 2017 New Revision: 1798548 URL: http://svn.apache.org/viewvc?rev=1798548&view=rev Log: When using EasyMock for mocking classes, one needs cglib and objenesis in the class path. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/tr

svn commit: r1798549 - in /tomcat/tc7.0.x/trunk: ./ res/ide-support/eclipse/eclipse.classpath

2017-06-12 Thread violetagg
Author: violetagg Date: Mon Jun 12 21:49:13 2017 New Revision: 1798549 URL: http://svn.apache.org/viewvc?rev=1798549&view=rev Log: When using EasyMock for mocking classes, one needs cglib and objenesis in the class path. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/tr

Re: Tomcat6 bug report

2017-06-12 Thread Mark Thomas
On 12/06/17 14:15, Orlando José Luque Moraira wrote: > Hi, first time here. This question belongs on the users list, not on the dev list. Mark > > Found in tomcat6, not sure if it have been solved / changed in a newer > version. > > Resumee: in a URLed jSessionId controlled session, if you do

svn commit: r1798560 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestCrawlerSessionManagerValve.java

2017-06-12 Thread violetagg
Author: violetagg Date: Tue Jun 13 06:24:57 2017 New Revision: 1798560 URL: http://svn.apache.org/viewvc?rev=1798560&view=rev Log: Collections.emptyEnumeration() does not exist in java 6, use alternative. Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestCrawlerSessionManage