why has some field not been locked before accessed.

2017-04-27 Thread ??????
Hi, The field sessionCounter and rejectedSessions in org.apache.catalina.session.ManagerBase is not atomic field?? Now, These fields ware not locked before they were accessed in Concurrent environment. it was allowed because the very low probability ? Look forward to your reply, thanks v

[Bug 61052] New: Startup can be excessively long due to scanning resource paths for TLDs

2017-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61052 Bug ID: 61052 Summary: Startup can be excessively long due to scanning resource paths for TLDs Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC OS: All

[Bug 61052] Startup can be excessively long due to scanning resource paths for TLDs

2017-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61052 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: why has some field not been locked before accessed.

2017-04-27 Thread Mark Thomas
On 27/04/17 13:19, ?? wrote: > Hi, > The field sessionCounter and rejectedSessions in > org.apache.catalina.session.ManagerBase > is not atomic field?? > > > Now, These fields ware not locked before they were accessed in Concurrent > environment. > > > it was allowed because the very l

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-04-27 Thread Violeta Georgieva
Hi, 2017-04-26 17:43 GMT+03:00 Mark Thomas : > > On 25/04/17 11:47, Violeta Georgieva wrote: > > > > > Thanks for the review. > > Changes for all comments are applied to the PR. > > Can you take a look? > > Sure. A few more comments but nothing serious. Unless the fixes for any > of these require

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-04-27 Thread Mark Thomas
On 27/04/17 21:22, Violeta Georgieva wrote: > Hi, > > 2017-04-26 17:43 GMT+03:00 Mark Thomas : >> >> On 25/04/17 11:47, Violeta Georgieva wrote: >> >> >> >>> Thanks for the review. >>> Changes for all comments are applied to the PR. >>> Can you take a look? >> >> Sure. A few more comments but not

svn commit: r1792957 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2017-04-27 Thread markt
Author: markt Date: Thu Apr 27 20:49:32 2017 New Revision: 1792957 URL: http://svn.apache.org/viewvc?rev=1792957&view=rev Log: Wildcard host names need quoting since '*' is a reserved character in an ObjectName. Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java tomcat/t

svn commit: r1792958 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2017-04-27 Thread markt
Author: markt Date: Thu Apr 27 20:50:41 2017 New Revision: 1792958 URL: http://svn.apache.org/viewvc?rev=1792958&view=rev Log: Wildcard host names need quoting since '*' is a reserved character in an ObjectName. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/

Re: svn commit: r1792957 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2017-04-27 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 4/27/17 4:49 PM, ma...@apache.org wrote: > Author: markt Date: Thu Apr 27 20:49:32 2017 New Revision: 1792957 > > URL: http://svn.apache.org/viewvc?rev=1792957&view=rev Log: > Wildcard host names need quoting since '*' is a reserved chara

[Bug 60963] Optimize class loading for unpackWARs=false case

2017-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60963 --- Comment #14 from Thomas Meyer --- Hi, any news on this? Do you want me to attach the patch here? Anything else I can do? -- You are receiving this mail because: You are the assignee for the bug. --

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-04-27 Thread Violeta Georgieva
Hi, 2017-04-26 17:43 GMT+03:00 Mark Thomas : > > On 25/04/17 11:47, Violeta Georgieva wrote: > > > > > Thanks for the review. > > Changes for all comments are applied to the PR. > > Can you take a look? > > Sure. A few more comments but nothing serious. Unless the fixes for any > of these require