[Bug 60306] New: Wrong javadoc for setRotatable

2016-10-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60306 Bug ID: 60306 Summary: Wrong javadoc for setRotatable Product: Tomcat 8 Version: 8.5.4 Hardware: PC OS: Mac OS X 10.1 Status: NEW Severity: minor

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Rainer Jung
Am 26.10.2016 um 08:33 schrieb Romain Manni-Bucau: 2016-10-26 8:26 GMT+02:00 Rainer Jung : Am 25.10.2016 um 22:40 schrieb Romain Manni-Bucau: 2016-10-25 22:35 GMT+02:00 Rainer Jung : Am 25.10.2016 um 17:07 schrieb Romain Manni-Bucau: I'm not sure though, how dangerous this is due to possi

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Rémy Maucherat
2016-10-26 11:38 GMT+02:00 Rainer Jung : > Note that for the jul bridge to work, the Log4J2 jar files have to be put > onto the CLASSPATH (otherwise the Log4J2 jul LogManager can't be used) and > so the resource pointing to the custom LogEventFactory must sit there as > well. > > But it seems one

svn commit: r1766664 - /tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 11:03:02 2016 New Revision: 174 URL: http://svn.apache.org/viewvc?rev=174&view=rev Log: Add a couple of tests to explicitly check Tomcat doesn't allow clients to create circular dependencies between streams. Modified: tomcat/trunk/test/org/apache/coyote

El software de construcción modular y escalable.

2016-10-26 Thread softw...@distritok.com

svn commit: r1766675 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http2/ test/org/a

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 12:37:27 2016 New Revision: 1766675 URL: http://svn.apache.org/viewvc?rev=1766675&view=rev Log: Refactor for consistency Limits applied after the request/response has been passed to the Adaptor are configured on the Connector and obtained via the Adaptor when requir

svn commit: r1766677 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/coyote/http2/TestAbstractStream.java

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 12:39:05 2016 New Revision: 1766677 URL: http://svn.apache.org/viewvc?rev=1766677&view=rev Log: Add a couple of tests to explicitly check Tomcat doesn't allow clients to create circular dependencies between streams. Modified: tomcat/tc8.5.x/trunk/ (props chan

svn commit: r1766678 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http2/

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 12:39:52 2016 New Revision: 1766678 URL: http://svn.apache.org/viewvc?rev=1766678&view=rev Log: Refactor for consistency Limits applied after the request/response has been passed to the Adaptor are configured on the Connector and obtained via the Adaptor when requir

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Romain Manni-Bucau
2016-10-26 11:50 GMT+02:00 Rémy Maucherat : > 2016-10-26 11:38 GMT+02:00 Rainer Jung : > > > Note that for the jul bridge to work, the Log4J2 jar files have to be put > > onto the CLASSPATH (otherwise the Log4J2 jul LogManager can't be used) > and > > so the resource pointing to the custom LogEven

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Rémy Maucherat
2016-10-26 15:32 GMT+02:00 Romain Manni-Bucau : > If I got the original issue right, it is only about allowing a user to > replace the default (JULi) so should be acceptable, no? > > Right, but once you place your logging framework in the main CL, you could run into issues. The default is indeed n

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Romain Manni-Bucau
2016-10-26 16:02 GMT+02:00 Rémy Maucherat : > 2016-10-26 15:32 GMT+02:00 Romain Manni-Bucau : > > > If I got the original issue right, it is only about allowing a user to > > replace the default (JULi) so should be acceptable, no? > > > > Right, but once you place your logging framework in the mai

[Bug 60306] Wrong javadoc for setRotatable

2016-10-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60306 --- Comment #1 from Christopher Schultz --- Would you care to supply a patch for this? It should be easy, plus you can get your name into the changelog :) -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1766698 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2016-10-26 Thread remm
Author: remm Date: Wed Oct 26 16:25:26 2016 New Revision: 1766698 URL: http://svn.apache.org/viewvc?rev=1766698&view=rev Log: Similar to the connector handling, refactor the embedded mode container handling to more cleanly allow multiples of each (if needed). Remove relevant todos. Modified:

svn commit: r1766700 - /tomcat/trunk/webapps/docs/config/http2.xml

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 16:38:33 2016 New Revision: 1766700 URL: http://svn.apache.org/viewvc?rev=1766700&view=rev Log: ws police Modified: tomcat/trunk/webapps/docs/config/http2.xml Modified: tomcat/trunk/webapps/docs/config/http2.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/w

svn commit: r1766706 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2016-10-26 Thread remm
Author: remm Date: Wed Oct 26 17:03:06 2016 New Revision: 1766706 URL: http://svn.apache.org/viewvc?rev=1766706&view=rev Log: Similar to the connector handling, refactor the embedded mode container handling to more cleanly allow multiples of each (if needed). Remove relevant todos. Modified:

svn commit: r1766713 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 17:54:03 2016 New Revision: 1766713 URL: http://svn.apache.org/viewvc?rev=1766713&view=rev Log: Fix an IDE nag Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java URL: http://s

svn commit: r1766714 - in /tomcat/trunk/java/org/apache/coyote/http2: LocalStrings.properties Stream.java StreamStateMachine.java

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 17:58:06 2016 New Revision: 1766714 URL: http://svn.apache.org/viewvc?rev=1766714&view=rev Log: Don't call receiveReset when sending a reset. Restore the sendReset() method on the state machine and use it as intended Modified: tomcat/trunk/java/org/apache/coyote

svn commit: r1766715 - in /tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2: AbstractStream.java Hpack.java

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 17:58:40 2016 New Revision: 1766715 URL: http://svn.apache.org/viewvc?rev=1766715&view=rev Log: Reviewing HTTP/2 difference between 8.5.x and 9.0.x Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/AbstractStream.java tomcat/tc8.5.x/trunk/java/org/

svn commit: r1766716 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 18:01:07 2016 New Revision: 1766716 URL: http://svn.apache.org/viewvc?rev=1766716&view=rev Log: Remove unnecessary ws Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHa

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Rainer Jung
Am 26.10.2016 um 15:32 schrieb Romain Manni-Bucau: 2016-10-26 11:50 GMT+02:00 Rémy Maucherat : 2016-10-26 11:38 GMT+02:00 Rainer Jung : Note that for the jul bridge to work, the Log4J2 jar files have to be put onto the CLASSPATH (otherwise the Log4J2 jul LogManager can't be used) and so the

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Rainer Jung
Am 26.10.2016 um 16:02 schrieb Rémy Maucherat: 2016-10-26 15:32 GMT+02:00 Romain Manni-Bucau : If I got the original issue right, it is only about allowing a user to replace the default (JULi) so should be acceptable, no? Right, but once you place your logging framework in the main CL, you cou

svn commit: r1766717 - /tomcat/trunk/webapps/docs/changelog.xml

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 18:05:21 2016 New Revision: 1766717 URL: http://svn.apache.org/viewvc?rev=1766717&view=rev Log: Update Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/do

svn commit: r1766718 - in /tomcat/tc8.5.x/trunk: java/org/apache/coyote/http2/LocalStrings.properties java/org/apache/coyote/http2/Stream.java webapps/docs/changelog.xml

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 18:06:17 2016 New Revision: 1766718 URL: http://svn.apache.org/viewvc?rev=1766718&view=rev Log: Correctly differentiate between sending and receiving a reset frame when tracking the state of an HTTP/2 stream. Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyot

svn commit: r1766719 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/Tomcat.java

2016-10-26 Thread markt
Author: markt Date: Wed Oct 26 18:06:54 2016 New Revision: 1766719 URL: http://svn.apache.org/viewvc?rev=1766719&view=rev Log: Remove unnecessary casts Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/Tomcat.java Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/

Re: TC 8.5 and Log4J2 via Juli: Wrong location info

2016-10-26 Thread Rémy Maucherat
2016-10-26 20:04 GMT+02:00 Rainer Jung : > Am 26.10.2016 um 16:02 schrieb Rémy Maucherat: > >> 2016-10-26 15:32 GMT+02:00 Romain Manni-Bucau : >> >> If I got the original issue right, it is only about allowing a user to >>> replace the default (JULi) so should be acceptable, no? >>> >>> Right, but

Re: Introduce methods read/write with ByteBuffer in CoyoteInputStream/CoyoteOutputStream

2016-10-26 Thread Violeta Georgieva
Hi Remy, 2016-10-25 1:49 GMT+03:00 Rémy Maucherat : > > 2016-10-24 20:18 GMT+02:00 Violeta Georgieva : > > > There are no issues reported for the refactored functionality available in > > 9.0.0.M11. > > I think it is safe to back port the changes for the next 8.5 release. > > Do you see any issues

Re: Introduce methods read/write with ByteBuffer in CoyoteInputStream/CoyoteOutputStream

2016-10-26 Thread Rémy Maucherat
2016-10-26 20:45 GMT+02:00 Violeta Georgieva : > Hi Remy, > > 2016-10-25 1:49 GMT+03:00 Rémy Maucherat : > > > > 2016-10-24 20:18 GMT+02:00 Violeta Georgieva : > > > > > There are no issues reported for the refactored functionality available > in > > > 9.0.0.M11. > > > I think it is safe to back p