[Bug 59655] New: The CookieNameValidator has issue that related to the consistency

https://bz.apache.org/bugzilla/show_bug.cgi?id=59655 Bug ID: 59655 Summary: The CookieNameValidator has issue that related to the consistency Product: Tomcat 9 Version: unspecified Hardware: All OS: All

Re: About CookieNameValidator

Hi all, I created a Bugzilla issue related to the previous mail. https://bz.apache.org/bugzilla/show_bug.cgi?id=59655 What do you think this? Best regards, Kyohei Nakamura 2016-05-23 15:48 GMT+09:00 Kyohei Nakamura : > Hi all, > > I think that the CookieNameValidator has issue that related t

svn commit: r1746549 - /tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java

Author: markt Date: Thu Jun 2 12:01:00 2016 New Revision: 1746549 URL: http://svn.apache.org/viewvc?rev=1746549&view=rev Log: Remove the commented out code. The solution is going to be a little more involved that this. Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Mod

svn commit: r1746551 - in /tomcat/trunk: java/org/apache/coyote/AbstractProcessor.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/ch

Author: markt Date: Thu Jun 2 12:14:20 2016 New Revision: 1746551 URL: http://svn.apache.org/viewvc?rev=1746551&view=rev Log: When timeouts occur process them as error events rather than closing the socket immediately so that the correct error handling (async listener, read/write listener) can

svn commit: r1746554 - /tomcat/trunk/test/org/apache/coyote/TestIoTimeouts.java

Author: markt Date: Thu Jun 2 13:08:38 2016 New Revision: 1746554 URL: http://svn.apache.org/viewvc?rev=1746554&view=rev Log: Add new test case for read timeout during non-blocking IO Added: tomcat/trunk/test/org/apache/coyote/TestIoTimeouts.java (with props) Added: tomcat/trunk/test/org/

svn commit: r1746555 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/

Author: markt Date: Thu Jun 2 13:08:52 2016 New Revision: 1746555 URL: http://svn.apache.org/viewvc?rev=1746555&view=rev Log: Pull up synchronization block Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/t

svn commit: r1746556 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Thu Jun 2 13:10:52 2016 New Revision: 1746556 URL: http://svn.apache.org/viewvc?rev=1746556&view=rev Log: Simplify. Remove unnecessary method Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Ni

svn commit: r1746558 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: markt Date: Thu Jun 2 13:11:34 2016 New Revision: 1746558 URL: http://svn.apache.org/viewvc?rev=1746558&view=rev Log: Simplify. Remove unnecessary method Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/N

svn commit: r1746559 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Thu Jun 2 13:13:09 2016 New Revision: 1746559 URL: http://svn.apache.org/viewvc?rev=1746559&view=rev Log: Remove unnecessary method Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/tc8.5

svn commit: r1746560 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Thu Jun 2 13:13:48 2016 New Revision: 1746560 URL: http://svn.apache.org/viewvc?rev=1746560&view=rev Log: Remove sync. I can't see why it is needed and the CI tests will fail due to a deadlock caused by the SocketProcessor switching to a sync on the socket wrapper. Modified

svn commit: r1746561 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/Nio2Endpoint.

Author: markt Date: Thu Jun 2 13:14:22 2016 New Revision: 1746561 URL: http://svn.apache.org/viewvc?rev=1746561&view=rev Log: Add a boolean return to the abstract processSocket() method facilitate the merging of the two processSocket() methods in each of the end points. Modified: tomcat/tc8

svn commit: r1746562 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Thu Jun 2 13:14:43 2016 New Revision: 1746562 URL: http://svn.apache.org/viewvc?rev=1746562&view=rev Log: Merge duplicate methods. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java tomcat/tc8.5

svn commit: r1746563 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/LocalStrings.properties

Author: markt Date: Thu Jun 2 13:15:09 2016 New Revision: 1746563 URL: http://svn.apache.org/viewvc?rev=1746563&view=rev Log: status -> event Simplify. The endpoint.warn.noExector was added to handle Comet related issues on connector stop so is no longer required. Modified: tomcat/tc8.5.x/t

svn commit: r1746564 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Thu Jun 2 13:15:46 2016 New Revision: 1746564 URL: http://svn.apache.org/viewvc?rev=1746564&view=rev Log: Align processSocket() implementations for NIO and NIO2. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio

svn commit: r1746565 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

Author: markt Date: Thu Jun 2 13:17:07 2016 New Revision: 1746565 URL: http://svn.apache.org/viewvc?rev=1746565&view=rev Log: Make processSocket() more like NIO/NIO2 Add a SocketProcessor cache to align with NIO/NIO2 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/

svn commit: r1746566 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/Nio2Endpoint.

Author: markt Date: Thu Jun 2 13:17:33 2016 New Revision: 1746566 URL: http://svn.apache.org/viewvc?rev=1746566&view=rev Log: Add a SocketProcessor cache to align with NIO/NIO2 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Abstract

svn commit: r1746567 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Thu Jun 2 13:18:14 2016 New Revision: 1746567 URL: http://svn.apache.org/viewvc?rev=1746567&view=rev Log: Simplify. Method is only called from a single location. Remove unnecessary code. The caches are cleared in stop(). Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1746568 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java

Author: markt Date: Thu Jun 2 13:19:04 2016 New Revision: 1746568 URL: http://svn.apache.org/viewvc?rev=1746568&view=rev Log: Remove the commented out code. The solution is going to be a little more involved that this. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/tru

svn commit: r1746569 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/ java/org/apache/tomcat/util/net/ test/org/apache/coyote/ webapps/docs/

Author: markt Date: Thu Jun 2 13:19:38 2016 New Revision: 1746569 URL: http://svn.apache.org/viewvc?rev=1746569&view=rev Log: When timeouts occur process them as error events rather than closing the socket immediately so that the correct error handling (async listener, read/write listener) can

svn commit: r1746570 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Thu Jun 2 13:20:18 2016 New Revision: 1746570 URL: http://svn.apache.org/viewvc?rev=1746570&view=rev Log: Simplify. Remove unnecessary method Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java t

svn commit: r1746584 - /tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java

Author: markt Date: Thu Jun 2 14:52:36 2016 New Revision: 1746584 URL: http://svn.apache.org/viewvc?rev=1746584&view=rev Log: Fix loop observed during local testing Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Modified: tomcat/trunk/java/org/apache/coyote/AbstractProt

svn commit: r1746585 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java

Author: markt Date: Thu Jun 2 14:54:11 2016 New Revision: 1746585 URL: http://svn.apache.org/viewvc?rev=1746585&view=rev Log: Fix loop observed during local testing Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java Propch

svn commit: r1746620 - /tomcat/trunk/test/org/apache/coyote/http11/TestHttp11Processor.java

Author: markt Date: Thu Jun 2 19:57:37 2016 New Revision: 1746620 URL: http://svn.apache.org/viewvc?rev=1746620&view=rev Log: Minor clean-up Modified: tomcat/trunk/test/org/apache/coyote/http11/TestHttp11Processor.java Modified: tomcat/trunk/test/org/apache/coyote/http11/TestHttp11Processor

svn commit: r1746649 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11Processor.java test/org/apache/coyote/http11/TestHttp11Processor.java webapps/docs/changelog.xml

Author: markt Date: Thu Jun 2 22:37:48 2016 New Revision: 1746649 URL: http://svn.apache.org/viewvc?rev=1746649&view=rev Log: If an async dispatch results in the completion of request processing, ensure that any remaining requets body is swallowed before starting the processing of the next requ