Author: markt
Date: Wed Apr 27 08:23:58 2016
New Revision: 1741157
URL: http://svn.apache.org/viewvc?rev=1741157&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Simplify. These fields are only used internally so they can be declared as Map
with Java 8.
Modified:
tomcat/trunk/
Author: markt
Date: Wed Apr 27 08:30:28 2016
New Revision: 1741159
URL: http://svn.apache.org/viewvc?rev=1741159&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Simplify. sessionKeys is only used internally so it can be declared as Map with
Java 8.
Also:
- Reduce visibility of fie
Author: markt
Date: Wed Apr 27 08:32:59 2016
New Revision: 1741160
URL: http://svn.apache.org/viewvc?rev=1741160&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Reduce visibility of fields.
- Use final where possible
Author: markt
Date: Wed Apr 27 08:36:54 2016
New Revision: 1741162
URL: http://svn.apache.org/viewvc?rev=1741162&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Expected to be safe since previous, more significant refactorin
Author: markt
Date: Wed Apr 27 08:43:30 2016
New Revision: 1741164
URL: http://svn.apache.org/viewvc?rev=1741164&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Simplify. These fields are only used internally so they can be declared as Map
with Java 8.
Reduce visibility of interna
Author: markt
Date: Wed Apr 27 08:45:17 2016
New Revision: 1741165
URL: http://svn.apache.org/viewvc?rev=1741165&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Reduce visibility of field
Modified:
tomcat/tc8.5.
Author: markt
Date: Wed Apr 27 08:52:36 2016
New Revision: 1741170
URL: http://svn.apache.org/viewvc?rev=1741170&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Expected to be safe since previous, more significant refactorin
Author: markt
Date: Wed Apr 27 09:00:43 2016
New Revision: 1741172
URL: http://svn.apache.org/viewvc?rev=1741172&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Reduce visibility of field
Modified:
tomcat/tc7.0.
Author: markt
Date: Wed Apr 27 09:14:44 2016
New Revision: 1741173
URL: http://svn.apache.org/viewvc?rev=1741173&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Simplify. These fields are only used internally so they can be declared as Map
with Java 8.
Modified:
tomcat/trunk/
Author: markt
Date: Wed Apr 27 09:16:44 2016
New Revision: 1741174
URL: http://svn.apache.org/viewvc?rev=1741174&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 09:23:57 2016
New Revision: 1741176
URL: http://svn.apache.org/viewvc?rev=1741176&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 09:27:29 2016
New Revision: 1741178
URL: http://svn.apache.org/viewvc?rev=1741178&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc7.0.x/trunk/ (props
Author: markt
Date: Wed Apr 27 09:32:47 2016
New Revision: 1741180
URL: http://svn.apache.org/viewvc?rev=1741180&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc6.0.x/trunk/ (props
Author: markt
Date: Wed Apr 27 09:41:02 2016
New Revision: 1741181
URL: http://svn.apache.org/viewvc?rev=1741181&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
attributes is non-final so it can be replaced. Define the field as
ConcurrentMap to ensure that thread-safety is maintai
Author: markt
Date: Wed Apr 27 09:41:39 2016
New Revision: 1741182
URL: http://svn.apache.org/viewvc?rev=1741182&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
attributes is non-final so it can be replaced. Define the field as
ConcurrentMap to ensure that thread-safety is maintai
Author: markt
Date: Wed Apr 27 09:41:59 2016
New Revision: 1741183
URL: http://svn.apache.org/viewvc?rev=1741183&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
attributes is non-final so it can be replaced. Define the field as
ConcurrentMap to ensure that thread-safety is maintai
Author: markt
Date: Wed Apr 27 09:43:26 2016
New Revision: 1741184
URL: http://svn.apache.org/viewvc?rev=1741184&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
attributes is non-final so it can be replaced. Define the field as
ConcurrentMap to ensure that thread-safety is maintai
Author: markt
Date: Wed Apr 27 09:46:59 2016
New Revision: 1741186
URL: http://svn.apache.org/viewvc?rev=1741186&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
attributes is non-final so it can be replaced. Define the field as
ConcurrentMap to ensure that thread-safety is maintai
Author: markt
Date: Wed Apr 27 09:56:53 2016
New Revision: 1741190
URL: http://svn.apache.org/viewvc?rev=1741190&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/trunk/java/org/apache/c
Author: markt
Date: Wed Apr 27 09:57:41 2016
New Revision: 1741191
URL: http://svn.apache.org/viewvc?rev=1741191&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc8.5.x/trunk/ (props
Author: markt
Date: Wed Apr 27 09:58:22 2016
New Revision: 1741192
URL: http://svn.apache.org/viewvc?rev=1741192&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc8.0.x/trunk/ (props
Author: markt
Date: Wed Apr 27 10:00:18 2016
New Revision: 1741193
URL: http://svn.apache.org/viewvc?rev=1741193&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc7.0.x/trunk/ (props
Author: markt
Date: Wed Apr 27 10:02:52 2016
New Revision: 1741195
URL: http://svn.apache.org/viewvc?rev=1741195&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc6.0.x/trunk/ (props
Author: markt
Date: Wed Apr 27 10:07:25 2016
New Revision: 1741197
URL: http://svn.apache.org/viewvc?rev=1741197&view=rev
Log:
Reduce visibility.
Use final.
Modified:
tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java
Modified: tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java
U
Author: markt
Date: Wed Apr 27 10:08:08 2016
New Revision: 1741198
URL: http://svn.apache.org/viewvc?rev=1741198&view=rev
Log:
Reduce visibility.
Use final.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/mapper/Mapper.java
Propchange: tomc
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344
Emmanuel Bourg changed:
What|Removed |Added
Status|RESOLVED|VERIFIED
--- Comment #14 from Emmanue
Author: markt
Date: Wed Apr 27 10:36:46 2016
New Revision: 1741203
URL: http://svn.apache.org/viewvc?rev=1741203&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 10:36:13 2016
New Revision: 1741202
URL: http://svn.apache.org/viewvc?rev=1741202&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/ti
Author: markt
Date: Wed Apr 27 10:37:43 2016
New Revision: 1741204
URL: http://svn.apache.org/viewvc?rev=1741204&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 10:38:25 2016
New Revision: 1741205
URL: http://svn.apache.org/viewvc?rev=1741205&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 10:39:58 2016
New Revision: 1741207
URL: http://svn.apache.org/viewvc?rev=1741207&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/t
Author: markt
Date: Wed Apr 27 10:40:26 2016
New Revision: 1741208
URL: http://svn.apache.org/viewvc?rev=1741208&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/trunk/java/org/apache/catalina/valves/Stu
Author: markt
Date: Wed Apr 27 10:40:58 2016
New Revision: 1741209
URL: http://svn.apache.org/viewvc?rev=1741209&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 10:41:22 2016
New Revision: 1741210
URL: http://svn.apache.org/viewvc?rev=1741210&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 10:42:53 2016
New Revision: 1741211
URL: http://svn.apache.org/viewvc?rev=1741211&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 10:43:50 2016
New Revision: 1741212
URL: http://svn.apache.org/viewvc?rev=1741212&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 10:46:04 2016
New Revision: 1741213
URL: http://svn.apache.org/viewvc?rev=1741213&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Simplify. These fields are only used internally so they can be declared as Map
with Java 8.
Modified:
tomcat/trunk/
Author: markt
Date: Wed Apr 27 10:47:09 2016
New Revision: 1741215
URL: http://svn.apache.org/viewvc?rev=1741215&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 10:49:49 2016
New Revision: 1741217
URL: http://svn.apache.org/viewvc?rev=1741217&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 10:51:21 2016
New Revision: 1741218
URL: http://svn.apache.org/viewvc?rev=1741218&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 10:54:57 2016
New Revision: 1741219
URL: http://svn.apache.org/viewvc?rev=1741219&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc6.0.x/trunk/ (props
Author: markt
Date: Wed Apr 27 10:55:30 2016
New Revision: 1741220
URL: http://svn.apache.org/viewvc?rev=1741220&view=rev
Log:
Make final
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java
Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProtocol.java
UR
Author: markt
Date: Wed Apr 27 11:00:08 2016
New Revision: 1741221
URL: http://svn.apache.org/viewvc?rev=1741221&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare that functions must be thread-safe
Modified:
tomcat/trunk/java/org/apache/el/lang/FunctionMapperImpl.java
M
Author: markt
Date: Wed Apr 27 11:00:33 2016
New Revision: 1741222
URL: http://svn.apache.org/viewvc?rev=1741222&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare that functions must be thread-safe
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trun
Hi,
I have a question about difference in the behaviour of
org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
I'm investigating the issue reported here [1].
In Tomcat 8+ when WebappClassLoaderBase.getResource is invoked with a path
that represents a jar resource and starts with
Author: markt
Date: Wed Apr 27 11:01:51 2016
New Revision: 1741223
URL: http://svn.apache.org/viewvc?rev=1741223&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare that functions must be thread-safe
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trun
Author: markt
Date: Wed Apr 27 11:09:15 2016
New Revision: 1741225
URL: http://svn.apache.org/viewvc?rev=1741225&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Jsp
Author: markt
Date: Wed Apr 27 11:11:38 2016
New Revision: 1741226
URL: http://svn.apache.org/viewvc?rev=1741226&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 11:12:18 2016
New Revision: 1741227
URL: http://svn.apache.org/viewvc?rev=1741227&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 11:14:52 2016
New Revision: 1741228
URL: http://svn.apache.org/viewvc?rev=1741228&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomc
Author: markt
Date: Wed Apr 27 11:16:39 2016
New Revision: 1741230
URL: http://svn.apache.org/viewvc?rev=1741230&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomc
On 27/04/2016 12:00, Violeta Georgieva wrote:
> Hi,
>
> I have a question about difference in the behaviour of
> org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
> I'm investigating the issue reported here [1].
>
> In Tomcat 8+ when WebappClassLoaderBase.getResource is invoke
2016-04-27 14:00 GMT+03:00 Violeta Georgieva :
> Hi,
>
> I have a question about difference in the behaviour of
> org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
> I'm investigating the issue reported here [1].
>
> In Tomcat 8+ when WebappClassLoaderBase.getResource is invoked
The Buildbot has detected a new failure on builder tomcat-8-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/596
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler sch
Author: markt
Date: Wed Apr 27 11:33:20 2016
New Revision: 1741232
URL: http://svn.apache.org/viewvc?rev=1741232&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/trunk/java/org/apache/t
Author: markt
Date: Wed Apr 27 11:34:42 2016
New Revision: 1741233
URL: http://svn.apache.org/viewvc?rev=1741233&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/tc8.5.x/trunk/ (props
Author: markt
Date: Wed Apr 27 11:36:47 2016
New Revision: 1741234
URL: http://svn.apache.org/viewvc?rev=1741234&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 11:39:39 2016
New Revision: 1741235
URL: http://svn.apache.org/viewvc?rev=1741235&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tom
Author: markt
Date: Wed Apr 27 11:41:01 2016
New Revision: 1741236
URL: http://svn.apache.org/viewvc?rev=1741236&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tom
On 27/04/2016 00:03, Mark Thomas wrote:
> On 25/04/2016 16:42, Romain Manni-Bucau wrote:
>> Hi guys,
>>
>> tomcat uses ConcurrentHashMap in few places and doesn't rely on
>> ConcurrentMap API (ApplicationContext IIRC for instance was the case I
>> encounter). This means if you build tomcat with ja
from what I saw in commit mails it seems so. Does it still worth a page
explaining linux distro rebuild tomcat and how to check the java version
(reading MANIFEST.MF from catalina.jar for instance) in case it happens
again or someone hits it short term?
Thanks to have taken it into consideration a
The Buildbot has detected a restored build on builder tomcat-8-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/597
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler
Romain,
On 4/26/16 5:32 PM, Romain Manni-Bucau wrote:
> Le 26 avr. 2016 22:27, "Christopher Schultz"
> a écrit :
>>
>> Romain,
>>
>> On 4/25/16 11:42 AM, Romain Manni-Bucau wrote:
>>> Hi guys,
>>>
>>> tomcat uses ConcurrentHashMap in few places and doesn't rely on
>>> ConcurrentMap API (Applicat
Konstantin,
On 4/27/16 7:27 AM, Konstantin Kolinko wrote:
> 2016-04-27 14:00 GMT+03:00 Violeta Georgieva :
>> Hi,
>>
>> I have a question about difference in the behaviour of
>> org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
>> I'm investigating the issue reported here [1].
Mark,
On 4/27/16 7:41 AM, Mark Thomas wrote:
> On 27/04/2016 00:03, Mark Thomas wrote:
>> On 25/04/2016 16:42, Romain Manni-Bucau wrote:
>>> Hi guys,
>>>
>>> tomcat uses ConcurrentHashMap in few places and doesn't rely on
>>> ConcurrentMap API (ApplicationContext IIRC for instance was the case I
https://bz.apache.org/bugzilla/show_bug.cgi?id=52952
--- Comment #4 from Abdessamed MANSOURI ---
Created attachment 33811
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33811&action=edit
Patch
This is a patch for duplication with some code enhancements (replacing iterator
loops with enha
https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
--- Comment #1 from Abdessamed MANSOURI ---
What do you suggest that classes be named?
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubsc
https://bz.apache.org/bugzilla/show_bug.cgi?id=58721
--- Comment #6 from Remy Maucherat ---
Last call before closing this.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev
https://bz.apache.org/bugzilla/show_bug.cgi?id=59226
--- Comment #2 from Mark Thomas ---
Notes:
- The web application class loader will ignore any Class-Path entries in a
manifest.
- Any class loader above that (common, server, shared, etc.) will process
Class-Path entries for any JAR on the clas
https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
--- Comment #2 from Christopher Schultz ---
I think any reasonably descriptive name will do.
If you're considering preparing a patch, please grab the latest trunk
(currently Tomcat 9.0.x) and write your initial patch for that version. Once
it'
70 matches
Mail list logo
