Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-08 Thread jean-frederic clere
On 01/06/2016 01:56 PM, Mark Thomas wrote: > On 05/01/2016 15:46, Mark Thomas wrote: >> Version 1.2.4 includes the following change: >> >> - Renegotiation improvements >> >> The proposed release artefacts can be found at [1], >> and the build was done using tag [2]. >> >> The Apache Tomcat Native 1

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-08 Thread jean-frederic clere
On 01/06/2016 08:45 PM, Mark Thomas wrote: > On 06/01/2016 19:34, Rainer Jung wrote: >> Hi Mark, >> >> there's no file bin/openssl.exe in the Windows binariy zip files. >> >> It existed in 1.2.3 but was also missing for 1.2.2. It also exists in >> 1.2.0 and 1.2.1 as well as 1.1.33 and 1.1.34. So I

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-08 Thread Mark Thomas
On 08/01/2016 09:13, jean-frederic clere wrote: > On 01/06/2016 08:45 PM, Mark Thomas wrote: >> On 06/01/2016 19:34, Rainer Jung wrote: >>> Hi Mark, >>> >>> there's no file bin/openssl.exe in the Windows binariy zip files. >>> >>> It existed in 1.2.3 but was also missing for 1.2.2. It also exists i

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-08 Thread Mark Thomas
On 06/01/2016 12:56, Mark Thomas wrote: > On 05/01/2016 15:46, Mark Thomas wrote: >> Version 1.2.4 includes the following change: >> >> - Renegotiation improvements >> >> The proposed release artefacts can be found at [1], >> and the build was done using tag [2]. >> >> The Apache Tomcat Native 1.2.

svn commit: r1723681 - in /tomcat/trunk/java/org/apache/catalina: core/ deploy/

2016-01-08 Thread remm
Author: remm Date: Fri Jan 8 10:50:42 2016 New Revision: 1723681 URL: http://svn.apache.org/viewvc?rev=1723681&view=rev Log: Javadoc fixes. Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java tomcat/trunk/java/org/apache/catalina/core/ApplicationSessionCookieCon

svn commit: r1723683 - /tomcat/trunk/java/org/apache/catalina/Manager.java

2016-01-08 Thread markt
Author: markt Date: Fri Jan 8 10:54:17 2016 New Revision: 1723683 URL: http://svn.apache.org/viewvc?rev=1723683&view=rev Log: Correct Javadoc Modified: tomcat/trunk/java/org/apache/catalina/Manager.java Modified: tomcat/trunk/java/org/apache/catalina/Manager.java URL: http://svn.apache.org

svn commit: r1723684 - /tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java

2016-01-08 Thread markt
Author: markt Date: Fri Jan 8 10:54:57 2016 New Revision: 1723684 URL: http://svn.apache.org/viewvc?rev=1723684&view=rev Log: Add some scaffolding so the test doesn't need to catch an Exception to work correctly. Modified: tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java Modif

svn commit: r1723707 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

2016-01-08 Thread markt
Author: markt Date: Fri Jan 8 11:57:05 2016 New Revision: 1723707 URL: http://svn.apache.org/viewvc?rev=1723707&view=rev Log: Remove unnecessary commented out code Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java Modified: tomcat/trunk/java/org/apache/catalina/se

svn commit: r1723708 - /tomcat/trunk/java/org/apache/catalina/deploy/NamingResourcesImpl.java

2016-01-08 Thread markt
Author: markt Date: Fri Jan 8 12:04:17 2016 New Revision: 1723708 URL: http://svn.apache.org/viewvc?rev=1723708&view=rev Log: Whitespace police Modified: tomcat/trunk/java/org/apache/catalina/deploy/NamingResourcesImpl.java Modified: tomcat/trunk/java/org/apache/catalina/deploy/NamingResour

svn commit: r1723709 - in /tomcat/trunk/java/org/apache/catalina/core: NamingContextListener.java StandardContext.java StandardServer.java

2016-01-08 Thread markt
Author: markt Date: Fri Jan 8 12:09:48 2016 New Revision: 1723709 URL: http://svn.apache.org/viewvc?rev=1723709&view=rev Log: Fix an IDE warning and mop up the last few Javadoc issues in this package Modified: tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java tomcat/t

buildbot failure in ASF Buildbot on tomcat-trunk

2016-01-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/885 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

buildbot success in ASF Buildbot on tomcat-trunk

2016-01-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/886 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

[PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Mark Thomas
I've been looking at the relationship between a Context and its Manager and I have identified some inconsistencies in the underlying assumptions on which the code is based. A. Context is always set In some places the code carefully checks to see if the Context is null. In other places (often in th

tagging tomcat 6.0.45

2016-01-08 Thread jean-frederic clere
Hi, I am planning to test and tag tomcat 6.0.45 during the week-end. Any objections? Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 58827] New: Review/remove references to JSR77 StateManageable

2016-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58827 Bug ID: 58827 Summary: Review/remove references to JSR77 StateManageable Product: Tomcat 9 Version: unspecified Hardware: PC Status: NEW Severity: minor Prior

svn commit: r1723736 - in /tomcat/trunk/java/org/apache/catalina/session: FileStore.java JDBCStore.java

2016-01-08 Thread markt
Author: markt Date: Fri Jan 8 15:15:13 2016 New Revision: 1723736 URL: http://svn.apache.org/viewvc?rev=1723736&view=rev Log: Store.load() implementations assume (in places) that getManager().getContext() always returns a non-null and we haven't had reports of NPEs so make the assumption consis

[Bug 58827] Review/remove references to JSR77 StateManageable

2016-01-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58827 Konstantin Kolinko changed: What|Removed |Added OS||All --- Comment #1 from Konstanti

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Rémy Maucherat
2016-01-08 13:33 GMT+01:00 Mark Thomas : > My preference is for 1. It is less work, Tomcat currently never changes > the Context and I can't see a viable use case for wanting to do so. > No problem, that's the best solution. Rémy

svn commit: r1723752 - in /tomcat/trunk/java/org/apache: catalina/filters/ catalina/ha/ catalina/ha/backend/ catalina/ha/deploy/ catalina/ha/session/ catalina/ha/tcp/ catalina/session/ catalina/tribes

2016-01-08 Thread remm
Author: remm Date: Fri Jan 8 16:12:22 2016 New Revision: 1723752 URL: http://svn.apache.org/viewvc?rev=1723752&view=rev Log: Javadoc fixes. Modified: tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilterBase.java

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Christopher Schultz
Mark, On 1/8/16 7:33 AM, Mark Thomas wrote: > I've been looking at the relationship between a Context and its Manager > and I have identified some inconsistencies in the underlying assumptions > on which the code is based. > > A. Context is always set > In some places the code carefully checks to

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Konstantin Kolinko
2016-01-08 15:33 GMT+03:00 Mark Thomas : > I've been looking at the relationship between a Context and its Manager > and I have identified some inconsistencies in the underlying assumptions > on which the code is based. > > A. Context is always set > In some places the code carefully checks to see

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Mark Thomas
On 08/01/2016 16:56, Konstantin Kolinko wrote: > 2016-01-08 15:33 GMT+03:00 Mark Thomas : >> I've been looking at the relationship between a Context and its Manager >> and I have identified some inconsistencies in the underlying assumptions >> on which the code is based. >> >> A. Context is always

Re: [PROPOSAL] Manager behaviour clarification for 9.0.x

2016-01-08 Thread Konstantin Kolinko
2016-01-08 20:26 GMT+03:00 Mark Thomas : > On 08/01/2016 16:56, Konstantin Kolinko wrote: >> 2016-01-08 15:33 GMT+03:00 Mark Thomas : >>> I've been looking at the relationship between a Context and its Manager >>> and I have identified some inconsistencies in the underlying assumptions >>> on which

Re: tagging tomcat 6.0.45

2016-01-08 Thread Konstantin Kolinko
2016-01-08 17:21 GMT+03:00 jean-frederic clere : > Hi, > > I am planning to test and tag tomcat 6.0.45 during the week-end. 1) A bug in a new feature: https://bz.apache.org/bugzilla/show_bug.cgi?id=58817 I plan to look there together with old Mapper patch (currently in STATUS), but I think it nee

Re: svn commit: r1723752 - in /tomcat/trunk/java/org/apache: catalina/filters/ catalina/ha/ catalina/ha/backend/ catalina/ha/deploy/ catalina/ha/session/ catalina/ha/tcp/ catalina/session/ catalina/tr

2016-01-08 Thread Konstantin Kolinko
/** - * Return the member that represents this node. - * - * @return Member + * @return the member that represents this node. */ public Member getLocalMember(); /** - * Return response status code that is used to reject denied request. + * @return respo

Re: svn commit: r1723752 - in /tomcat/trunk/java/org/apache: catalina/filters/ catalina/ha/ catalina/ha/backend/ catalina/ha/deploy/ catalina/ha/session/ catalina/ha/tcp/ catalina/session/ catalina/tr

2016-01-08 Thread Rémy Maucherat
2016-01-08 20:00 GMT+01:00 Konstantin Kolinko : > /** > - * Return the member that represents this node. > - * > - * @return Member > + * @return the member that represents this node. > */ > public Member getLocalMember(); > > /** > - * Return response stat

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-08 Thread Konstantin Kolinko
2016-01-08 12:58 GMT+03:00 Mark Thomas : > On 08/01/2016 09:13, jean-frederic clere wrote: >> On 01/06/2016 08:45 PM, Mark Thomas wrote: >>> On 06/01/2016 19:34, Rainer Jung wrote: Hi Mark, there's no file bin/openssl.exe in the Windows binariy zip files. It existed in 1.2.

svn commit: r1723806 - in /tomcat/trunk: BUILDING.txt webapps/docs/changelog.xml

2016-01-08 Thread kkolinko
Author: kkolinko Date: Fri Jan 8 21:56:44 2016 New Revision: 1723806 URL: http://svn.apache.org/viewvc?rev=1723806&view=rev Log: 1. Document the test.threads option in BUILDING.txt 2. Update description of FindBugs option: unlike ckeckstyle it is not executed during build or test. The "findbugs"

Re: tagging tomcat 6.0.45

2016-01-08 Thread Mark Thomas
On 08/01/2016 14:21, jean-frederic clere wrote: > Hi, > > I am planning to test and tag tomcat 6.0.45 during the week-end. > > Any objections? I'm working on some session stuff that really should be in the next 6 release. I don't think it will be ready until early next week. Mark

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2016-01-08 Thread Bill Barker
it/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160108.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/wo

svn commit: r1723824 - /tomcat/tc6.0.x/trunk/NOTICE

2016-01-08 Thread kkolinko
Author: kkolinko Date: Sat Jan 9 04:45:49 2016 New Revision: 1723824 URL: http://svn.apache.org/viewvc?rev=1723824&view=rev Log: Fix Typo in NOTICE. (In Tomcat 7 this was fixed in r752584) Modified: tomcat/tc6.0.x/trunk/NOTICE Modified: tomcat/tc6.0.x/trunk/NOTICE URL: http://svn.apache.o

svn commit: r1723825 - /tomcat/tc6.0.x/trunk/build.xml

2016-01-08 Thread kkolinko
Author: kkolinko Date: Sat Jan 9 04:50:26 2016 New Revision: 1723825 URL: http://svn.apache.org/viewvc?rev=1723825&view=rev Log: Update some comments in build.xml. No functional change. Modified: tomcat/tc6.0.x/trunk/build.xml Modified: tomcat/tc6.0.x/trunk/build.xml URL: http://svn.apache

svn commit: r1723827 - in /tomcat/tc6.0.x/trunk: .gitignore build.xml dist.xml java/org/apache/catalina/startup/ java/org/apache/catalina/startup/catalina.properties webapps/docs/changelog.xml

2016-01-08 Thread kkolinko
Author: kkolinko Date: Sat Jan 9 05:37:54 2016 New Revision: 1723827 URL: http://svn.apache.org/viewvc?rev=1723827&view=rev Log: Remove redundant copy of catalina.properties from o.a.c.startup. Generate this copy during the ant "compile" task. In Tomcat 7 this feature was implemented in r1138825

svn propchange: r1723827 - svn:log

2016-01-08 Thread kkolinko
Author: kkolinko Revision: 1723827 Modified property: svn:log Modified: svn:log at Sat Jan 9 06:16:38 2016 -- --- svn:log (original) +++ svn:log Sat Jan 9 06:16:38 2016 @@ -3,3 +3,7 @@ Generate this copy during the ant "

svn commit: r1723828 - in /tomcat/tc6.0.x/branches/tomcat6-testing_20160106: ./ .gitignore BRANCH-README.txt NOTICE build.xml dist.xml java/org/apache/catalina/startup/ java/org/apache/catalina/startu

2016-01-08 Thread kkolinko
Author: kkolinko Date: Sat Jan 9 06:30:33 2016 New Revision: 1723828 URL: http://svn.apache.org/viewvc?rev=1723828&view=rev Log: Rebase branch onto current tc6.0.x/trunk This means a catch-up merge of all revisions up to r1723827. Removed: tomcat/tc6.0.x/branches/tomcat6-testing_20160106/ja

svn commit: r1723829 - in /tomcat/tc6.0.x/branches/tomcat6-testing_20160106: BUILDING.txt build.properties.default build.xml test/build.xml test/org/apache/catalina/startup/TomcatBaseTest.java

2016-01-08 Thread kkolinko
Author: kkolinko Date: Sat Jan 9 06:44:50 2016 New Revision: 1723829 URL: http://svn.apache.org/viewvc?rev=1723829&view=rev Log: Implement running the test with Apache Ant. The command is: ant download ant test Remove unused test/build.xml Note: running with APR connector is supported,

svn commit: r1723830 - /tomcat/tc6.0.x/branches/tomcat6-testing_20160106/BRANCH-README.txt

2016-01-08 Thread kkolinko
Author: kkolinko Date: Sat Jan 9 06:45:40 2016 New Revision: 1723830 URL: http://svn.apache.org/viewvc?rev=1723830&view=rev Log: Update BRANCH-README.txt with the current status. Modified: tomcat/tc6.0.x/branches/tomcat6-testing_20160106/BRANCH-README.txt Modified: tomcat/tc6.0.x/branches/t