Re: JASPIC Implementation pointers

On 03/07/2015 07:37, Fjodor Vershinin wrote: > Hi! > Unfortunately, commit rearrangement requires some more effort from me, so I > haven't finished it yesterday. > I need some more time to fix checkstyle errors and so on. OK. >> We can change the way users have to configure it. For example, we co

Re: JASPIC Implementation pointers

2015-07-03 15:31 GMT+03:00 Mark Thomas : > On 03/07/2015 07:37, Fjodor Vershinin wrote: > > Hi! > > Unfortunately, commit rearrangement requires some more effort from me, > so I > > haven't finished it yesterday. > > I need some more time to fix checkstyle errors and so on. > > OK. I have prepare

Re: svn commit: r1688911 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2015-07-03 0:07 GMT+03:00 : > Author: markt > Date: Thu Jul 2 21:07:18 2015 > New Revision: 1688911 > > URL: http://svn.apache.org/r1688911 > Log: (empty) Log message =? This looks like a followup to http://svn.apache.org/r1688909 Removing "ka = null;" line has no effect, as "ka" variable is no

Re: JASPIC Implementation pointers

On 03/07/2015 13:56, Fjodor Vershinin wrote: > 2015-07-03 15:31 GMT+03:00 Mark Thomas : > >> On 03/07/2015 07:37, Fjodor Vershinin wrote: >>> Hi! >>> Unfortunately, commit rearrangement requires some more effort from me, >> so I >>> haven't finished it yesterday. >>> I need some more time to fix c

Re: JASPIC Implementation pointers

> > > Another option would be to define a jaspic element for server.xml / > context.xml that is nested in a Context and if present takes precedence > for JASPIC config. For that to work modules would have to: > - have zero arg constructors > - be fully configurable via setters > - use simple types

Early Access builds for JDK 8u60 b21 and JDK 9 b70 are available on java.net

Hi Mark/Mladen, Early Access build for JDK 8u60 b21 is available on java.net, summary of changes are listed here. As we enter the later phases of development for JDK 8u60, please log any show

Re: JASPIC Implementation pointers

I am working on polishing FORM authentication module code. I will continue with that this evening. JASPIC modules configuration looks more like architectural stuff, so we need to make some decisions how to proceed forward. I think it can be task for next week together SPNEGO authentication module.

svn commit: r1689026 - in /tomcat/trunk/test/org/apache/catalina/authenticator: ResponseDescriptor.java TestJaspicBasicAuthenticator.java

Author: markt Date: Fri Jul 3 14:47:12 2015 New Revision: 1689026 URL: http://svn.apache.org/r1689026 Log: Implemented integration test for JASPIC BASIC authentication Patch by fjodorver Added: tomcat/trunk/test/org/apache/catalina/authenticator/ResponseDescriptor.java (with props) t

svn commit: r1689034 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/TomcatAuthModule.java

Author: markt Date: Fri Jul 3 14:59:01 2015 New Revision: 1689034 URL: http://svn.apache.org/r1689034 Log: Fix NPE on empty realm name Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/TomcatAuthModule.java Modified: tomcat/trunk/jav

Re: JASPIC Implementation pointers

On 03/07/2015 15:42, Fjodor Vershinin wrote: > I am working on polishing FORM authentication module code. I will continue > with that this evening. OK. I'm commenting on commits as I apply them. Some of them have suggestions for further improvements. These improvements don't need to be implemented

[Bug 58095] Empty

https://bz.apache.org/bugzilla/show_bug.cgi?id=58095 --- Comment #3 from Christopher Schultz --- I'm not sure this is a Tomcat issue, but I'm not sure exactly how Tomcat does its XML parsing, etc. I know that I've seen this problem with other XML-oriented HTML-handling software as well. A specif

JASPIC Implementation pointers

> On 03/07/2015 15:42, Fjodor Vershinin wrote: > > I am working on polishing FORM authentication module code. I will > continue > > with that this evening. > > OK. I'm commenting on commits as I apply them. Some of them have > suggestions for further improvements. These improvements don't need to >

svn commit: r1689056 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider: TomcatAuthConfig.java modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 18:49:45 2015 New Revision: 1689056 URL: http://svn.apache.org/r1689056 Log: Added dummy FORM auth module Patch by fjodorver Added: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java (with props) Modified: to

svn commit: r1689058 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider: ./ modules/

Author: markt Date: Fri Jul 3 18:54:29 2015 New Revision: 1689058 URL: http://svn.apache.org/r1689058 Log: Make the Context available to the auth modules. Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/TomcatAuthConfig.java tomcat/trunk

svn commit: r1689060 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 18:58:24 2015 New Revision: 1689060 URL: http://svn.apache.org/r1689060 Log: Port FORM auth to JASPIC Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/trunk/java/org/

svn commit: r1689061 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:00:51 2015 New Revision: 1689061 URL: http://svn.apache.org/r1689061 Log: Validation extracted to separate method, in order to make exception handling easier Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/mo

svn commit: r1689062 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestJaspicFormAuthenticator.java

Author: markt Date: Fri Jul 3 19:04:23 2015 New Revision: 1689062 URL: http://svn.apache.org/r1689062 Log: Port FORM auth unit test for JASPIC Patch by fjodorver Added: tomcat/trunk/test/org/apache/catalina/authenticator/TestJaspicFormAuthenticator.java (with props) Added: tomcat/trunk

svn commit: r1689063 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:07:30 2015 New Revision: 1689063 URL: http://svn.apache.org/r1689063 Log: Remove unnecessary code Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/trunk/java/org/a

svn commit: r1689064 - /tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java

Author: markt Date: Fri Jul 3 19:07:52 2015 New Revision: 1689064 URL: http://svn.apache.org/r1689064 Log: Remove unnecessary code Thanks to fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java Modified: tomcat/trunk/java/org/apache/catalina/authen

svn commit: r1689067 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:15:06 2015 New Revision: 1689067 URL: http://svn.apache.org/r1689067 Log: Added realm and login-config fields to FormAuthModule Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modi

svn commit: r1689068 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:19:00 2015 New Revision: 1689068 URL: http://svn.apache.org/r1689068 Log: Extracted principal callbacks handling Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/t

svn commit: r1689069 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:20:20 2015 New Revision: 1689069 URL: http://svn.apache.org/r1689069 Log: Extracted expired session handling Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/trunk

svn commit: r1689070 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:21:17 2015 New Revision: 1689070 URL: http://svn.apache.org/r1689070 Log: Meaningful name for variable Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/trunk/java/

svn commit: r1689071 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:23:18 2015 New Revision: 1689071 URL: http://svn.apache.org/r1689071 Log: Extracted login and non-login actions Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/tr

svn commit: r1689072 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:32:52 2015 New Revision: 1689072 URL: http://svn.apache.org/r1689072 Log: extracted sending saved request Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/trunk/ja

svn commit: r1689073 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:49:08 2015 New Revision: 1689073 URL: http://svn.apache.org/r1689073 Log: Extracted is login action request check Removed password validation callback, because we can use Realm directly Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authe

svn commit: r1689075 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules: FormAuthModule.java TomcatAuthModule.java

Author: markt Date: Fri Jul 3 19:57:38 2015 New Revision: 1689075 URL: http://svn.apache.org/r1689075 Log: Principal cache settings moved into parent class Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java tomcat/trunk/java/org/

svn commit: r1689077 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 19:58:28 2015 New Revision: 1689077 URL: http://svn.apache.org/r1689077 Log: Enabled character encoding Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified: tomcat/trunk/java/or

svn commit: r1689078 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules: BasicAuthModule.java DigestAuthModule.java FormAuthModule.java TomcatAuthModule.java

Author: markt Date: Fri Jul 3 20:00:56 2015 New Revision: 1689078 URL: http://svn.apache.org/r1689078 Log: JASPIC callback management moved to parent class Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/BasicAuthModule.java tomc

svn commit: r1689080 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 20:03:51 2015 New Revision: 1689080 URL: http://svn.apache.org/r1689080 Log: Change session id on authenication field added Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java Modified:

svn commit: r1689082 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Author: markt Date: Fri Jul 3 20:08:18 2015 New Revision: 1689082 URL: http://svn.apache.org/r1689082 Log: Extracted saved authentication handling to separate method Patch by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/provider/modules/FormAuthModule.java

Re: JASPIC Implementation pointers

On 03/07/2015 18:55, Fjodor Vershinin wrote: >> On 03/07/2015 15:42, Fjodor Vershinin wrote: >>> I am working on polishing FORM authentication module code. I will >> continue >>> with that this evening. >> >> OK. I'm commenting on commits as I apply them. Some of them have >> suggestions for furthe

JASPIC configuration

On 03/07/2015 18:55, Fjodor Vershinin wrote: > For example the way how we handle module configurations. What do > you think about my proposal to use Provider based config? OK. We need the configuration settings in the ServerAuthModule implementations. It is pretty clear from the API that those se