Re: [GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2015-02-22 Thread Mark Thomas
On 22/02/2015 03:58, Bill Barker wrote: >[concat] Testsuites with failed tests: >[concat] > TEST-org.apache.tomcat.util.net.jsse.openssl.TestOpenSSLCipherConfigurationParser.NIO.txt Am I missing something here? A couple of times I have made some changes which I thought fixed this (i.e.

Re: [GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2015-02-22 Thread Mark Thomas
On 22/02/2015 10:13, Mark Thomas wrote: > On 22/02/2015 03:58, Bill Barker wrote: > > > >>[concat] Testsuites with failed tests: >>[concat] >> TEST-org.apache.tomcat.util.net.jsse.openssl.TestOpenSSLCipherConfigurationParser.NIO.txt > > Am I missing something here? A couple of times I

svn commit: r1661513 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:14 2015 New Revision: 1661513 URL: http://svn.apache.org/r1661513 Log: Remove call to awaitBytes from longPoll for NIO2 as it could trigger double registrations Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java Modified: tomcat/

svn commit: r1661514 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: LocalStrings.properties UpgradeProcessor.java UpgradeServletInputStream.java UpgradeServletOutputStream.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:22 2015 New Revision: 1661514 URL: http://svn.apache.org/r1661514 Log: isCloseRequired -> Closed Align behaviour of methods with closed state Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties tomcat/trunk/java/org/apa

svn commit: r1661516 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeServletInputStream.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:32 2015 New Revision: 1661516 URL: http://svn.apache.org/r1661516 Log: Align ServletInputStream with required behaviour as clarified by recent EG discussions. Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeServletInputStream.java Mod

svn commit: r1661520 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:51 2015 New Revision: 1661520 URL: http://svn.apache.org/r1661520 Log: As per EG discussion, the connection only closes after both streams have been closed. Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java Modified: tomc

svn commit: r1661518 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:42 2015 New Revision: 1661518 URL: http://svn.apache.org/r1661518 Log: Fix infinite loop observed while running unit tests when write is called with no data on the input side and wrapping also produces no data. Modified: tomcat/trunk/java/org/apache/tomcat

svn commit: r1661515 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeServletInputStream.java UpgradeServletOutputStream.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:27 2015 New Revision: 1661515 URL: http://svn.apache.org/r1661515 Log: The container is responsible for the first calls to onDataAvailable() and onWritePossible(). Trigger them from the setting of the appropriate listener. Modified: tomcat/trunk/java/org/

svn commit: r1661521 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: WsHttpUpgradeHandler.java WsRemoteEndpointImplServer.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:56 2015 New Revision: 1661521 URL: http://svn.apache.org/r1661521 Log: Now need to close both streams Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemo

svn commit: r1661519 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: WsFrameServer.java WsHttpUpgradeHandler.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:47 2015 New Revision: 1661519 URL: http://svn.apache.org/r1661519 Log: Align WebSocket impl with changes to upgrade end-of-stream handling Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFrameServer.java tomcat/trunk/java/org/apache/t

svn commit: r1661522 - /tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:50:01 2015 New Revision: 1661522 URL: http://svn.apache.org/r1661522 Log: Update unit test to take account of recent changes to upgared behaviour in light of EG discussions. Modified: tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java Modifi

svn commit: r1661517 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:49:37 2015 New Revision: 1661517 URL: http://svn.apache.org/r1661517 Log: Update I/O implementations to support returning -1 for end of stream. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/uti

svn commit: r1661523 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:50:06 2015 New Revision: 1661523 URL: http://svn.apache.org/r1661523 Log: Remove some temporary debug logging Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java Modified: tomcat/trunk/test/org/apache/tomcat/websocket/T

svn commit: r1661525 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:50:15 2015 New Revision: 1661525 URL: http://svn.apache.org/r1661525 Log: Remove upgradeInit code as the code that called it has been removed Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomc

svn commit: r1661526 - in /tomcat/trunk: java/org/apache/coyote/http11/upgrade/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/websocket/server/ res/checkstyle/

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:50:23 2015 New Revision: 1661526 URL: http://svn.apache.org/r1661526 Log: Limit concurrent read/write for HTTP upgrade to implementations that explicitly request it via a Tomcat specific interface. Note that the expectation is that concurrent read/writes will be r

svn commit: r1661524 - /tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java

2015-02-22 Thread markt
Author: markt Date: Sun Feb 22 18:50:11 2015 New Revision: 1661524 URL: http://svn.apache.org/r1661524 Log: Fix indent Modified: tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java Modified: tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java URL: http://svn.

Re: TestPojoEndpointBase failing on trunk

2015-02-22 Thread Mark Thomas
On 19/02/2015 18:27, Mark Thomas wrote: > On 19/02/2015 15:17, Jeremy Boynes wrote: >> Mark >> >> I am seing regular failures in TestPojoEndpointBase in trunk where >> the socket is not being closed (see attached log). I’ve not dug in >> yet but this has started since r1660358 and may be related to

Re: TestPojoEndpointBase failing on trunk

2015-02-22 Thread Jeremy Boynes
On Feb 22, 2015, at 10:57 AM, Mark Thomas wrote: > > On 19/02/2015 18:27, Mark Thomas wrote: >> On 19/02/2015 15:17, Jeremy Boynes wrote: >>> Mark >>> >>> I am seing regular failures in TestPojoEndpointBase in trunk where >>> the socket is not being closed (see attached log). I’ve not dug in >>>

svn commit: r1661594 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2015-02-22 Thread kfujino
Author: kfujino Date: Mon Feb 23 02:34:50 2015 New Revision: 1661594 URL: http://svn.apache.org/r1661594 Log: When docBase refers internal war and unpackWARs is set to false, avoid registration of the invalid redeploy resource that has been added ".war" extension in duplicate. Modified: tom

svn commit: r1661595 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2015-02-22 Thread kfujino
Author: kfujino Date: Mon Feb 23 02:37:11 2015 New Revision: 1661595 URL: http://svn.apache.org/r1661595 Log: If WAR exists, it is not necessary to trigger a reload when adding a Directory. Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/or

svn commit: r1661597 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2015-02-22 Thread kfujino
Author: kfujino Date: Mon Feb 23 02:40:58 2015 New Revision: 1661597 URL: http://svn.apache.org/r1661597 Log: -When docBase refers internal war and unpackWARs is set to false, avoid registration of the invalid redeploy resource that has been added ".war" extension in duplicate. -If WAR exists, i

svn commit: r1661598 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2015-02-22 Thread kfujino
Author: kfujino Date: Mon Feb 23 02:43:23 2015 New Revision: 1661598 URL: http://svn.apache.org/r1661598 Log: -When docBase refers internal war and unpackWARs is set to false, avoid registration of the invalid redeploy resource that has been added ".war" extension in duplicate. -If WAR exists, i

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) success, but with warnings.

2015-02-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 contains errors. The current state of this projec

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) success, but with warnings.

2015-02-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr contains errors. The current state of this project

[Bug 57617] New: File upload error reporting behaviour changed

2015-02-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57617 Bug ID: 57617 Summary: File upload error reporting behaviour changed Product: Tomcat 7 Version: unspecified Hardware: All Status: NEW Severity: normal Priorit

[Bug 57617] File upload error reporting behaviour changed

2015-02-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57617 --- Comment #1 from Oliver Henlich --- Created attachment 32506 --> https://bz.apache.org/bugzilla/attachment.cgi?id=32506&action=edit jsp -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 57617] File upload error reporting behaviour changed

2015-02-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57617 --- Comment #2 from Oliver Henlich --- Created attachment 32507 --> https://bz.apache.org/bugzilla/attachment.cgi?id=32507&action=edit server.xml -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 57617] File upload error reporting behaviour changed

2015-02-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57617 Oliver Henlich changed: What|Removed |Added OS||All CC|

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2015-02-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. Th

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) success, but with warnings.

2015-02-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio contains errors. The current state of this project

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2015-02-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. T

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-02-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th