svn commit: r1643761 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 08:20:35 2014 New Revision: 1643761 URL: http://svn.apache.org/r1643761 Log: Close the InputStream after retrieving the last modification time from URLConnection. Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/t

svn commit: r1643764 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 08:51:47 2014 New Revision: 1643764 URL: http://svn.apache.org/r1643764 Log: Merged revision 1643761 from tomcat/trunk: Close the InputStream after retrieving the last modification time from URLConnection. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1643765 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 08:53:46 2014 New Revision: 1643765 URL: http://svn.apache.org/r1643765 Log: Merged revision 1643761 from tomcat/trunk: Close the InputStream after retrieving the last modification time from URLConnection. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1643766 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 09:04:56 2014 New Revision: 1643766 URL: http://svn.apache.org/r1643766 Log: Extract several "protected" methods in order to make StandardRoot easier for extending. Modified: tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Modified: to

[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections

2014-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57324 --- Comment #3 from Vamsi Krishna --- I am attaching traces from my wireshark analysis. It captures 3 request response cycles. Please proceed to my notes at the end after the trace. ** 1) POS

[Bug 57326] New: AsyncContextImpl doesn't allow AsyncListener to re-register themselves when firing onStartAsync

2014-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57326 Bug ID: 57326 Summary: AsyncContextImpl doesn't allow AsyncListener to re-register themselves when firing onStartAsync Product: Tomcat 7 Version: trunk Hardware: PC

svn commit: r1643768 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/StandardRoot.java webapps/docs/changelog.xml

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 09:28:22 2014 New Revision: 1643768 URL: http://svn.apache.org/r1643768 Log: Merged revision 1643766 from tomcat/trunk: Extract several "protected" methods in order to make StandardRoot easier for extending. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1643770 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 09:41:28 2014 New Revision: 1643770 URL: http://svn.apache.org/r1643770 Log: Merged revision 1643675 from tomcat/trunk: It is not necessary to handle MalformedURLException separately as it extends IOException. Modified: tomcat/tc7.0.x/trunk/ (props change

[jira] [Created] (MTOMCAT-290) Parallel deployment - Support version in war file name when using run-war goal

2014-12-08 Thread Olivier Roger (JIRA)
Olivier Roger created MTOMCAT-290: - Summary: Parallel deployment - Support version in war file name when using run-war goal Key: MTOMCAT-290 URL: https://issues.apache.org/jira/browse/MTOMCAT-290 Proj

[jira] [Updated] (MTOMCAT-290) Parallel deployment - Support version in war file name when using run-war goal

2014-12-08 Thread Olivier Roger (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Roger updated MTOMCAT-290: -- Description: When using the tomcat7:run-war goal, the context is created based on the *path* c

svn commit: r1643814 - in /tomcat/trunk/java/org/apache/tomcat/dbcp/pool2: ./ impl/BaseGenericObjectPool.java impl/DefaultPooledObject.java impl/LinkedBlockingDeque.java

2014-12-08 Thread markt
Author: markt Date: Mon Dec 8 13:25:58 2014 New Revision: 1643814 URL: http://svn.apache.org/r1643814 Log: Update fork of Apache Commons Pool2 to latest trunk to pick up fixes including one for a potential infinite loop. Modified: tomcat/trunk/java/org/apache/tomcat/dbcp/pool2/ (props cha

svn commit: r1643815 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/dbcp/pool2/ java/org/apache/tomcat/dbcp/pool2/impl/ webapps/docs/

2014-12-08 Thread markt
Author: markt Date: Mon Dec 8 13:28:01 2014 New Revision: 1643815 URL: http://svn.apache.org/r1643815 Log: Update fork of Apache Commons Pool2 to latest trunk to pick up fixes including one for a potential infinite loop. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/t

[jira] [Updated] (MTOMCAT-290) Parallel deployment - Support version in war file name when using run-war goal

2014-12-08 Thread Olivier Roger (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Roger updated MTOMCAT-290: -- Attachment: tomcat-maven-plugin_parallel-deploy.patch Simple patch that solve the issue for thi

[GitHub] tomcat-maven-plugin pull request: MTOMCAT-290 - Fix for parallel d...

2014-12-08 Thread oroger
GitHub user oroger opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/14 MTOMCAT-290 - Fix for parallel deployment Fix for the probleme explained in MTOMCAT-290 (https://issues.apache.org/jira/browse/MTOMCAT-290). This fix simply strip the version, if pres

[jira] [Commented] (MTOMCAT-290) Parallel deployment - Support version in war file name when using run-war goal

2014-12-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237887#comment-14237887 ] ASF GitHub Bot commented on MTOMCAT-290: GitHub user oroger opened a pull request

[GitHub] tomcat-maven-plugin pull request: Bind Tomcat to an address via co...

2014-12-08 Thread seanking
GitHub user seanking opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/15 Bind Tomcat to an address via command-line option Introduce a -httpAddress command-line option to the Tomcat Runner. Update the Runner to bind Tomcat to the specified address.

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-08 Thread Mark Thomas
On 04/12/2014 14:04, Rémy Maucherat wrote: > 2014-12-04 14:58 GMT+01:00 Mark Thomas : > >> Shouldn't there still be a single empty message in that case? Otherwise, >> how is the client meant to differentiate between no write and a write of >> zero length? >> > The problem I am trying to fix is ext

svn commit: r1643906 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java

2014-12-08 Thread markt
Author: markt Date: Mon Dec 8 20:31:23 2014 New Revision: 1643906 URL: http://svn.apache.org/r1643906 Log: Add a comment to explain what is going on and why Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java Modified: tomcat/trunk/java/org/apache/tomcat/w

svn commit: r1643908 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2014-12-08 Thread markt
Author: markt Date: Mon Dec 8 20:38:48 2014 New Revision: 1643908 URL: http://svn.apache.org/r1643908 Log: Rename method since equals() has a specific meaning that doesn't seem the right fit for this use case. This also stops the IDE complaining that hashCode() needs to be overridden because eq

Re: svn commit: r1643008 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2014-12-08 Thread Mark Thomas
On 05/12/2014 18:42, Mark Thomas wrote: > On 04/12/2014 14:21, Rémy Maucherat wrote: >> 2014-12-04 15:01 GMT+01:00 Mark Thomas : >> Ah actually, it is a mix then of the two, it should implement what is marked as WSC-4.8.1 in the spec instead. >>> >>> I thought that was what was implemente

svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-08 Thread rjung
Author: rjung Date: Mon Dec 8 20:51:01 2014 New Revision: 1643912 URL: http://svn.apache.org/r1643912 Log: Add support for Log4J2 to juli. Log4J2 has builtin support for commons logging. But using that would mean the Log4J2 jar files have to be put on the CLASSPATH. One can instead integrate Log

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-08 Thread Rémy Maucherat
2014-12-08 21:18 GMT+01:00 Mark Thomas : > On 04/12/2014 14:04, Rémy Maucherat wrote: > > 2014-12-04 14:58 GMT+01:00 Mark Thomas : > > > >> Shouldn't there still be a single empty message in that case? Otherwise, > >> how is the client meant to differentiate between no write and a write of > >> ze

Re: svn commit: r1643194 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java Util.java WsWebSocketContainer.java

2014-12-08 Thread Mark Thomas
On 05/12/2014 19:11, Rémy Maucherat wrote: > 2014-12-05 19:52 GMT+01:00 Mark Thomas : > >> On 05/12/2014 08:42, r...@apache.org wrote: >>> +// Configuration for extensions >>> +static final boolean DISABLE_BUILTIN_EXTENSIONS = >>> + >> Boolean.getBoolean("org.apache.tomcat.websocket.DIS

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-08 Thread Mark Thomas
On 08/12/2014 20:54, Rémy Maucherat wrote: > 2014-12-08 21:18 GMT+01:00 Mark Thomas : > >> On 04/12/2014 14:04, Rémy Maucherat wrote: >>> 2014-12-04 14:58 GMT+01:00 Mark Thomas : >>> Shouldn't there still be a single empty message in that case? Otherwise, how is the client meant to diffe

Re: svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-08 Thread Konstantin Kolinko
2014-12-08 23:51 GMT+03:00 : > Author: rjung > Date: Mon Dec 8 20:51:01 2014 > New Revision: 1643912 > > URL: http://svn.apache.org/r1643912 > Log: > Add support for Log4J2 to juli. > > Log4J2 has builtin support for commons logging. > But using that would mean the Log4J2 jar files have > to be p

[Bug 57331] New: Allow ExpiresFilter to use "year" as synonym for "years" in its configuration

2014-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57331 Bug ID: 57331 Summary: Allow ExpiresFilter to use "year" as synonym for "years" in its configuration Product: Tomcat 7 Version: 7.0.57 Hardware: PC Status

svn commit: r1643937 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 21:40:06 2014 New Revision: 1643937 URL: http://svn.apache.org/r1643937 Log: Additional method was introduced to StandardRoot in order to be able to extend classResources. Modified: tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Modif

svn commit: r1643938 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/StandardRoot.java

2014-12-08 Thread violetagg
Author: violetagg Date: Mon Dec 8 21:42:12 2014 New Revision: 1643938 URL: http://svn.apache.org/r1643938 Log: Merged revision 1643937 from tomcat/trunk: Additional method was introduced to StandardRoot in order to be able to extend classResources. Modified: tomcat/tc8.0.x/trunk/ (props c

Re: svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-08 Thread Rainer Jung
Hi Konstantin, Am 08.12.2014 um 22:10 schrieb Konstantin Kolinko: 2014-12-08 23:51 GMT+03:00 : Author: rjung Date: Mon Dec 8 20:51:01 2014 New Revision: 1643912 URL: http://svn.apache.org/r1643912 Log: Add support for Log4J2 to juli. Log4J2 has builtin support for commons logging. But using

Re: svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-08 Thread Rainer Jung
Am 08.12.2014 um 22:58 schrieb Rainer Jung: Hi Konstantin, Am 08.12.2014 um 22:10 schrieb Konstantin Kolinko: 2014-12-08 23:51 GMT+03:00 : Author: rjung Date: Mon Dec 8 20:51:01 2014 New Revision: 1643912 URL: http://svn.apache.org/r1643912 Log: Add support for Log4J2 to juli. Log4J2 has b

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-08 Thread Rémy Maucherat
2014-12-08 21:59 GMT+01:00 Mark Thomas : > What triggers the exception. That is the bit I don't understand. > > The test is throwing an exception, it goes to onError which writes a message, but the writer empty message gets sent first. From what I remember. To go further in this discussion, pleas

Re: svn commit: r1643194 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java Util.java WsWebSocketContainer.java

2014-12-08 Thread Rémy Maucherat
2014-12-08 21:56 GMT+01:00 Mark Thomas : > The more I think about this, the more I think it made no sense to > include extensions on the server side without an API to add extension > implementations. But that boat has sailed. > Ok, but these APIs are there for the time being, as I said these folk

Re: svn commit: r1643766 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-08 Thread Mark Thomas
On 08/12/2014 09:04, violet...@apache.org wrote: > Author: violetagg > Date: Mon Dec 8 09:04:56 2014 > New Revision: 1643766 > > URL: http://svn.apache.org/r1643766 > Log: > Extract several "protected" methods in order to make StandardRoot easier for > extending. > > Modified: > tomcat/trun

Re: svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-08 Thread Konstantin Kolinko
2014-12-09 1:24 GMT+03:00 Rainer Jung : > >> > > Adding to self: not only does the out-of-the-box integration need the > various log4j2 jar files on the CLASSPATH, but if you want to configure it > using the config file search as a resource via classloader, then again it > must be found by the sys

Re: svn commit: r1643937 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-08 Thread Mark Thomas
On 08/12/2014 21:40, violet...@apache.org wrote: > Author: violetagg > Date: Mon Dec 8 21:40:06 2014 > New Revision: 1643937 > > URL: http://svn.apache.org/r1643937 > Log: > Additional method was introduced to StandardRoot in order to be able to > extend classResources. > > Modified: > tomc

svn commit: r1643963 - in /tomcat/trunk: java/org/apache/catalina/filters/ExpiresFilter.java webapps/docs/config/filter.xml

2014-12-08 Thread kkolinko
Author: kkolinko Date: Tue Dec 9 00:51:00 2014 New Revision: 1643963 URL: http://svn.apache.org/r1643963 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57331 Allow ExpiresFilter to use "year" as synonym for "years" in its configuration. Update documentation to mention both "" and "s"

svn commit: r1643964 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/ExpiresFilter.java webapps/docs/changelog.xml webapps/docs/config/filter.xml

2014-12-08 Thread kkolinko
Author: kkolinko Date: Tue Dec 9 00:54:37 2014 New Revision: 1643964 URL: http://svn.apache.org/r1643964 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57331 Allow ExpiresFilter to use "year" as synonym for "years" in its configuration. Update documentation to mention both "" and "s"

svn commit: r1643965 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/ExpiresFilter.java webapps/docs/changelog.xml webapps/docs/config/filter.xml

2014-12-08 Thread kkolinko
Author: kkolinko Date: Tue Dec 9 00:56:22 2014 New Revision: 1643965 URL: http://svn.apache.org/r1643965 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57331 Allow ExpiresFilter to use "year" as synonym for "years" in its configuration. Update documentation to mention both "" and "s"

[Bug 57331] Allow ExpiresFilter to use "year" as synonym for "years" in its configuration

2014-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57331 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

Re: svn commit: r1643766 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-08 Thread Violeta Georgieva
Hi Mark, 2014-12-09 1:17 GMT+02:00 Mark Thomas : > > On 08/12/2014 09:04, violet...@apache.org wrote: > > Author: violetagg > > Date: Mon Dec 8 09:04:56 2014 > > New Revision: 1643766 > > > > URL: http://svn.apache.org/r1643766 > > Log: > > Extract several "protected" methods in order to make Sta

Re: svn commit: r1643937 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-08 Thread Violeta Georgieva
Hi Mark, 2014-12-09 1:22 GMT+02:00 Mark Thomas : > > On 08/12/2014 21:40, violet...@apache.org wrote: > > Author: violetagg > > Date: Mon Dec 8 21:40:06 2014 > > New Revision: 1643937 > > > > URL: http://svn.apache.org/r1643937 > > Log: > > Additional method was introduced to StandardRoot in orde